azeroth 1.0.0 → 2.0.0

data/spec/lib/azeroth/decorator/method_builder_spec.rb

@@ -3,21 +3,80 @@
 require 'spec_helper'
 
 describe Azeroth::Decorator::MethodBuilder do
+  subject(:build_reader) do
+    described_class.build_reader(decorator_class, :age, options)
+  end
+
   let(:decorator_class) { Class.new(Azeroth::Decorator) }
   let(:decorator)       { decorator_class.new(object) }
   let(:model)           { build(:dummy_model) }
   let(:object)          { model }
+  let(:options)         { Azeroth::Decorator::Options.new(options_hash) }
+  let(:options_hash)    { {} }
 
   describe '.build_reader' do
     it do
-      expect { described_class.build_reader(decorator_class, :age) }
+      expect { build_reader }
         .to add_method(:age).to(decorator)
     end
 
     it do
-      described_class.build_reader(decorator_class, :age)
+      build_reader
 
       expect(decorator.age).to eq(model.age)
     end
+
+    context 'when passing reader option' do
+      context 'when passing true' do
+        let(:options_hash) { { reader: true } }
+
+        it do
+          expect { build_reader }
+            .to add_method(:age).to(decorator)
+        end
+      end
+
+      context 'when passing false' do
+        let(:options_hash) { { reader: false } }
+
+        it do
+          expect { build_reader }
+            .not_to add_method(:age).to(decorator)
+        end
+      end
+    end
+
+    context 'when passing override option as true' do
+      let(:options_hash) { { override: false } }
+
+      it do
+        expect { build_reader }
+          .to add_method(:age).to(decorator)
+      end
+    end
+
+    context 'when method already existed' do
+      before do
+        decorator_class.define_method(:age) { 1 }
+      end
+
+      context 'when passing override option as true' do
+        let(:options_hash) { { override: true } }
+
+        it do
+          expect { build_reader }
+            .to change_method(:age).on(decorator)
+        end
+      end
+
+      context 'when passing override option as false' do
+        let(:options_hash) { { override: false } }
+
+        it do
+          expect { build_reader }
+            .not_to change_method(:age).on(decorator)
+        end
+      end
+    end
   end
 end

data/spec/lib/azeroth/decorator_spec.rb

@@ -5,14 +5,16 @@ require 'spec_helper'
 describe Azeroth::Decorator do
   subject(:decorator) { DummyModel::Decorator.new(object) }
 
-  let(:model)  { build(:dummy_model) }
-  let(:object) { model }
+  let(:model)    { build(:dummy_model) }
+  let(:object)   { model }
+  let(:instance) { decorator.new(object) }
 
   describe '.expose' do
     subject(:decorator) { Class.new(described_class) }
 
+    let(:options_hash) { {} }
     let(:expected_options) do
-      Azeroth::Decorator::Options.new
+      Azeroth::Decorator::Options.new(options_hash)
     end
 
     it do
@@ -59,6 +61,97 @@ describe Azeroth::Decorator do
           .and raise_error(Sinclair::Exception::InvalidOptions)
       end
     end
+
+    context 'when decorator already has the method' do
+      before do
+        decorator.define_method(:name) do
+          'some name'
+        end
+      end
+
+      context 'when not passing override' do
+        it do
+          expect { decorator.send(:expose, :name) }
+            .to change(decorator, :attributes_map)
+            .from({})
+            .to({ name: expected_options })
+        end
+
+        it do
+          expect { decorator.send(:expose, :name) }
+            .to change_method(:name)
+            .on(instance)
+        end
+      end
+
+      context 'when passing override as true' do
+        let(:options_hash) { { override: true } }
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to change(decorator, :attributes_map)
+            .from({})
+            .to({ name: expected_options })
+        end
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to change_method(:name)
+            .on(instance)
+        end
+      end
+
+      context 'when passing override as false' do
+        let(:options_hash) { { override: false } }
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to change(decorator, :attributes_map)
+            .from({})
+            .to({ name: expected_options })
+        end
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .not_to change_method(:name)
+            .on(instance)
+        end
+      end
+    end
+
+    context 'when passing reader option' do
+      context 'when option is true' do
+        let(:options_hash) { { reader: true } }
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to change(decorator, :attributes_map)
+            .from({})
+            .to({ name: expected_options })
+        end
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to add_method(:name).to(decorator)
+        end
+      end
+
+      context 'when option is false' do
+        let(:options_hash) { { reader: false } }
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .to change(decorator, :attributes_map)
+            .from({})
+            .to({ name: expected_options })
+        end
+
+        it do
+          expect { decorator.send(:expose, :name, **options_hash) }
+            .not_to add_method(:name).to(decorator)
+        end
+      end
+    end
   end
 
   describe '#as_json' do
@@ -323,12 +416,10 @@ describe Azeroth::Decorator do
     end
 
     context 'when method is private and passing include_private' do
-      # rubocop:disable RSpec/PredicateMatcher
       it do
         expect(decorator.respond_to?(:private_name, true))
           .to be_truthy
       end
-      # rubocop:enable RSpec/PredicateMatcher
     end
 
     context 'when object does not respond to it' do

data/spec/lib/azeroth/request_handler/pagination_spec.rb

@@ -0,0 +1,133 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Azeroth::RequestHandler::Pagination do
+  subject(:pagination) { described_class.new(params, options) }
+
+  let(:options)      { Azeroth::Options.new(options_hash) }
+  let(:options_hash) { {} }
+  let(:params)       { ActionController::Parameters.new(parameters) }
+  let(:parameters)   { {} }
+
+  describe '#offset' do
+    context 'when nothing was defined' do
+      it do
+        expect(pagination.offset).to be_zero
+      end
+    end
+
+    context 'when parameters has page value' do
+      let(:parameters)        { { page: page } }
+      let(:page)              { Random.rand(1..10) }
+      let(:expected_offset)   { (page - 1) * expected_per_page }
+      let(:expected_per_page) { 20 }
+
+      it 'returns value from request using default per_page' do
+        expect(pagination.offset).to eq(expected_offset)
+      end
+    end
+
+    context 'when parameters has per_page value' do
+      let(:parameters)        { { per_page: per_page } }
+      let(:per_page)          { Random.rand(1..10) }
+
+      it do
+        expect(pagination.offset).to be_zero
+      end
+    end
+
+    context 'when parameters has page and per page values' do
+      let(:parameters)        { { page: page, per_page: per_page } }
+      let(:page)              { Random.rand(1..10) }
+      let(:per_page)          { Random.rand(1..10) }
+      let(:expected_offset)   { (page - 1) * expected_per_page }
+      let(:expected_per_page) { per_page }
+
+      it 'returns value from request' do
+        expect(pagination.offset).to eq(expected_offset)
+      end
+    end
+
+    context 'when parameters has page and options per page values' do
+      let(:parameters)        { { page: page } }
+      let(:options_hash)      { { per_page: per_page } }
+      let(:page)              { Random.rand(1..10) }
+      let(:per_page)          { Random.rand(1..10) }
+      let(:expected_offset)   { (page - 1) * expected_per_page }
+      let(:expected_per_page) { per_page }
+
+      it 'returns value from request and options' do
+        expect(pagination.offset).to eq(expected_offset)
+      end
+    end
+
+    context 'when params has page and per_page and options per page values' do
+      let(:parameters)        { { page: page, per_page: per_page } }
+      let(:options_hash)      { { per_page: options_per_page } }
+      let(:page)              { Random.rand(1..10) }
+      let(:options_per_page)  { Random.rand(1..10) }
+      let(:per_page)          { Random.rand(1..10) }
+      let(:expected_offset)   { (page - 1) * expected_per_page }
+      let(:expected_per_page) { per_page }
+
+      it 'returns value from request' do
+        expect(pagination.offset).to eq(expected_offset)
+      end
+    end
+  end
+
+  describe '#limit' do
+    context 'when nothing was defined' do
+      it 'returns default value' do
+        expect(pagination.limit).to eq(20)
+      end
+    end
+
+    context 'when parameters has per_page' do
+      let(:parameters) { { per_page: per_page } }
+      let(:per_page)   { Random.rand(1..10) }
+
+      it 'returns value from request' do
+        expect(pagination.limit).to eq(per_page)
+      end
+    end
+
+    context 'when options has per_page' do
+      let(:options_hash) { { per_page: per_page } }
+      let(:per_page)     { Random.rand(1..10) }
+
+      it 'returns value from options' do
+        expect(pagination.limit).to eq(per_page)
+      end
+    end
+
+    context 'when params and options have per_page' do
+      let(:parameters)       { { per_page: per_page } }
+      let(:per_page)         { Random.rand(1..10) }
+      let(:options_hash)     { { per_page: options_per_page } }
+      let(:options_per_page) { Random.rand(1..10) }
+
+      it 'returns value from request' do
+        expect(pagination.limit).to eq(per_page)
+      end
+    end
+  end
+
+  describe '#current_page' do
+    context 'when nothing was defined' do
+      it 'returns first page' do
+        expect(pagination.current_page).to eq(1)
+      end
+    end
+
+    context 'when parameters has page' do
+      let(:parameters) { { page: page } }
+      let(:page)       { Random.rand(1..10) }
+
+      it 'returns value from request' do
+        expect(pagination.current_page).to eq(page)
+      end
+    end
+  end
+end

data/spec/lib/azeroth/request_handler/update_spec.rb

@@ -30,7 +30,7 @@ describe Azeroth::RequestHandler::Update do
       end
     end
 
-    context 'when update_with option is given ' do
+    context 'when update_with option is given' do
       context 'with block' do
         it_behaves_like 'a request handler' do
           let(:block) do

data/spec/spec_helper.rb

@@ -22,7 +22,7 @@ require 'shoulda-matchers'
 require 'rspec/collection_matchers'
 
 support_files = File.expand_path('spec/support/**/*.rb')
-Dir[support_files].sort.each { |file| require file }
+Dir[support_files].each { |file| require file }
 
 RSpec::Matchers.define_negated_matcher :not_change, :change
 RSpec::Matchers.define_negated_matcher :not_add_method, :add_method

data/spec/support/app/controllers/controller.rb

@@ -4,6 +4,7 @@ require 'action_controller'
 
 class Controller < ActionController::Base
   def initialize(params = {})
+    super()
     @params = ActionController::Parameters.new(params)
   end
 

data/spec/support/matchers/add_method.rb

@@ -6,11 +6,12 @@ module RSpec
       attr_reader :method
 
       def initialize(method = nil)
+        super
         @method = method
       end
 
-      def to(instance = nil, &block)
-        AddMethodTo.new(instance, method, &block)
+      def to(instance = nil, &)
+        AddMethodTo.new(instance, method, &)
       end
     end
 
@@ -18,6 +19,7 @@ module RSpec
       attr_reader :method, :instance, :block
 
       def initialize(instance, method, &block)
+        super
         @instance = instance
         @method = method
         @block = block
@@ -68,8 +70,8 @@ module RSpec
 
       def raise_block_syntax_error
         raise SyntaxError, 'Block not received by the' \
-        '`add_method_to` matcher. ' \
-        'Perhaps you want to use `{ ... }` instead of do/end?'
+                           '`add_method_to` matcher. ' \
+                           'Perhaps you want to use `{ ... }` instead of do/end?'
       end
     end
   end

data/spec/support/shared_examples/request_handler.rb

@@ -29,15 +29,11 @@ shared_examples 'a request handler' do |status: :ok|
   before do
     create_list(:document, documents_count)
 
-    allow(controller).to receive(:params)
-      .and_return(params)
-
     allow(controller).to receive(:render)
       .with(json: expected_json, status: status)
       .and_return(expected_json)
 
-    allow(controller).to receive(:headers)
-      .and_return(controller_headers)
+    allow(controller).to receive_messages(params: params, headers: controller_headers)
   end
 
   it 'returns all documents json' do