azeroth 0.6.5 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e28a5c409533eebedc8579f02941b55a956b8296459243b8cf5572857f64d1c
-  data.tar.gz: ba50b329165868a7b2a65b4762a20c91898c45593bedc528e440d6d51b9fae01
+  metadata.gz: 197968637291c04e3ce145d6d5dd9f84451e4b47d104d420aef7c1a5e7b999dc
+  data.tar.gz: 9936013b82fcc56048027c6a469130bc15913e095c5373a9b3b50d577d2fcc93
 SHA512:
-  metadata.gz: 38ca1d96bf67471f7eb0bdd1c626832e534c9418646d09d2381659096c1739a8d06b592a8c4063e1068f4e2fa8502bc9fcc25f2a9e6c998c659459eea837325c
-  data.tar.gz: 9cb5e259c5f9961d60d6ae8c50563ada7d45ab2a850f2cf79dfd8977d5b30b53ea9e029617466d19a237c2256db3c6491fe9a674cb463ad074e76b78693852ee
+  metadata.gz: d05f185b913c3ac80e58bfad3cdcfea1de68c4836251d5a121826961bf3779adc3e9b39e4dff6d92e72204a4bc8d355d063f0b910c4607dad17f741206a31149
+  data.tar.gz: 85e4d4c4625e36fd40358bf486e5bb2dd81fef82cc6fbf198545b6fdad51642d63d3ee5af2e828d0cf394ca0dfbf7aff5efd568634517a1c5236a79901275915

data/.circleci/config.yml

@@ -1,8 +1,24 @@
 version: 2
+workflows:
+  version: 2
+  test-and-build:
+    jobs:
+      - test:
+          filters:
+            tags:
+              only: /.*/
+      - build-and-release:
+          requires: [test]
+          filters:
+            tags:
+              only: /\d+\.\d+\.\d+/
+            branches:
+              only:
+                - master
 jobs:
-  build:
+  test:
     docker:
-      - image: darthjee/circleci_rails_gems:0.5.1
+      - image: darthjee/circleci_rails_gems:0.6.3
         environment:
           PROJECT: azeroth
     steps:
@@ -34,3 +50,22 @@ jobs:
       - run:
           name: Check unit tests
           command: check_specs
+  build-and-release:
+    docker:
+      - image: darthjee/circleci_rails_gems:0.6.3
+        environment:
+          PROJECT: azeroth
+    steps:
+      - checkout
+      - run:
+          name: Bundle Install
+          command: bundle install
+      - run:
+          name: Signin
+          command: build_gem.sh signin
+      - run:
+          name: Build Gem
+          command: build_gem.sh build
+      - run:
+          name: Push Gem
+          command: build_gem.sh push

data/Dockerfile

@@ -1,5 +1,5 @@
-FROM darthjee/rails_gems:0.5.2 as base
-FROM darthjee/scripts:0.1.7 as scripts
+FROM darthjee/rails_gems:0.7.0 as base
+FROM darthjee/scripts:0.1.8 as scripts
 
 ######################################
 

data/README.md

@@ -11,7 +11,7 @@ Azeroth
 
 Yard Documentation
 -------------------
-[https://www.rubydoc.info/gems/azeroth/0.6.5](https://www.rubydoc.info/gems/azeroth/0.6.5)
+[https://www.rubydoc.info/gems/azeroth/0.7.4](https://www.rubydoc.info/gems/azeroth/0.7.4)
 
 Azeroth has been designed making the coding of controllers easier
 as routes in controllers are usually copy, paste and replace of same
@@ -25,6 +25,25 @@ does not perform database operations
 Future versions will enable `html` rendering to also perform
 database operations.
 
+Installation
+---------------
+
+- Install it
+
+```ruby
+  gem install azeroth
+```
+
+- Or add Sinclair to your `Gemfile` and `bundle install`:
+
+```ruby
+  gem 'azeroth'
+```
+
+```bash
+  bundle install azeroth
+```
+
 Usage
 -----
 
@@ -36,9 +55,12 @@ which adds a resource and action methods for `create`, `show`, `index`,
 `update`, `delete`, `edit`
 
 It accepts options
-- only List of actions to be built
-- except List of actions to not to be built
-- decorator Decorator class or flag allowing/disallowing decorators
+- only: List of actions to be built
+- except: List of actions to not to be built
+- decorator: Decorator class or flag allowing/disallowing decorators
+- before_save: Method/Proc to be ran before saving the resource on create or update
+- after_save: Method/Proc to be ran after saving the resource on create or update
+- build_with: Method/Block to be ran when building the reource on create
 
 ```ruby
   # publishers_controller.rb
@@ -76,6 +98,36 @@ It accepts options
   end
 ```
 
+```ruby
+  # pokemons_controller.rb
+
+  class PokemonsController < ApplicationController
+    include Azeroth::Resourceable
+
+    resource_for :pokemon,
+                 only: %i[create update],
+                 before_save: :set_favorite
+
+    private
+
+    def set_favorite
+      pokemon.favorite = true
+    end
+
+    def pokemons
+      master.pokemons
+    end
+
+    def master
+      @master ||= PokemonMaster.find(master_id)
+    end
+
+    def master_id
+      params.require(:pokemon_master_id)
+    end
+  end
+```
+
 ## Azeroth::Decorator
 
 [Decorators](https://www.rubydoc.info/gems/azeroth/Azeroth/Decorator) are

data/azeroth.gemspec

@@ -18,32 +18,33 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
 
-  gem.add_runtime_dependency 'activesupport',       '~> 5.2.0'
+  gem.add_runtime_dependency 'activesupport',       '~> 5.2.x'
   gem.add_runtime_dependency 'darthjee-active_ext', '>= 1.3.2'
-  gem.add_runtime_dependency 'sinclair',            '>= 1.6.4'
+  gem.add_runtime_dependency 'jace',                '>= 0.0.3'
+  gem.add_runtime_dependency 'sinclair',            '>= 1.6.7'
 
-  gem.add_development_dependency 'actionpack',               '5.2.4.2'
-  gem.add_development_dependency 'activerecord',             '5.2.4.2'
+  gem.add_development_dependency 'actionpack',               '~> 5.2.x'
+  gem.add_development_dependency 'activerecord',             '~> 5.2.x'
   gem.add_development_dependency 'bundler',                  '1.16.1'
   gem.add_development_dependency 'factory_bot',              '5.2.0'
-  gem.add_development_dependency 'nokogiri',                 '1.10.9'
+  gem.add_development_dependency 'nokogiri',                 '1.11.4'
   gem.add_development_dependency 'pry',                      '0.12.2'
   gem.add_development_dependency 'pry-nav',                  '0.3.0'
-  gem.add_development_dependency 'rails',                    '5.2.4.2'
+  gem.add_development_dependency 'rails',                    '~> 5.2.x'
   gem.add_development_dependency 'rails-controller-testing', '1.0.4'
-  gem.add_development_dependency 'rake',                     '13.0.1'
-  gem.add_development_dependency 'reek',                     '5.6.0'
+  gem.add_development_dependency 'rake',                     '13.0.3'
+  gem.add_development_dependency 'reek',                     '6.0.3'
   gem.add_development_dependency 'rspec',                    '3.9.0'
-  gem.add_development_dependency 'rspec-core',               '3.9.1'
-  gem.add_development_dependency 'rspec-expectations',       '3.9.1'
+  gem.add_development_dependency 'rspec-core',               '3.9.3'
+  gem.add_development_dependency 'rspec-expectations',       '3.9.4'
   gem.add_development_dependency 'rspec-mocks',              '3.9.1'
   gem.add_development_dependency 'rspec-rails',              '3.9.0'
-  gem.add_development_dependency 'rspec-support',            '3.9.2'
+  gem.add_development_dependency 'rspec-support',            '3.9.4'
   gem.add_development_dependency 'rubocop',                  '0.80.1'
   gem.add_development_dependency 'rubocop-rspec',            '1.38.1'
-  gem.add_development_dependency 'rubycritic',               '4.4.1'
+  gem.add_development_dependency 'rubycritic',               '4.6.1'
   gem.add_development_dependency 'simplecov',                '0.17.1'
   gem.add_development_dependency 'sqlite3',                  '1.4.2'
-  gem.add_development_dependency 'yard',                     '0.9.24'
+  gem.add_development_dependency 'yard',                     '0.9.26'
   gem.add_development_dependency 'yardstick',                '0.9.9'
 end

data/lib/azeroth.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'sinclair'
+require 'jace'
 
 # @api public
 #

data/lib/azeroth/model.rb

@@ -62,6 +62,8 @@ module Azeroth
     #
     # @return [Azeroth::Options]
 
+    delegate :decorator, to: :options
+
     # @private
     #
     # Returns decorator class for the object
@@ -85,7 +87,7 @@ module Azeroth
     # @return [Azeroth::Decorator,DummyDecorator]
     def calculate_decorator_class
       return DummyDecorator unless options.decorator
-      return options.decorator if options.decorator.is_a?(Class)
+      return decorator if decorator.is_a?(Class)
 
       klass::Decorator
     rescue NameError

data/lib/azeroth/options.rb

@@ -10,10 +10,17 @@ module Azeroth
   #   Sinclair::Options
   class Options < Sinclair::Options
     # Default options
+    #
+    # @api public
+    #
+    # @see Resourceable::ClassMethods#resource_for
     DEFAULT_OPTIONS = {
       only: %i[create destroy edit index new show update],
       except: [],
-      decorator: true
+      decorator: true,
+      before_save: nil,
+      after_save: nil,
+      build_with: nil
     }.freeze
 
     with_options DEFAULT_OPTIONS
@@ -25,6 +32,20 @@ module Azeroth
       [only].flatten.map(&:to_sym) - [except].flatten.map(&:to_sym)
     end
 
+    # Returns event dispatcher
+    #
+    # Event dispatcher is responsible for
+    # sending events such as +before_save+
+    # to it's correct calling point
+    #
+    # @return [Jace::Dispatcher]
+    def event_dispatcher(event)
+      Jace::Dispatcher.new(
+        before: try("before_#{event}"),
+        after: try("after_#{event}")
+      )
+    end
+
     # @method only
     # @api private
     #
@@ -50,5 +71,34 @@ module Azeroth
     # model.as_json
     #
     # @return [Decorator,TrueClass,FalseClass]
+
+    # @method before_save
+    # @api private
+    #
+    # Block or method name to be run before save
+    #
+    # The given method or block will be ran
+    # before committing changes in models
+    # to database
+    #
+    # @return [Symbol,Proc]
+
+    # @method after_save
+    # @api private
+    #
+    # Block or method name to be run after save
+    #
+    # The given method or block will be ran
+    # after committing changes in models
+    # to database
+    #
+    # @return [Symbol,Proc]
+
+    # @method build_with
+    # @api private
+    #
+    # Block or method name to be ran when building the resource
+    #
+    # @return [Symbol,Proc]
   end
 end

data/lib/azeroth/request_handler.rb

@@ -18,9 +18,10 @@ module Azeroth
 
     # @param controller [ApplicationController]
     # @param model [Azeroth::Model]
-    def initialize(controller, model)
+    def initialize(controller, model, options)
       @controller = controller
       @model = model
+      @options = options
     end
 
     # process the request
@@ -44,7 +45,7 @@ module Azeroth
 
     private
 
-    attr_reader :controller, :model
+    attr_reader :controller, :model, :options
     # @method controller
     # @api private
     # @private
@@ -61,6 +62,14 @@ module Azeroth
     #
     # @return [Azeroth::Model]
 
+    # @method options
+    # @api private
+    # @private
+    #
+    # Handling options
+    #
+    # @return [Azeroth::Options]
+
     delegate :params, to: :controller
     # @method params
     # @api private
@@ -104,5 +113,33 @@ module Azeroth
     def status
       :ok
     end
+
+    # @private
+    #
+    # Run a block triggering the event
+    #
+    # @return [Object] Result of given block
+    def trigger_event(event, &block)
+      options.event_dispatcher(event)
+             .dispatch(controller, &block)
+    end
+
+    # @private
+    #
+    # Attributes to be used on resource creating
+    #
+    # @return [Hash]
+    def attributes
+      @attributes ||= controller.send("#{model.name}_params")
+    end
+
+    # @private
+    #
+    # Collection scope of the resource
+    #
+    # @return [ActiveRecord::Relation]
+    def collection
+      @collection = controller.send(model.plural)
+    end
   end
 end

data/lib/azeroth/request_handler/create.rb

@@ -8,6 +8,8 @@ module Azeroth
     class Create < RequestHandler
       private
 
+      delegate :build_with, to: :options
+
       # @private
       #
       # Creates and return an instance of the model
@@ -17,16 +19,40 @@ module Azeroth
       #
       # @return [Object]
       def resource
-        @resource ||= build_resource
+        @resource ||= build_and_save_resource
       end
 
-      # build resource for create
+      # @private
+      #
+      # build resource for create and save it
       #
       # @return [Object]
+      def build_and_save_resource
+        @resource = build_resource
+        controller.instance_variable_set("@#{model.name}", resource)
+
+        trigger_event(:save) do
+          resource.tap(&:save)
+        end
+      end
+
+      # @private
+      #
+      # build resource without saving it
+      #
+      # when +build_with+ option is given, the proc/method
+      # is called instead of collection.build
+      #
+      # @return [Object] resource built
       def build_resource
-        attributes = controller.send("#{model.name}_params")
-        collection = controller.send(model.plural)
-        collection.create(attributes)
+        return collection.build(attributes) unless build_with
+
+        case build_with
+        when Proc
+          controller.instance_eval(&build_with)
+        else
+          controller.send(build_with)
+        end
       end
 
       # @private

data/lib/azeroth/request_handler/update.rb

@@ -24,10 +24,10 @@ module Azeroth
       #
       # @return [Object]
       def update_resource
-        attributes = controller.send("#{model.name}_params")
-
         controller.send(model.name).tap do |entry|
-          entry.update(attributes)
+          trigger_event(:save) do
+            entry.update(attributes)
+          end
         end
       end