azeroth 0.6.4 → 0.7.3

data/lib/azeroth/resourceable/class_methods.rb

@@ -9,18 +9,11 @@ module Azeroth
     module ClassMethods
       # Adds resource methods for resource
       #
-      # @param name [String, Symbol] Name of the resource
-      # @param options [Hash] resource building options
-      # @option options only [Array<Symbol,String>] List of
-      #   actions to be built
-      # @option options except [Array<Symbol,String>] List of
-      #   actions to not to be built
-      # @option options decorator [Azeroth::Decorator,TrueClass,FalseClass]
-      #   Decorator class or flag allowing/disallowing decorators
+      # @param (see Resourceable.resource_for)
+      # @option (see Resourceable.resource_for)
+      # @return (see Resourceable.resource_for)
       #
-      # @return [Array<MethodDefinition>] list of methods created
-      #
-      # @see Options
+      # @see (see Resourceable.resource_for)
       #
       # @example Controller without delete
       #   class DocumentsController < ApplicationController
@@ -124,6 +117,33 @@ module Azeroth
       #   #     name: 'Nintendo'
       #   # }
       #   }
+      #
+      # @example Controller with before_save
+      #   class PokemonsController < ApplicationController
+      #     include Azeroth::Resourceable
+      #
+      #     resource_for :pokemon,
+      #                  only: %i[create update],
+      #                  before_save: :set_favorite
+      #
+      #     private
+      #
+      #     def set_favorite
+      #       pokemon.favorite = true
+      #     end
+      #
+      #     def pokemons
+      #       master.pokemons
+      #     end
+      #
+      #     def master
+      #       @master ||= PokemonMaster.find(master_id)
+      #     end
+      #
+      #     def master_id
+      #       params.require(:pokemon_master_id)
+      #     end
+      #   end
       def resource_for(name, **options)
         Builder.new(
           self, name, Azeroth::Options.new(options)

data/lib/azeroth/routes_builder.rb

@@ -62,13 +62,14 @@ module Azeroth
 
     def route_code(route)
       model_interface = model
+      options_object = options
       handler_class = Azeroth::RequestHandler.const_get(
         route.to_s.capitalize
       )
 
       proc do
         handler_class.new(
-          self, model_interface
+          self, model_interface, options_object
         ).process
       end
     end

data/lib/azeroth/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Azeroth
-  VERSION = '0.6.4'
+  VERSION = '0.7.3'
 end

data/spec/controllers/pokemon_masters_controller_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe PokemonMastersController do
+  describe 'POST create' do
+    let(:parameters) do
+      {
+        format: :json,
+        pokemon_master: {
+          first_name: 'Ash'
+        }
+      }
+    end
+
+    it 'creates pokemon master' do
+      expect { post :create, params: parameters }
+        .to change(PokemonMaster, :count)
+        .by(1)
+    end
+
+    it 'updates pokemon master age' do
+      post :create, params: parameters
+
+      expect(PokemonMaster.last.age).to eq(10)
+    end
+  end
+
+  describe 'POST update' do
+    let(:master) do
+      create(:pokemon_master, age: 20, last_name: nil)
+    end
+
+    let(:parameters) do
+      {
+        id: master.id,
+        format: :json,
+        pokemon_master: { last_name: 'Joe' }
+      }
+    end
+
+    it 'updates pokemon master' do
+      expect { post :update, params: parameters }
+        .to change { master.reload.last_name }
+        .from(nil)
+        .to('Joe')
+    end
+
+    it 'updates pokemon master age' do
+      expect { post :update, params: parameters }
+        .to change { master.reload.age }
+        .from(20)
+        .to(10)
+    end
+  end
+end

data/spec/controllers/pokemons_controller_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe PokemonsController do
+  let(:master) { create(:pokemon_master) }
+
+  describe 'POST create' do
+    let(:parameters) do
+      {
+        pokemon_master_id: master.id,
+        format: :json,
+        pokemon: { name: 'Bulbasaur' }
+      }
+    end
+
+    it 'creates pokemon' do
+      expect { post :create, params: parameters }
+        .to change(Pokemon, :count)
+        .by(1)
+    end
+
+    it 'updates pokemon to be favorite' do
+      expect { post :create, params: parameters }
+        .to change { master.reload.favorite_pokemon }
+        .from(nil)
+    end
+  end
+
+  describe 'POST update' do
+    let(:pokemon) { create(:pokemon) }
+    let(:master)  { pokemon.pokemon_master }
+
+    let(:parameters) do
+      {
+        pokemon_master_id: master.id,
+        id: pokemon.id,
+        format: :json,
+        pokemon: { name: 'Butterfree' }
+      }
+    end
+
+    it 'updates pokemon' do
+      expect { post :update, params: parameters }
+        .to change { pokemon.reload.name }
+        .from('Bulbasaur')
+        .to('Butterfree')
+    end
+
+    it 'updates pokemon to be favorite' do
+      expect { post :update, params: parameters }
+        .to change { pokemon.reload.favorite }
+        .from(nil)
+    end
+  end
+end

data/spec/dummy/app/controllers/pokemon_masters_controller.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class PokemonMastersController < ApplicationController
+  include Azeroth::Resourceable
+
+  resource_for :pokemon_master,
+               only: %i[create update],
+               before_save: proc { pokemon_master.age = 10 }
+end

data/spec/dummy/app/controllers/pokemons_controller.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+class PokemonsController < ApplicationController
+  include Azeroth::Resourceable
+
+  resource_for :pokemon,
+               only: %i[create update],
+               before_save: :set_favorite
+
+  private
+
+  def set_favorite
+    pokemon.favorite = true
+  end
+
+  def pokemons
+    master.pokemons
+  end
+
+  def master
+    @master ||= PokemonMaster.find(master_id)
+  end
+
+  def master_id
+    params.require(:pokemon_master_id)
+  end
+end

data/spec/dummy/config/routes.rb

@@ -8,4 +8,8 @@ Rails.application.routes.draw do
   resources :publishers, only: %i[create index] do
     resources :games, except: :delete
   end
+
+  resources :pokemon_masters, only: %i[create update] do
+    resources :pokemons, only: %i[create update]
+  end
 end

data/spec/lib/azeroth/decorator/key_value_extractor_spec.rb

@@ -227,5 +227,37 @@ describe Azeroth::Decorator::KeyValueExtractor do
         end
       end
     end
+
+    context 'when value is nil' do
+      context 'without decorator options' do
+        let(:object) { build(:document, name: nil) }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator false' do
+        let(:object)       { build(:document, name: nil) }
+        let(:options_hash) { { decorator: false } }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator option' do
+        let(:object)       { create(:pokemon_master) }
+        let(:options_hash) { { decorator: Pokemon::Decorator } }
+        let(:attribute)    { :favorite_pokemon }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'favorite_pokemon' => nil })
+        end
+      end
+    end
   end
 end

data/spec/lib/azeroth/decorator_spec.rb

@@ -62,6 +62,12 @@ describe Azeroth::Decorator do
   end
 
   describe '#as_json' do
+    context 'when object is nil' do
+      let(:object) { nil }
+
+      it { expect(decorator.as_json).to be_nil }
+    end
+
     context 'when object is just a model' do
       let(:expected_json) do
         {
@@ -166,7 +172,7 @@ describe Azeroth::Decorator do
       end
     end
 
-    context 'with decotator for model with validation' do
+    context 'with decorator for model with validation' do
       subject(:decorator) do
         Document::DecoratorWithError.new(object)
       end
@@ -255,6 +261,26 @@ describe Azeroth::Decorator do
           expect(decorator.as_json).to eq(expected_json)
         end
       end
+
+      context 'with nil value and defined decorator' do
+        subject(:decorator) do
+          Factory::DecoratorWithProduct.new(factory)
+        end
+
+        let(:factory) { create(:factory) }
+
+        let(:expected_json) do
+          {
+            name: factory.name,
+            main_product: nil,
+            products: []
+          }.deep_stringify_keys
+        end
+
+        it 'exposes relation' do
+          expect(decorator.as_json).to eq(expected_json)
+        end
+      end
     end
   end
 
@@ -262,7 +288,7 @@ describe Azeroth::Decorator do
     subject(:decorator) { decorator_class.new(object) }
 
     let(:decorator_class) { Class.new(described_class) }
-    let(:model) { build(:dummy_model) }
+    let(:model)           { build(:dummy_model) }
 
     it 'delegates methods to object' do
       expect(decorator.first_name).not_to be_nil

data/spec/lib/azeroth/request_handler/create_spec.rb

@@ -23,6 +23,172 @@ describe Azeroth::RequestHandler::Create do
           .by(1)
       end
     end
+
+    context 'with before_save block option' do
+      it_behaves_like 'a request handler', status: :created do
+        let(:block) do
+          value = 10
+          proc do
+            document.reference = "X-MAGIC-#{value}"
+          end
+        end
+
+        let(:options_hash) do
+          {
+            before_save: block
+          }
+        end
+
+        let(:extra_params) do
+          {
+            document: {
+              name: 'My Document'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'My Document',
+            'reference' => 'X-MAGIC-10'
+          }
+        end
+
+        it 'creates entry' do
+          expect { handler.process }
+            .to change(Document, :count)
+            .by(1)
+        end
+
+        it 'changes entry before saving' do
+          handler.process
+
+          expect(Document.last.reference)
+            .to eq('X-MAGIC-10')
+        end
+      end
+    end
+
+    context 'with before_save symbol option' do
+      it_behaves_like 'a request handler', status: :created do
+        let(:options_hash) do
+          {
+            before_save: :add_magic_reference
+          }
+        end
+
+        let(:extra_params) do
+          {
+            document: {
+              name: 'My Document'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'My Document',
+            'reference' => 'X-MAGIC-15'
+          }
+        end
+
+        it 'creates entry' do
+          expect { handler.process }
+            .to change(Document, :count)
+            .by(1)
+        end
+
+        it 'changes entry before saving' do
+          handler.process
+
+          expect(Document.last.reference)
+            .to eq('X-MAGIC-15')
+        end
+      end
+    end
+  end
+
+  context 'with build_with as symbol' do
+    it_behaves_like 'a request handler', status: :created do
+      let(:options_hash) do
+        {
+          build_with: :build_magic_document
+        }
+      end
+
+      let(:extra_params) do
+        {
+          document: {
+            name: 'My Document'
+          }
+        }
+      end
+
+      let(:expected_json) do
+        {
+          'name' => 'My Document',
+          'reference' => 'X-MAGIC-15'
+        }
+      end
+
+      it 'creates entry' do
+        expect { handler.process }
+          .to change(Document, :count)
+          .by(1)
+      end
+
+      it 'builds entity with custom method' do
+        handler.process
+
+        expect(Document.last.reference)
+          .to eq('X-MAGIC-15')
+      end
+    end
+  end
+
+  context 'with build_with as block' do
+    it_behaves_like 'a request handler', status: :created do
+      let(:block) do
+        proc do
+          documents.where(reference: 'X-MAGIC-20')
+                   .build(document_params)
+        end
+      end
+
+      let(:options_hash) do
+        {
+          build_with: block
+        }
+      end
+
+      let(:extra_params) do
+        {
+          document: {
+            name: 'My Document'
+          }
+        }
+      end
+
+      let(:expected_json) do
+        {
+          'name' => 'My Document',
+          'reference' => 'X-MAGIC-20'
+        }
+      end
+
+      it 'creates entry' do
+        expect { handler.process }
+          .to change(Document, :count)
+          .by(1)
+      end
+
+      it 'builds entity with custom method' do
+        handler.process
+
+        expect(Document.last.reference)
+          .to eq('X-MAGIC-20')
+      end
+    end
   end
 
   context 'when payload is invalid' do