azeroth 0.6.3 → 0.7.2

data/spec/integration/yard/controllers/games_controller_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe GamesController, controller: true do
+  describe 'yard' do
+    describe 'POST create' do
+      it 'create game' do
+        post '/publishers.json', params: {
+          publisher: {
+            name: 'Nintendo'
+          }
+        }
+
+        publisher = JSON.parse(response.body)
+        expect(publisher)
+          .to eq({
+                   'id' => publisher['id'],
+                   'name' => 'Nintendo'
+                 })
+
+        publisher = Publisher.last
+        post "/publishers/#{publisher['id']}/games.json", params: {
+          game: {
+            name: 'Pokemon'
+          }
+        }
+
+        game = Game.last
+
+        expect(JSON.parse(response.body))
+          .to eq({
+                   'id' => game.id,
+                   'name' => 'Pokemon',
+                   'publisher' => {
+                     'name' => 'Nintendo'
+                   }
+                 })
+      end
+    end
+  end
+end

data/spec/lib/azeroth/decorator/key_value_extractor_spec.rb

@@ -227,5 +227,37 @@ describe Azeroth::Decorator::KeyValueExtractor do
         end
       end
     end
+
+    context 'when value is nil' do
+      context 'without decorator options' do
+        let(:object) { build(:document, name: nil) }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator false' do
+        let(:object)       { build(:document, name: nil) }
+        let(:options_hash) { { decorator: false } }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'name' => nil })
+        end
+      end
+
+      context 'with decorator option' do
+        let(:object)       { create(:pokemon_master) }
+        let(:options_hash) { { decorator: Pokemon::Decorator } }
+        let(:attribute)    { :favorite_pokemon }
+
+        it 'returns nil for value' do
+          expect(extractor.as_json)
+            .to eq({ 'favorite_pokemon' => nil })
+        end
+      end
+    end
   end
 end

data/spec/lib/azeroth/decorator_spec.rb

@@ -62,6 +62,12 @@ describe Azeroth::Decorator do
   end
 
   describe '#as_json' do
+    context 'when object is nil' do
+      let(:object) { nil }
+
+      it { expect(decorator.as_json).to be_nil }
+    end
+
     context 'when object is just a model' do
       let(:expected_json) do
         {
@@ -166,7 +172,7 @@ describe Azeroth::Decorator do
       end
     end
 
-    context 'with decotator for model with validation' do
+    context 'with decorator for model with validation' do
       subject(:decorator) do
         Document::DecoratorWithError.new(object)
       end
@@ -255,6 +261,26 @@ describe Azeroth::Decorator do
           expect(decorator.as_json).to eq(expected_json)
         end
       end
+
+      context 'with nil value and defined decorator' do
+        subject(:decorator) do
+          Factory::DecoratorWithProduct.new(factory)
+        end
+
+        let(:factory) { create(:factory) }
+
+        let(:expected_json) do
+          {
+            name: factory.name,
+            main_product: nil,
+            products: []
+          }.deep_stringify_keys
+        end
+
+        it 'exposes relation' do
+          expect(decorator.as_json).to eq(expected_json)
+        end
+      end
     end
   end
 
@@ -262,7 +288,7 @@ describe Azeroth::Decorator do
     subject(:decorator) { decorator_class.new(object) }
 
     let(:decorator_class) { Class.new(described_class) }
-    let(:model) { build(:dummy_model) }
+    let(:model)           { build(:dummy_model) }
 
     it 'delegates methods to object' do
       expect(decorator.first_name).not_to be_nil

data/spec/lib/azeroth/request_handler/create_spec.rb

@@ -23,6 +23,172 @@ describe Azeroth::RequestHandler::Create do
           .by(1)
       end
     end
+
+    context 'with before_save block option' do
+      it_behaves_like 'a request handler', status: :created do
+        let(:block) do
+          value = 10
+          proc do
+            document.reference = "X-MAGIC-#{value}"
+          end
+        end
+
+        let(:options_hash) do
+          {
+            before_save: block
+          }
+        end
+
+        let(:extra_params) do
+          {
+            document: {
+              name: 'My Document'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'My Document',
+            'reference' => 'X-MAGIC-10'
+          }
+        end
+
+        it 'creates entry' do
+          expect { handler.process }
+            .to change(Document, :count)
+            .by(1)
+        end
+
+        it 'changes entry before saving' do
+          handler.process
+
+          expect(Document.last.reference)
+            .to eq('X-MAGIC-10')
+        end
+      end
+    end
+
+    context 'with before_save symbol option' do
+      it_behaves_like 'a request handler', status: :created do
+        let(:options_hash) do
+          {
+            before_save: :add_magic_reference
+          }
+        end
+
+        let(:extra_params) do
+          {
+            document: {
+              name: 'My Document'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'My Document',
+            'reference' => 'X-MAGIC-15'
+          }
+        end
+
+        it 'creates entry' do
+          expect { handler.process }
+            .to change(Document, :count)
+            .by(1)
+        end
+
+        it 'changes entry before saving' do
+          handler.process
+
+          expect(Document.last.reference)
+            .to eq('X-MAGIC-15')
+        end
+      end
+    end
+  end
+
+  context 'with build_with as symbol' do
+    it_behaves_like 'a request handler', status: :created do
+      let(:options_hash) do
+        {
+          build_with: :build_magic_document
+        }
+      end
+
+      let(:extra_params) do
+        {
+          document: {
+            name: 'My Document'
+          }
+        }
+      end
+
+      let(:expected_json) do
+        {
+          'name' => 'My Document',
+          'reference' => 'X-MAGIC-15'
+        }
+      end
+
+      it 'creates entry' do
+        expect { handler.process }
+          .to change(Document, :count)
+          .by(1)
+      end
+
+      it 'builds entity with custom method' do
+        handler.process
+
+        expect(Document.last.reference)
+          .to eq('X-MAGIC-15')
+      end
+    end
+  end
+
+  context 'with build_with as block' do
+    it_behaves_like 'a request handler', status: :created do
+      let(:block) do
+        proc do
+          documents.where(reference: 'X-MAGIC-20')
+                   .build(document_params)
+        end
+      end
+
+      let(:options_hash) do
+        {
+          build_with: block
+        }
+      end
+
+      let(:extra_params) do
+        {
+          document: {
+            name: 'My Document'
+          }
+        }
+      end
+
+      let(:expected_json) do
+        {
+          'name' => 'My Document',
+          'reference' => 'X-MAGIC-20'
+        }
+      end
+
+      it 'creates entry' do
+        expect { handler.process }
+          .to change(Document, :count)
+          .by(1)
+      end
+
+      it 'builds entity with custom method' do
+        handler.process
+
+        expect(Document.last.reference)
+          .to eq('X-MAGIC-20')
+      end
+    end
   end
 
   context 'when payload is invalid' do

data/spec/lib/azeroth/request_handler/update_spec.rb

@@ -30,6 +30,97 @@ describe Azeroth::RequestHandler::Update do
       end
     end
 
+    context 'with before_save block option' do
+      it_behaves_like 'a request handler' do
+        let(:block) do
+          value = 10
+          proc do
+            document.reference = "X-MAGIC-#{value}"
+          end
+        end
+
+        let(:options_hash) do
+          {
+            before_save: block
+          }
+        end
+
+        let(:expected_resource) { document }
+
+        let(:extra_params) do
+          {
+            id: document.id,
+            document: {
+              name: 'New Name'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'New Name',
+            'reference' => 'X-MAGIC-10'
+          }
+        end
+
+        it 'updates the values given by request' do
+          expect { handler.process }
+            .to change { document.reload.name }
+            .from(document.name)
+            .to('New Name')
+        end
+
+        it 'updates the values done by before_save' do
+          expect { handler.process }
+            .to change { document.reload.reference }
+            .from(nil)
+            .to('X-MAGIC-10')
+        end
+      end
+    end
+
+    context 'with before_save symbol option' do
+      it_behaves_like 'a request handler' do
+        let(:options_hash) do
+          {
+            before_save: :add_magic_reference
+          }
+        end
+
+        let(:expected_resource) { document }
+
+        let(:extra_params) do
+          {
+            id: document.id,
+            document: {
+              name: 'New Name'
+            }
+          }
+        end
+
+        let(:expected_json) do
+          {
+            'name' => 'New Name',
+            'reference' => 'X-MAGIC-15'
+          }
+        end
+
+        it 'updates the values given by request' do
+          expect { handler.process }
+            .to change { document.reload.name }
+            .from(document.name)
+            .to('New Name')
+        end
+
+        it 'updates the values done by before_save' do
+          expect { handler.process }
+            .to change { document.reload.reference }
+            .from(nil)
+            .to('X-MAGIC-15')
+        end
+      end
+    end
+
     context 'when payload is invalid' do
       it_behaves_like 'a request handler',
                       status: :unprocessable_entity do

data/spec/lib/azeroth/request_handler_spec.rb

@@ -4,7 +4,9 @@ require 'spec_helper'
 
 describe Azeroth::RequestHandler do
   describe '#process' do
-    subject(:handler) { handler_class.new(controller, model) }
+    subject(:handler) do
+      handler_class.new(controller, model, options)
+    end
 
     let(:controller) { controller_class.new }
     let(:params)     { ActionController::Parameters.new(parameters) }

data/spec/support/app/controllers/request_handler_controller.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class RequestHandlerController < ActionController::Base
+  private
+
   def document_params
     params.require(:document).permit(:name)
   end
@@ -10,6 +12,15 @@ class RequestHandlerController < ActionController::Base
   end
 
   def document
-    documents.find(params.require(:id))
+    @document ||= documents.find(params.require(:id))
+  end
+
+  def add_magic_reference
+    document.reference = 'X-MAGIC-15'
+  end
+
+  def build_magic_document
+    documents.where(reference: 'X-MAGIC-15')
+             .build(document_params)
   end
 end

data/spec/support/factories/game.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :game, class: '::Game' do
+    sequence(:name) { |n| "Game #{n}" }
+    publisher
+  end
+end