aygabtu 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6b0b899e98b001d66c42529c6070b7b5cd49129
-  data.tar.gz: 28884477631fe89aa365216d2ad84355d0748c04
+  metadata.gz: 820b903bfa3013e8b888d87c17d5c378fae75ecd
+  data.tar.gz: d2d923d2c5eeb6bc6f053d80daa871c5b6e251ed
 SHA512:
-  metadata.gz: 3d45b28adaf1d9ce713ca993aae6ef8405d0378f4e1ec9508c26d75a378f87619443c597c6238b0994735b3c04a16113fa02df0d30774f51d5da2b08e1529873
-  data.tar.gz: cc8db6af0efc3e617c64155f1755c87f0c1d25ff6ab95aa0671415e7055f2da4cebb3b4c3b1505f5906d84c9845d1f5137010f134981a178ac94b62c9dc8bbb5
+  metadata.gz: 7a78573431064dfe833d44a863991f901cf61b9cae68b359343df51b05c571c0b39f00f23dc07a1c2bbb3ebf2d7d755dfa2d853aed21245b4d29c3a0c7733ed9
+  data.tar.gz: 7758b5b65c947f5c9b9f35f42469378294a925915ae1c9ed75a2d6c6b09f976ad706a13c577f2dd4f4a0bf4859335f9ca7621f083487f695f6b8f3c2522e26af

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 rvm:
-    - 1.9.3
     - 2.1.1
+    - 2.2.4
 env:
   - RAILS_VERSION="~> 4.1.0" RSPEC_VERSION="~> 2.0"
   - RAILS_VERSION="~> 4.1.0" RSPEC_VERSION="~> 3.0"

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 0.3.0 (2016-03-01)
+
+Breaking change:
+
+  - dropped support for ruby 1.9.3, added ruby 2.2 to CI matrix
+
+Improvements
+
+  - documentation
+
+New feature:
+
+  - aygabtu_select_route? extension point
+
 ## 0.2.0 (2015-04-28)
 
 Breaking change:

data/Gemfile

@@ -6,3 +6,5 @@ gemspec
 gem 'rake'
 gem 'rails', ENV['RAILS_VERSION'] || '~> 0'
 gem 'rspec', ENV['RSPEC_VERSION'] || '~> 0'
+
+gem 'test-unit' if RUBY_VERSION.start_with?('2.2')

data/README.md

@@ -32,13 +32,14 @@ Or install it yourself as:
 Create `spec/features/aygabtu_features_spec.rb` with the following content:
 
 ```
-require 'spec_helper' # or whatever is necessary to initialize your Rails app and configure rspec and capybara
+require 'rails_helper'
 
 require 'aygabtu/rspec'
 
 describe "Aygabtu generated features", type: :feature do
   include Aygabtu::RSpec.example_group_module
 
+  # callback method for asserting against a loaded page
   def aygabtu_assertions
     aygabtu_assert_status_success
     aygabtu_assert_not_redirected_away
@@ -48,7 +49,7 @@ describe "Aygabtu generated features", type: :feature do
 
   # must be at the very bottom
   remaining.static_routes.visit
-  remaining.pend "pending because route needs segments passed"
+  remaining.pend "pending because route requires segments to be visited"
 end
 ```
 
@@ -227,13 +228,29 @@ You can also use `remaining` at the very bottom to pend all remaining routes, se
 * `dynamic_routes` matches routes which have a dynamic segment.
 * `static_routes` matches routes which have no dynamic segment.
 
-## Caveats
+## Extension points
 
-* With the standard assertions configured, Aygabtu will happily accept a rails error page as long as the HTTP status is 200. Somebody should find out how these can be reliably told apart from regular result pages, so the default assertions can be improved. Until then, you should try to add an assertion that checks for a common element on pages, like a footer element.
+Several class and instance methods (read: example group and example methods)
+can be overwritten to tweak behaviour as needed.
+
+### `#aygabtu_assertions`
+
+This is already demonstrated in the initial example. It is necessary
+to override this method with assertions specific to your project. Besides using
+available assertions as shown, add an assertion against an element common to all
+pages (fex. inside the site footer) and a negative assertion against text
+found in your 404 page.
+
+### `.aygabtu_select_route?`
+
+Allows to filter out unwanted routes at a low level. This method is passed a route object
+from the journey gem and returns true for every route to be considered by aygabtu.
+
+This method helps keeping deep project specific knowledge and the knowledge about Rails interna needed
+to implement filtering out of aygabtu by giving users control.
 
 ## Missing features
 
-* tests, preferrably against different versions of Rails, RSpec and capybara
 * support for example metadata (you can have it with a conventional `context` any time)
 
 ## Contributing

data/lib/aygabtu/handle.rb

@@ -3,6 +3,9 @@ require_relative 'scope_actor'
 
 module Aygabtu
   class Handle
+    def initialize
+      @verbose = false
+    end
 
     def routes
       @routes ||= rails_application_routes.set.map do |journey_route|
@@ -25,7 +28,7 @@ module Aygabtu
     end
 
     def verbose?
-      !!@verbose
+      @verbose
     end
 
     private

data/lib/aygabtu/point_of_call.rb

@@ -15,14 +15,14 @@ module Aygabtu
     end
 
     def self.gem_root
-      return @gem_root if @gem_root
+      @gem_root ||= begin
+        path = Pathname(__FILE__)
+        while new_path = path.parent and new_path.to_s.include?('lib/aygabtu')
+          path = new_path
+        end
 
-      path = Pathname(__FILE__)
-      while new_path = path.parent and new_path.to_s.include?('lib/aygabtu')
-        path = new_path
+        path.to_s
       end
-
-      @gem_root= path.to_s
     end
   end
 end

data/lib/aygabtu/rspec.rb

@@ -43,9 +43,13 @@ module Aygabtu
 
       def aygabtu_matching_routes(scope = aygabtu_scope)
         scope = scope.scope if scope.respond_to?(:scope) # a scope chain can be pased as well
-        aygabtu_handle.routes.select do |route|
-          scope.matches_route?(route)
-        end
+        aygabtu_handle.routes.select { |route|
+          scope.matches_route?(route) && aygabtu_select_route?(route.journey_route)
+        }
+      end
+
+      def aygabtu_select_route?(journey_route)
+        true
       end
 
       ScopeActor.actions.each do |action|

data/lib/aygabtu/version.rb

@@ -1,3 +1,3 @@
 module Aygabtu
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/support/identifies_routes.rb

@@ -7,7 +7,7 @@ module IdentifiesRoutes
     satisfy { |rw| rw.journey_route.defaults[:route_identifier] == identifier }
   end
 
-  def route_identified_by(identifier, all_routes = all_routes)
+  def route_identified_by(identifier, all_routes = all_routes())
     identified_routes = all_routes.select do |rw|
       rw.journey_route.defaults[:route_identifier] == identifier
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aygabtu
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Thomas Stratmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-28 00:00:00.000000000 Z
+date: 2016-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails
@@ -103,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Feature test generator for GET requests
@@ -120,4 +120,3 @@ test_files:
 - spec/support/matcher_shims.rb
 - spec/support_spec/identifies_routes_spec.rb
 - spec/visiting_routes_spec.rb
-has_rdoc: