aye_commander 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da0a543274b37fae29f538f76fad4d4f623843c9
-  data.tar.gz: cb01c076185caf5b56cd74a40b6946e3cd39e433
+  metadata.gz: 5cd9e163ad88759356856bb67d1631806f3a6061
+  data.tar.gz: 92352f5d37a173072f885c6b44c6ae8c4b3bf64e
 SHA512:
-  metadata.gz: bd388cbf2ad8c23963f21d7ed0201a620c573a0e1e8839087788e5a714c100ad6d23c398f6130b9c79719b1d4f0d57410d0bb0627765f7fb5ba8e44fa5eea00d
-  data.tar.gz: 672f0c73a5ff813f6cf233b2376f8ecaa5502fbd98f2d842e86de76776b445f4027f8610a2727cfc244aacd71691175d71954f893f98eccbc86051b9ad07eedc
+  metadata.gz: 6737d92b45dfc9becbfb301aa75498affbbca75ddf823179f9cd5c715c55902f9f52a6d30756c8e3bc7ba5f341b77a041aa38bd7f3d8adc928497747a5858b3e
+  data.tar.gz: bfafe03df2dac3af038492aed9e4648f8cfc0cc0610b90edeacbb8cf09bb91e38e3e0bf49d4eda62b414574e81788463a6b5df8b8cbfd479c4b15d1e199fe229

data/lib/aye_commander/callable.rb

@@ -35,7 +35,6 @@ module AyeCommander
     # #call is what a user redefines in their own command, and what he
     # customizes to give a command the behavior he desires.
     # An empty call is defined in a command so they can be run even without one.
-    def call
-    end
+    define_method(:call) {}
   end
 end

data/lib/aye_commander/errors.rb

@@ -4,6 +4,14 @@ module AyeCommander
     def initialize(info = nil)
       @info = info
     end
+
+    def inspect
+      "#<#{self.class}: #{self}>"
+    end
+
+    def to_s
+      message
+    end
   end
 
   # Raised when command specifies 'requires' and one or more required arguments

data/lib/aye_commander/hookable.rb

@@ -6,7 +6,7 @@ module AyeCommander
     # All hook functionality is defined at a class level, but runs at instance
     # level
     module ClassMethods
-      TYPES = %i(before around after aborted).freeze
+      TYPES = %i[before around after aborted].freeze
 
       TYPES.each do |kind|
         # Defines .before .around .after and .aborted

data/lib/aye_commander/limitable.rb

@@ -5,7 +5,7 @@ module AyeCommander
     # Limitable is a module which functionality is completely defined at class
     # level.
     module ClassMethods
-      LIMITERS = %i(receives requires returns).freeze
+      LIMITERS = %i[receives requires returns].freeze
 
       # Contains all the limiters
       def limiters
@@ -54,13 +54,24 @@ module AyeCommander
 
       # Validates the limiter arguments
       def validate_arguments(args, skip_validations: false)
-        unless [true, :requires].include?(skip_validations) || requires.empty?
+        if validate_required_arguments?(skip_validations)
           validate_required_arguments(args)
         end
 
-        unless [true, :receives].include?(skip_validations) || receives.empty?
-          validate_received_arguments(args)
-        end
+        return unless validate_received_arguments?(skip_validations)
+        validate_received_arguments(args)
+      end
+
+      # Dont validate if asked to skip or requires is empty
+      def validate_required_arguments?(skip_validations)
+        return if [true, :requires].include?(skip_validations)
+        requires.any?
+      end
+
+      # Dont validate if asked to skip or receives is empty
+      def validate_received_arguments?(skip_validations)
+        return if [true, :receives].include?(skip_validations)
+        receives.any?
       end
 
       # Validates the required arguments

data/lib/aye_commander/shareable.rb

@@ -9,7 +9,7 @@ module AyeCommander
       def included(includer)
         super
         includer.extend AyeCommander::Command::ClassMethods
-        %i(@limiters @succeeds @hooks).each do |var|
+        %i[@limiters @succeeds @hooks].each do |var|
           if instance_variable_defined? var
             includer.instance_variable_set var, instance_variable_get(var)
           end
@@ -21,7 +21,7 @@ module AyeCommander
       # the variables to the inheriter.
       def inherited(inheriter)
         super
-        %i(@limiters @succeeds @hooks).each do |var|
+        %i[@limiters @succeeds @hooks].each do |var|
           if instance_variable_defined? var
             inheriter.instance_variable_set var, instance_variable_get(var)
           end

data/lib/aye_commander/version.rb

@@ -1,3 +1,3 @@
 module AyeCommander
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.0.2'.freeze
 end

data/spec/aye_commander/commander_spec.rb

@@ -13,7 +13,7 @@ describe AyeCommander::Commander::ClassMethods do
 
     it 'saves the necessary instance variables for the commander' do
       includer.execute :taco, :burrito
-      expect(includer2.executes).to eq %i(taco burrito)
+      expect(includer2.executes).to eq %i[taco burrito]
     end
   end
 
@@ -25,7 +25,7 @@ describe AyeCommander::Commander::ClassMethods do
 
     it 'saves the necessary instance variables for the commander' do
       commander.execute :taco, :burrito
-      expect(inheriter.executes).to eq %i(taco burrito)
+      expect(inheriter.executes).to eq %i[taco burrito]
     end
   end
 
@@ -62,7 +62,7 @@ describe AyeCommander::Commander::ClassMethods do
   context '.execute' do
     it 'adds the received arguments to the executes array' do
       commander.execute :taco, :burrito
-      expect(commander.executes).to eq %i(taco burrito)
+      expect(commander.executes).to eq %i[taco burrito]
     end
   end
 

data/spec/aye_commander/errors_spec.rb

@@ -9,6 +9,17 @@ describe AyeCommander::MissingRequiredArgumentError do
     errori = error.new [:taco]
     expect(errori.message).to eq 'Missing required arguments: [:taco]'
   end
+
+  it 'should print the class and message with #inspect' do
+    errori   = error.new [:taco]
+    expected = '#<AyeCommander::MissingRequiredArgumentError: Missing required arguments: [:taco]>'
+    expect(errori.inspect).to eq expected
+  end
+
+  it 'should print the message with #to_s' do
+    errori = error.new [:taco]
+    expect(errori.to_s).to eq 'Missing required arguments: [:taco]'
+  end
 end
 
 describe AyeCommander::UnexpectedReceivedArgumentError do
@@ -22,4 +33,15 @@ describe AyeCommander::UnexpectedReceivedArgumentError do
     errori = error.new [:taco]
     expect(errori.message).to eq 'Received unexpected arguments: [:taco]'
   end
+
+  it 'should print the class and message with #inspect' do
+    errori   = error.new [:taco]
+    expected = '#<AyeCommander::UnexpectedReceivedArgumentError: Received unexpected arguments: [:taco]>'
+    expect(errori.inspect).to eq expected
+  end
+
+  it 'should print the message with #to_s' do
+    errori = error.new [:taco]
+    expect(errori.to_s).to eq 'Received unexpected arguments: [:taco]'
+  end
 end

data/spec/aye_commander/hookable_spec.rb

@@ -1,11 +1,11 @@
 describe AyeCommander::Hookable::ClassMethods do
   include_context :command
 
-  %i(before around after aborted).each do |kind|
+  %i[before around after aborted].each do |kind|
     context ".#{kind}" do
       it "adds the args to the #{kind} hooks array" do
         command.send kind, :some, :method
-        expect(command.send("#{kind}_hooks")).to eq [:some, :method]
+        expect(command.send("#{kind}_hooks")).to eq %i[some method]
         expect(command.instance_variable_get(:@hooks)).to_not be_empty
         expect(command.instance_variable_get(:@hooks).default).to be_empty
       end
@@ -19,13 +19,13 @@ describe AyeCommander::Hookable::ClassMethods do
       it 'adds the args at the end of the array' do
         command.send kind, :first
         command.send kind, :second, :third
-        expect(command.send("#{kind}_hooks")).to eq [:first, :second, :third]
+        expect(command.send("#{kind}_hooks")).to eq %i[first second third]
       end
 
       it 'adds the args at the beginning of the array with the prepend option' do
         command.send kind, :first
         command.send kind, :second, :third, prepend: true
-        expect(command.send("#{kind}_hooks")).to eq [:second, :third, :first]
+        expect(command.send("#{kind}_hooks")).to eq %i[second third first]
       end
     end
 
@@ -41,7 +41,7 @@ describe AyeCommander::Hookable::ClassMethods do
     end
   end
 
-  %i(before after aborted).each do |kind|
+  %i[before after aborted].each do |kind|
     context ".call_#{kind}_hooks" do
       before :each do
         body = -> { success? }

data/spec/aye_commander/inspectable_spec.rb

@@ -20,7 +20,7 @@ describe AyeCommander::Inspectable do
 
     it 'gives a hash representation of the innards of the class with the requested values' do
       result = { :@variable => :something, :@other => :potato }
-      expect(instance.to_hash([:@variable, :other])).to eq result
+      expect(instance.to_hash(%i[@variable other])).to eq result
     end
   end
 

data/spec/aye_commander/limitable_spec.rb

@@ -1,6 +1,6 @@
 describe AyeCommander::Limitable::ClassMethods do
   include_context :command
-  let(:args)      { %i(arg1 arg2) }
+  let(:args) { %i[arg1 arg2] }
 
   context '.uses' do
     it 'should call save_variable' do
@@ -17,7 +17,7 @@ describe AyeCommander::Limitable::ClassMethods do
     end
   end
 
-  %i(receives requires returns).each do |limiter|
+  %i[receives requires returns].each do |limiter|
     context ".#{limiter}" do
       before :each do
         command.public_send limiter, *args
@@ -34,12 +34,12 @@ describe AyeCommander::Limitable::ClassMethods do
 
       it 'should add consecutive values without any problem' do
         command.public_send limiter, :arg3
-        expect(command.limiters[limiter]).to eq %i(arg1 arg2 arg3)
+        expect(command.limiters[limiter]).to eq %i[arg1 arg2 arg3]
       end
 
       it 'should not add repeated args' do
         command.public_send limiter, :arg1, :arg4
-        expect(command.limiters[limiter]).to eq %i(arg1 arg2 arg4)
+        expect(command.limiters[limiter]).to eq %i[arg1 arg2 arg4]
       end
     end
   end

data/spec/aye_commander/status_spec.rb

@@ -7,30 +7,30 @@ describe AyeCommander::Status::ClassMethods do
     end
 
     it 'returns whathever the :@succeds class instance variable contains' do
-      command.instance_variable_set :@succeeds, %i(im a little teapot)
-      expect(command.succeeds).to eq %i(im a little teapot)
+      command.instance_variable_set :@succeeds, %i[im a little teapot]
+      expect(command.succeeds).to eq %i[im a little teapot]
     end
   end
 
   context '.suceeds_with' do
-    let(:args) { %i(succ1 succ2) }
+    let(:args) { %i[succ1 succ2] }
 
     before :each do
       command.succeeds_with(*args)
     end
 
     it 'adds the values to the succeeds array' do
-      expect(command.succeeds).to eq %i(success succ1 succ2)
+      expect(command.succeeds).to eq %i[success succ1 succ2]
     end
 
     it 'allows consecutive succeeds' do
       command.succeeds_with :potato
-      expect(command.succeeds).to eq %i(success succ1 succ2 potato)
+      expect(command.succeeds).to eq %i[success succ1 succ2 potato]
     end
 
     it 'doesnt add repeated succeeds' do
       command.succeeds_with(*args)
-      expect(command.succeeds).to eq %i(success succ1 succ2)
+      expect(command.succeeds).to eq %i[success succ1 succ2]
     end
 
     it 'removes :success from the array if called with the exclude_suceed option' do

data/spec/spec_helper.rb

@@ -1,11 +1,7 @@
-if ENV['CODECLIMATE_REPO_TOKEN']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-else
-  require 'simplecov'
-  SimpleCov.start do
-    add_filter 'spec/'
-  end
+# NOTE Coverage must be required and initialized before anything else
+require 'simplecov'
+SimpleCov.start do
+  add_filter 'spec/'
 end
 
 require 'pry'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aye_commander
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - pyzlnar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-15 00:00:00.000000000 Z
+date: 2017-08-21 00:00:00.000000000 Z
 dependencies: []
 description: A gem that helps to write commands in ruby.
 email: pyzlnar@gmail.com
@@ -68,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A simple command pattern gem