axn 0.1.0.pre.alpha.2.8.1 → 0.1.0.pre.alpha.3

data/lib/rubocop/cop/axn/README.md

@@ -4,11 +4,11 @@ This directory contains custom RuboCop cops specifically designed for the Axn li
 
 ## Axn/UncheckedResult
 
-This cop enforces proper result handling when calling Actions. It can be configured to check nested calls, non-nested calls, or both.
+This cop enforces proper result handling when calling Axns. It can be configured to check nested calls, non-nested calls, or both.
 
 ### Why This Rule Exists
 
-When Actions are nested, proper error handling becomes crucial. Without proper result checking, failures in nested Actions can be silently ignored, leading to:
+When Axns are nested, proper error handling becomes crucial. Without proper result checking, failures in nested Axns can be silently ignored, leading to:
 
 - Silent failures that are hard to debug
 - Inconsistent error handling patterns
@@ -21,8 +21,8 @@ The cop supports flexible configuration to match your team's needs:
 ```yaml
 Axn/UncheckedResult:
   Enabled: true
-  CheckNested: true      # Check nested Action calls (default: true)
-  CheckNonNested: true   # Check non-nested Action calls (default: true)
+  CheckNested: true      # Check nested Axn calls (default: true)
+  CheckNonNested: true   # Check non-nested Axn calls (default: true)
   Severity: warning      # or error, if you want to enforce it strictly
 ```
 
@@ -33,21 +33,21 @@ Axn/UncheckedResult:
    CheckNested: true
    CheckNonNested: true
    ```
-   Checks all Action calls regardless of nesting.
+   Checks all Axn calls regardless of nesting.
 
 2. **Nested Only**:
    ```yaml
    CheckNested: true
    CheckNonNested: false
    ```
-   Only checks Action calls from within other Actions.
+   Only checks Axn calls from within other Axns.
 
 3. **Non-Nested Only**:
    ```yaml
    CheckNested: false
    CheckNonNested: true
    ```
-   Only checks top-level Action calls.
+   Only checks top-level Axn calls.
 
 4. **Disabled**:
    ```yaml
@@ -62,7 +62,7 @@ Axn/UncheckedResult:
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     InnerAction.call(param: "value")  # Missing result check
     # This will always continue even if InnerAction fails
@@ -74,7 +74,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     InnerAction.call!(param: "value")  # Using call! ensures exceptions bubble up
   end
@@ -85,7 +85,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     result = InnerAction.call(param: "value")
     return result unless result.ok?
@@ -98,7 +98,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     result = InnerAction.call(param: "value")
     if result.failed?
@@ -113,7 +113,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     result = InnerAction.call(param: "value")
     if result.error
@@ -128,7 +128,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     result = InnerAction.call(param: "value")
     result  # Result is returned, so it's properly handled
@@ -140,7 +140,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   exposes :nested_result
   def call
     result = InnerAction.call(param: "value")
@@ -153,7 +153,7 @@ end
 
 ```ruby
 class OuterAction
-  include Action
+  include Axn
   def call
     result = InnerAction.call(param: "value")
     process_result(result)  # Result is used, so it's properly handled
@@ -165,19 +165,19 @@ end
 
 The cop analyzes your code to determine if you're:
 
-1. **Inside an Action class** - Classes that `include Action`
+1. **Inside an Axn class** - Classes that `include Axn`
 2. **Inside the `call` method** - Only the main execution method
-3. **Calling another Action** - Using `.call` on Action classes
+3. **Calling another Axn** - Using `.call` on Axn classes
 4. **Properly handling the result** - One of the acceptable patterns above
 
 ### What the Cop Ignores
 
 The cop will NOT report offenses for:
 
-- Action calls outside of Action classes
-- Action calls in methods other than `call`
-- Action calls that use `call!` (bang method)
-- Action calls where the result is properly handled
+- Axn calls outside of Axn classes
+- Axn calls in methods other than `call`
+- Axn calls that use `call!` (bang method)
+- Axn calls where the result is properly handled
 
 ### Configuration
 
@@ -189,8 +189,8 @@ require:
 
 Axn/UncheckedResult:
   Enabled: true
-  CheckNested: true      # Check nested Action calls
-  CheckNonNested: true   # Check non-nested Action calls
+  CheckNested: true      # Check nested Axn calls
+  CheckNonNested: true   # Check non-nested Axn calls
   Severity: warning      # or error, if you want to enforce it strictly
 ```
 

data/lib/rubocop/cop/axn/unchecked_result.rb

@@ -3,13 +3,17 @@
 module RuboCop
   module Cop
     module Axn
-      # This cop enforces that when calling Actions from within other Actions,
+      # This cop enforces that when calling Axns from within other Axns,
       # you must either use `call!` (with the bang) or check `result.ok?`.
       #
+      # When the ActionsNamespace configuration is set (e.g., to "Actions"),
+      # the cop will only check calls on classes under that namespace,
+      # reducing false positives from other service objects.
+      #
       # @example
       #   # bad
       #   class OuterAction
-      #     include Action
+      #     include Axn
       #     def call
       #       InnerAction.call(param: "value")  # Missing result check
       #     end
@@ -17,7 +21,7 @@ module RuboCop
       #
       #   # good
       #   class OuterAction
-      #     include Action
+      #     include Axn
       #     def call
       #       result = InnerAction.call(param: "value")
       #       return result unless result.ok?
@@ -27,17 +31,68 @@ module RuboCop
       #
       #   # also good
       #   class OuterAction
-      #     include Action
+      #     include Axn
       #     def call
       #       InnerAction.call!(param: "value")  # Using call! ensures exceptions bubble up
       #     end
       #   end
       #
+      # @example With ActionsNamespace configured as string
+      #   # .rubocop.yml
+      #   Axn/UncheckedResult:
+      #     ActionsNamespace: "Actions"
+      #
+      #   # This will only check Actions::* classes, not other service objects
+      #   class OuterAction
+      #     include Axn
+      #     def call
+      #       SomeService.call(param: "value")  # Won't trigger cop
+      #       Actions::InnerAction.call(param: "value")  # Will trigger cop
+      #     end
+      #   end
+      #
+      # @example With ActionsNamespace configured as array
+      #   # .rubocop.yml
+      #   Axn/UncheckedResult:
+      #     ActionsNamespace: ["Actions", "Services"]
+      #
+      #   # This will check both Actions::* and Services::* classes
+      #   class OuterAction
+      #     include Axn
+      #     def call
+      #       SomeService.call(param: "value")  # Won't trigger cop
+      #       Actions::InnerAction.call(param: "value")  # Will trigger cop
+      #       Services::SomeService.call(param: "value")  # Will trigger cop
+      #     end
+      #   end
+      #
       # rubocop:disable Metrics/ClassLength
       class UncheckedResult < RuboCop::Cop::Base
         extend RuboCop::Cop::AutoCorrector
 
-        MSG = "Use `call!` or check `result.ok?` when calling Actions from within Actions"
+        MSG = "Use `call!` or check `result.ok?` when calling Axns from within Axns"
+
+        # Define the configuration schema
+        def self.configuration_schema
+          @configuration_schema ||= RuboCop::ConfigSchema::Schema.new(
+            {
+              "ActionsNamespace" => {
+                "type" => %w[string array],
+                "description" => 'Only check calls on classes under this namespace (e.g., "Actions") or array of namespaces (e.g., ["Actions", "Services"])',
+              },
+              "CheckNested" => {
+                "type" => "boolean",
+                "description" => "Check nested Axn calls",
+                "default" => true,
+              },
+              "CheckNonNested" => {
+                "type" => "boolean",
+                "description" => "Check non-nested Axn calls",
+                "default" => true,
+              },
+            },
+          )
+        end
 
         # Configuration options
         def check_nested?
@@ -48,20 +103,20 @@ module RuboCop
           cop_config["CheckNonNested"] != false
         end
 
-        # Track whether we're inside an Action class and its call method
+        # Track whether we're inside an Axn class and its call method
         def_node_search :action_class?, <<~PATTERN
-          (class _ (const nil? :Action) ...)
+          (class _ (const nil? :Axn) ...)
         PATTERN
 
         def_node_search :includes_action?, <<~PATTERN
-          (send nil? :include (const nil? :Action))
+          (send nil? :include (const nil? :Axn))
         PATTERN
 
         def_node_search :call_method?, <<~PATTERN
           (def :call ...)
         PATTERN
 
-        def_node_search :action_call?, <<~PATTERN
+        def_node_search :axn_call?, <<~PATTERN
           (send (const _ _) :call ...)
         PATTERN
 
@@ -102,9 +157,10 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless action_call?(node)
+          return unless axn_call?(node)
+          return unless axn_action_call?(node)
           return if bang_call?(node)
-          return unless inside_action_call_method?(node)
+          return unless inside_axn_call_method?(node)
 
           # Check if we should process this call based on configuration
           is_inside_action = inside_action_context?(node)
@@ -117,8 +173,73 @@ module RuboCop
 
         private
 
-        def inside_action_call_method?(node)
-          # Check if we're inside a call method of an Action class
+        def axn_action_call?(node)
+          # Get the receiver of the call method
+          receiver = node.children[0]
+          return false unless receiver&.type == :const
+
+          # Get the constant name - handle both simple constants and namespaced constants
+          const_name = get_constant_name(receiver)
+          return false unless const_name
+
+          # Check if we have the Actions namespace configured
+          namespace = actions_namespace
+
+          if namespace
+            # Handle both string and array configurations
+            case namespace
+            when String
+              return const_name.start_with?("#{namespace}::")
+            when Array
+              # If array is empty, fall back to checking all calls
+              return true if namespace.empty?
+
+              return namespace.any? { |ns| const_name.start_with?("#{ns}::") }
+            end
+          end
+
+          # If no namespace is configured, we can't be as precise
+          # Fall back to checking if the class includes Axn (more complex)
+          true
+        rescue StandardError => _e
+          # If there's any error, assume it's not an Axn action call
+          false
+        end
+
+        def get_constant_name(const_node)
+          # Handle both simple constants (const :SomeClass) and namespaced constants (const (const nil :Actions) :SomeClass)
+          if const_node.children[0]&.type == :const
+            # This is a namespaced constant like Actions::SomeClass
+            namespace = get_constant_name(const_node.children[0])
+            class_name = const_node.children[1]
+            "#{namespace}::#{class_name}"
+          else
+            # This is a simple constant like SomeClass
+            const_node.children[1]
+          end
+        end
+
+        def actions_namespace
+          # First try to get from RuboCop configuration
+          config_value = cop_config["ActionsNamespace"]
+          return nil unless config_value
+
+          # Handle both string and array configurations
+          case config_value
+          when String
+            config_value
+          when Array
+            config_value.map(&:to_s)
+          else
+            config_value.to_s
+          end
+        rescue StandardError => _e
+          # If there's any error accessing the configuration, return nil
+          nil
+        end
+
+        def inside_axn_call_method?(node)
+          # Check if we're inside a call method of an Axn class
           current_node = node
           while current_node.parent
             current_node = current_node.parent
@@ -126,19 +247,19 @@ module RuboCop
             # Check if we're inside a def :call
             next unless call_method?(current_node) && current_node.method_name == :call
 
-            # Now check if this class includes Action
+            # Now check if this class includes Axn
             class_node = find_enclosing_class(current_node)
             return includes_action?(class_node) if class_node
           end
           false
         rescue StandardError => _e
-          # If there's any error in the analysis, assume we're not in an Action call method
+          # If there's any error in the analysis, assume we're not in an Axn call method
           # This prevents the cop from crashing on complex or malformed code
           false
         end
 
         def inside_action_context?(node)
-          # Check if this Action call is inside an Action class's call method
+          # Check if this Axn call is inside an Axn class's call method
           current_node = node
           while current_node.parent
             current_node = current_node.parent
@@ -146,7 +267,7 @@ module RuboCop
             # Check if we're inside a def :call
             next unless call_method?(current_node) && current_node.method_name == :call
 
-            # Now check if this class includes Action
+            # Now check if this class includes Axn
             class_node = find_enclosing_class(current_node)
             return true if class_node && includes_action?(class_node)
           end

metadata

@@ -1,54 +1,54 @@
 --- !ruby/object:Gem::Specification
 name: axn
 version: !ruby/object:Gem::Version
-  version: 0.1.0.pre.alpha.2.8.1
+  version: 0.1.0.pre.alpha.3
 platform: ruby
 authors:
 - Kali Donovan
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-08-25 00:00:00.000000000 Z
+date: 2025-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.2'
 description: Pattern for writing callable service objects with contract validation
-  and error swallowing
+  and exception handling
 email:
 - kali@teamshares.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".rspec"
-- ".rubocop.yml"
-- ".tool-versions"
+- ".cursor/rules/axn-framework-patterns.mdc"
+- ".cursor/rules/general-coding-standards.mdc"
+- ".cursor/rules/spec/testing-patterns.mdc"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - LICENSE.txt
@@ -56,6 +56,8 @@ files:
 - Rakefile
 - docs/.vitepress/config.mjs
 - docs/advanced/conventions.md
+- docs/advanced/mountable.md
+- docs/advanced/profiling.md
 - docs/advanced/rough.md
 - docs/index.md
 - docs/intro/about.md
@@ -64,7 +66,8 @@ files:
 - docs/recipes/rubocop-integration.md
 - docs/recipes/testing.md
 - docs/recipes/validating-user-input.md
-- docs/reference/action-result.md
+- docs/reference/async.md
+- docs/reference/axn-result.md
 - docs/reference/class.md
 - docs/reference/configuration.md
 - docs/reference/instance.md
@@ -74,61 +77,82 @@ files:
 - docs/usage/steps.md
 - docs/usage/using.md
 - docs/usage/writing.md
-- lib/action/attachable.rb
-- lib/action/attachable/base.rb
-- lib/action/attachable/steps.rb
-- lib/action/attachable/subactions.rb
-- lib/action/configuration.rb
-- lib/action/context.rb
-- lib/action/core.rb
-- lib/action/core/automatic_logging.rb
-- lib/action/core/context/facade.rb
-- lib/action/core/context/facade_inspector.rb
-- lib/action/core/context/internal.rb
-- lib/action/core/contract.rb
-- lib/action/core/contract_for_subfields.rb
-- lib/action/core/contract_validation.rb
-- lib/action/core/flow.rb
-- lib/action/core/flow/callbacks.rb
-- lib/action/core/flow/exception_execution.rb
-- lib/action/core/flow/handlers.rb
-- lib/action/core/flow/handlers/base_descriptor.rb
-- lib/action/core/flow/handlers/descriptors/callback_descriptor.rb
-- lib/action/core/flow/handlers/descriptors/message_descriptor.rb
-- lib/action/core/flow/handlers/invoker.rb
-- lib/action/core/flow/handlers/matcher.rb
-- lib/action/core/flow/handlers/registry.rb
-- lib/action/core/flow/handlers/resolvers/base_resolver.rb
-- lib/action/core/flow/handlers/resolvers/callback_resolver.rb
-- lib/action/core/flow/handlers/resolvers/message_resolver.rb
-- lib/action/core/flow/messages.rb
-- lib/action/core/hooks.rb
-- lib/action/core/logging.rb
-- lib/action/core/nesting_tracking.rb
-- lib/action/core/timing.rb
-- lib/action/core/tracing.rb
-- lib/action/core/use_strategy.rb
-- lib/action/core/validation/fields.rb
-- lib/action/core/validation/subfields.rb
-- lib/action/core/validation/validators/model_validator.rb
-- lib/action/core/validation/validators/type_validator.rb
-- lib/action/core/validation/validators/validate_validator.rb
-- lib/action/enqueueable.rb
-- lib/action/enqueueable/via_sidekiq.rb
-- lib/action/exceptions.rb
-- lib/action/result.rb
-- lib/action/strategies.rb
-- lib/action/strategies/transaction.rb
 - lib/axn.rb
+- lib/axn/async.rb
+- lib/axn/async/adapters.rb
+- lib/axn/async/adapters/active_job.rb
+- lib/axn/async/adapters/disabled.rb
+- lib/axn/async/adapters/sidekiq.rb
+- lib/axn/configuration.rb
+- lib/axn/context.rb
+- lib/axn/core.rb
+- lib/axn/core/automatic_logging.rb
+- lib/axn/core/context/facade.rb
+- lib/axn/core/context/facade_inspector.rb
+- lib/axn/core/context/internal.rb
+- lib/axn/core/contract.rb
+- lib/axn/core/contract_for_subfields.rb
+- lib/axn/core/contract_validation.rb
+- lib/axn/core/contract_validation_for_subfields.rb
+- lib/axn/core/field_resolvers.rb
+- lib/axn/core/field_resolvers/extract.rb
+- lib/axn/core/field_resolvers/model.rb
+- lib/axn/core/flow.rb
+- lib/axn/core/flow/callbacks.rb
+- lib/axn/core/flow/exception_execution.rb
+- lib/axn/core/flow/handlers.rb
+- lib/axn/core/flow/handlers/base_descriptor.rb
+- lib/axn/core/flow/handlers/descriptors/callback_descriptor.rb
+- lib/axn/core/flow/handlers/descriptors/message_descriptor.rb
+- lib/axn/core/flow/handlers/invoker.rb
+- lib/axn/core/flow/handlers/matcher.rb
+- lib/axn/core/flow/handlers/registry.rb
+- lib/axn/core/flow/handlers/resolvers/base_resolver.rb
+- lib/axn/core/flow/handlers/resolvers/callback_resolver.rb
+- lib/axn/core/flow/handlers/resolvers/message_resolver.rb
+- lib/axn/core/flow/messages.rb
+- lib/axn/core/hooks.rb
+- lib/axn/core/logging.rb
+- lib/axn/core/nesting_tracking.rb
+- lib/axn/core/profiling.rb
+- lib/axn/core/timing.rb
+- lib/axn/core/tracing.rb
+- lib/axn/core/use_strategy.rb
+- lib/axn/core/validation/fields.rb
+- lib/axn/core/validation/subfields.rb
+- lib/axn/core/validation/validators/model_validator.rb
+- lib/axn/core/validation/validators/type_validator.rb
+- lib/axn/core/validation/validators/validate_validator.rb
+- lib/axn/exceptions.rb
 - lib/axn/factory.rb
+- lib/axn/internal/logging.rb
+- lib/axn/internal/registry.rb
+- lib/axn/mountable.rb
+- lib/axn/mountable/descriptor.rb
+- lib/axn/mountable/helpers/class_builder.rb
+- lib/axn/mountable/helpers/mounter.rb
+- lib/axn/mountable/helpers/namespace_manager.rb
+- lib/axn/mountable/helpers/validator.rb
+- lib/axn/mountable/inherit_profiles.rb
+- lib/axn/mountable/mounting_strategies.rb
+- lib/axn/mountable/mounting_strategies/_base.rb
+- lib/axn/mountable/mounting_strategies/axn.rb
+- lib/axn/mountable/mounting_strategies/enqueue_all.rb
+- lib/axn/mountable/mounting_strategies/method.rb
+- lib/axn/mountable/mounting_strategies/step.rb
+- lib/axn/rails/engine.rb
+- lib/axn/rails/generators/axn_generator.rb
+- lib/axn/rails/generators/templates/action.rb.erb
+- lib/axn/rails/generators/templates/action_spec.rb.erb
+- lib/axn/result.rb
 - lib/axn/rubocop.rb
+- lib/axn/strategies.rb
+- lib/axn/strategies/transaction.rb
 - lib/axn/testing/spec_helpers.rb
-- lib/axn/util.rb
+- lib/axn/util/memoization.rb
 - lib/axn/version.rb
 - lib/rubocop/cop/axn/README.md
 - lib/rubocop/cop/axn/unchecked_result.rb
-- package.json
-- yarn.lock
 homepage: https://github.com/teamshares/axn
 licenses:
 - MIT
@@ -145,7 +169,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.2.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---color
---require spec_helper