axlsx 1.1.3 → 1.2.0

data/test/drawing/tc_drawing.rb

@@ -9,8 +9,6 @@ class TestDrawing < Test::Unit::TestCase
 
   def test_initialization
     assert(@ws.workbook.drawings.empty?)
-    assert_equal(@ws.drawing, @ws.workbook.drawings.last, "drawing is added to workbook")
-    assert(@ws.drawing.anchors.is_a?(Axlsx::SimpleTypedList) && @ws.drawing.anchors.empty?, "anchor list is created and empty")
   end
 
   def test_add_chart
@@ -32,9 +30,13 @@ class TestDrawing < Test::Unit::TestCase
     assert_equal(600, image.width)
     assert_equal(400, image.height)
   end
-
+  def test_add_two_cell_anchor_image
+     src = File.dirname(__FILE__) + "/../../examples/image1.jpeg"
+     image = @ws.add_image(:image_src => src, :start_at=>[0,0], :end_at => [15,0])
+    assert(@ws.drawing.anchors.last.is_a?(Axlsx::TwoCellAnchor))
+    assert(image.is_a?(Axlsx::Pic))
+  end
   def test_charts
-    assert(@ws.drawing.charts.empty?)
     chart = @ws.add_chart(Axlsx::Pie3DChart, :title=>"bob", :start_at=>[0,0], :end_at=>[1,1])
     assert_equal(@ws.drawing.charts.last, chart, "add chart is returned")
     chart = @ws.add_chart(Axlsx::Pie3DChart, :title=>"nancy", :start_at=>[1,5], :end_at=>[5,10])
@@ -42,23 +44,26 @@ class TestDrawing < Test::Unit::TestCase
   end
 
   def test_pn
+    @ws.add_chart(Axlsx::Pie3DChart)
     assert_equal(@ws.drawing.pn, "drawings/drawing1.xml")
   end
 
   def test_rels_pn
+    @ws.add_chart(Axlsx::Pie3DChart)
     assert_equal(@ws.drawing.rels_pn, "drawings/_rels/drawing1.xml.rels")
   end
 
   def test_rId
+    @ws.add_chart(Axlsx::Pie3DChart)
     assert_equal(@ws.drawing.rId, "rId1")
   end
 
   def test_index
+    @ws.add_chart(Axlsx::Pie3DChart)
     assert_equal(@ws.drawing.index, @ws.workbook.drawings.index(@ws.drawing))
   end
 
   def test_relationships
-    assert(@ws.drawing.relationships.empty?)
     chart = @ws.add_chart(Axlsx::Pie3DChart, :title=>"bob", :start_at=>[0,0], :end_at=>[1,1])
     assert_equal(@ws.drawing.relationships.size, 1, "adding a chart adds a relationship")
     chart = @ws.add_chart(Axlsx::Pie3DChart, :title=>"nancy", :start_at=>[1,5], :end_at=>[5,10])
@@ -67,6 +72,7 @@ class TestDrawing < Test::Unit::TestCase
 
   def test_to_xml
     schema = Nokogiri::XML::Schema(File.open(Axlsx::DRAWING_XSD))
+    @ws.add_chart(Axlsx::Pie3DChart)
     doc = Nokogiri::XML(@ws.drawing.to_xml_string)
     errors = []
     schema.validate(doc).each do |error|

data/test/drawing/tc_hyperlink.rb

@@ -19,11 +19,6 @@ class TestHyperlink < Test::Unit::TestCase
     assert_equal(@hyperlink.href, "http://axlsx.blogspot.com")
   end
 
-  def test_invalidUrl
-    assert_nothing_raised { @hyperlink.invalidUrl = "http://axlsx.blogspot.com" }
-    assert_equal(@hyperlink.invalidUrl, "http://axlsx.blogspot.com")
-  end
-
   def test_tgtFrame
     assert_nothing_raised { @hyperlink.tgtFrame = "http://axlsx.blogspot.com" }
     assert_equal(@hyperlink.tgtFrame, "http://axlsx.blogspot.com")
@@ -66,4 +61,8 @@ class TestHyperlink < Test::Unit::TestCase
     assert_equal(@hyperlink.history, false )
   end
 
+  def test_to_xml_string
+    doc = Nokogiri::XML(@p.workbook.worksheets.first.drawing.to_xml_string)
+    assert(doc.xpath("//a:hlinkClick"))
+  end
 end

data/test/drawing/tc_line_series.rb

@@ -5,22 +5,20 @@ class TestLineSeries < Test::Unit::TestCase
   def setup
     p = Axlsx::Package.new
     @ws = p.workbook.add_worksheet :name=>"hmmm"
-    chart = @ws.drawing.add_chart Axlsx::Line3DChart, :title => "fishery"
-    @series = chart.add_series :data=>[0,1,2], :labels=>["zero", "one", "two"], :title=>"bob"
+    chart = @ws.add_chart Axlsx::Line3DChart, :title => "fishery"
+    @series = chart.add_series :data=>[0,1,2], :labels=>["zero", "one", "two"], :title=>"bob", :color => "#FF0000"
   end
 
   def test_initialize
     assert_equal(@series.title.text, "bob", "series title has been applied")
-    assert_equal(@series.data, [0,1,2], "data option applied")
-    assert_equal(@series.labels, ["zero", "one","two"], "labels option applied")
-  end
+    assert_equal(@series.labels.class, Axlsx::AxDataSource)
+    assert_equal(@series.data.class, Axlsx::NumDataSource)
 
-  def test_data
-    assert_equal(@series.data, [0,1,2])
   end
-
-  def test_labels
-    assert_equal(@series.labels, ["zero", "one", "two"])
+  
+  def test_to_xml_string
+    doc = Nokogiri::XML(@series.to_xml_string)
+    assert(doc.xpath("//srgbClr[@val='#{@series.color}']"))
   end
-
+  #TODO serialization testing
 end

data/test/drawing/tc_named_axis_data.rb

@@ -0,0 +1,27 @@
+# require 'tc_helper.rb'
+
+# class TestNamedAxisData < Test::Unit::TestCase
+
+#   def setup
+#     p = Axlsx::Package.new
+#     @ws = p.workbook.add_worksheet
+#     @chart = @ws.drawing.add_chart Axlsx::Line3DChart
+#     @series = @chart.add_series :data=>[0,1,2]
+#   end
+
+#   def test_initialize
+#     assert(@series.data.is_a?Axlsx::SimpleTypedList)
+#     assert_equal(@series.data, [0,1,2])
+#   end
+
+#   def test_to_xml_string
+#     doc = Nokogiri::XML(@chart.to_xml_string)
+#     assert_equal(doc.xpath("//c:val/c:numRef/c:f").size,1)
+#     assert_equal(doc.xpath("//c:numCache/c:ptCount[@val='#{@series.data.size}']").size,1)
+#     @series.data.each_with_index do |datum, index|
+#       assert_equal(doc.xpath("//c:numCache/c:pt[@idx='#{index}']").size,1)
+#       assert_equal(doc.xpath("//c:numCache/c:pt/c:v[text()='#{datum}']").size,1)
+#     end
+#   end
+
+# end

data/test/drawing/tc_num_data.rb

@@ -0,0 +1,31 @@
+require 'tc_helper.rb'
+
+class TestNumData < Test::Unit::TestCase
+
+  def setup
+    @num_data = Axlsx::NumData.new :data => [1, 2, 3]
+  end
+
+  def test_initialize
+    assert_equal(@num_data.format_code, "General")
+  end
+ 
+  def test_formula_based_cell
+  
+  end
+ 
+  def test_format_code
+    assert_raise(ArgumentError) {@num_data.format_code = 7}
+    assert_nothing_raised {@num_data.format_code = 'foo_bar'}
+  end
+
+  def test_to_xml_string
+    str = '<?xml version="1.0" encoding="UTF-8"?>'
+    str << '<c:chartSpace xmlns:c="' << Axlsx::XML_NS_C << '">'
+    str << @num_data.to_xml_string
+    doc = Nokogiri::XML(str)
+    assert_equal(doc.xpath("//c:numLit/c:ptCount[@val=3]").size, 1)
+    assert_equal(doc.xpath("//c:numLit/c:pt/c:v[text()='1']").size, 1)
+  end
+
+end

data/test/drawing/tc_num_val.rb

@@ -0,0 +1,29 @@
+require 'tc_helper.rb'
+
+class TestNumVal < Test::Unit::TestCase
+
+  def setup
+    @num_val = Axlsx::NumVal.new :v => 1
+  end
+
+  def test_initialize
+    assert_equal(@num_val.format_code, "General")
+    assert_equal(@num_val.v, "1")
+  end
+
+  def test_format_code
+    assert_raise(ArgumentError) {@num_val.format_code = 7}
+    assert_nothing_raised {@num_val.format_code = 'foo_bar'}
+  end
+
+  def test_to_xml_string
+    str = '<?xml version="1.0" encoding="UTF-8"?>'
+    str << '<c:chartSpace xmlns:c="' << Axlsx::XML_NS_C << '">'
+    str << @num_val.to_xml_string(0)
+    doc = Nokogiri::XML(str)
+    # lets see if this works?
+    assert_equal(doc.xpath("//c:pt/c:v[text()='1']").size, 1)
+
+  end
+
+end

data/test/drawing/tc_pic.rb

@@ -6,7 +6,7 @@ class TestPic < Test::Unit::TestCase
     @p = Axlsx::Package.new
     ws = @p.workbook.add_worksheet
     @test_img =  File.dirname(__FILE__) + "/../../examples/image1.jpeg"
-    @image = ws.add_image :image_src => @test_img
+    @image = ws.add_image :image_src => @test_img, :hyperlink => 'https://github.com/randym', :tooltip => "What's up doc?"
   end
 
   def teardown
@@ -14,11 +14,31 @@ class TestPic < Test::Unit::TestCase
 
   def test_initialization
     assert_equal(@p.workbook.images.first, @image)
+    assert_equal(@image.file_name, 'image1.jpeg')
     assert_equal(@image.image_src, @test_img)
   end
 
+  def test_anchor_swapping
+    #swap from one cell to two cell when end_at is specified
+    assert(@image.anchor.is_a?(Axlsx::OneCellAnchor))
+    start_at = @image.anchor.from 
+    @image.end_at 10,5
+    assert(@image.anchor.is_a?(Axlsx::TwoCellAnchor))
+    assert_equal(start_at.col, @image.anchor.from.col)
+    assert_equal(start_at.row, @image.anchor.from.row)
+    assert_equal(10,@image.anchor.to.col)
+    assert_equal(5, @image.anchor.to.row)
+  
+    #swap from two cell to one cell when width or height are specified
+    @image.width = 200
+    assert(@image.anchor.is_a?(Axlsx::OneCellAnchor))
+    assert_equal(start_at.col, @image.anchor.from.col)
+    assert_equal(start_at.row, @image.anchor.from.row)
+    assert_equal(200, @image.width)
+  
+  end
   def test_hyperlink
-    assert_equal(@image.hyperlink, nil)
+    assert_equal(@image.hyperlink.href, "https://github.com/randym")
     @image.hyperlink = "http://axlsx.blogspot.com"
     assert_equal(@image.hyperlink.href, "http://axlsx.blogspot.com")
   end

data/test/drawing/tc_pie_3D_chart.rb

@@ -6,26 +6,22 @@ class TestPie3DChart < Test::Unit::TestCase
     p = Axlsx::Package.new
     ws = p.workbook.add_worksheet
     @row = ws.add_row ["one", 1, Time.now]
-    @chart = ws.drawing.add_chart Axlsx::Pie3DChart, :title => "fishery"
+    @chart = ws.add_chart Axlsx::Pie3DChart, :title => "fishery"
   end
 
   def teardown
   end
 
   def test_initialization
-    assert_equal(@chart.view3D.rotX, 30, "view 3d default rotX incorrect")
-    assert_equal(@chart.view3D.perspective, 30, "view 3d default perspective incorrect")
+    assert_equal(@chart.view_3D.rot_x, 30, "view 3d default rot_x incorrect")
+    assert_equal(@chart.view_3D.perspective, 30, "view_3d default perspective incorrect")
     assert_equal(@chart.series_type, Axlsx::PieSeries, "series type incorrect")
   end
 
   def test_to_xml
     schema = Nokogiri::XML::Schema(File.open(Axlsx::DRAWING_XSD))
     doc = Nokogiri::XML(@chart.to_xml_string)
-    errors = []
-    schema.validate(doc).each do |error|
-      errors.push error
-      puts error.message
-    end
+    errors = schema.validate(doc).map {|error| puts error.message; error }
     assert(errors.empty?, "error free validation")
   end
 

data/test/drawing/tc_pie_series.rb

@@ -5,30 +5,28 @@ class TestPieSeries < Test::Unit::TestCase
   def setup
     p = Axlsx::Package.new
     @ws = p.workbook.add_worksheet :name=>"hmmm"
-    chart = @ws.drawing.add_chart Axlsx::Pie3DChart, :title => "fishery"
-    @series = chart.add_series :data=>[0,1,2], :labels=>["zero", "one", "two"], :title=>"bob"
+    chart = @ws.add_chart Axlsx::Pie3DChart, :title => "fishery"
+    @series = chart.add_series :data=>[0,1,2], :labels=>["zero", "one", "two"], :title=>"bob", :colors => ["FF0000", "00FF00", "0000FF"]
   end
 
   def test_initialize
     assert_equal(@series.title.text, "bob", "series title has been applied")
-    assert_equal(@series.data, [0,1,2], "data option applied")
-    assert_equal(@series.labels, ["zero", "one","two"], "labels option applied")
+    assert_equal(@series.labels.class, Axlsx::AxDataSource)
+    assert_equal(@series.data.class, Axlsx::NumDataSource)
     assert_equal(@series.explosion, nil, "series shape has been applied")
   end
 
-  def test_data
-    assert_equal(@series.data, [0,1,2])
-  end
-
-  def test_labels
-    assert_equal(@series.labels, ["zero", "one", "two"])
-
-  end
-
   def test_explosion
     assert_raise(ArgumentError, "require valid explosion") { @series.explosion = :lots }
     assert_nothing_raised("allow valid explosion") { @series.explosion = 20 }
     assert(@series.explosion == 20)
   end
 
+  def test_to_xml_string
+    doc = Nokogiri::XML(@series.to_xml_string)
+    assert(doc.xpath("//srgbClr[@val='#{@series.colors[0]}']"))
+
+  end
+  #TODO test unique serialization parts
+
 end

data/test/drawing/tc_scatter_chart.rb

@@ -4,7 +4,7 @@ class TestScatterChart < Test::Unit::TestCase
   def setup
     @p = Axlsx::Package.new
     @chart = nil
-    ws = @p.workbook.add_worksheet do |sheet|
+    @p.workbook.add_worksheet do |sheet|
       sheet.add_row ["First",  1,  5,  7,  9]
       sheet.add_row ["",       1, 25, 49, 81]
       sheet.add_row ["Second", 5,  2, 14,  9]
@@ -22,6 +22,11 @@ class TestScatterChart < Test::Unit::TestCase
   def teardown
   end
 
+  def test_scatter_style
+    @chart.scatterStyle = :marker
+    assert(@chart.scatterStyle == :marker)
+    assert_raise(ArgumentError) { @chart.scatterStyle = :buckshot }
+  end
   def test_initialization
     assert_equal(@chart.scatterStyle, :lineMarker, "scatterStyle defualt incorrect")
     assert_equal(@chart.series_type, Axlsx::ScatterSeries, "series type incorrect")

data/test/drawing/tc_scatter_series.rb

@@ -5,16 +5,17 @@ class TestScatterSeries < Test::Unit::TestCase
   def setup
     p = Axlsx::Package.new
     @ws = p.workbook.add_worksheet :name=>"hmmm"
-    chart = @ws.drawing.add_chart Axlsx::ScatterChart, :title => "Scatter Chart"
-    @series = chart.add_series :xData=>[1,2,4], :yData=>[1,3,9], :title=>"exponents"
+    @chart = @ws.add_chart Axlsx::ScatterChart, :title => "Scatter Chart"
+    @series = @chart.add_series :xData=>[1,2,4], :yData=>[1,3,9], :title=>"exponents", :color => 'FF0000'
   end
 
   def test_initialize
     assert_equal(@series.title.text, "exponents", "series title has been applied")
   end
 
-  def test_data
-    assert_equal(@series.xData, [1,2,4])
-    assert_equal(@series.yData, [1,3,9])
+  def test_to_xml_string
+    doc = Nokogiri::XML(@chart.to_xml_string)
+    assert_equal(doc.xpath("//a:srgbClr[@val='#{@series.color}']").size,4)
   end
+
 end

data/test/drawing/tc_series.rb

@@ -5,7 +5,7 @@ class TestSeries < Test::Unit::TestCase
   def setup
     p = Axlsx::Package.new
     @ws = p.workbook.add_worksheet :name=>"hmmm"
-    chart = @ws.drawing.add_chart Axlsx::Chart, :title => "fishery"
+    chart = @ws.add_chart Axlsx::Chart, :title => "fishery"
     @series = chart.add_series :title=>"bob"
   end
 

data/test/drawing/tc_str_data.rb

@@ -0,0 +1,18 @@
+require 'tc_helper.rb'
+
+class TestStrData < Test::Unit::TestCase
+
+  def setup
+    @str_data = Axlsx::StrData.new :data => ["1", "2", "3"]
+  end
+
+  def test_to_xml_string_strLit
+    str = '<?xml version="1.0" encoding="UTF-8"?>'
+    str << '<c:chartSpace xmlns:c="' << Axlsx::XML_NS_C << '">'
+    str << @str_data.to_xml_string
+    doc = Nokogiri::XML(str)
+    assert_equal(doc.xpath("//c:strLit/c:ptCount[@val=3]").size, 1)
+    assert_equal(doc.xpath("//c:strLit/c:pt/c:v[text()='1']").size, 1)
+  end
+
+end

data/test/drawing/tc_str_val.rb

@@ -0,0 +1,21 @@
+require 'tc_helper.rb'
+
+class TestStrVal < Test::Unit::TestCase
+
+  def setup
+    @str_val = Axlsx::StrVal.new :v => "1"
+  end
+
+  def test_initialize
+    assert_equal(@str_val.v, "1")
+  end
+
+  def test_to_xml_string
+    str = '<?xml version="1.0" encoding="UTF-8"?>'
+    str << '<c:chartSpace xmlns:c="' << Axlsx::XML_NS_C << '">'
+    str << @str_val.to_xml_string(0)
+    doc = Nokogiri::XML(str)
+    assert_equal(doc.xpath("//c:pt/c:v[text()='1']").size, 1)
+  end
+
+end

data/test/drawing/tc_title.rb

@@ -1,3 +1,5 @@
+$LOAD_PATH.unshift "#{File.dirname(__FILE__)}/../"
+
 require 'tc_helper.rb'
 
 class TestTitle < Test::Unit::TestCase
@@ -30,4 +32,18 @@ class TestTitle < Test::Unit::TestCase
     assert(@title.text == "one")
   end
 
+  def test_to_xml_string_text
+    @chart.title.text = 'foo'
+    doc = Nokogiri::XML(@chart.to_xml_string)
+    assert_equal(1, doc.xpath('//c:rich').size)
+    assert_equal(1, doc.xpath("//a:t[text()='foo']").size)
+  end
+
+  def test_to_xml_string_cell
+    @chart.title.cell = @row.cells.first
+    doc = Nokogiri::XML(@chart.to_xml_string)
+    assert_equal(1, doc.xpath('//c:strCache').size)
+    assert_equal(1, doc.xpath('//c:v[text()="one"]').size)
+  end
+
 end

data/test/drawing/tc_two_cell_anchor.rb

@@ -5,8 +5,7 @@ class TestTwoCellAnchor < Test::Unit::TestCase
   def setup
     p = Axlsx::Package.new
     @ws = p.workbook.add_worksheet
-    row = @ws.add_row ["one", 1, Time.now]
-    title = Axlsx::Title.new
+    @ws.add_row ["one", 1, Time.now]
     chart = @ws.add_chart Axlsx::Bar3DChart
     @anchor = chart.graphic_frame.anchor
   end
@@ -23,7 +22,7 @@ class TestTwoCellAnchor < Test::Unit::TestCase
 
 
   def test_options
-    assert_raise(ArgumentError, 'invalid start_at') { @ws.add_chart Axlsx::Chart, :start_at=>[1] }
+    assert_raise(ArgumentError, 'invalid start_at') { @ws.add_chart Axlsx::Chart, :start_at=>"1" }
     assert_raise(ArgumentError, 'invalid end_at') { @ws.add_chart Axlsx::Chart, :start_at=>[1,2], :end_at => ["a", 4] }
     # this is actually raised in the graphic frame
     assert_raise(ArgumentError, 'invalid Chart') { @ws.add_chart Axlsx::TwoCellAnchor }

data/test/drawing/tc_view_3D.rb

@@ -9,33 +9,33 @@ class TestView3D < Test::Unit::TestCase
   end
 
   def test_options
-    v = Axlsx::View3D.new :rotX => 10, :rotY => 5, :hPercent => "30%", :depthPercent => "45%", :rAngAx => false, :perspective => 10
-    assert_equal(v.rotX, 10)
-    assert_equal(v.rotY, 5)
-    assert_equal(v.hPercent, "30%")
-    assert_equal(v.depthPercent, "45%")
-    assert_equal(v.rAngAx, false)
+    v = Axlsx::View3D.new :rot_x => 10, :rot_y => 5, :h_percent => "30%", :depth_percent => "45%", :r_ang_ax => false, :perspective => 10
+    assert_equal(v.rot_x, 10)
+    assert_equal(v.rot_y, 5)
+    assert_equal(v.h_percent, "30%")
+    assert_equal(v.depth_percent, "45%")
+    assert_equal(v.r_ang_ax, false)
     assert_equal(v.perspective, 10)
   end
 
-  def test_rotX
-    assert_raise(ArgumentError) {@view.rotX = "bob"}
-    assert_nothing_raised {@view.rotX = -90}
+  def test_rot_x
+    assert_raise(ArgumentError) {@view.rot_x = "bob"}
+    assert_nothing_raised {@view.rot_x = -90}
   end
 
-  def test_rotY
-    assert_raise(ArgumentError) {@view.rotY = "bob"}
-    assert_nothing_raised {@view.rotY = 90}
+  def test_rot_y
+    assert_raise(ArgumentError) {@view.rot_y = "bob"}
+    assert_nothing_raised {@view.rot_y = 90}
   end
 
-  def test_hPercent
-    assert_raise(ArgumentError) {@view.hPercent = "bob"}
-    assert_nothing_raised {@view.hPercent = "500%"}
+  def test_h_percent
+    assert_raise(ArgumentError) {@view.h_percent = "bob"}
+    assert_nothing_raised {@view.h_percent = "500%"}
   end
 
-  def test_depthPercent
-    assert_raise(ArgumentError) {@view.depthPercent = "bob"}
-    assert_nothing_raised {@view.depthPercent = "20%"}
+  def test_depth_percent
+    assert_raise(ArgumentError) {@view.depth_percent = "bob"}
+    assert_nothing_raised {@view.depth_percent = "20%"}
   end
 
 

data/test/drawing/tc_vml_drawing.rb

@@ -0,0 +1,25 @@
+require 'tc_helper.rb'
+
+class TestVmlDrawing < Test::Unit::TestCase
+
+  def setup
+    p = Axlsx::Package.new
+    wb = p.workbook
+    @ws = wb.add_worksheet
+    @ws.add_comment :ref => 'A1', :text => 'penut machine', :author => 'crank'
+    @ws.add_comment :ref => 'C3', :text => 'rust bucket', :author => 'PO'
+    @vml_drawing = @ws.comments.vml_drawing
+  end
+
+  def test_initialize
+    assert_raise(ArgumentError) { Axlsx::VmlDrawing.new }
+  end
+
+  def test_to_xml_string
+    str = @vml_drawing.to_xml_string()
+    doc = Nokogiri::XML(str)
+    assert_equal(doc.xpath("//v:shape").size, 2)
+    assert(doc.xpath("//o:idmap[@o:data='#{@ws.index+1}']"))
+  end
+
+end

data/test/drawing/tc_vml_shape.rb

@@ -0,0 +1,100 @@
+require 'tc_helper.rb'
+
+class TestVmlShape < Test::Unit::TestCase
+
+  def setup
+    p = Axlsx::Package.new
+    wb = p.workbook
+    @ws = wb.add_worksheet
+    @ws.add_comment :ref => 'A1', :text => 'penut machine', :author => 'crank'
+    @ws.add_comment :ref => 'C3', :text => 'rust bucket', :author => 'PO'
+    @comments = @ws.comments
+  end
+
+  def test_initialize
+    assert_raise(ArgumentError) { Axlsx::VmlDrawing.new }
+  end
+
+  def test_row
+    shape = @comments.first.vml_shape
+    assert_equal(shape.row, 0)
+    shape = @comments.last.vml_shape
+    assert_equal(shape.row, 2)
+  end
+
+  def test_column
+    shape = @comments.first.vml_shape
+    assert_equal(shape.column, 0)
+    shape = @comments.last.vml_shape
+    assert_equal(shape.column, 2)
+  end
+
+  def test_left_column
+    shape = @comments.first.vml_shape
+    shape.left_column = 3
+    assert(shape.left_column == 3)
+    assert_raise(ArgumentError) { shape.left_column = [] }
+  end
+
+  def test_left_offset
+    shape = @comments.first.vml_shape
+    shape.left_offset = 3
+    assert(shape.left_offset == 3)
+    assert_raise(ArgumentError) { shape.left_offset = [] }
+  end
+
+  def test_right_column
+    shape = @comments.first.vml_shape
+    shape.right_column = 3
+    assert(shape.right_column == 3)
+    assert_raise(ArgumentError) { shape.right_column = [] }
+  end
+
+  def test_right_offset
+    shape = @comments.first.vml_shape
+    shape.right_offset = 3
+    assert(shape.right_offset == 3)
+    assert_raise(ArgumentError) { shape.right_offset = [] }
+  end
+
+  def test_top_offset
+    shape = @comments.first.vml_shape
+    shape.top_offset = 3
+    assert(shape.top_offset == 3)
+    assert_raise(ArgumentError) { shape.top_offset = [] }
+  end
+
+  def test_bottom_offset
+    shape = @comments.first.vml_shape
+    shape.bottom_offset = 3
+    assert(shape.bottom_offset == 3)
+    assert_raise(ArgumentError) { shape.bottom_offset = [] }
+  end
+
+  def test_bottom_row
+    shape = @comments.first.vml_shape
+    shape.bottom_row = 3
+    assert(shape.bottom_row == 3)
+    assert_raise(ArgumentError) { shape.bottom_row = [] }
+  end
+
+  def test_top_row
+    shape = @comments.first.vml_shape
+    shape.top_row = 3
+    assert(shape.top_row == 3)
+    assert_raise(ArgumentError) { shape.top_row = [] }
+  end
+
+  def test_to_xml_string
+    str = @comments.vml_drawing.to_xml_string()
+    doc = Nokogiri::XML(str)
+    assert_equal(doc.xpath("//v:shape").size, 2)
+    @comments.each do |comment|
+      shape = comment.vml_shape
+      assert(doc.xpath("//v:shape/x:ClientData/x:Row[text()='#{shape.row}']").size == 1)
+      assert(doc.xpath("//v:shape/x:ClientData/x:Column[text()='#{shape.column}']").size == 1)
+      assert(doc.xpath("//v:shape/x:ClientData/x:Anchor[text()='#{shape.left_column}, #{shape.left_offset}, #{shape.top_row}, #{shape.top_offset}, #{shape.right_column}, #{shape.right_offset}, #{shape.bottom_row}, #{shape.bottom_offset}']").size == 1)
+    end
+  end
+
+end

data/test/rels/tc_relationship.rb

@@ -10,6 +10,7 @@ class TestRelationships < Test::Unit::TestCase
   def test_type
     assert_raise(ArgumentError) { Axlsx::Relationship.new 'type', 'target' }
     assert_nothing_raised { Axlsx::Relationship.new Axlsx::WORKSHEET_R, 'target' }
+    assert_nothing_raised { Axlsx::Relationship.new Axlsx::COMMENT_R, 'target' }
   end
 
   def test_target_mode

data/test/stylesheet/tc_gradient_fill.rb

@@ -61,4 +61,12 @@ class TestGradientFill < Test::Unit::TestCase
     assert(@item.stop.size == 1)
     assert(@item.stop.last.is_a?(Axlsx::GradientStop))
   end
+
+  def test_to_xml_string
+    @item.stop << Axlsx::GradientStop.new(Axlsx::Color.new(:rgb => "000000"), 0.5)
+    @item.stop << Axlsx::GradientStop.new(Axlsx::Color.new(:rgb => "FFFFFF"), 0.5)
+    @item.type = :path
+    doc = Nokogiri::XML(@item.to_xml_string)
+    assert(doc.xpath("//color[@rgb='FF000000']"))
+  end
 end