axe-core-api 4.9.0.pre.849d39a → 4.9.1.pre.1a5838a

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ea179a516f33e0d5e64fb563c16a4fb4b267fae8e7f23bffbd227404e68bff8
-  data.tar.gz: 46941651ccb03f0c77f28430544fe9e94f4147df21eb3b633ffbed29a8a4e1dd
+  metadata.gz: 12c93c9466138b2f7e70781d37dc404da0cc7d1aac8e2ad907e730491ec6b0bc
+  data.tar.gz: fc35cf2bfdb8fad39f07c52a3708e4f6c31394322882cce528bc5f06a655bd73
 SHA512:
-  metadata.gz: 72f76da27e87b79c6db29ca096239f0377925d3aa285b33f30b8daa65d677623503044d48c5f3b77e06e8f937bcd225f89741df92290eed81660fe88eec1f618
-  data.tar.gz: 5ed059168a23382bda115c0564498c747f0256f1b1fd839b383003a25d69d6584cf2cf82f21b734f2e466f1ee6aca581b122ef160bcb95d0045814e4d8f2c2fb
+  metadata.gz: b08b4d39d1346d1292e7dfb151267745b21ba62752a89293c5f0ccfa69c62bece7eaad8e81bf4edb4cd5dbf2025776533ebc0cc303ba9a4a683885a2701d3546
+  data.tar.gz: aa900c93bcbd4f4100cfcbd8f7616df6bad1bab07ae46f1048870b27e2a44ac86624e3c7defd1929586b9898b91380d9982f39fbc5190ad851b18d0522f4ee84

data/lib/axe/api/run.rb

@@ -87,22 +87,28 @@ module Axe
 
       def within_about_blank_context(page)
         driver = get_selenium page
+        # This is a workaround to maintain Selenium 3 support
+        # Likely driver.switch_to.new_window(:tab) should be used instead, should we drop support, as per
+        # https://github.com/dequelabs/axe-core-gems/issues/352
 
-        num_handles = page.window_handles.length
+        before_handles = page.window_handles
         begin
           driver.execute_script("window.open('about:blank'), '_blank'")
-          if num_handles == page.window_handles.length
-            raise StandardError.new "Could not open new window. Please make sure that you have popup blockers disabled."
-          end
-          driver.switch_to.window page.window_handles[-1]
         rescue
-            raise StandardError.new "switchToWindow failed. Are you using updated browser drivers? Please check out https://github.com/dequelabs/axe-core-gems/blob/develop/error-handling.md"
+          raise StandardError.new "switchToWindow failed. Are you using updated browser drivers? Please check out https://github.com/dequelabs/axe-core-gems/blob/develop/error-handling.md"
+        end
+        after_handles = page.window_handles
+        new_handles = after_handles.difference(before_handles)
+        if new_handles.length != 1
+          raise StandardError.new "Unable to determine window handle"
         end
+        new_handle = new_handles[0]
+        driver.switch_to.window new_handle
         driver.get "about:blank"
 
         ret = yield page
 
-        driver.switch_to.window page.window_handles[-1]
+        driver.switch_to.window new_handle
         driver.close
         driver.switch_to.window @original_window
 

data/lib/axe/api.rb

@@ -0,0 +1,5 @@
+module Axe
+  module API
+    autoload :Run, "axe/api/run"
+  end
+end

data/lib/axe/core.rb

@@ -38,22 +38,8 @@ module Axe
       Core.has_run_partial?(@page) and not Axe::Configuration.instance.legacy_mode
     end
 
-    def assert_frame_ready
-      begin
-        ready = Timeout.timeout(10) {
-          @page.evaluate_script <<-JS
-            document.readyState === 'complete'
-          JS
-        }
-      rescue Timeout::Error
-        ready = false
-      end
-      raise Exception.new "Page/frame not ready" if not ready
-    end
-
     def load_axe_core(source)
       return if already_loaded?
-      assert_frame_ready
       loader = Common::Loader.new(@page, self)
       loader.load_top_level source
       return if use_run_partial

data/lib/axe/matchers/be_axe_clean.rb

@@ -2,7 +2,7 @@ require "forwardable"
 
 require_relative "../../chain_mail/chainable"
 require_relative "../core"
-require_relative "../api/run"
+require_relative "../api"
 
 module Axe
   module Matchers