awspec 1.25.1 → 1.25.2

data/lib/awspec/generator/spec/kms.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Kms
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         aliases = select_all_kms_aliases.select { |kms_alias| customer_managed_key?(kms_alias) }
         raise 'Not Found alias' if aliases.empty?
+
         ERB.new(keys_spec_template, nil, '-').result(binding).chomp
       end
 
       def keys_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% aliases.each do |kms_alias| %>
 describe kms('<%= kms_alias.alias_name.split('/').last %>') do
   it { should exist }
@@ -19,7 +22,6 @@ describe kms('<%= kms_alias.alias_name.split('/').last %>') do
 end
 <% end %>
 EOF
-        template
       end
 
       private

data/lib/awspec/generator/spec/lambda.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Lambda
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         lambda_functions = select_all_lambda_functions
         raise 'Not Found lambda' if lambda_functions.empty?
+
         ERB.new(lambda_spec_template, nil, '-').result(binding).chomp
       end
 
       def lambda_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% lambda_functions.each do |function| %>
 describe lambda('<%= function.function_name %>') do
   it { should exist }
@@ -22,7 +25,6 @@ describe lambda('<%= function.function_name %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/nat_gateway.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NatGateway
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         nat_gateways = select_nat_gateway_by_vpc_id(@vpc_id)
@@ -18,7 +21,7 @@ module Awspec::Generator
       end
 
       def nat_gateway_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe nat_gateway('<%= nat_gateway_id %>') do
   it { should exist }
   it { should be_<%= nat_gateway.state %> }
@@ -32,7 +35,6 @@ describe nat_gateway('<%= nat_gateway_id %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/network_acl.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NetworkAcl
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         network_acls = select_network_acl_by_vpc_id(@vpc_id)
@@ -31,9 +34,9 @@ module Awspec::Generator
         acl.associations.each do |a|
           subnet = find_subnet(a.subnet_id)
           spec = if subnet.tag_name
-                   "it { should have_subnet('" + subnet.tag_name + "') }"
+                   "it { should have_subnet('#{subnet.tag_name}') }"
                  else
-                   "it { should have_subnet('" + subnet.subnet_id + "') }"
+                   "it { should have_subnet('#{subnet.subnet_id}') }"
                  end
           specs.push(spec)
         end
@@ -47,23 +50,23 @@ module Awspec::Generator
           line = ''
           inout = 'inbound'
           inout = 'outbound' if entry.egress
-          line += 'its(:' + inout + ') { should'
+          line += "its(:#{inout}) { should"
           actions = { allow: 'be_allowed', deny: 'be_denied' }
-          line += ' ' + actions[entry.rule_action.to_sym]
+          line += " #{actions[entry.rule_action.to_sym]}"
           port_range = entry.port_range
           unless port_range.nil?
             port = if port_range.from == port_range.to
                      port_range.from.to_s
                    else
-                     "'" + port_range.from.to_s + '-' + port_range.to.to_s + "'"
+                     "'#{port_range.from}-#{port_range.to}'"
                    end
-            line += '(' + port + ')'
+            line += "(#{port})"
           end
-          line += ".protocol('" + protocols[entry.protocol.to_i] + "')"
-          line += ".source('" + entry.cidr_block + "')"
+          line += ".protocol('#{protocols[entry.protocol.to_i]}')"
+          line += ".source('#{entry.cidr_block}')"
           rule_number = entry.rule_number.to_i
           rule_number = "'*'" if rule_number == 32_767
-          line += '.rule_number(' + rule_number.to_s + ')'
+          line += ".rule_number(#{rule_number})"
           line += ' }'
           linespecs.push(line)
         end
@@ -71,7 +74,7 @@ module Awspec::Generator
       end
 
       def network_acl_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if network_acl_tag_name -%>
 describe network_acl('<%= network_acl_tag_name %>') do
 <%- else -%>
@@ -89,7 +92,6 @@ describe network_acl('<%= network_acl_id %>') do
   its(:outbound_entries_count) { should eq <%= inbound_entries_count %> }
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/network_interface.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NetworkInterface
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         network_interfaces = select_network_interface_by_vpc_id(@vpc_id)
@@ -23,6 +26,7 @@ module Awspec::Generator
 
       def generate_instance_spec(interface)
         return unless interface.attachment.instance_id
+
         instance = find_ec2(interface.attachment.instance_id)
         instance_spec = if instance.tag_name
                           "it { should be_attached_to('#{instance.tag_name}')"
@@ -35,13 +39,13 @@ module Awspec::Generator
 
       def generate_subnet_spec(interface)
         return unless interface.subnet_id
+
         subnet = find_subnet(interface.subnet_id)
-        subnet_spec = if subnet.tag_name
-                        "it { should belong_to_subnet('#{subnet.tag_name}') }"
-                      else
-                        "it { should belong_to_subnet('#{subnet.subnet_id}') }"
-                      end
-        subnet_spec
+        if subnet.tag_name
+          "it { should belong_to_subnet('#{subnet.tag_name}') }"
+        else
+          "it { should belong_to_subnet('#{subnet.subnet_id}') }"
+        end
       end
 
       def generate_linespecs(interface)
@@ -56,7 +60,7 @@ module Awspec::Generator
       end
 
       def network_interface_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe network_interface('<%= network_interface_id %>') do
   it { should exist }
   it { should be_<%= interface.status.tr('-', '_') %> }
@@ -73,7 +77,6 @@ describe network_interface('<%= network_interface_id %>') do
   its(:private_ip_addresses_count) { should eq <%= interface.private_ip_addresses.count %> }
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/nlb.rb

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Nlb
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           load_balancer_name
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         nlbs = select_nlb_by_vpc_id(@vpc_id)
@@ -19,7 +22,7 @@ module Awspec::Generator
       end
 
       def nlb_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe nlb('<%= nlb.load_balancer_name %>') do
   it { should exist }
   its(:load_balancer_arn) { should eq '<%= nlb.load_balancer_arn %>' }
@@ -31,7 +34,6 @@ describe nlb('<%= nlb.load_balancer_name %>') do
   its(:ip_address_type) { should eq '<%= nlb.ip_address_type %>' }
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/nlb_listener.rb

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NlbListener
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           load_balancer_arn port protocol ssl_policy
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         nlbs = select_nlb_by_vpc_id(@vpc_id)
@@ -77,7 +80,7 @@ module Awspec::Generator
       end
 
       def nlb_listener_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe nlb_listener('<%= listener.listener_arn %>') do
   it { should exist }
   <%- describes.each do |describe| -%>
@@ -103,7 +106,6 @@ describe nlb_listener('<%= listener.listener_arn %>') do
   <%- end -%>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/rds.rb

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Rds
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           db_instance_identifier db_instance_class multi_az availability_zone
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         db_instances = select_rds_by_vpc_id(@vpc_id)

data/lib/awspec/generator/spec/rds_db_cluster_parameter_group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class RdsDbClusterParameterGroup
@@ -9,14 +11,13 @@ module Awspec::Generator
       end
 
       def db_cluster_parameter_group_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe rds_db_cluster_parameter_group('<%= @parameter_group %>') do
 <% res.each do |key, value| %>
   its('<%= key %>') { should eq '<%= value %>' }
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/rds_db_parameter_group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class RdsDbParameterGroup
@@ -9,14 +11,13 @@ module Awspec::Generator
       end
 
       def db_parameter_group_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe rds_db_parameter_group('<%= @parameter_group %>') do
 <% res.each do |key, value| %>
   its('<%= key %>') { should eq '<%= value %>' }
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/redshift.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Redshift
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           node_type master_username db_name availability_zone
           allow_version_upgrade number_of_nodes publicly_accessible encrypted
           kms_key_id enhanced_vpc_routing pending_actions maintenance_track_name
           elastic_resize_number_of_node_options
-        )
+        ]
 
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         clusters = select_redshift_by_vpc_id(@vpc_id)

data/lib/awspec/generator/spec/redshift_cluster_parameter_group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class RedshiftClusterParameterGroup
@@ -9,14 +11,13 @@ module Awspec::Generator
       end
 
       def redshift_cluster_parameters_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe redshift_cluster_parameter_group('<%= @parameter_group %>') do
 <% res.each do |key, value| %>
   its('<%= key %>') { should eq '<%= value %>' }
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/route53_hosted_zone.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Route53HostedZone
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_by_domain_name(id)
         hosted_zone = find_hosted_zone(id)
         raise 'Not Found Route53 Hosted Zone' unless hosted_zone
+
         id = hosted_zone[:id]
         selected = []
         res = @route53_client.list_resource_record_sets({
@@ -56,7 +59,7 @@ EOF
       end
 
       def route53_hosted_zone_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe route53_hosted_zone('<%= hosted_zone.name %>') do
   it { should exist }
   its(:resource_record_set_count) { should eq <%= hosted_zone.resource_record_set_count %> }
@@ -65,7 +68,6 @@ describe route53_hosted_zone('<%= hosted_zone.name %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/route_table.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class RouteTable
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         route_tables = select_route_table_by_vpc_id(@vpc_id)
@@ -47,6 +50,7 @@ module Awspec::Generator
         linespecs = []
         route_table.associations.each do |a|
           next if a.subnet_id.nil?
+
           subnet = find_subnet(a.subnet_id)
           linespecs.push(ERB.new(route_table_spec_subnet_linetemplate, nil, '-').result(binding)) if subnet
         end
@@ -54,54 +58,49 @@ module Awspec::Generator
       end
 
       def route_table_spec_gateway_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 it { should have_route('<%= destination %>').target(gateway: '<%= route.gateway_id %>') }
 EOF
-        template
       end
 
       def route_table_spec_instance_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if instance.tag_name -%>
 it { should have_route('<%= route.destination_cidr_block %>').target(instance: '<%= instance.tag_name %>') }
 <%- else -%>
 it { should have_route('<%= route.destination_cidr_block %>').target(instance: '<%= route.instance_id %>') }
 <%- end -%>
 EOF
-        template
       end
 
       def route_table_spec_connection_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if connection.tag_name -%>
 it { should have_route('<%= route.destination_cidr_block %>').target(vpc_peering_connection: '<%= connection.tag_name %>') }
 <%- else -%>
 it { should have_route('<%= route.destination_cidr_block %>').target(vpc_peering_connection: '<%= route.vpc_peering_connection_id %>') }
 <%- end -%>
 EOF
-        template
       end
 
       def route_table_spec_nat_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 it { should have_route('<%= route.destination_cidr_block %>').target(nat: '<%= route.nat_gateway_id %>') }
 EOF
-        template
       end
 
       def route_table_spec_subnet_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if subnet.tag_name -%>
 it { should have_subnet('<%= subnet.tag_name %>') }
 <%- else -%>
 it { should have_subnet('<%= subnet.subnet_id %>') }
 <%- end -%>
 EOF
-        template
       end
 
       def route_table_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if route_table_tag_name -%>
 describe route_table('<%= route_table_tag_name %>') do
 <%- else -%>
@@ -121,7 +120,6 @@ describe route_table('<%= route_table_id %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/s3_bucket.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class S3Bucket
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         buckets = select_all_buckets
         raise 'Not Found Bucket' if buckets.empty?
+
         specs = buckets.map do |bucket|
           content(bucket)
         end
@@ -18,6 +21,7 @@ module Awspec::Generator
 
       def generate_grant_specs(acl)
         return [] unless acl
+
         linespecs = []
         acl.grants.each do |grant|
           linespecs.push(ERB.new(grant_linetemplate, nil, '-').result(binding))
@@ -27,10 +31,9 @@ module Awspec::Generator
 
       def grant_linetemplate
         grantee = 'grant.grantee.display_name || grant.grantee.uri || grant.grantee.id'
-        template = <<-EOF
+        <<-EOF
 it { should have_acl_grant(grantee: '<%= #{grantee} %>', permission: '<%= grant.permission %>') }
         EOF
-        template
       end
 
       def generate_lifecycle_rule_transitions_spec(transitions_rule)
@@ -47,13 +50,14 @@ it { should have_acl_grant(grantee: '<%= #{grantee} %>', permission: '<%= grant.
                           "#{k}: '#{v.inspect}'"
                         end
           end
-          rules << '{ ' + elements.join(', ') + ' }'
+          rules << "{ #{elements.join(', ')} }"
         end
-        '[' + rules.join(', ') + ']'
+        "[#{rules.join(', ')}]"
       end
 
       def generate_lifecycle_rule_specs(lifecycle_rule)
         return [] unless lifecycle_rule
+
         linespecs = []
         lifecycle_rule.rules.each do |rule|
           transitions = generate_lifecycle_rule_transitions_spec(rule.transitions.map(&:to_h))
@@ -81,7 +85,7 @@ it do
       end
 
       def bucket_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe s3_bucket('<%= bucket.name %>') do
   it { should exist }
 <%- if acl -%>
@@ -107,7 +111,6 @@ describe s3_bucket('<%= bucket.name %>') do
 <%- end -%>
 end
 EOF
-        template
       end
 
       private

data/lib/awspec/generator/spec/security_group.rb

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class SecurityGroup
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           group_id group_name
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         sgs = select_security_group_by_vpc_id(@vpc_id)
@@ -28,14 +31,14 @@ module Awspec::Generator
       def generate_linespecs(sg)
         linespecs = []
         permissions = { 'inbound' => sg.ip_permissions, 'outbound' => sg.ip_permissions_egress }
-        %w(inbound outbound).each do |inout|
+        %w[inbound outbound].each do |inout|
           permissions[inout].each do |permission|
             port = if permission.from_port.nil?
                      nil
                    elsif permission.from_port == permission.to_port
                      permission.from_port
                    else
-                     "'" + permission.from_port.to_s + '-' + permission.to_port.to_s + "'"
+                     "'#{permission.from_port}-#{permission.to_port}'"
                    end
 
             protocol = if permission.ip_protocol.to_i < 0
@@ -59,14 +62,13 @@ module Awspec::Generator
       end
 
       def security_group_spec_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 its(:<%= inout %>) { should be_opened<%- unless port.nil? -%>(<%= port %>)<%- end -%>.protocol('<%= protocol %>').for('<%= target %>') }
 EOF
-        template
       end
 
       def security_group_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe security_group('<%= sg.group_name %>') do
   it { should exist }
 <% describes.each do |describe| %>
@@ -88,7 +90,6 @@ describe security_group('<%= sg.group_name %>') do
 <%- end -%>
 end
 EOF
-        template
       end
     end
   end