awspec 1.24.3 → 1.25.2

data/lib/awspec/generator/spec/cloudwatch_event.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class CloudwatchEvent
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         events = select_all_cloudwatch_events
         raise 'Not Found event' if events.empty?
+
         ERB.new(event_spec_template, nil, '-').result(binding).chomp
       end
 
       def event_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% events.each do |event| %>
 describe cloudwatch_event('<%= event.name %>') do
   it { should exist }
@@ -20,7 +23,6 @@ describe cloudwatch_event('<%= event.name %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/cloudwatch_logs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class CloudwatchLogs
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         log_groups = select_all_cloudwatch_logs_log_groups
         raise 'Not Found Log Group' if log_groups.empty?
+
         specs = log_groups.map do |log_group|
           log_stream_line = generate_log_stream_spec(log_group.log_group_name)
           metric_filter_lines = generate_log_metric_filters_specs(log_group.log_group_name)
@@ -23,7 +26,11 @@ module Awspec::Generator
         metric_filters = select_all_cloudwatch_logs_metric_filter(log_group)
         metric_filter_lines = []
         metric_filters.each do |metric_filter|
-          line = "it { should have_metric_filter('#{metric_filter.filter_name}') }"
+          line = "it { should have_metric_filter('#{metric_filter.filter_name}')"
+          unless metric_filter.filter_pattern.empty?
+            line += ".filter_pattern('#{metric_filter.filter_pattern}')"
+          end
+          line += ' }'
           metric_filter_lines.push(line)
         end
         metric_filter_lines
@@ -44,7 +51,7 @@ module Awspec::Generator
       end
 
       def cloudwatch_logs_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe cloudwatch_logs('<%= log_group.log_group_name %>') do
   it { should exist }
 <%- unless log_group.retention_in_days.nil? -%>
@@ -61,7 +68,6 @@ describe cloudwatch_logs('<%= log_group.log_group_name %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/codebuild.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Codebuild
@@ -5,18 +7,18 @@ module Awspec::Generator
       def generate_all
         projects = select_all_codebuild_projects
         raise 'Not Found CodeBuild Project' if projects.empty?
+
         ERB.new(codebuild_spec_template, nil, '-').result(binding).chomp
       end
 
       def codebuild_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% projects.each do |project| %>
 describe codebuild('<%= project %>') do
   it { should exist }
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/directconnect.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Directconnect
@@ -9,11 +11,12 @@ module Awspec::Generator
       def generate_virtual_interface_all
         virtual_interfaces = select_virtual_interfaces
         raise 'Not Found virtual_interfaces' if virtual_interfaces.empty?
+
         ERB.new(virtual_interface_spec_template, nil, '-').result(binding).chomp
       end
 
       def virtual_interface_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% virtual_interfaces.each do |interface| %>
 describe directconnect_virtual_interface('<%= interface.virtual_interface_name %>') do
   it { should exist }
@@ -26,7 +29,6 @@ describe directconnect_virtual_interface('<%= interface.virtual_interface_name %
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/ebs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Ebs
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         volumes = select_all_attached_ebs
         raise 'Not Found EBS' if volumes.empty?
+
         specs = volumes.map do |volume|
           attachment_specs = generate_attachment_specs(volume)
           content = ERB.new(ebs_spec_template, nil, '-').result(binding).gsub(/^\n/, '')
@@ -22,18 +25,17 @@ module Awspec::Generator
       end
 
       def attachment_linetemplate
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if instance.tag_name -%>
 it { should be_attached_to('<%= instance.tag_name %>') }
 <%- else -%>
 it { should be_attached_to('<%= instance.instance_id %>') }
 <%- end -%>
 EOF
-        template
       end
 
       def ebs_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if volume.tag_name -%>
 describe ebs('<%= volume.tag_name %>') do
 <%- else -%>
@@ -48,7 +50,6 @@ describe ebs('<%= volume.volume_id %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/ec2.rb

@@ -1,14 +1,17 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Ec2
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           instance_id image_id private_dns_name public_dns_name
           instance_type private_ip_address public_ip_address
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         instances = select_ec2_by_vpc_id(@vpc_id)

data/lib/awspec/generator/spec/efs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Efs
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         file_systems = select_all_file_systems
         raise 'EFS not found' if file_systems.empty?
+
         specs = file_systems.map do |file_system|
           file_system.name = get_name_by_id(file_system.file_system_id)
           content = ERB.new(file_system_spec_template, nil, '-').result(binding).gsub(/^\n/, '')
@@ -13,7 +16,7 @@ module Awspec::Generator
       end
 
       def file_system_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe efs('<%= file_system.name %>') do
   it { should exist }
   its(:number_of_mount_targets) { should eq <%= file_system.number_of_mount_targets %> }
@@ -21,7 +24,6 @@ describe efs('<%= file_system.name %>') do
   its(:performance_mode) { should eq '<%= file_system.performance_mode %>' }
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/eip.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Eip
@@ -10,11 +12,12 @@ module Awspec::Generator
       def generate_all
         eips = select_all_addresses
         raise 'Not Found Elastic IP addresses.' if eips.empty?
+
         ERB.new(eip_spec_template, nil, '-').result(binding).chomp
       end
 
       def eip_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% eips.each do |eip| %>
 describe eip('<%= eip.public_ip %>') do
   it { should exist }
@@ -23,7 +26,6 @@ describe eip('<%= eip.public_ip %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/elasticache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Elasticache
@@ -9,14 +11,16 @@ module Awspec::Generator
           res = elasticache_client.describe_cache_clusters(opt)
           clusters.push(*res.cache_clusters)
           break if res.marker.nil?
+
           opt = { marker: res.marker }
         end
         raise 'Not Found Cache Clusters' if clusters.empty?
+
         ERB.new(cache_clusters_spec_template, nil, '-').result(binding).gsub(/^\n/, '')
       end
 
       def cache_clusters_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% clusters.each do |cluster| %>
 describe elasticache('<%= cluster.cache_cluster_id %>') do
   it { should exist }
@@ -36,7 +40,6 @@ describe elasticache('<%= cluster.cache_cluster_id %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/elasticsearch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Elasticsearch
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         domains = select_all_elasticsearch_domains
         raise 'Not Found Domain' if domains.empty?
+
         ERB.new(domain_spec_template, nil, '-').result(binding).gsub(/^\n/, '')
       end
 
       def domain_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% domains.each do |domain| %>
 describe elasticsearch('<%= domain.domain_status.domain_name %>') do
   it { should exist }
@@ -34,7 +37,6 @@ describe elasticsearch('<%= domain.domain_status.domain_name %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/elb.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Elb
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
+        describes = %w[
           load_balancer_name
-        )
-        health_check_options = %w(
+        ]
+        health_check_options = %w[
           target interval timeout
           unhealthy_threshold healthy_threshold
-        )
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         lbs = select_elb_by_vpc_id(@vpc_id)
@@ -23,7 +26,7 @@ module Awspec::Generator
       end
 
       def elb_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe elb('<%= lb.load_balancer_name %>') do
   it { should exist }
 <% describes.each do |describe| %>
@@ -52,7 +55,6 @@ describe elb('<%= lb.load_balancer_name %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/iam_group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class IamGroup
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         groups = select_all_iam_groups
         raise 'Not Found IAM Group' if groups.empty?
+
         specs = groups.map do |group|
           inline_policies = select_inline_policy_by_group_name(group.group_name).map do |policy_name|
             res = iam_client.get_group_policy({
@@ -20,7 +23,7 @@ module Awspec::Generator
       end
 
       def iam_group_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe iam_group('<%= group.group_name %>') do
   it { should exist }
   its(:arn) { should eq '<%= group.arn %>' }
@@ -32,7 +35,6 @@ describe iam_group('<%= group.group_name %>') do
 <%- end -%>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/iam_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class IamPolicy
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         policies = select_all_attached_policies
         raise 'Not Found policy' if policies.empty?
+
         ERB.new(policy_spec_template, nil, '-').result(binding).chomp
       end
 

data/lib/awspec/generator/spec/iam_role.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class IamRole
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         roles = select_all_iam_roles
         raise 'Not Found IAM Role' if roles.empty?
+
         specs = roles.map do |role|
           inline_policies = select_inline_policy_by_role_name(role.role_name).map do |policy_name|
             res = iam_client.get_role_policy({
@@ -20,7 +23,7 @@ module Awspec::Generator
       end
 
       def iam_role_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe iam_role('<%= role.role_name %>') do
   it { should exist }
   its(:arn) { should eq '<%= role.arn %>' }
@@ -32,7 +35,6 @@ describe iam_role('<%= role.role_name %>') do
 <%- end -%>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/iam_user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class IamUser
@@ -5,6 +7,7 @@ module Awspec::Generator
       def generate_all
         users = select_all_iam_users
         raise 'Not Found IAM User' if users.empty?
+
         specs = users.map do |user|
           inline_policies = select_inline_policy_by_user_name(user.user_name).map do |policy_name|
             res = iam_client.get_user_policy({
@@ -20,7 +23,7 @@ module Awspec::Generator
       end
 
       def iam_user_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe iam_user('<%= user.user_name %>') do
   it { should exist }
   its(:arn) { should eq '<%= user.arn %>' }
@@ -32,7 +35,6 @@ describe iam_user('<%= user.user_name %>') do
 <%- end -%>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/internet_gateway.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class InternetGateway
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         internet_gateways = select_internet_gateway_by_vpc_id(@vpc_id)
@@ -18,7 +21,7 @@ module Awspec::Generator
       end
 
       def internet_gateway_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe internet_gateway('<%= internet_gateway_id %>') do
   it { should exist }
 <%- if @vpc_tag_name -%>
@@ -28,7 +31,6 @@ describe internet_gateway('<%= internet_gateway_id %>') do
 <%- end -%>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/kms.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Kms
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         aliases = select_all_kms_aliases.select { |kms_alias| customer_managed_key?(kms_alias) }
         raise 'Not Found alias' if aliases.empty?
+
         ERB.new(keys_spec_template, nil, '-').result(binding).chomp
       end
 
       def keys_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% aliases.each do |kms_alias| %>
 describe kms('<%= kms_alias.alias_name.split('/').last %>') do
   it { should exist }
@@ -19,7 +22,6 @@ describe kms('<%= kms_alias.alias_name.split('/').last %>') do
 end
 <% end %>
 EOF
-        template
       end
 
       private

data/lib/awspec/generator/spec/lambda.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class Lambda
@@ -5,11 +7,12 @@ module Awspec::Generator
       def generate_all
         lambda_functions = select_all_lambda_functions
         raise 'Not Found lambda' if lambda_functions.empty?
+
         ERB.new(lambda_spec_template, nil, '-').result(binding).chomp
       end
 
       def lambda_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <% lambda_functions.each do |function| %>
 describe lambda('<%= function.function_name %>') do
   it { should exist }
@@ -22,7 +25,6 @@ describe lambda('<%= function.function_name %>') do
 end
 <% end %>
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/nat_gateway.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NatGateway
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         nat_gateways = select_nat_gateway_by_vpc_id(@vpc_id)
@@ -18,7 +21,7 @@ module Awspec::Generator
       end
 
       def nat_gateway_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 describe nat_gateway('<%= nat_gateway_id %>') do
   it { should exist }
   it { should be_<%= nat_gateway.state %> }
@@ -32,7 +35,6 @@ describe nat_gateway('<%= nat_gateway_id %>') do
 <% end %>
 end
 EOF
-        template
       end
     end
   end

data/lib/awspec/generator/spec/network_acl.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 module Awspec::Generator
   module Spec
     class NetworkAcl
       include Awspec::Helper::Finder
       def generate_by_vpc_id(vpc_id)
-        describes = %w(
-        )
+        describes = %w[
+        ]
         vpc = find_vpc(vpc_id)
         raise 'Not Found VPC' unless vpc
+
         @vpc_id = vpc[:vpc_id]
         @vpc_tag_name = vpc.tag_name
         network_acls = select_network_acl_by_vpc_id(@vpc_id)
@@ -31,9 +34,9 @@ module Awspec::Generator
         acl.associations.each do |a|
           subnet = find_subnet(a.subnet_id)
           spec = if subnet.tag_name
-                   "it { should have_subnet('" + subnet.tag_name + "') }"
+                   "it { should have_subnet('#{subnet.tag_name}') }"
                  else
-                   "it { should have_subnet('" + subnet.subnet_id + "') }"
+                   "it { should have_subnet('#{subnet.subnet_id}') }"
                  end
           specs.push(spec)
         end
@@ -47,23 +50,23 @@ module Awspec::Generator
           line = ''
           inout = 'inbound'
           inout = 'outbound' if entry.egress
-          line += 'its(:' + inout + ') { should'
+          line += "its(:#{inout}) { should"
           actions = { allow: 'be_allowed', deny: 'be_denied' }
-          line += ' ' + actions[entry.rule_action.to_sym]
+          line += " #{actions[entry.rule_action.to_sym]}"
           port_range = entry.port_range
           unless port_range.nil?
             port = if port_range.from == port_range.to
                      port_range.from.to_s
                    else
-                     "'" + port_range.from.to_s + '-' + port_range.to.to_s + "'"
+                     "'#{port_range.from}-#{port_range.to}'"
                    end
-            line += '(' + port + ')'
+            line += "(#{port})"
           end
-          line += ".protocol('" + protocols[entry.protocol.to_i] + "')"
-          line += ".source('" + entry.cidr_block + "')"
+          line += ".protocol('#{protocols[entry.protocol.to_i]}')"
+          line += ".source('#{entry.cidr_block}')"
           rule_number = entry.rule_number.to_i
           rule_number = "'*'" if rule_number == 32_767
-          line += '.rule_number(' + rule_number.to_s + ')'
+          line += ".rule_number(#{rule_number})"
           line += ' }'
           linespecs.push(line)
         end
@@ -71,7 +74,7 @@ module Awspec::Generator
       end
 
       def network_acl_spec_template
-        template = <<-'EOF'
+        <<-'EOF'
 <%- if network_acl_tag_name -%>
 describe network_acl('<%= network_acl_tag_name %>') do
 <%- else -%>
@@ -89,7 +92,6 @@ describe network_acl('<%= network_acl_id %>') do
   its(:outbound_entries_count) { should eq <%= inbound_entries_count %> }
 end
 EOF
-        template
       end
     end
   end