aws_elb_health_check 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b089bc94aec441ba10a63114666ed64cc75c828
-  data.tar.gz: 7f4eedff6eab9e8f6d9a9d7f7c1b1bebaa55faf8
+  metadata.gz: 40d15eef37ad7221dc935ec3b144d426ad9f2e15
+  data.tar.gz: a1aa8c7680d5dafda34e79373b4ccb437c33e3c6
 SHA512:
-  metadata.gz: ea032eb2176876b1a5370279884a7bf38b0631c48d98d39e016a8a3736df69c8f5374598cb186d3429500b2856cf94b5a5476fdb970d9c2af862e54528067fbc
-  data.tar.gz: de6b2b979565deda56355a3ca74f7abff77d006fff383373034a8d406020ce1d5b9619832867f72d09372cd8a499c7aa332477b66b627e6c9304e2159e3df4d2
+  metadata.gz: b797f50212d5fd71c9a8bb899c2fb4b7e15f0e5523ac7fcd530c3f133e4959892f9d0bf4ff2a1f82e8ea2c3e96c9d50bf5d83aa1c9a704f491e59029dee261c9
+  data.tar.gz: fefcbcd47a5b03a22997fe83404df903f87935d20b70e6d98de47134f1ac69a4cdd1d974bc9540f03bd6675aa8a23faa934eef08abb5e67020bbdd9c048ea9aa

data/app/controllers/aws_elb_health_check/health_checks_controller.rb

@@ -4,7 +4,7 @@ module AwsElbHealthCheck
   class HealthChecksController < ApplicationController
     def index
       if secret_key.present?
-        if params[:key] == secret_key
+        if params[:check_key] == secret_key
           head :ok
         else
           head 403

data/config/routes.rb

@@ -1,4 +1,4 @@
 AwsElbHealthCheck::Engine.routes.draw do
-  get 'check' => "health_checks#index"
+  get 'check/:check_key' => "health_checks#index"
 
 end

data/lib/aws_elb_health_check/version.rb

@@ -1,3 +1,3 @@
 module AwsElbHealthCheck
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/test/controllers/aws_elb_health_check/health_checks_controller_test.rb

@@ -8,25 +8,19 @@ module AwsElbHealthCheck
 
     test "should get success when secret key is used" do
       ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"] = "asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"
-      get :index, key: ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"]
+      get :index, check_key: ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"]
       assert_response :success
     end
 
     test "should get failure when secret key is wrong" do
       ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"] = "asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"
-      get :index, key: ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"] + "foobar"
-      assert_response 403
-    end
-
-    test "should get failure when secret key is omitted" do
-      ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"] = "asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"
-      get :index
+      get :index, check_key: ENV["AWS_ELB_HEALTH_CHECK_SECRET_KEY"] + "foobar"
       assert_response 403
     end
 
     test "should get 501 when secret key has not been configured" do
       ENV.delete("AWS_ELB_HEALTH_CHECK_SECRET_KEY")
-      get :index
+      get :index, check_key: "asdfasdfasdf"
       assert_response 501
     end
 

data/test/dummy/log/test.log

@@ -566,3 +566,120 @@ Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
 AwsElbHealthCheckTest: test_truth
 ---------------------------------
    (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+---------------------------------
+AwsElbHealthCheckTest: test_truth
+---------------------------------
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+----------------------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_501_when_secret_key_has_not_been_configured
+----------------------------------------------------------------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_success_when_secret_key_is_used
+----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+-------------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_failure_when_secret_key_is_omitted
+-------------------------------------------------------------------------------------------------
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+-----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_failure_when_secret_key_is_wrong
+-----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlffoobar"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+---------------------------------
+AwsElbHealthCheckTest: test_truth
+---------------------------------
+   (0.0ms)  rollback transaction
+   (0.2ms)  begin transaction
+----------------------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_501_when_secret_key_has_not_been_configured
+----------------------------------------------------------------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+-----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_failure_when_secret_key_is_wrong
+-----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlffoobar"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_success_when_secret_key_is_used
+----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.4ms)  begin transaction
+----------------------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_501_when_secret_key_has_not_been_configured
+----------------------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdfasdfasdf"}
+Application is not configured properly: 'AWS_ELB_HEALTH_CHECK_SECRET_KEY' is not set up, so no health check can ever pass
+Completed 501 Not Implemented in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_success_when_secret_key_is_used
+----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+-----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_failure_when_secret_key_is_wrong
+-----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlffoobar"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+---------------------------------
+AwsElbHealthCheckTest: test_truth
+---------------------------------
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+-----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_failure_when_secret_key_is_wrong
+-----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlffoobar"}
+Completed 403 Forbidden in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_501_when_secret_key_has_not_been_configured
+----------------------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdfasdfasdf"}
+Application is not configured properly: 'AWS_ELB_HEALTH_CHECK_SECRET_KEY' is not set up, so no health check can ever pass
+Completed 501 Not Implemented in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+----------------------------------------------------------------------------------------------
+AwsElbHealthCheck::HealthChecksControllerTest: test_should_get_success_when_secret_key_is_used
+----------------------------------------------------------------------------------------------
+Processing by AwsElbHealthCheck::HealthChecksController#index as HTML
+  Parameters: {"check_key"=>"asdlkfjhasdlkfjhasdlkjfhasdlkfjhasdlf"}
+Completed 200 OK in 0ms (ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+---------------------------------
+AwsElbHealthCheckTest: test_truth
+---------------------------------
+   (0.0ms)  rollback transaction

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aws_elb_health_check
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Stitch Fix Engineering