aws-ssm-env 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42b51ae8562dfef400fdc2a244ac04ee333d76e836b80b1cd722ca3027bde2d4
-  data.tar.gz: 351176835c06d118460bb5455a34cfdd3198771b161aca9c1d8e66aac0eb0368
+  metadata.gz: be6a2edcd4a52513b69f9772ab8d2fc1a1fb0df183c23cc634e14e5ff326b4d7
+  data.tar.gz: 83d419751b1ac7ed482f5a7891eba301c7ed6cad5e91df1cbe5ce0772224f132
 SHA512:
-  metadata.gz: 27a30b575fd1b1b1ca6b951df0bff61f61b549f59f8568039007d352ae61b65f5c204b88e43ef23f95cf9caff66d5437ac2fad8d3091a964b499747afc6b1615
-  data.tar.gz: 7cab36b73fa5adeb5c2532695239777aa97be74128668b34ec8a48a57833f7b53dd19e7e68bd5518087fa1d4f9795685876d5f5a1170f6f15c915d3d84e8f74f
+  metadata.gz: 7272c39318b617cc4f61628cabeed3fb79292b7e0813959c51ef81f7390fb95374661d129f89aa16bfabee256ba54fd56275ba36134345a6f2bb175b0b56e013
+  data.tar.gz: b4b1bede2255c8ab6269e69b4b01636fd0b6700db00e4e6704ccbe6f17d17d5fbe92f54151ac6100fc0e01581faa734a0c865d0b07f309ed44f685264dea83c2

data/CHANGELOG.md

@@ -1,7 +1,16 @@
 # CHANGELOG
 
+## 0.1.3 (2024-01-29)
+
+- Change ruby supported versions #14
+
+## 0.1.2 (2020-12-02)
+
+- Add ruby 2.7 to Travis CI test matrix #7
+- Fix for early abort when next_token is not null #8
+- drop ruby 2.4 support, and fix warnings #11
+
 ## 0.1.1 (2018-01-16)
 
 - Translate README.
 - Added ruby 2.5 tests.
-

data/README.md

@@ -16,7 +16,7 @@ The naming of environment variables is optional and can be customized.
 
 ## Installation
 
-This gem has been tested with ruby version 2.2 to 2.5.
+This gem has been tested with ruby version 2.7 to 3.3.
 
 ```
 gem install aws-ssm-env
@@ -67,7 +67,7 @@ Or, you can pass `ssm_client_args` as the argument for `AwsSsmEnv#load`:
 
 ```ruby
 AwsSsmEnv.load(
-  fetch: "/myservice/#{ENV['RAILS_ENV']}",
+  path: "/myservice/#{ENV['RAILS_ENV']}",
   ssm_client_args: {
     access_key_id: 'ACCESS_KEY_ID',
     secret_access_key: 'SECRET_ACCESS_KEY',

data/README_ja.md

@@ -13,7 +13,7 @@ AWS EC2 Parameter Storeから取得したパラメータを環境変数として
 
 ## Installation
 
-このgemはRuby2.2から2.5まででテストされています。
+このgemはRuby2.7から3.3まででテストされています。
 
 ```
 gem install aws-ssm-env

data/lib/aws-ssm-env/fetcher.rb

@@ -23,25 +23,20 @@ module AwsSsmEnv
     #
     # @see http://docs.aws.amazon.com/sdk-for-ruby/v3/api/index.html
     def initialize(**args)
-      @client = create_ssm_client(args)
-      @with_decryption = with_decryption?(args)
+      @client = create_ssm_client(**args)
+      @with_decryption = with_decryption?(**args)
     end
 
     # Iteratorパターンを実装したメソッド。AwsSsmEnv#load から呼び出される。
     # 実際のパラメータ取得はサブクラスで実装された fetch メソッドで行う。
     # @yield [consumer] 取得したパラメータを受け取って処理を行うブロック引数。
     # @yieldparam [Aws::SSM::Types::Parameter] parameter パラメータ
-    def each
+    def each(&block)
       next_token = nil
       loop do
         response = fetch(next_token)
         next_token = response.next_token
-        if response.parameters.empty?
-          break
-        end
-        response.parameters.each do |p|
-          yield(p)
-        end
+        response.parameters.each(&block)
         if next_token.nil?
           break
         end
@@ -80,10 +75,8 @@ module AwsSsmEnv
     def with_decryption?(decryption: 'true', **)
       if decryption.nil?
         true
-      elsif decryption.to_s.downcase == 'true'
-        true
       else
-        false
+        decryption.to_s.downcase == 'true'
       end
     end
 

data/lib/aws-ssm-env/fetchers/begins_with.rb

@@ -16,7 +16,7 @@ module AwsSsmEnv
     # @option args [Integet] :fetch_size <optional> 一度のAPI実行で取得するパラメータ数。最大50。デフォルトは50。
     def initialize(**args)
       super
-      @base_params = base_params(args)
+      @base_params = base_params(**args)
     end
 
     protected
@@ -44,6 +44,7 @@ module AwsSsmEnv
       if begins_with.nil?
         raise ArgumentError, ':begins_with is required.'
       end
+
       {
         parameter_filters: to_parameter_filters(begins_with),
         max_results: detect_max_results(fetch_size)
@@ -51,9 +52,7 @@ module AwsSsmEnv
     end
 
     def detect_max_results(fetch_size)
-      if fetch_size.nil?
-        MAX_FETCH_SIZE
-      elsif fetch_size.to_i > MAX_FETCH_SIZE
+      if fetch_size.nil? || fetch_size.to_i > MAX_FETCH_SIZE
         MAX_FETCH_SIZE
       else
         fetch_size.to_i
@@ -62,7 +61,7 @@ module AwsSsmEnv
 
     def to_parameter_filters(begins_with)
       values = Array(begins_with)
-      [ BASE_FILTER.merge(values: values) ]
+      [BASE_FILTER.merge(values: values)]
     end
 
     def fetch_params(next_token)

data/lib/aws-ssm-env/fetchers/factory.rb

@@ -19,16 +19,17 @@ module AwsSsmEnv
         fetch_type = args[:fetch]
         case fetch_type
         when nil
-          default_fetcher(args)
+          default_fetcher(**args)
         when PATH_FETCHER
-          create_path_fetcher(args)
+          create_path_fetcher(**args)
         when BEGINS_WITH_FETCHER
-          create_begins_with_fetcher(args)
+          create_begins_with_fetcher(**args)
         else
           unless fetcher_instance?(fetch_type)
-            raise ArgumentError, 'Possible values for :fetch are either :path, :begins_with, ' \
-                + '"AwsSsmEnv::Fetcher" implementation class, an object with "each" method.'
+            raise ArgumentError,
+                  'Possible values for :fetch are either :path, :begins_with, "AwsSsmEnv::Fetcher" implementation class, an object with "each" method.' # rubocop:disable Layout/LineLength
           end
+
           fetch_type
         end
       end
@@ -37,30 +38,24 @@ module AwsSsmEnv
 
       def default_fetcher(**args)
         if args.key?(:begins_with)
-          create_begins_with_fetcher(args)
+          create_begins_with_fetcher(**args)
         else
-          create_path_fetcher(args)
+          create_path_fetcher(**args)
         end
       end
 
       def create_path_fetcher(**args)
         require 'aws-ssm-env/fetchers/path'
-        AwsSsmEnv::PathFetcher.new(args)
+        AwsSsmEnv::PathFetcher.new(**args)
       end
 
       def create_begins_with_fetcher(**args)
         require 'aws-ssm-env/fetchers/begins_with'
-        AwsSsmEnv::BeginsWithFetcher.new(args)
+        AwsSsmEnv::BeginsWithFetcher.new(**args)
       end
 
       def fetcher_instance?(object)
-        if object.is_a?(AwsSsmEnv::Fetcher)
-          true
-        elsif object.respond_to?(:each)
-          true
-        else
-          false
-        end
+        object.is_a?(AwsSsmEnv::Fetcher) || object.respond_to?(:each)
       end
     end
   end

data/lib/aws-ssm-env/fetchers/path.rb

@@ -18,7 +18,7 @@ module AwsSsmEnv
     # @option args [Integer] :fetch_size <optional> 一度のAPI実行で取得するパラメータ数。最大10。デフォルトは10。
     def initialize(**args)
       super
-      @base_params = base_params(args)
+      @base_params = base_params(**args)
     end
 
     protected
@@ -38,6 +38,7 @@ module AwsSsmEnv
       if path.nil?
         raise ArgumentError, 'path is required.'
       end
+
       {
         path: path,
         recursive: recursive?(recursive),
@@ -47,17 +48,11 @@ module AwsSsmEnv
     end
 
     def recursive?(recursive)
-      if recursive.to_s.downcase == 'true'
-        true
-      else
-        false
-      end
+      recursive.to_s.downcase == 'true'
     end
 
     def detect_max_results(fetch_size)
-      if fetch_size.nil?
-        MAX_FETCH_SIZE
-      elsif fetch_size.to_i > 10
+      if fetch_size.nil? || fetch_size.to_i > 10
         MAX_FETCH_SIZE
       else
         fetch_size.to_i

data/lib/aws-ssm-env/loader.rb

@@ -10,11 +10,11 @@ module AwsSsmEnv
   class Loader
     # メイン処理。引数の詳細は AwsSsmEnv#load を参照。
     def self.load(**args)
-      new(args).load
+      new(**args).load
     end
 
     def initialize(**args)
-      parse_options(args)
+      parse_options(**args)
       if @logger
         @logger.debug("#{self.class.name} overwrite: #{@overwrite}")
         @logger.debug("#{self.class.name} fetcher: #{@fetcher}")
@@ -25,7 +25,7 @@ module AwsSsmEnv
     def load
       @fetcher.each do |parameter|
         var_name = @naming_strategy.parse_name(parameter)
-        @logger.debug("#{self.class.name} #{parameter.name} parameter value into ENV['#{var_name}']") if @logger
+        @logger&.debug("#{self.class.name} #{parameter.name} parameter value into ENV['#{var_name}']")
         send(@applier, var_name, parameter.value)
       end
     end
@@ -34,9 +34,9 @@ module AwsSsmEnv
 
     def parse_options(**options)
       @logger = options[:logger]
-      @fetcher = AwsSsmEnv::FetcherFactory.create_fetcher(options)
-      @naming_strategy = AwsSsmEnv::NamingStrategyFactory.create_naming_strategy(options)
-      @overwrite = overwrite?(options)
+      @fetcher = AwsSsmEnv::FetcherFactory.create_fetcher(**options)
+      @naming_strategy = AwsSsmEnv::NamingStrategyFactory.create_naming_strategy(**options)
+      @overwrite = overwrite?(**options)
       if @overwrite
         @applier = :apply!
       else
@@ -57,6 +57,7 @@ module AwsSsmEnv
       if ENV[name]
         return
       end
+
       apply!(name, value)
     end
 

data/lib/aws-ssm-env/naming_strategies/factory.rb

@@ -18,13 +18,14 @@ module AwsSsmEnv
       def create_naming_strategy(**args)
         naming_strategy = args[:naming]
         if naming_strategy.nil?
-          return default_strategy(args)
+          return default_strategy(**args)
         end
+
         case naming_strategy
         when BASENAME_STRATEGY
-          create_basename_strategy(args)
+          create_basename_strategy(**args)
         when SNAKE_CASE_STRATEGY
-          create_snakecase_strategy(args)
+          create_snakecase_strategy(**args)
         else
           unknown_naming_strategy(naming_strategy)
         end
@@ -33,34 +34,33 @@ module AwsSsmEnv
       private
 
       def default_strategy(**args)
-        create_basename_strategy(args)
+        create_basename_strategy(**args)
       end
 
       def create_basename_strategy(**args)
         require 'aws-ssm-env/naming_strategies/basename'
-        AwsSsmEnv::BasenameNamingStrategy.new(args)
+        AwsSsmEnv::BasenameNamingStrategy.new(**args)
       end
 
       def create_snakecase_strategy(**args)
         require 'aws-ssm-env/naming_strategies/snakecase'
-        AwsSsmEnv::SnakeCaseNamingStrategy.new(args)
+        AwsSsmEnv::SnakeCaseNamingStrategy.new(**args)
       end
 
       def unknown_naming_strategy(naming_strategy)
         unless naming_strategy_instance?(naming_strategy)
-          raise ArgumentError, 'Possible values for :naming are either :basename, :snakecase, ' \
-                + '"AwsSsmEnv::NamingStrategy" implementation class, an object with "parse_name" method.'
+          raise ArgumentError,
+                'Possible values for :naming are either :basename, :snakecase, "AwsSsmEnv::NamingStrategy" implementation class, an object with "parse_name" method.' # rubocop:disable Layout/LineLength
         end
+
         naming_strategy
       end
 
       def naming_strategy_instance?(object)
         if object.is_a?(AwsSsmEnv::NamingStrategy)
           true
-        elsif object.respond_to?(:parse_name)
-          true
         else
-          false
+          object.respond_to?(:parse_name)
         end
       end
     end

data/lib/aws-ssm-env/naming_strategies/snakecase.rb

@@ -17,11 +17,12 @@ module AwsSsmEnv
     # @option args [String, Regexp] :delimiter
     #   アンダースコアに変換する区切り文字。デフォルトはスラッシュ('/')。 TODO: AwsSsmEnv#loadとREADMEに反映
     def initialize(**args)
+      super
       @logger = args[:logger]
-      @delimiter = detect_delimiter(args)
-      removed_prefix = detect_prefix(args).sub(%r{/\z}, '')
+      @delimiter = detect_delimiter(**args)
+      removed_prefix = detect_prefix(**args).sub(%r{/\z}, '')
       @removed_prefix = /\A#{Regexp.escape(removed_prefix)}/
-      @logger.debug("#{self.class.name} removed_prefix is #{@removed_prefix}") if @logger
+      @logger&.debug("#{self.class.name} removed_prefix is #{@removed_prefix}")
     end
 
     # @see AwsSsmEnv::NamingStrategy#parse_name

data/lib/aws-ssm-env/version.rb

@@ -1,3 +1,3 @@
 module AwsSsmEnv
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.3'.freeze
 end

data/lib/aws-ssm-env.rb

@@ -149,12 +149,12 @@ module AwsSsmEnv
   #
   # @see AwsSsmEnv::Loader#load
   def load(**args)
-    AwsSsmEnv::Loader.load(args)
+    AwsSsmEnv::Loader.load(**args)
   end
 
   # `overwrite`オプションを付与した AwsSsmEnv::Loader#load の委譲メソッド。
   # @see AwsSsmEnv::Loader#load
   def load!(**args)
-    AwsSsmEnv::Loader.load(args.merge(overwrite: true))
+    AwsSsmEnv::Loader.load(**args.merge(overwrite: true))
   end
 end

data/spec/{aws-ssm-env/fetchers/begins_with_spec.rb → aws_ssm_env/begins_with_fetcher_spec.rb}

@@ -2,9 +2,9 @@ require 'spec_helper'
 require 'aws-ssm-env/fetchers/begins_with'
 
 describe AwsSsmEnv::BeginsWithFetcher do
-  let(:fetcher) { described_class.new(args) }
-  let(:args) { { begins_with: [ '/foo', '/bar' ] } }
-  let(:base_params) { fetcher.instance_variable_get(:'@base_params') }
+  let(:fetcher) { described_class.new(**args) }
+  let(:args) { { begins_with: ['/foo', '/bar'] } }
+  let(:base_params) { fetcher.instance_variable_get(:@base_params) }
   let(:parameter_filter) { base_params[:parameter_filters][0] }
 
   describe '#initialize' do
@@ -24,7 +24,7 @@ describe AwsSsmEnv::BeginsWithFetcher do
       let(:args) { { begins_with: '/foo' } }
 
       it 'parameter_filter[:values] is [ begins_with value ]' do
-        expect(parameter_filter[:values]).to eq([ args[:begins_with] ])
+        expect(parameter_filter[:values]).to eq([args[:begins_with]])
       end
     end
 
@@ -84,7 +84,7 @@ describe AwsSsmEnv::BeginsWithFetcher do
     end
 
     context 'when describe_parameters return not empty parameters' do
-      let!(:dummy_parameters) { [ Parameter.new('foo'), Parameter.new('bar') ] }
+      let!(:dummy_parameters) { [Parameter.new('foo'), Parameter.new('bar')] }
       let!(:dummy_response) { AwsSsmEnv::FetchResult.new(dummy_parameters, 'next_token') }
 
       before do

data/spec/{aws-ssm-env/fetchers/factory_spec.rb → aws_ssm_env/fetcher_factory_spec.rb}

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe AwsSsmEnv::FetcherFactory do
   describe '#create_fetcher' do
-    let(:fetcher) { described_class.create_fetcher(args) }
+    let(:fetcher) { described_class.create_fetcher(**args) }
 
     context 'when fetch was not set' do
       context 'when begins_with was not set' do
@@ -56,7 +56,7 @@ describe AwsSsmEnv::FetcherFactory do
       end
     end
 
-    context 'in other cases' do
+    context 'when in other cases' do
       it 'raise error' do
         expect { described_class.create_fetcher(fetch: 'foo') }.to raise_error(ArgumentError)
       end

data/spec/{aws-ssm-env → aws_ssm_env}/fetcher_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe AwsSsmEnv::Fetcher do
-  let(:fetcher) { described_class.new(args) }
+  let(:fetcher) { described_class.new(**args) }
   let(:args) { {} }
   let(:client) { fetcher.send(:client) }
   let(:ssm_client_args) {
@@ -83,61 +83,64 @@ describe AwsSsmEnv::Fetcher do
   end
 
   describe '#each' do
-    let(:parameters) { [ Parameter.new('foo', 'foo'), Parameter.new('bar', 'bar') ] }
+    let(:parameters) { [Parameter.new('foo', 'foo'), Parameter.new('bar', 'bar')] }
     let(:fetcher) {
       mock_class = Class.new(described_class) do
-        def initialize(response); @response = response; end
-        protected def fetch(_); @response; end
+        def initialize(responses)
+          super()
+          @responses = responses
+        end
+
+        protected
+
+        def fetch(_); @responses.shift; end
       end
-      mock_class.new(dummy_response)
+      mock_class.new(responses)
     }
 
+    def call_count
+      called = 0
+      fetcher.each do |_|
+        called += 1
+      end
+      called
+    end
+
     context 'when fetch returns empty parameters at first' do
-      let(:dummy_response) { AwsSsmEnv::FetchResult::EMPTY }
+      let(:responses) { [AwsSsmEnv::FetchResult::EMPTY] }
 
       it 'consumer is not called' do
-        called = false
-        fetcher.each do |_|
-          called = true
-        end
-        expect(called).to be_falsey
+        expect(call_count).to eq(0)
+      end
+    end
+
+    context 'when fetch returns empty params and next_token at first, fetch returns two parameters and empty next_token at second' do
+      let(:responses) {
+        [AwsSsmEnv::FetchResult.new([], 'next_token'),
+         AwsSsmEnv::FetchResult.new(parameters, nil)]
+      }
+
+      it 'consumer is called twice' do
+        expect(call_count).to eq(2)
       end
     end
 
     context 'when fetch returns two parameters at first and empty next_token' do
-      let(:dummy_response) { AwsSsmEnv::FetchResult.new(parameters, nil) }
+      let(:responses) { [AwsSsmEnv::FetchResult.new(parameters, nil)] }
 
       it 'consumer is called twice' do
-        called = 0
-        fetcher.each do |_|
-          called += 1
-        end
-        expect(called).to eq(2)
+        expect(call_count).to eq(2)
       end
     end
 
     context 'when fetch returns two parameters and next_token at first, fetch returns two parameters and empty next_token at second' do
-      let(:fetcher) {
-        mock_class = Class.new(described_class) do
-          def initialize(parameters); @parameters = parameters; @count = 0; end
-          protected def fetch(_)
-            if @count == 0
-              @count = 1
-              AwsSsmEnv::FetchResult.new(@parameters, 'next_token')
-            else
-              AwsSsmEnv::FetchResult.new(@parameters, nil)
-            end
-          end
-        end
-        mock_class.new(parameters)
+      let(:responses) {
+        [AwsSsmEnv::FetchResult.new(parameters, 'next_token'),
+         AwsSsmEnv::FetchResult.new(parameters, nil)]
       }
 
       it 'consumer is called four times' do
-        called = 0
-        fetcher.each do |_|
-          called += 1
-        end
-        expect(called).to eq(4)
+        expect(call_count).to eq(4)
       end
     end
   end

data/spec/{aws-ssm-env → aws_ssm_env}/loader_spec.rb

@@ -4,7 +4,7 @@ describe AwsSsmEnv::Loader do
   let(:args) { { path: '/foo' } }
 
   describe '#initialize' do
-    let(:loader) { described_class.new(args) }
+    let(:loader) { described_class.new(**args) }
 
     it 'has fetcher and naming_strategy' do
       expect(loader.instance_variable_get(:@fetcher)).to be_a(AwsSsmEnv::PathFetcher)
@@ -52,14 +52,14 @@ describe AwsSsmEnv::Loader do
         ENV['foo'] = nil
         ENV['fizz'] = 'fizz'
 
-        loader = described_class.new(args)
+        loader = described_class.new(**args)
         loader.instance_variable_set(:@fetcher,
-          [ Parameter.new('foo', 'bar'), Parameter.new('fizz', 'buzz') ])
+                                     [Parameter.new('foo', 'bar'), Parameter.new('fizz', 'buzz')])
 
         loader.load
 
-        expect(ENV['foo']).to eq('bar')
-        expect(ENV['fizz']).to eq('fizz')
+        expect(ENV.fetch('foo', nil)).to eq('bar')
+        expect(ENV.fetch('fizz', nil)).to eq('fizz')
       end
     end
 
@@ -70,14 +70,14 @@ describe AwsSsmEnv::Loader do
         ENV['foo'] = nil
         ENV['fizz'] = 'fizz'
 
-        loader = described_class.new(args)
+        loader = described_class.new(**args)
         loader.instance_variable_set(:@fetcher,
-          [ Parameter.new('foo', 'bar'), Parameter.new('fizz', 'buzz') ])
+                                     [Parameter.new('foo', 'bar'), Parameter.new('fizz', 'buzz')])
 
         loader.load
 
-        expect(ENV['foo']).to eq('bar')
-        expect(ENV['fizz']).to eq('buzz')
+        expect(ENV.fetch('foo', nil)).to eq('bar')
+        expect(ENV.fetch('fizz', nil)).to eq('buzz')
       end
     end
   end

data/spec/{aws-ssm-env/naming_strategies/factory_spec.rb → aws_ssm_env/naming_strategy_factory_spec.rb}

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe AwsSsmEnv::NamingStrategyFactory do
   describe '#create_naming_strategy' do
-    let(:naming_strategy) { described_class.create_naming_strategy(args) }
+    let(:naming_strategy) { described_class.create_naming_strategy(**args) }
 
     context 'when naming was not set' do
       let(:args) { { naming: nil } }
@@ -48,7 +48,7 @@ describe AwsSsmEnv::NamingStrategyFactory do
       end
     end
 
-    context 'in other cases' do
+    context 'when in other cases' do
       it 'raise error' do
         expect { described_class.create_naming_strategy(naming: 'foo') }.to raise_error(ArgumentError)
       end

data/spec/{aws-ssm-env → aws_ssm_env}/parameter.rb

@@ -1,5 +1,6 @@
 class Parameter
   attr_reader :name, :value
+
   def initialize(*args)
     @name = args[0]
     @value = args[1]

data/spec/{aws-ssm-env/fetchers/path_spec.rb → aws_ssm_env/path_fetcher_spec.rb}

@@ -2,9 +2,9 @@ require 'spec_helper'
 require 'aws-ssm-env/fetchers/path'
 
 describe AwsSsmEnv::PathFetcher do
-  let(:fetcher) { described_class.new(args) }
+  let(:fetcher) { described_class.new(**args) }
   let(:args) { { path: '/path' } }
-  let(:base_params) { fetcher.instance_variable_get(:'@base_params') }
+  let(:base_params) { fetcher.instance_variable_get(:@base_params) }
 
   describe '#initialize' do
     context 'when path was not set' do

data/spec/{aws-ssm-env/naming_strategies/snakecase_spec.rb → aws_ssm_env/snake_case_naming_strategy_spec.rb}

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'aws-ssm-env/naming_strategies/snakecase'
 
 describe AwsSsmEnv::SnakeCaseNamingStrategy do
-  let(:strategy) { described_class.new(args) }
+  let(:strategy) { described_class.new(**args) }
   let(:name) { 'path.to.db/password' }
   let(:env_name) { strategy.parse_name(Parameter.new(name)) }
 

data/spec/{aws-ssm-env_spec.rb → aws_ssm_env_spec.rb}

@@ -1,6 +1,17 @@
 require 'spec_helper'
 require 'logger'
 
+PARAMETERS = [
+  { name: "/test/#{RUBY_VERSION}/aws-ssm-env/db_password", value: 'db_password', type: :SecureString },
+  { name: "/test/#{RUBY_VERSION}/aws-ssm-env/db/username", value: 'db_username', type: :String },
+  { name: "/test/#{RUBY_VERSION}/aws-ssm-env/roles", value: 'admin,guest', type: :StringList },
+  { name: "test.#{RUBY_VERSION}.aws-ssm-env.db_password", value: 'db_password', type: :SecureString },
+  { name: "test.#{RUBY_VERSION}.aws-ssm-env.username", value: 'db_username', type: :String },
+  { name: "test.#{RUBY_VERSION}.aws-ssm-env.roles", value: 'admin,guest', type: :StringList },
+].freeze
+
+ENV_NAMES = %w[db_password username roles].freeze
+
 describe AwsSsmEnv do
   let(:ssm_client) {
     stub_responses = {
@@ -24,8 +35,8 @@ describe AwsSsmEnv do
 
         described_class.load(client: ssm_client, path: '/path')
 
-        expect(ENV['foo']).to eq('bar')
-        expect(ENV['fizz']).to eq('fizz')
+        expect(ENV.fetch('foo', nil)).to eq('bar')
+        expect(ENV.fetch('fizz', nil)).to eq('fizz')
       end
     end
 
@@ -36,8 +47,8 @@ describe AwsSsmEnv do
 
         described_class.load!(client: ssm_client, path: '/path', logger: logger)
 
-        expect(ENV['foo']).to eq('bar')
-        expect(ENV['fizz']).to eq('buzz')
+        expect(ENV.fetch('foo', nil)).to eq('bar')
+        expect(ENV.fetch('fizz', nil)).to eq('buzz')
       end
     end
   end
@@ -54,17 +65,7 @@ describe AwsSsmEnv do
   #     allowed_pattern: "AllowedPattern",
   #   })
   #
-  describe 'Integration test', integration: true do
-    PARAMETERS = [
-      { name: "/test/#{RUBY_VERSION}/aws-ssm-env/db_password", value: 'db_password', type: :SecureString },
-      { name: "/test/#{RUBY_VERSION}/aws-ssm-env/db/username", value: 'db_username', type: :String },
-      { name: "/test/#{RUBY_VERSION}/aws-ssm-env/roles", value: 'admin,guest', type: :StringList },
-      { name: "test.#{RUBY_VERSION}.aws-ssm-env.db_password", value: 'db_password', type: :SecureString },
-      { name: "test.#{RUBY_VERSION}.aws-ssm-env.username", value: 'db_username', type: :String },
-      { name: "test.#{RUBY_VERSION}.aws-ssm-env.roles", value: 'admin,guest', type: :StringList },
-    ].freeze
-    ENV_NAMES = %w[db_password username roles].freeze
-
+  describe 'Integration test', :integration do
     def remove_env_all
       ENV_NAMES.each do |name|
         ENV[name] = nil
@@ -100,18 +101,18 @@ describe AwsSsmEnv do
       context 'when recursive is true' do
         it 'set environment variables from EC2 Parameter Store parameters' do
           described_class.load(path: "/test/#{RUBY_VERSION}/aws-ssm-env", recursive: true, logger: logger)
-          expect(ENV['db_password']).to eq('db_password')
-          expect(ENV['username']).to eq('db_username')
-          expect(ENV['roles']).to eq('admin,guest')
+          expect(ENV.fetch('db_password', nil)).to eq('db_password')
+          expect(ENV.fetch('username', nil)).to eq('db_username')
+          expect(ENV.fetch('roles', nil)).to eq('admin,guest')
         end
       end
 
       context 'when recursive is false' do
         it 'set environment variables from EC2 Parameter Store parameters' do
           described_class.load(path: "/test/#{RUBY_VERSION}/aws-ssm-env", recursive: false, logger: logger)
-          expect(ENV['db_password']).to eq('db_password')
-          expect(ENV['username']).to be_nil
-          expect(ENV['roles']).to eq('admin,guest')
+          expect(ENV.fetch('db_password', nil)).to eq('db_password')
+          expect(ENV.fetch('username', nil)).to be_nil
+          expect(ENV.fetch('roles', nil)).to eq('admin,guest')
         end
       end
     end
@@ -119,9 +120,9 @@ describe AwsSsmEnv do
     describe 'begins_with fetcher' do
       it 'set environment variables from EC2 Parameter Store parameters' do
         described_class.load(begins_with: "test.#{RUBY_VERSION}.aws-ssm-env.", naming: :snakecase, delimiter: '.', logger: logger)
-        expect(ENV['DB_PASSWORD']).to eq('db_password')
-        expect(ENV['USERNAME']).to eq('db_username')
-        expect(ENV['ROLES']).to eq('admin,guest')
+        expect(ENV.fetch('DB_PASSWORD', nil)).to eq('db_password')
+        expect(ENV.fetch('USERNAME', nil)).to eq('db_username')
+        expect(ENV.fetch('ROLES', nil)).to eq('admin,guest')
       end
     end
   end

data/spec/spec_helper.rb

@@ -15,8 +15,8 @@ else
 end
 
 require 'aws-ssm-env'
-require 'aws-ssm-env/parameter'
+require 'aws_ssm_env/parameter'
 
 RSpec.configure do |config|
-  config.filter_run_excluding(integration: true) unless ENV['CI']
+  config.filter_run_excluding(integration: true)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aws-ssm-env
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Ryohei Sonoda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-16 00:00:00.000000000 Z
+date: 2024-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-ssm
@@ -28,86 +28,86 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 13.1.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.12.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 1.60.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 1.60.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.26.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.26.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.16.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.16.1
 - !ruby/object:Gem::Dependency
   name: simplecov-console
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.1
 description: Set parameters acquired from AWS EC2 Parameter Store as environment variables.
 email:
 - ryohei-sonoda@m3.com
@@ -130,24 +130,24 @@ files:
 - lib/aws-ssm-env/naming_strategies/snakecase.rb
 - lib/aws-ssm-env/naming_strategy.rb
 - lib/aws-ssm-env/version.rb
-- spec/aws-ssm-env/fetcher_spec.rb
-- spec/aws-ssm-env/fetchers/begins_with_spec.rb
-- spec/aws-ssm-env/fetchers/factory_spec.rb
-- spec/aws-ssm-env/fetchers/path_spec.rb
-- spec/aws-ssm-env/loader_spec.rb
-- spec/aws-ssm-env/naming_strategies/basename_spec.rb
-- spec/aws-ssm-env/naming_strategies/factory_spec.rb
-- spec/aws-ssm-env/naming_strategies/snakecase_spec.rb
-- spec/aws-ssm-env/naming_strategy_spec.rb
-- spec/aws-ssm-env/parameter.rb
-- spec/aws-ssm-env_spec.rb
+- spec/aws_ssm_env/basename_naming_strategy_spec.rb
+- spec/aws_ssm_env/begins_with_fetcher_spec.rb
+- spec/aws_ssm_env/fetcher_factory_spec.rb
+- spec/aws_ssm_env/fetcher_spec.rb
+- spec/aws_ssm_env/loader_spec.rb
+- spec/aws_ssm_env/naming_strategy_factory_spec.rb
+- spec/aws_ssm_env/naming_strategy_spec.rb
+- spec/aws_ssm_env/parameter.rb
+- spec/aws_ssm_env/path_fetcher_spec.rb
+- spec/aws_ssm_env/snake_case_naming_strategy_spec.rb
+- spec/aws_ssm_env_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/sonodar/aws-ssm-env-ruby
 licenses:
 - Apache-2.0
 metadata:
   source_code_uri: https://github.com/sonodar/aws-ssm-env-ruby
-  changelog_uri: https://github.com/sonodar/aws-ssm-env-ruby/tree/master/aws-ssm-env-ruby/CHANGELOG.md
+  changelog_uri: https://github.com/sonodar/aws-ssm-env-ruby/tree/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -156,28 +156,27 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: Set parameters acquired from AWS EC2 Parameter Store as environment variables.
 test_files:
-- spec/aws-ssm-env/fetcher_spec.rb
-- spec/aws-ssm-env/fetchers/begins_with_spec.rb
-- spec/aws-ssm-env/fetchers/factory_spec.rb
-- spec/aws-ssm-env/fetchers/path_spec.rb
-- spec/aws-ssm-env/loader_spec.rb
-- spec/aws-ssm-env/naming_strategies/basename_spec.rb
-- spec/aws-ssm-env/naming_strategies/factory_spec.rb
-- spec/aws-ssm-env/naming_strategies/snakecase_spec.rb
-- spec/aws-ssm-env/naming_strategy_spec.rb
-- spec/aws-ssm-env/parameter.rb
-- spec/aws-ssm-env_spec.rb
+- spec/aws_ssm_env/basename_naming_strategy_spec.rb
+- spec/aws_ssm_env/begins_with_fetcher_spec.rb
+- spec/aws_ssm_env/fetcher_factory_spec.rb
+- spec/aws_ssm_env/fetcher_spec.rb
+- spec/aws_ssm_env/loader_spec.rb
+- spec/aws_ssm_env/naming_strategy_factory_spec.rb
+- spec/aws_ssm_env/naming_strategy_spec.rb
+- spec/aws_ssm_env/parameter.rb
+- spec/aws_ssm_env/path_fetcher_spec.rb
+- spec/aws_ssm_env/snake_case_naming_strategy_spec.rb
+- spec/aws_ssm_env_spec.rb
 - spec/spec_helper.rb