aws-sessionstore-dynamodb 1.0.0 → 2.0.0

data/spec/aws/session_store/dynamo_db/rack_middleware_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright 2013 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"). You
@@ -22,19 +24,19 @@ module Aws
         before { @options = {} }
 
         def ensure_data_updated(mutated_data)
-          dynamo_db_client.should_receive(:update_item) do |options|
+          expect(dynamo_db_client).to receive(:update_item) do |options|
             if mutated_data
-              options[:attribute_updates]["data"].should_not be_nil
+              expect(options[:attribute_updates]['data']).not_to be_nil
             else
-              options[:attribute_updates]["data"].should be_nil
+              expect(options[:attribute_updates]['data']).to be_nil
             end
           end
         end
 
         before do
           @options = {
-            :dynamo_db_client => dynamo_db_client,
-            :secret_key => 'watermelon_cherries'
+            dynamo_db_client: dynamo_db_client,
+            secret_key: 'watermelon_cherries'
           }
         end
 
@@ -42,105 +44,101 @@ module Aws
         let(:app) { RackMiddleware.new(base_app, @options) }
 
         let(:sample_packed_data) do
-          [Marshal.dump("multiplier" => 1)].pack("m*")
+          [Marshal.dump('multiplier' => 1)].pack('m*')
         end
 
         let(:dynamo_db_client) do
-          client = double('Aws::DynamoDB::Client')
-          client.stub(:delete_item) { 'Deleted' }
-          client.stub(:list_tables) { {:table_names => ['Sessions']} }
-          client.stub(:get_item) do
-            { :item => { 'data' => sample_packed_data } }
-          end
-          client.stub(:update_item) do
-            { :attributes => { :created_at => 'now' } }
-          end
-          client
+          double(
+            'Aws::DynamoDB::Client',
+            delete_item: 'Deleted',
+            list_tables: { table_names: ['Sessions'] },
+            get_item: { item: { 'data' => sample_packed_data } },
+            update_item: { attributes: { created_at: 'now' } }
+          )
         end
 
-        context "Testing best case session storage with mock client" do
-          it "stores session data in session object" do
-            get "/"
-            last_request.session.to_hash.should eq("multiplier" => 1)
+        context 'Testing best case session storage with mock client' do
+          it 'stores session data in session object' do
+            get '/'
+            expect(last_request.session.to_hash).to eq('multiplier' => 1)
           end
 
-          it "creates a new HTTP cookie when Cookie not supplied" do
-            get "/"
-            last_response.body.should eq('All good!')
-            last_response['Set-Cookie'].should be_truthy
+          it 'creates a new HTTP cookie when Cookie not supplied' do
+            get '/'
+            expect(last_response.body).to eq('All good!')
+            expect(last_response['Set-Cookie']).to be_truthy
           end
 
-          it "loads/manipulates a session based on id from HTTP-Cookie" do
-            get "/"
-            last_request.session.to_hash.should eq("multiplier" => 1)
+          it 'loads/manipulates a session based on id from HTTP-Cookie' do
+            get '/'
+            expect(last_request.session.to_hash).to eq('multiplier' => 1)
 
-            get "/"
-            last_request.session.to_hash.should eq("multiplier" => 2)
+            get '/'
+            expect(last_request.session.to_hash).to eq('multiplier' => 2)
           end
 
-          it "does not rewrite Cookie if cookie previously/accuarately set" do
-            get "/"
-            last_response['Set-Cookie'].should_not be_nil
+          it 'does not rewrite Cookie if cookie previously/accuarately set' do
+            get '/'
+            expect(last_response['Set-Cookie']).not_to be_nil
 
-            get "/"
-            last_response['Set-Cookie'].should be_nil
+            get '/'
+            expect(last_response['Set-Cookie']).to be_nil
           end
 
-          it "does not set cookie when defer option is specifed" do
+          it 'does not set cookie when defer option is specifed' do
             @options[:defer] = true
-            get "/"
-            last_response['Set-Cookie'].should eq(nil)
+            get '/'
+            expect(last_response['Set-Cookie']).to be_nil
           end
 
-          it "creates new sessopm with false/nonexistant http-cookie id" do
-            get "/"
-            last_response['Set-Cookie'].should_not eq('1234')
-            last_response['Set-Cookie'].should_not be_nil
+          it 'creates new session with false/nonexistant http-cookie id' do
+            get '/'
+            expect(last_response['Set-Cookie']).not_to eq('1234')
+            expect(last_response['Set-Cookie']).not_to be_nil
           end
 
-          it "expires after specified time and sets date for cookie to expire" do
+          it 'expires after specified time and sets date for cookie to expire' do
             @options[:expire_after] = 0
-            get "/"
+            get '/'
             session_cookie = last_response['Set-Cookie']
 
-            get "/"
-            last_response['Set-Cookie'].should_not be_nil
-            last_response['Set-Cookie'].should_not eq(session_cookie)
+            get '/'
+            expect(last_response['Set-Cookie']).not_to be_nil
+            expect(last_response['Set-Cookie']).not_to eq(session_cookie)
           end
 
           it "doesn't reset Cookie if not outside expire date" do
             @options[:expire_after] = 3600
-            get "/"
+            get '/'
             session_cookie = last_response['Set-Cookie']
-            get "/"
-            last_response['Set-Cookie'].should eq(session_cookie)
+            get '/'
+            expect(last_response['Set-Cookie']).to eq(session_cookie)
           end
 
-          it "will not set a session cookie when defer is true" do
+          it 'will not set a session cookie when defer is true' do
             @options[:defer] = true
-            get "/"
-            last_response['Set-Cookie'].should eq(nil)
+            get '/'
+            expect(last_response['Set-Cookie']).to be_nil
           end
 
-          it "generates sid and migrates data to new sid when renew is selected" do
+          it 'generates sid and migrates data to new sid when renew is selected' do
             @options[:renew] = true
-            get "/"
-            last_request.session.to_hash.should eq("multiplier" => 1)
+            get '/'
+            expect(last_request.session.to_hash).to eq('multiplier' => 1)
             session_cookie = last_response['Set-Cookie']
 
-            get "/" , "HTTP_Cookie" => session_cookie
-            last_response['Set-Cookie'].should_not eq(session_cookie)
-            last_request.session.to_hash.should eq("multiplier" => 2)
-            session_cookie = last_response['Set-Cookie']
+            get '/', 'HTTP_Cookie' => session_cookie
+            expect(last_response['Set-Cookie']).not_to eq(session_cookie)
+            expect(last_request.session.to_hash).to eq('multiplier' => 2)
           end
 
           it "doesn't resend unmutated data" do
             ensure_data_updated(true)
             @options[:renew] = true
-            get "/"
+            get '/'
 
             ensure_data_updated(false)
-            get "/", {}, { "rack.session" => { "multiplier" => nil } }
+            get '/', {}, { 'rack.session' => { 'multiplier' => nil } }
           end
         end
       end

data/spec/aws/session_store/dynamo_db/table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright 2013 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"). You
@@ -19,22 +21,22 @@ module Aws
   module SessionStore
     module DynamoDB
       describe Table do
-        context "Mock Table Methods Tests", :integration => true do
+        context 'Mock Table Methods Tests', integration: true do
           let(:table_name) { "sessionstore-integration-test-#{Time.now.to_i}" }
-          let(:options) { {:table_name => table_name} }
+          let(:options) { { table_name: table_name } }
           let(:io) { StringIO.new }
 
-          before { Table.stub(:logger) { Logger.new(io) } }
+          before { allow(Table).to receive(:logger) { Logger.new(io) } }
 
-          it "Creates and deletes a new table" do
+          it 'Creates and deletes a new table' do
             Table.create_table(options)
 
             # second attempt should warn
             Table.create_table(options)
 
-            io.string.should include("Table #{table_name} created, waiting for activation...\n")
-            io.string.should include("Table #{table_name} is now ready to use.\n")
-            io.string.should include("Table #{table_name} already exists, skipping creation.\n")
+            expect(io.string).to include("Table #{table_name} created, waiting for activation...\n")
+            expect(io.string).to include("Table #{table_name} is now ready to use.\n")
+            expect(io.string).to include("Table #{table_name} already exists, skipping creation.\n")
 
             # now delete table
             Table.delete_table(options)

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright 2013 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License"). You
@@ -19,7 +21,7 @@ begin
 rescue LoadError
 end
 
-$: << File.join(File.dirname(File.dirname(__FILE__)), "lib")
+$LOAD_PATH << File.join(File.dirname(File.dirname(__FILE__)), 'lib')
 
 require 'rspec'
 require 'aws-sessionstore-dynamodb'
@@ -33,35 +35,36 @@ class MultiplierApplication
     else
       env['rack.session'][:multiplier] = 1
     end
-    [200, {'Content-Type' => 'text/plain'}, ['All good!']]
+    [200, { 'Content-Type' => 'text/plain' }, ['All good!']]
   end
 end
 
 ConstantHelpers = lambda do
   let(:token_error_msg) { 'The security token included in the request is invalid' }
-  let(:resource_error) {
+  let(:resource_error) do
     Aws::DynamoDB::Errors::ResourceNotFoundException.new(double('Seahorse::Client::RequestContext'), resource_error_msg)
-  }
+  end
   let(:resource_error_msg) { 'The Resource is not found.' }
   let(:key_error) { Aws::DynamoDB::Errors::ValidationException.new(double('Seahorse::Client::RequestContext'), key_error_msg) }
   let(:key_error_msg) { 'The provided key element does not match the schema' }
-  let(:client_error) {
+  let(:client_error) do
     Aws::DynamoDB::Errors::UnrecognizedClientException.new(double('Seahorse::Client::RequestContext'), client_error_msg)
-  }
+  end
   let(:client_error_msg) { 'Unrecognized Client.'}
-  let(:invalid_cookie) { {"HTTP_COOKIE" => "rack.session=ApplePieBlueberries"} }
-  let(:invalid_session_data) { {"rack.session"=>{"multiplier" => 1}} }
+  let(:invalid_cookie) { { 'HTTP_COOKIE' => 'rack.session=ApplePieBlueberries' } }
+  let(:invalid_session_data) { { 'rack.session' => { 'multiplier' => 1 } } }
   let(:rack_default_error_msg) { "Warning! Aws::SessionStore::DynamoDB failed to save session. Content dropped.\n" }
   let(:missing_key_error) { Aws::SessionStore::DynamoDB::MissingSecretKeyError }
 end
 
 RSpec.configure do |c|
-  c.before(:each, :integration => true) do
-    opts = {:table_name => 'sessionstore-integration-test'}
+  c.raise_errors_for_deprecations!
+  c.before(:each, integration: true) do
+    opts = { table_name: 'sessionstore-integration-test' }
 
     defaults = Aws::SessionStore::DynamoDB::Configuration::DEFAULTS
     defaults = defaults.merge(opts)
-    stub_const("Aws::SessionStore::DynamoDB::Configuration::DEFAULTS", defaults)
+    stub_const('Aws::SessionStore::DynamoDB::Configuration::DEFAULTS', defaults)
     Aws::SessionStore::DynamoDB::Table.create_table(opts)
   end
 end

metadata

@@ -1,57 +1,67 @@
 --- !ruby/object:Gem::Specification
 name: aws-sessionstore-dynamodb
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
-- Ruby Robinson
-autorequire: 
+- Amazon Web Services
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-08-14 00:00:00.000000000 Z
+date: 2020-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: aws-sdk
+  name: aws-sdk-dynamodb
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.4
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.4
-description: 
-email: 
+        version: '2'
+description:
+email:
+- mamuller@amazon.com
+- alexwoo@amazon.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/PULL_REQUEST_TEMPLATE.md"
 - ".gitignore"
+- ".gitmodules"
 - ".travis.yml"
 - ".yardopts"
+- CHANGELOG.md
+- CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
-- LICENSE.txt
+- LICENSE
 - README.md
 - Rakefile
+- VERSION
 - aws-sessionstore-dynamodb.gemspec
+- doc-src/templates/default/layout/html/footer.erb
+- doc-src/templates/default/layout/html/layout.erb
 - lib/aws-sessionstore-dynamodb.rb
 - lib/aws/session_store/dynamo_db/configuration.rb
 - lib/aws/session_store/dynamo_db/errors/base_handler.rb
@@ -64,31 +74,22 @@ files:
 - lib/aws/session_store/dynamo_db/locking/pessimistic.rb
 - lib/aws/session_store/dynamo_db/missing_secret_key_error.rb
 - lib/aws/session_store/dynamo_db/rack_middleware.rb
-- lib/aws/session_store/dynamo_db/railtie.rb
 - lib/aws/session_store/dynamo_db/table.rb
-- lib/aws/session_store/dynamo_db/tasks/session_table.rake
 - lib/aws/session_store/dynamo_db/version.rb
-- lib/rails/generators/sessionstore/dynamodb/dynamodb_generator.rb
-- lib/rails/generators/sessionstore/dynamodb/templates/sessionstore/USAGE
-- lib/rails/generators/sessionstore/dynamodb/templates/sessionstore/dynamodb.yml
-- lib/rails/generators/sessionstore/dynamodb/templates/sessionstore_migration.rb
 - spec/aws/session_store/dynamo_db/app_config.yml
-- spec/aws/session_store/dynamo_db/config/dynamo_db_session.yml
 - spec/aws/session_store/dynamo_db/configuration_spec.rb
 - spec/aws/session_store/dynamo_db/error/default_error_handler_spec.rb
 - spec/aws/session_store/dynamo_db/garbage_collection_spec.rb
 - spec/aws/session_store/dynamo_db/locking/threaded_sessions_spec.rb
 - spec/aws/session_store/dynamo_db/rack_middleware_database_spec.rb
 - spec/aws/session_store/dynamo_db/rack_middleware_spec.rb
-- spec/aws/session_store/dynamo_db/rails_app_config.yml
 - spec/aws/session_store/dynamo_db/table_spec.rb
 - spec/spec_helper.rb
-- tasks/test.rake
 homepage: http://github.com/aws/aws-sessionstore-dynamodb-ruby
 licenses:
 - Apache License 2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -103,21 +104,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: The Amazon DynamoDB Session Store handles sessions for Ruby web applications
   using a DynamoDB backend.
 test_files:
 - spec/aws/session_store/dynamo_db/app_config.yml
-- spec/aws/session_store/dynamo_db/config/dynamo_db_session.yml
 - spec/aws/session_store/dynamo_db/configuration_spec.rb
 - spec/aws/session_store/dynamo_db/error/default_error_handler_spec.rb
 - spec/aws/session_store/dynamo_db/garbage_collection_spec.rb
 - spec/aws/session_store/dynamo_db/locking/threaded_sessions_spec.rb
 - spec/aws/session_store/dynamo_db/rack_middleware_database_spec.rb
 - spec/aws/session_store/dynamo_db/rack_middleware_spec.rb
-- spec/aws/session_store/dynamo_db/rails_app_config.yml
 - spec/aws/session_store/dynamo_db/table_spec.rb
 - spec/spec_helper.rb

data/lib/aws/session_store/dynamo_db/railtie.rb

@@ -1,28 +0,0 @@
-# Copyright 2013 Amazon.com, Inc. or its affiliates. All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License"). You
-# may not use this file except in compliance with the License. A copy of
-# the License is located at
-#
-#     http://aws.amazon.com/apache2.0/
-#
-# or in the "license" file accompanying this file. This file is
-# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
-# ANY KIND, either express or implied. See the License for the specific
-# language governing permissions and limitations under the License.
-
-
-module Aws::SessionStore::DynamoDB
-  class Railtie < Rails::Railtie
-    initializer 'aws-sessionstore-dynamodb-rack-middleware' do
-      ActionDispatch::Session::DynamodbStore = Aws::SessionStore::DynamoDB::RackMiddleware
-    end
-
-    # Load all rake tasks
-    rake_tasks do
-      Dir[File.expand_path("../tasks/*.rake", __FILE__)].each do |rake_task|
-        load rake_task
-      end
-    end
-  end
-end