aws-liam 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ca62555809a9e79275146771a80aa72f2d6bd595
-  data.tar.gz: 86bcc1a6ae4cc503b9bf2d47454d38dacc90da4c
+SHA256:
+  metadata.gz: cb56b9b9adaa264e64fd5a8e60171e279c52761f5a00cea30977a96396a47b74
+  data.tar.gz: 86166f8802d24fd4aa93cda51d7606619658470fe3e66580b382acf89beb80f4
 SHA512:
-  metadata.gz: da4597e779ea8d6a0466865fed72ceddd3d166675f3d001c7d69c92b16c59ca9c9a41cbb1c300913fdd54a442c994f59a41a940ecf3471c306ca4413a744a949
-  data.tar.gz: f853d341dd2468c6c304ed400e9b3c792c8463b24373eb64d6585d0e87f6e9adde2e9229d972d150504e0e697b7a40af07ca19c71cc548cb8037f2a1df6aabba
+  metadata.gz: 93f2c7b2277433830e3f37b3630f97040d5b7916efa5954386b3b664dc3b6f6a75124aefc043caa686aa07c733669fae6b912a81fdd9c111441b33f35caf6289
+  data.tar.gz: 4823392801ca44d27bc379286a3e41d7a5b6777b740fb61ef91da7c7bbc07a87513ba1991ef899050f7abdbd0b31c8304eb74fd557983ac9ef2576cc662a962d

data/README.md

@@ -52,10 +52,10 @@ Go to the first one an setup your credentials and topics endpoints at AWS. The s
 Every time something happens in Service A that needs to be shared to other applications (for example, an article was published) you need to put this simple three lines (basically create the article JSON, define where do you want to send the message and send the message):
 
 ```ruby
-  message    = { id: id, title: title, created_at: created_at }
-  topic_name = 'liam_ArticleCreated'
+message    = { id: id, title: title, created_at: created_at }
+topic_name = 'liam_ArticleCreated'
 
-  Liam::Producer.message(topic: topic_name, message: message)
+Liam::Producer.message(topic: topic_name, message: message)
 ```
 
 ### The Consumer (Service B)
@@ -82,23 +82,27 @@ All of these files should live at `app/services/liam`.
 
 Now you have to run the included task inside the Consumer App (make sure this task runs for ever):
 
-```
+```bash
 $ bundle exec rake liam:consumer:start production
 ```
 
 And that's it!
 
 ## Testing
-Can you run the test easily executing
 
-```
-  $ bundle exec rspec
+Before running the test suite you must create the topic we use to test the gem functionality:
+
+```bash
+$ aws --endpoint-url=http://localhost:4575 sns create-topic --name liam_TestProducer
 ```
 
-If you want to run all test successfully, we need the LocalStack daemon when sending a message
+This is mandatory, otherwise you're going to receive an `Aws::SNS::Errors::NotFound: Topic does not exist` exception.
 
-## Localstack Running
-  TODO
+After that, you can run the suite with RSpec as usual:
+
+```bash
+$ bundle exec rspec
+```
 
 ## Contributing
 

data/lib/liam.rb

@@ -2,8 +2,18 @@
 
 require 'liam/version'
 require 'liam/consumer'
+require 'liam/processor'
 require 'liam/producer'
-require 'liam/exceptions/message_without_value_attribute_error'
 require 'liam/exceptions/uninitialized_message_processor_error'
 require 'liam/exceptions/no_topics_in_config_file_error'
 require 'liam/exceptions/unexpected_message_error'
+
+module Liam
+  class << self
+    attr_writer :logger
+
+    def logger
+      @logger ||= Logger.new($stdout).tap { |log| log.progname = self.name }
+    end
+  end
+end

data/lib/liam/common.rb

@@ -8,15 +8,17 @@ module Liam
 
     def client_options
       {
-        access_key_id: env_credentials['aws']['access_key_id'],
-        endpoint: env_credentials['aws']['sns']['endpoint'],
-        region: env_credentials['aws']['region'],
-        secret_access_key: env_credentials['aws']['secret_access_key']
+        access_key_id: env_credentials.dig('aws', 'access_key_id'),
+        endpoint: env_credentials.dig('aws', 'sns', 'endpoint'),
+        region: env_credentials.dig('aws', 'region'),
+        secret_access_key: env_credentials.dig('aws', 'secret_access_key')
       }.compact
     end
 
     def env_credentials
-      @env_credentials ||= credentials[ENV['RAILS_ENV']]
+      return @env_credentials if defined?(@env_credentials)
+
+      @env_credentials = credentials[ENV['RAILS_ENV']]
     end
 
     def credentials

data/lib/liam/consumer.rb

@@ -22,10 +22,11 @@ module Liam
     attr_reader :options
 
     def execute
+      Liam.logger.info 'Consumer initialized'
       poller.poll(poller_options) do |messages|
-        puts "INFO -- [aws-liam] : ** Received messages: #{messages.size} ** --"
+        Liam.logger.info "Total received messages: #{messages.size}"
         messages.each do |message|
-          pp message
+          Liam.logger.info message
           MessageProcessor.process(message)
         end
       end

data/lib/liam/message_processor.rb

@@ -13,7 +13,7 @@ module Liam
 
     def self.process(message)
       raise UnexpectedMessageError, message unless message.is_a?(Aws::SQS::Types::Message)
-      puts "[aws-liam] Processing..."
+      Liam.logger.info 'Processing...'
 
       new(message).send(:process)
     end
@@ -40,25 +40,14 @@ module Liam
       raise UninitializedMessageProcessorError, e
     end
 
-    def message_topic_name
-      message_attribute_value.sub('_', '::').gsub(/(?<=^)(.*)(?=::)/, &:capitalize)
-    end
-
-    def message_attribute_value
-      raise MessageWithoutValueAttributeError if value.nil? || value.empty?
+    def topic_arn
+      return '' unless parsed_body.is_a?(Hash)
 
-      value
+      parsed_body['TopicArn'] || ''
     end
 
-    def value
-      return @value if defined?(@value)
-
-      @value = begin
-                 return if parsed_body.nil? || parsed_body.empty?
-
-                 message_attributes['event_name']&.string_value ||
-                   parsed_body.dig('MessageAttributes', 'event_name', 'Value')
-               end
+    def message_topic_name
+      topic_arn.split(':').last.sub('_', '::').gsub(/(?<=^)(.*)(?=::)/, &:capitalize)
     end
   end
 end

data/lib/liam/processor.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Liam
+  module Processor
+    def initialize(message)
+      @message = message
+    end
+
+    private
+
+    attr_reader :message
+  end
+end

data/lib/liam/producer.rb

@@ -34,7 +34,7 @@ module Liam
       return UNSUPPORTED_TOPIC_ERROR unless supported_topic?
       return UNSUPPORTED_MESSAGE_ERROR unless message.is_a?(Hash)
 
-      puts "INFO -- [aws-liam]: ** Publishing message: #{message} ** --"
+      Liam.logger.info "Publishing message: #{message}"
       Aws::SNS::Client.new(client_options).publish(
         topic_arn: topic_arn,
         message: message.to_json,

data/lib/liam/version.rb

@@ -1,3 +1,3 @@
 module Liam
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aws-liam
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - alexismansilla
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-07 00:00:00.000000000 Z
+date: 2020-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-sns
@@ -135,11 +135,11 @@ files:
 - lib/liam/.DS_Store
 - lib/liam/common.rb
 - lib/liam/consumer.rb
-- lib/liam/exceptions/message_without_value_attribute_error.rb
 - lib/liam/exceptions/no_topics_in_config_file_error.rb
 - lib/liam/exceptions/unexpected_message_error.rb
 - lib/liam/exceptions/uninitialized_message_processor_error.rb
 - lib/liam/message_processor.rb
+- lib/liam/processor.rb
 - lib/liam/producer.rb
 - lib/liam/version.rb
 homepage: http://github.com/archdaily/aws-liam
@@ -161,8 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: AWS SQS+SNS middleware integration between Ruby microservices

data/lib/liam/exceptions/message_without_value_attribute_error.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module Liam
-  class MessageWithoutValueAttributeError < StandardError
-    def initialize
-      super(
-        <<~MSG.gsub(/\n/, '')
-        Expected to get a message attribute value to initialize the class to process 
-        this message, but the value received is invalid.
-        MSG
-      )
-    end
-  end
-end