awesome_translations 0.0.30 → 0.0.31

data/spec/handlers/file_handler_spec.rb

@@ -0,0 +1,103 @@
+require "spec_helper"
+
+describe AwesomeTranslations::Handlers::FileHandler do
+  let(:handler) { AwesomeTranslations::Handlers::FileHandler.new }
+
+  describe "erb stuff" do
+    let(:users_index_group) { handler.groups.find { |group| group.name == "app/views/users/index.html.haml" } }
+    let(:users_index_translations) { users_index_group.translations }
+    let(:users_partial_test_translations) { handler.groups.find { |group| group.name == "app/views/users/_partial_test.html.haml" }.translations }
+    let(:layout_group) { handler.groups.find { |group| group.name == "app/views/layouts/application.html.haml" } }
+    let(:layout_translations) { layout_group.translations }
+
+    it "finds translations made with the t method" do
+      hello_world_translations = users_index_translations.select { |t| t.key == "users.index.hello_world" }.to_a
+      expect(hello_world_translations.length).to eq 1
+    end
+
+    it "finds translations in the layout" do
+      danish_translations = layout_translations.select { |t| t.key == "layouts.application.danish" }.to_a
+      expect(danish_translations.length).to eq 1
+    end
+
+    it "doesnt include _ in partial keys" do
+      partial_test = users_partial_test_translations.select { |t| t.key == "users.partial_test.partial_test" }.to_a
+      expect(partial_test.length).to eq 1
+    end
+
+    it "removes special characters when using the custom method" do
+      current_language_translation = layout_translations.select { |t| t.key == "layouts.application.the_current_language_is" }.to_a
+      expect(current_language_translation.length).to eq 1
+    end
+
+    it "has unique translations" do
+      expect(layout_translations.select { |t| t.key == "layouts.application.hello_world" }.to_a.length).to eq 1
+    end
+
+    it "sets the correct translation path" do
+      danish_translation = layout_translations.find { |t| t.key == "layouts.application.danish" }
+      expect(danish_translation.dir).to eq "#{Rails.root}/config/locales/awesome_translations/app/views/layouts/application"
+    end
+  end
+
+  describe "library stuff" do
+    let(:group) { handler.groups.find { |group| group.name == "app/models/role.rb" } }
+    let(:mailer_group) { handler.groups.find { |group| group.name == "app/mailers/my_mailer.rb" } }
+    let(:subject_translation) { mailer_group.translations.find { |translation| translation.key == "my_mailer.mailer_action.custom_subject" } }
+    let(:admin_translation) { group.translations.find { |translation| translation.key == "models.role.administrator" } }
+    let(:application_helper_group) { handler.groups.find { |group| group.name == "app/helpers/application_helper.rb" } }
+    let(:hello_world_translation) { application_helper_group.translations.find { |translation| translation.key == "helpers.application_helper.hello_world" } }
+    let(:users_controller_handler) { handler.groups.find { |group| group.name == "app/controllers/users_controller.rb" } }
+    let(:update_saved_translation) { users_controller_handler.translations.find { |translation| translation.key == "users.user_was_updated" } }
+
+    it "finds translations made with the t method" do
+      expect(admin_translation).to_not eq nil
+      expect(admin_translation.key).to eq "models.role.administrator"
+      expect(admin_translation.dir).to end_with "spec/dummy/config/locales/awesome_translations/app/models/role"
+    end
+
+    it "generates keys with method-name for mailers" do
+      expect(subject_translation.key).to eq "my_mailer.mailer_action.custom_subject"
+    end
+
+    it "finds translations in arrays" do
+      moderator_translation = group.translations.find { |translation| translation.key == "models.role.moderator" }
+      user_translation = group.translations.find { |translation| translation.key == "models.role.user" }
+
+      expect(moderator_translation).to_not eq nil
+      expect(user_translation).to_not eq nil
+    end
+
+    it "finds helpers translations using helper_t" do
+      expect(hello_world_translation.key).to eq "helpers.application_helper.hello_world"
+    end
+
+    it "finds translations with the controller_t-method" do
+      expect(update_saved_translation).to_not eq nil
+      expect(update_saved_translation.key).to eq "users.user_was_updated"
+      expect(update_saved_translation.dir).to end_with "spec/dummy/config/locales/awesome_translations/app/controllers/users_controller"
+    end
+  end
+
+  describe "global stuff" do
+    let(:group) { handler.groups.find { |group| group.name == "app/views/users/show.html.erb" } }
+    let(:translations) { group.translations.to_a }
+    let(:yes_translation) { translations.find { |translation| translation.key == "yes" } }
+
+    it "finds the right translations" do
+      expect(translations.length).to eq 3
+    end
+
+    it "reads the keys right" do
+      expect(yes_translation.key).to eq "yes"
+    end
+
+    it "sets the correct translation path" do
+      expect(yes_translation.dir).to eq "#{Rails.root}/config/locales/awesome_translations"
+    end
+
+    it "doesn't detect absolute existing direct translations" do
+      expect(translations.map(&:key)).to_not include "activerecord.attributes.users.email"
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: awesome_translations
 version: !ruby/object:Gem::Version
-  version: 0.0.30
+  version: 0.0.31
 platform: ruby
 authors:
 - Kasper Johansen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-05 00:00:00.000000000 Z
+date: 2016-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -507,9 +507,7 @@ files:
 - lib/awesome_translations/handlers.rb
 - lib/awesome_translations/handlers/base_handler.rb
 - lib/awesome_translations/handlers/devise_handler.rb
-- lib/awesome_translations/handlers/erb_handler.rb
-- lib/awesome_translations/handlers/global_handler.rb
-- lib/awesome_translations/handlers/library_handler.rb
+- lib/awesome_translations/handlers/file_handler.rb
 - lib/awesome_translations/handlers/model_handler.rb
 - lib/awesome_translations/handlers/rails_handler.rb
 - lib/awesome_translations/handlers/validations_handler.rb
@@ -1400,9 +1398,7 @@ files:
 - spec/factories/translation_value.rb
 - spec/factories/user.rb
 - spec/features/clean_ups_spec.rb
-- spec/handlers/erb_handler_spec.rb
-- spec/handlers/global_handler_spec.rb
-- spec/handlers/library_handler_spec.rb
+- spec/handlers/file_handler_spec.rb
 - spec/handlers/model_handler_spec.rb
 - spec/handlers/validations_handler_spec.rb
 - spec/handlers_spec.rb
@@ -2321,9 +2317,7 @@ test_files:
 - spec/factories/translation_value.rb
 - spec/factories/user.rb
 - spec/features/clean_ups_spec.rb
-- spec/handlers/erb_handler_spec.rb
-- spec/handlers/global_handler_spec.rb
-- spec/handlers/library_handler_spec.rb
+- spec/handlers/file_handler_spec.rb
 - spec/handlers/model_handler_spec.rb
 - spec/handlers/validations_handler_spec.rb
 - spec/handlers_spec.rb

data/lib/awesome_translations/handlers/global_handler.rb

@@ -1,31 +0,0 @@
-class AwesomeTranslations::Handlers::GlobalHandler < AwesomeTranslations::Handlers::BaseHandler
-  def groups
-    ArrayEnumerator.new do |yielder|
-      yielder << AwesomeTranslations::Group.new(
-        id: "global",
-        handler: self,
-        data: {
-          name: "Global translations"
-        }
-      )
-    end
-  end
-
-  def translations_for_group(_group)
-    ArrayEnumerator.new do |yielder|
-      translations_found = {}
-
-      erb_inspector = AwesomeTranslations::ErbInspector.new
-      erb_inspector.files.each do |file|
-        file.translations.each do |translation|
-          next unless translation.global?
-
-          unless translations_found.key?(translation.full_key)
-            translations_found[translation.full_key] = true
-            yielder << translation.model
-          end
-        end
-      end
-    end
-  end
-end

data/lib/awesome_translations/handlers/library_handler.rb

@@ -1,41 +0,0 @@
-class AwesomeTranslations::Handlers::LibraryHandler < AwesomeTranslations::Handlers::BaseHandler
-  def groups
-    ArrayEnumerator.new do |yielder|
-      erb_inspector.files.each do |file|
-        id = file.file_path.gsub(/[^A-z0-9]/, "_")
-
-        group = AwesomeTranslations::Group.new(
-          id: id,
-          handler: self,
-          data: {
-            name: file.file_path,
-            root_path: file.root_path,
-            full_path: file.full_path,
-            file_path: file.file_path
-          }
-        )
-
-        yielder << group if translations_for_group(group).any?
-      end
-    end
-  end
-
-  def translations_for_group(group)
-    ArrayEnumerator.new do |yielder|
-      file = erb_inspector.file(group.data[:root_path], group.data[:file_path])
-
-      file.translations.each do |translation|
-        next unless translation.relative?
-        yielder << translation.model
-      end
-    end
-  end
-
-private
-
-  def erb_inspector
-    @erb_inspector ||= AwesomeTranslations::ErbInspector.new(
-      exts: [".rb", ".rake"]
-    )
-  end
-end

data/spec/handlers/erb_handler_spec.rb

@@ -1,39 +0,0 @@
-require "spec_helper"
-
-describe AwesomeTranslations::Handlers::ErbHandler do
-  let(:handler) { AwesomeTranslations::Handlers::ErbHandler.new }
-  let(:users_index_group) { handler.groups.find { |group| group.name == "app/views/users/index.html.haml" } }
-  let(:users_index_translations) { users_index_group.translations }
-  let(:users_partial_test_translations) { handler.groups.find { |group| group.name == "app/views/users/_partial_test.html.haml" }.translations }
-  let(:layout_group) { handler.groups.find { |group| group.name == "app/views/layouts/application.html.haml" } }
-  let(:layout_translations) { layout_group.translations }
-
-  it "finds translations made with the t method" do
-    hello_world_translations = users_index_translations.select { |t| t.key == "users.index.hello_world" }.to_a
-    expect(hello_world_translations.length).to eq 1
-  end
-
-  it "finds translations in the layout" do
-    danish_translations = layout_translations.select { |t| t.key == "layouts.application.danish" }.to_a
-    expect(danish_translations.length).to eq 1
-  end
-
-  it "doesnt include _ in partial keys" do
-    partial_test = users_partial_test_translations.select { |t| t.key == "users.partial_test.partial_test" }.to_a
-    expect(partial_test.length).to eq 1
-  end
-
-  it "removes special characters when using the custom method" do
-    current_language_translation = layout_translations.select { |t| t.key == "layouts.application.the_current_language_is" }.to_a
-    expect(current_language_translation.length).to eq 1
-  end
-
-  it "has unique translations" do
-    expect(layout_translations.select { |t| t.key == "layouts.application.hello_world" }.to_a.length).to eq 1
-  end
-
-  it "sets the correct translation path" do
-    danish_translation = layout_translations.find { |t| t.key == "layouts.application.danish" }
-    expect(danish_translation.dir).to eq "#{Rails.root}/config/locales/awesome_translations/app/views/layouts/application"
-  end
-end

data/spec/handlers/global_handler_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe AwesomeTranslations::Handlers::GlobalHandler do
-  let(:global_handler) { AwesomeTranslations::Handlers::GlobalHandler.new }
-  let(:translations) { global_handler.groups.first.translations.to_a }
-  let(:yes_translation) { translations.find { |translation| translation.key == "yes" } }
-
-  it "finds the right translations" do
-    expect(translations.length).to eq 2
-  end
-
-  it "reads the keys right" do
-    expect(yes_translation.key).to eq "yes"
-  end
-
-  it "sets the correct translation path" do
-    expect(yes_translation.dir).to eq "#{Rails.root}/config/locales/awesome_translations"
-  end
-
-  it "doesn't detect absolute existing direct translations" do
-    expect(translations.map(&:key)).to_not include "activerecord.attributes.users.email"
-  end
-end

data/spec/handlers/library_handler_spec.rb

@@ -1,41 +0,0 @@
-require "spec_helper"
-
-describe AwesomeTranslations::Handlers::LibraryHandler do
-  let(:handler) { AwesomeTranslations::Handlers::LibraryHandler.new }
-  let(:group) { handler.groups.find { |group| group.name == "app/models/role.rb" } }
-  let(:mailer_group) { handler.groups.find { |group| group.name == "app/mailers/my_mailer.rb" } }
-  let(:subject_translation) { mailer_group.translations.find { |translation| translation.key == "my_mailer.mailer_action.custom_subject" } }
-  let(:admin_translation) { group.translations.find { |translation| translation.key == "models.role.administrator" } }
-  let(:application_helper_group) { handler.groups.find { |group| group.name == "app/helpers/application_helper.rb" } }
-  let(:hello_world_translation) { application_helper_group.translations.find { |translation| translation.key == "helpers.application_helper.hello_world" } }
-  let(:users_controller_handler) { handler.groups.find { |group| group.name == "app/controllers/users_controller.rb" } }
-  let(:update_saved_translation) { users_controller_handler.translations.find { |translation| translation.key == "users.user_was_updated" } }
-
-  it "finds translations made with the t method" do
-    expect(admin_translation).to_not eq nil
-    expect(admin_translation.key).to eq "models.role.administrator"
-    expect(admin_translation.dir).to end_with "spec/dummy/config/locales/awesome_translations/app/models/role"
-  end
-
-  it "generates keys with method-name for mailers" do
-    expect(subject_translation.key).to eq "my_mailer.mailer_action.custom_subject"
-  end
-
-  it "finds translations in arrays" do
-    moderator_translation = group.translations.find { |translation| translation.key == "models.role.moderator" }
-    user_translation = group.translations.find { |translation| translation.key == "models.role.user" }
-
-    expect(moderator_translation).to_not eq nil
-    expect(user_translation).to_not eq nil
-  end
-
-  it "finds helpers translations using helper_t" do
-    expect(hello_world_translation.key).to eq "helpers.application_helper.hello_world"
-  end
-
-  it "finds translations with the controller_t-method" do
-    expect(update_saved_translation).to_not eq nil
-    expect(update_saved_translation.key).to eq "users.user_was_updated"
-    expect(update_saved_translation.dir).to end_with "spec/dummy/config/locales/awesome_translations/app/controllers/users_controller"
-  end
-end