avro_turf 1.18.0 → 1.20.0

data/spec/confluent_schema_registry_spec.rb

@@ -1,22 +1,40 @@
-require 'webmock/rspec'
-require 'avro_turf/confluent_schema_registry'
-require 'avro_turf/test/fake_confluent_schema_registry_server'
+# frozen_string_literal: true
+
+require "webmock/rspec"
+require "avro_turf/confluent_schema_registry"
+require "avro_turf/test/fake_confluent_schema_registry_server"
 
 describe AvroTurf::ConfluentSchemaRegistry do
   let(:user) { "abc" }
   let(:password) { "xxyyzz" }
   let(:client_cert) { "test client cert" }
+  let(:client_chain) { "test client cert chain" }
   let(:client_key) { "test client key" }
   let(:client_key_pass) { "test client key password" }
   let(:connect_timeout) { 10 }
 
-  context 'authenticated by cert' do
+  context "authenticated by cert" do
+    it_behaves_like "a confluent schema registry client" do
+      let(:registry) {
+        described_class.new(
+          registry_url,
+          logger: logger,
+          client_cert: client_cert,
+          client_key: client_key,
+          client_key_pass: client_key_pass
+        )
+      }
+    end
+  end
+
+  context "authenticated by cert with chain" do
     it_behaves_like "a confluent schema registry client" do
       let(:registry) {
         described_class.new(
           registry_url,
           logger: logger,
           client_cert: client_cert,
+          client_chain: client_chain,
           client_key: client_key,
           client_key_pass: client_key_pass
         )
@@ -24,23 +42,25 @@ describe AvroTurf::ConfluentSchemaRegistry do
     end
   end
 
-  context 'authenticated by basic auth' do
+  context "authenticated by basic auth" do
     it_behaves_like "a confluent schema registry client" do
       let(:registry) {
         described_class.new(
           registry_url,
+          logger: logger,
           user: user,
-          password: password,
+          password: password
         )
       }
     end
   end
 
-  context 'with connect_timeout' do
+  context "with connect_timeout" do
     it_behaves_like "a confluent schema registry client" do
       let(:registry) {
         described_class.new(
           registry_url,
+          logger: logger,
           user: user,
           password: password,
           connect_timeout: connect_timeout
@@ -49,12 +69,13 @@ describe AvroTurf::ConfluentSchemaRegistry do
     end
   end
 
-  context 'with non default schema_context' do
-    it_behaves_like "a confluent schema registry client", schema_context: 'other' do
+  context "with non default schema_context" do
+    it_behaves_like "a confluent schema registry client", schema_context: "other" do
       let(:registry) {
         described_class.new(
           registry_url,
-          schema_context: 'other',
+          logger: logger,
+          schema_context: "other",
           user: user,
           password: password,
           connect_timeout: connect_timeout

data/spec/core_ext/date_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Date, "#as_avro" do
   it "returns Date object describing the time" do
     date = Date.today

data/spec/core_ext/enumerable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Enumerable, "#as_avro" do
   it "returns an array" do
     expect(Set.new.as_avro).to eq []

data/spec/core_ext/false_class_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe FalseClass, "#as_avro" do
   it "returns itself" do
     expect(false.as_avro).to eq false

data/spec/core_ext/hash_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 describe Hash, "#as_avro" do
   it "coerces the keys and values to Avro" do
     x = double(as_avro: "x")
     y = double(as_avro: "y")
 
-    expect({ x => y }.as_avro).to eq({ "x" => "y" })
+    expect({x => y}.as_avro).to eq({"x" => "y"})
   end
 end

data/spec/core_ext/nil_class_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe NilClass, "#as_avro" do
   it "returns itself" do
     expect(nil.as_avro).to eq nil

data/spec/core_ext/numeric_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Numeric, "#as_avro" do
   it "returns the number itself" do
     expect(42.as_avro).to eq 42

data/spec/core_ext/string_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe String, "#as_avro" do
   it "returns itself" do
     expect("hello".as_avro).to eq "hello"

data/spec/core_ext/symbol_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Symbol, "#as_avro" do
   it "returns the String representation of the Symbol" do
     expect(:hello.as_avro).to eq("hello")

data/spec/core_ext/time_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe Time, "#as_avro" do
   it "returns an ISO8601 string describing the time" do
     time = Time.now

data/spec/core_ext/true_class_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe TrueClass, "#as_avro" do
   it "returns itself" do
     expect(true.as_avro).to eq true

data/spec/disk_cached_confluent_schema_registry_spec.rb

@@ -1,18 +1,20 @@
-require 'webmock/rspec'
-require 'avro_turf/cached_confluent_schema_registry'
-require 'avro_turf/test/fake_confluent_schema_registry_server'
+# frozen_string_literal: true
+
+require "webmock/rspec"
+require "avro_turf/cached_confluent_schema_registry"
+require "avro_turf/test/fake_confluent_schema_registry_server"
 
 describe AvroTurf::CachedConfluentSchemaRegistry do
   let(:upstream) { instance_double(AvroTurf::ConfluentSchemaRegistry) }
   let(:logger_io) { StringIO.new }
-  let(:cache)    { AvroTurf::DiskCache.new("spec/cache", logger: Logger.new(logger_io))}
+  let(:cache) { AvroTurf::DiskCache.new("spec/cache", logger: Logger.new(logger_io)) }
   let(:registry) { described_class.new(upstream, cache: cache) }
   let(:id) { rand(999) }
   let(:schema) do
     {
       type: "record",
       name: "person",
-      fields: [{ name: "name", type: "string" }]
+      fields: [{name: "name", type: "string"}]
     }.to_json
   end
 
@@ -21,21 +23,21 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
     {
       type: "record",
       name: "city",
-      fields: [{ name: "name", type: "string" }]
+      fields: [{name: "name", type: "string"}]
     }.to_json
   end
 
-  let(:subject) { 'subject' }
+  let(:subject) { "subject" }
   let(:version) { rand(999) }
   let(:subject_version_schema) do
     {
       subject: subject,
       version: version,
       id: id,
-      schema:  {
+      schema: {
         type: "record",
         name: "city",
-        fields: { name: "name", type: "string" }
+        fields: {name: "name", type: "string"}
       }
     }.to_json
   end
@@ -47,13 +49,13 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
   describe "#fetch" do
     let(:cache_before) do
       {
-        "#{id}" => "#{schema}"
+        id.to_s => schema.to_s
       }
     end
     let(:cache_after) do
       {
-        "#{id}" => "#{schema}",
-        "#{city_id}" => "#{city_schema}"
+        id.to_s => schema.to_s,
+        city_id.to_s => city_schema.to_s
       }
     end
 
@@ -84,13 +86,13 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
   describe "#fetch (zero length cache file)" do
     let(:cache_after) do
       {
-        "#{id}" => "#{schema}"
+        id.to_s => schema.to_s
       }
     end
 
     before do
       # setup the disk cache with a zero length file
-      File.write(File.join("spec/cache", "schemas_by_id.json"), '')
+      File.write(File.join("spec/cache", "schemas_by_id.json"), "")
     end
 
     it "skips zero length disk cache" do
@@ -107,11 +109,11 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
   describe "#fetch (corrupt cache file)" do
     before do
       # setup the disk cache with a corrupt file (i.e. not json)
-      File.write(File.join("spec/cache", "schemas_by_id.json"), 'NOTJSON')
+      File.write(File.join("spec/cache", "schemas_by_id.json"), "NOTJSON")
     end
 
     it "raises error on corrupt cache file" do
-      expect{registry.fetch(id)}.to raise_error(JSON::ParserError, /unexpected token/)
+      expect { registry.fetch(id) }.to raise_error(JSON::ParserError, /unexpected token/)
     end
   end
 
@@ -124,7 +126,7 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
     end
 
     let(:city_name) { "a_city" }
-    let(:cache_after) do 
+    let(:cache_after) do
       {
         "#{subject_name}#{schema}" => id,
         "#{city_name}#{city_schema}" => city_id
@@ -139,7 +141,7 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
     it "uses preloaded disk cache" do
       # multiple calls return same result, with zero upstream calls
       allow(upstream).to receive(:register).with(subject_name, schema).and_return(id)
-      expect(registry.register(subject_name, schema)).to eq(id) 
+      expect(registry.register(subject_name, schema)).to eq(id)
       expect(registry.register(subject_name, schema)).to eq(id)
       expect(upstream).to have_received(:register).exactly(0).times
       expect(load_cache("ids_by_schema.json")).to eq cache_before
@@ -165,7 +167,7 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
 
     before do
       # setup the disk cache with a zero length file
-      File.write(File.join("spec/cache", "ids_by_schema.json"), '')
+      File.write(File.join("spec/cache", "ids_by_schema.json"), "")
     end
 
     it "skips zero length disk cache" do
@@ -182,11 +184,11 @@ describe AvroTurf::CachedConfluentSchemaRegistry do
   describe "#register (corrupt cache file)" do
     before do
       # setup the disk cache with a corrupt file (i.e. not json)
-      File.write(File.join("spec/cache", "ids_by_schema.json"), 'NOTJSON')
+      File.write(File.join("spec/cache", "ids_by_schema.json"), "NOTJSON")
     end
 
     it "raises error on corrupt cache file" do
-      expect{registry.register(subject_name, schema)}.to raise_error(JSON::ParserError, /unexpected token/)
+      expect { registry.register(subject_name, schema) }.to raise_error(JSON::ParserError, /unexpected token/)
     end
   end