avro-patches 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e79aa3bc80d548e2c6556c05208e1ac2b6b47889
-  data.tar.gz: b84ac201fea59bb1cd68fe70cf4874ba8252acbf
+  metadata.gz: ed60cb5d2757a33263b574ba6346fc9665b84548
+  data.tar.gz: 2b36545e5fc8dcb16c5aa93bb1e83fd1248e1b28
 SHA512:
-  metadata.gz: a085676807b8837acb53c6d66a5cd53cc2a0e4bad3055892abdd03c59fdf02a9b85cabeee91b81fc6a75c3e428b4a0f7bef6941c9034a8f646b30353c1cf178f
-  data.tar.gz: 73404b334dfec4168f3cebbe7dc07266be9ecf716ce5c0d3ea9a0086e1d2919cbe99766b743e12f7596a1a9d91e6d6ccbe3868b5c8529f898d95d39938f1a75e
+  metadata.gz: 6727d406d14b6767422de730149d85abd1a819c773267c90a467d89a4233da76d8140bcefffbd67a3049a464e4072e3f201d685d0033f032cdd86b821523b133
+  data.tar.gz: a5960d92f14696c5fbb22c3ec80f245cdc3da3a8b1b50a5b39eaf919b68cc7786499d48bdffb87feffa6715dd183f6584811ae4e09c659783b52ac68dab9c826

data/.gitignore

@@ -7,3 +7,5 @@
 /pkg/
 /spec/reports/
 /tmp/
+.idea
+*.iml

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # avro-patches
 
+## v0.3.4
+- Allow promotion of nested records to optional 
+
 ## v0.3.3
 - Restore basic validation of records, arrays, and maps before writing.
 - Add validation to protect against nil value for map.

data/bin/setup

@@ -3,6 +3,7 @@ set -euo pipefail
 IFS=$'\n\t'
 set -v
 
+gem install bundler
 bundle update
 
 overcommit --install

data/lib/avro-patches/schema_compatibility/schema_compatibility.rb

@@ -1,4 +1,6 @@
 module Avro
+
+  # see http://avro.apache.org/docs/current/spec.html#Schema+Resolution for what this should do
   module SchemaCompatibility
     def self.can_read?(writers_schema, readers_schema)
       Checker.new.can_read?(writers_schema, readers_schema)
@@ -106,6 +108,7 @@ module Avro
         end
       end
 
+      # reader is a union
       def match_union_schemas(writers_schema, readers_schema)
         raise 'readers_schema must be a union' unless readers_schema.type_sym == :union
 
@@ -117,17 +120,23 @@ module Avro
         end
       end
 
+      # reader is a record
       def match_record_schemas(writers_schema, readers_schema)
-        writer_fields_hash = writers_schema.fields_hash
-        readers_schema.fields.each do |field|
-          if writer_fields_hash.key?(field.name)
-            return false unless full_match_schemas(writer_fields_hash[field.name].type, field.type)
-          else
-            return false unless field.default?
+        case writers_schema.type_sym
+        when :union
+          return false
+        else
+          writer_fields_hash = writers_schema.fields_hash
+          readers_schema.fields.each do |field|
+            if writer_fields_hash.key?(field.name)
+              return false unless full_match_schemas(writer_fields_hash[field.name].type, field.type)
+            else
+              return false unless field.default?
+            end
           end
-        end
 
-        return true
+          return true
+        end
       end
 
       def recursion_in_progress?(writers_schema, readers_schema)

data/lib/avro-patches/version.rb

@@ -1,3 +1,3 @@
 module AvroPatches
-  VERSION = '0.3.3'.freeze
+  VERSION = '0.3.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: avro-patches
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Salsify, Inc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-02 00:00:00.000000000 Z
+date: 2018-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Patches for the official Apache Avro Ruby implementation