avo 4.2.6 → 4.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a64a8878e0c42cef0fcbe360cdf217635be5cdcca396cf180888e24a034ab8d
-  data.tar.gz: f05b38be082e6fbe6cc9c5f5c85c87452108d8539dd284d320bd3bd09c9fb92d
+  metadata.gz: 06a99742dcd8d96855fb10577085da6acf2fb2eabebc8ba66d02b653e404f962
+  data.tar.gz: 7d63ef33110cdf91bb3188ecf82abac3ecf9f56fd3c1edc53605737da96b2557
 SHA512:
-  metadata.gz: 19222c1d66ac795e3e0fa668ca5a903604dbe3ae412e2aa528bb8afe6e753cf79abfdd3f3d84f0cfaaecca6e4847ce56f692a14a7abbec498e524c5bbe63009a
-  data.tar.gz: 294e34314e882e5cc255f34e9060f683e384fa888795083275566546d305955d7d090e7293471e1588ea4c0f06a9afb8d4b3085c31e611b98c2ee16bad037d2c
+  metadata.gz: 4dec169c3e7a227e2fd6baffd9a8766c91fe0fba55a04fb3bcf9cd1691c12479a5579450e98cf27a90c1cfab99970d9b5498a9b26e3a745c443878b4f1504006
+  data.tar.gz: 8903fb5e47c672f02254cf44e90fb3df88775e0d5b382131b7ca70c3567d5d6b35815b09e6a129b827111ef447d6cc6dc1dba99655b4bf628d59b9eb114dd69d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    avo (4.2.6)
+    avo (4.2.7)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -139,7 +139,7 @@ GEM
     avo-record_link_field (0.0.2)
     avo-rhino_field (4.1.0)
     aws-eventstream (1.4.0)
-    aws-partitions (1.1287.0)
+    aws-partitions (1.1289.0)
     aws-sdk-core (3.257.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.992.0)
@@ -432,7 +432,7 @@ GEM
       addressable (~> 2.8)
       childprocess (~> 5.0)
       logger (~> 1.6)
-    lexxy (0.9.32)
+    lexxy (0.9.33)
       railties (>= 8.0.2)
     lint_roller (1.1.0)
     listen (3.10.0)
@@ -514,7 +514,7 @@ GEM
     openssl (4.0.2)
     orm_adapter (0.5.0)
     ostruct (0.6.3)
-    pagy (43.6.2)
+    pagy (43.6.3)
       json
       uri
       yaml
@@ -596,7 +596,7 @@ GEM
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.4.2)
-    ransack (4.4.1)
+    ransack (5.0.2)
       activerecord (>= 7.2)
       activesupport (>= 7.2)
       i18n
@@ -624,7 +624,7 @@ GEM
       parser (~> 3.3.0)
       rainbow (>= 2.0, < 4.0)
       rexml (~> 3.1)
-    regexp_parser (2.12.0)
+    regexp_parser (2.13.0)
     reline (0.7.0)
       io-console (~> 0.5)
     responders (3.2.1)

data/app/components/avo/modal_component.html.erb

@@ -17,7 +17,7 @@
     aria-modal="true"
     class="modal__card-container"
   >
-    <div class="modal__card" data-<%= ctrl %>-target="card">
+    <div class="modal__card" <%= tag.attributes(data: {"#{ctrl}-target": "card"}) %>>
       <div class="card">
         <div class="card__wrapper">
           <% if has_header? %>

data/app/components/avo/u_i/panel_component.html.erb

@@ -36,7 +36,7 @@
   <% end %>
 
   <div class="panel__content">
-    <div class="panel__body" <%= "data-content-focus tabindex=-1".html_safe if content_focusable? %>>
+    <div class="panel__body" <%= tag.attributes(content_focusable? ? {data: {"content-focus": ""}, tabindex: -1} : {}) %>>
       <% if card? %>
         <div class="panel__card"><%= card %></div>
       <% else %>

data/app/controllers/avo/associations_controller.rb

@@ -412,6 +412,9 @@ module Avo
     def checkbox_list_option(record)
       resource = @attachment_resource.new(record:, view: Avo::ViewInquirer.new(:new), params:)
       search_item = (@attachment_resource.fetch_search(:item, record:) || {}).with_indifferent_access
+      # Same split as the global search controller: `record_title` is the fallback, and a
+      # declared `self.search[:item]` supplies title, description and image itself. Those
+      # values are app-authored and outside what a title-attribute rule governs.
       title = search_item[:title] || resource.record_title
 
       {

data/app/controllers/avo/search_controller.rb

@@ -160,6 +160,10 @@ module Avo
     end
 
     def fetch_result_information(record, resource, item)
+      # `record_title` is the fallback here, not the source: a resource declaring
+      # `self.search[:item]` supplies the title itself, and that block is app-authored.
+      # Anything that governs which attributes a title may expose therefore reaches this
+      # surface through `record_title` only — the item half is the app's own.
       title = item&.dig(:title) || resource.record_title
       highlighted_title = highlight(title&.to_s, CGI.escapeHTML(params[:q] || ""))
 

data/app/views/avo/partials/_confirm_dialog.html.erb

@@ -2,14 +2,14 @@
   <form method="dialog">
     <div class="card relative">
       <button value="cancel" class="absolute top-3 inset-e-2.5 text-content-secondary bg-transparent hover:bg-tertiary hover:text-content rounded-lg text-sm size-8 ms-auto inline-flex justify-center items-center" data-modal-hide="popup-modal" tabindex="3">
-        <%= svg "x-mark", class: "size-6" %>
+        <%= svg "x", class: "size-6" %>
         <span class="sr-only"><%= t "avo.close_modal" %></span>
       </button>
       <div class="card__wrapper">
         <div class="card__body text-center items-center justify-between min-h-56">
           <div class="flex flex-col items-center justify-center p-4 md:p-5">
             <svg class="mt-4 mx-auto mb-4 text-content-secondary size-12" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 20 20">
-              <path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 11V6m0 8h.01M19 10a9 9 0 1 1-18 0 9 9 0 0 1 18 0Z"/>
+              <path stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 11V6m0 8h.01M19 10a9 9 0 1 1-18 0 9 9 0 0 1 18 0Z" />
             </svg>
             <p class="text-md font-normal text-content">
               <%= t "avo.are_you_sure" %>

data/lib/avo/base_action.rb

@@ -186,8 +186,11 @@ module Avo
 
         # For some fields, like belongs_to, the id and database_id differ (user vs user_id).
         # That's why we need to fetch the database_id for when we process the action.
-        action_fields_by_database_id = action_fields.map do |id, value|
-          [value.database_id.to_sym, value]
+        action_fields_by_database_id = action_fields.values.flat_map do |field|
+          # A polymorphic belongs_to submits both `<name>_type` and `<name>_id`, but its database_id only covers the type.
+          database_ids = field.try(:is_polymorphic?) ? field.to_permitted_param : [field.database_id]
+
+          database_ids.map { |database_id| [database_id.to_sym, field] }
         end.to_h
 
         args[:fields].to_unsafe_h.map do |name, value|

data/lib/avo/current.rb

@@ -27,13 +27,31 @@ class Avo::Current < ActiveSupport::CurrentAttributes
 
   attribute :appearance_settings
 
+  # Which Avo surface this request arrived through: `:ui` for the admin screens, `:api`,
+  # `:ai`, `:mcp`. It names the client, not the screen — `view` already means index/show/
+  # edit/new, which is a screen within one surface. Consumers that resolve an answer per
+  # user can differ per surface without a second declaration.
+  attribute :interface
+
+  # Set by the callers that map over every resource with no user in scope — this gem's
+  # telemetry, and avo-licensing's debug service. Consumers that restrict what a user may
+  # reach read this to opt out explicitly, so the exemption can never be inferred from a
+  # nil user (which is a legitimate state on the API surface).
+  attribute :enumerating_all_resources
+
   # Rails 7.1 CurrentAttributes#attribute is only `def attribute(*names)` — no `default:` keyword.
   # `attribute :x, default: {}` is passed as a second positional `{ default: {} }`, so `names.map(&:to_sym)` raises.
-  resets { self.appearance_settings = {} }
+  resets do
+    self.appearance_settings = {}
+    self.interface = :ui
+    self.enumerating_all_resources = false
+  end
 
   def initialize
     super
     self.appearance_settings = {}
+    self.interface = :ui
+    self.enumerating_all_resources = false
   end
 
   # Protect from error #<RuntimeError: Missing rack.input> when request is ActionDispatch::Request.empty

data/lib/avo/fields/location_field.rb

@@ -3,6 +3,12 @@
 module Avo
   module Fields
     class LocationField < BaseField
+      # The two columns a location is stored across, when it is stored across two. Read
+      # by anything that has to know which columns back a field — `to_permitted_param`
+      # cannot answer that here, since it yields the field id and a hash rather than the
+      # column names.
+      attr_reader :stored_as
+
       def initialize(id, **args, &block)
         hide_on :index
         super

data/lib/avo/resources/base.rb

@@ -516,21 +516,52 @@ module Avo
         fetch_record_title.to_s
       end
 
+      # Whether this resource may expose `attribute` inside a record title. Core always
+      # answers true; a plugin that restricts what a user may reach overrides this and
+      # answers from its own rules. That is what keeps a restricted attribute out of
+      # global search results, breadcrumbs, record links and the association picker
+      # without teaching each of those surfaces separately — they all render a title.
+      #
+      # Deliberately a question about one attribute rather than a field lookup: a bare
+      # `Resource.new(record:)` is built once per option in a belongs_to lookup list, and
+      # its items holder is empty until `detect_fields` runs, so resolving a title through
+      # the field pipeline would both cost a detection per option and answer nothing on
+      # the resources that never detect.
+      def title_attribute_reachable?(attribute)
+        true
+      end
+
       def fetch_record_title
         return name if @record.nil?
 
         # Get the title from the record if title is not set, try to get the name, title or label, or fallback to the to_param
-        return @record.try(:name) || @record.try(:title) || @record.try(:label) || @record.to_param if title.nil?
+        return reachable_title_fallback || @record.to_param if title.nil?
 
         # If the title is a symbol, get the value from the record else execute the block/string
         case title
         when Symbol
-          @record.send title
+          title_attribute_reachable?(title) ? @record.send(title) : @record.to_param
         when Proc
+          # App-authored code. The app's own code is outside this boundary, so the
+          # reachability question is not asked of it.
           Avo::ExecutionContext.new(target: title, resource: self, record: @record).handle
         end
       end
 
+      # Preserves the original `||` chain exactly — an unreachable candidate is skipped
+      # the same way a blank one is.
+      def reachable_title_fallback
+        reachable_title_attribute(:name) ||
+          reachable_title_attribute(:title) ||
+          reachable_title_attribute(:label)
+      end
+
+      def reachable_title_attribute(attribute)
+        return unless title_attribute_reachable?(attribute)
+
+        @record.try(attribute)
+      end
+
       def record_icon
         fetch_record_icon.to_s
       end

data/lib/avo/services/telemetry_service.rb

@@ -24,7 +24,10 @@ class Avo::Services::TelemetryService
     def avo_metadata
       resources = Avo.resource_manager.all
       dashboards = Avo::Current.app.dashboard_manager.all
-      field_definitions = resources.map(&:get_field_definitions)
+      # Counting fields across every resource with no user in scope. Declared explicitly so a
+      # consumer that restricts fields per user opts out here rather than inferring it from a
+      # nil user — nil is a legitimate user on the API surface, where restriction must still apply.
+      field_definitions = enumerating_all_resources { resources.map(&:get_field_definitions) }
       fields_count = field_definitions.map(&:count).sum
       fields_per_resource = sprintf("%0.01f", fields_count / (resources.count + 0.0))
 
@@ -69,6 +72,17 @@ class Avo::Services::TelemetryService
       "error: #{error.message}"
     end
 
+    # Marks a block as enumerating every resource without a user, restoring whatever the
+    # surrounding request had set rather than assuming it was unset.
+    def enumerating_all_resources
+      previous = Avo::Current.enumerating_all_resources
+      Avo::Current.enumerating_all_resources = true
+
+      yield
+    ensure
+      Avo::Current.enumerating_all_resources = previous
+    end
+
     def other_metadata(type = :actions)
       resources = Avo.resource_manager.all
 

data/lib/avo/version.rb

@@ -1,3 +1,3 @@
 module Avo
-  VERSION = "4.2.6" unless const_defined?(:VERSION)
+  VERSION = "4.2.7" unless const_defined?(:VERSION)
 end

data/lib/avo/view_types/view_type_manager.rb

@@ -40,24 +40,26 @@ module Avo
 
       private
 
+      # Names, not constants: plugins register view types from Avo.boot, and loading a component there loads
+      # Action View while the app initializes, which Rails 8.2 flags (rails/rails#57224).
       def register_defaults
         register :table,
-          component: Avo::ViewTypes::TableComponent,
+          component: "Avo::ViewTypes::TableComponent",
           icon: "tabler/outline/layout-list",
           active_icon: "tabler/filled/layout-list"
 
         register :grid,
-          component: Avo::ViewTypes::GridComponent,
+          component: "Avo::ViewTypes::GridComponent",
           icon: "tabler/outline/layout-grid",
           active_icon: "tabler/filled/layout-grid"
 
         register :map,
-          component: Avo::ViewTypes::MapComponent,
+          component: "Avo::ViewTypes::MapComponent",
           icon: "tabler/outline/compass",
           active_icon: "tabler/filled/compass"
 
         register :list,
-          component: Avo::ViewTypes::TableComponent,
+          component: "Avo::ViewTypes::TableComponent",
           icon: "tabler/outline/layout-list",
           active_icon: "tabler/filled/layout-list"
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: avo
 version: !ruby/object:Gem::Version
-  version: 4.2.6
+  version: 4.2.7
 platform: ruby
 authors:
 - Adrian Marin