avo 4.0.26 → 4.1.0

data/app/controllers/avo/attachments_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/application_controller"
-
 module Avo
-  class AttachmentsController < ApplicationController
+  class AttachmentsController < Avo::ApplicationController
     before_action :set_resource_name, only: [:destroy, :create]
     before_action :set_resource, only: [:destroy, :create]
     before_action :set_record, only: [:destroy, :create]

data/app/controllers/avo/base_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/application_controller"
-
 module Avo
-  class BaseController < ApplicationController
+  class BaseController < Avo::ApplicationController
     include Avo::Concerns::FiltersSessionHandler
     include Avo::Concerns::AssociationQueryScope
     include Avo::Concerns::SafeCall

data/app/controllers/avo/charts_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/base_controller"
-
 module Avo
-  class ChartsController < BaseController
+  class ChartsController < Avo::BaseController
     # Summarizable charts reuse the index query pipeline (including policy scope via
     # `query_scope`). They were never meant to require `distribution_chart?` /
     # `distribution_chart_full?` policy methods — those only surfaced once

data/app/controllers/avo/debug_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/application_controller"
-
 module Avo
-  class DebugController < ApplicationController
+  class DebugController < Avo::ApplicationController
     before_action :authenticate_developer_or_admin!
 
     def status

data/app/controllers/avo/home_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/application_controller"
-
 module Avo
-  class HomeController < ApplicationController
+  class HomeController < Avo::ApplicationController
     def index
       if Avo.configuration.home_path.present?
         # If the home_path is a block run it, if not, just use it

data/app/controllers/avo/media_library_controller.rb

@@ -1,5 +1,5 @@
 module Avo
-  class MediaLibraryController < ApplicationController
+  class MediaLibraryController < Avo::ApplicationController
     include Pagy::Method
 
     before_action :authorize_access!

data/app/controllers/avo/private_controller.rb

@@ -1,7 +1,5 @@
-require_dependency "avo/application_controller"
-
 module Avo
-  class PrivateController < ApplicationController
+  class PrivateController < Avo::ApplicationController
     before_action :authenticate_developer_or_admin!
 
     def design

data/app/controllers/avo/resources_controller.rb

@@ -1,6 +1,4 @@
-require_dependency "avo/base_controller"
-
 module Avo
-  class ResourcesController < BaseController
+  class ResourcesController < Avo::BaseController
   end
 end

data/app/controllers/avo/search_controller.rb

@@ -3,10 +3,8 @@
 # This controller is currently only used for searchable fields, it keeps the old search controller without any changes
 # Possibly have much more logic that it uses, but it's not worth the effort to refactor it since we're going to replace it with a new searchable fields way
 
-require_dependency "avo/application_controller"
-
 module Avo
-  class SearchController < ApplicationController
+  class SearchController < Avo::ApplicationController
     include Rails.application.routes.url_helpers
     include ActionView::Helpers::TextHelper
 

data/app/javascript/js/controllers/modal_size_controller.js

@@ -2,8 +2,6 @@ import { Controller } from '@hotwired/stimulus'
 
 // Connects to data-controller="modal-size"
 export default class extends Controller {
-  static targets = ['container']
-
   static values = {
     currentWidth: String,
     currentHeight: String,
@@ -28,56 +26,18 @@ export default class extends Controller {
   }
 
   updateWidthClass(width) {
-    // Remove all modal width classes from the modal element
-    this.modalElement.classList.remove(
-      'modal--width-sm',
-      'modal--width-md',
-      'modal--width-lg',
-      'modal--width-xl',
-      'modal--width-2xl',
-      'modal--width-3xl',
-      'modal--width-4xl',
-      'modal--width-full',
-      'modal--width-25',
-      'modal--width-50',
-      'modal--width-75',
-      'modal--width-100',
-    )
-
-    // Remove all width classes from the container
-    this.containerTarget.classList.remove('w-sm', 'w-md', 'w-lg', 'w-xl', 'w-2xl', 'w-3xl', 'w-4xl', 'w-full')
-
-    // Add the new modal width class to the modal element
-    this.modalElement.classList.add(`modal--width-${width}`)
-
-    // Add the corresponding width class to the container
-    if (width === 'full') {
-      this.containerTarget.classList.add('w-full')
-    } else {
-      this.containerTarget.classList.add(`w-${width}`)
-    }
+    this.#swapModifier('modal--width-', width)
   }
 
   updateHeightClass(height) {
-    // Remove all modal height classes from the modal element
-    this.modalElement.classList.remove(
-      'modal--height-auto',
-      'modal--height-sm',
-      'modal--height-md',
-      'modal--height-lg',
-      'modal--height-xl',
-      'modal--height-2xl',
-      'modal--height-3xl',
-      'modal--height-4xl',
-      'modal--height-full',
-      'modal--height-25',
-      'modal--height-50',
-      'modal--height-75',
-      'modal--height-100',
-    )
+    this.#swapModifier('modal--height-', height)
+  }
 
-    // Add the new modal height class to the modal element
-    // The CSS will handle applying the appropriate height to .modal__card
-    this.modalElement.classList.add(`modal--height-${height}`)
+  // The CSS owns the sizes: each `modal--width-*` / `modal--height-*` modifier
+  // sizes `.modal__card`. Swapping by prefix means a new size token is a CSS
+  // rule and nothing else — no list here to keep in sync with the stylesheet.
+  #swapModifier(prefix, value) {
+    this.modalElement.classList.remove(...[...this.modalElement.classList].filter((name) => name.startsWith(prefix)))
+    this.modalElement.classList.add(`${prefix}${value}`)
   }
 }

data/app/javascript/js/controllers/record_selector_controller.js

@@ -9,8 +9,19 @@ export default class extends Controller {
 
   autoClicking = false
 
+  // Every lookup in here is scoped to this controller's element. A page can hold several tables (a
+  // show page renders one per has_many association) and each numbers its rows from zero, so a
+  // document-wide lookup by index always lands in the first table.
   get itemSelectorCells() {
-    return document.querySelectorAll('.item-selector-cell')
+    return this.element.querySelectorAll('.item-selector-cell')
+  }
+
+  #rowAt(index) {
+    return this.element.querySelector(`tr[data-index="${index}"]`)
+  }
+
+  #checkboxAt(index) {
+    return this.element.querySelector(`input[type="checkbox"][data-index="${index}"]`)
   }
 
   get hasLastCheckedIndex() {
@@ -32,6 +43,12 @@ export default class extends Controller {
       return
     }
 
+    // Ranges are addressed by row. Index view types outside a table (avo-notifications renders one)
+    // give this component an index but no row to walk up to, so there's nothing to span.
+    if (!event.target.closest('tr')) {
+      return
+    }
+
     // If there's no last checked index and the shift key isn't pressed, set the starting index
     if (!this.hasLastCheckedIndex) {
       this.#setStartingIndex(event)
@@ -57,7 +74,7 @@ export default class extends Controller {
 
     // Loop through the range of rows and toggle the checkboxes
     theRange.forEach((index) => {
-      const checkbox = document.querySelector(`input[type="checkbox"][data-index="${index}"]`)
+      const checkbox = this.#checkboxAt(index)
 
       // Toggle the checkbox if it's not in the same state as the target checkbox
       if (checkbox.checked !== state) {
@@ -110,7 +127,8 @@ export default class extends Controller {
   #selectorMouseenterHandler(event) {
     // Add the highlighted-row class to the row that the mouse is over
     event.target.closest('tr').classList.add('highlighted-row')
-    if (this.lastCheckedIndex) {
+    // Check against null, not truthiness — index 0 is a valid anchor
+    if (this.hasLastCheckedIndex) {
       // Highlight the range of rows between the last checked index and the current index
       this.#highlightRange(this.lastCheckedIndex, parseInt(event.target.closest('tr').dataset.index))
     }
@@ -120,17 +138,16 @@ export default class extends Controller {
     // Remove the highlighted-row class from the row that the mouse is over
     event.target.closest('tr').classList.remove('highlighted-row')
     // Remove the highlighted-row class from all rows
-    document.querySelectorAll('tr[data-index]').forEach((tr) => {
+    this.element.querySelectorAll('tr[data-index]').forEach((tr) => {
       tr.classList.remove('highlighted-row')
     })
   }
 
   // Highlight the range of rows between the start index and the end index
   #highlightRange(startIndex, endIndex) {
-    const theRange = difference(range(startIndex, endIndex))
-    theRange.forEach((index) => {
-      const tr = document.querySelector(`tr[data-index="${index}"]`)
-      tr.classList.add('highlighted-row')
+    // `range` excludes the end index, but the hovered row is highlighted by the caller
+    range(startIndex, endIndex).forEach((index) => {
+      this.#rowAt(index).classList.add('highlighted-row')
     })
   }
 

data/app/views/avo/media_library/index.html.erb

@@ -1,6 +1,9 @@
 <%= render Avo::TurboFrameWrapperComponent.new(turbo_frame_request_id) do %>
   <% if turbo_frame_request_id %>
-    <%= render Avo::ModalComponent.new(title: t("avo.media_library.title")) do |c| %>
+    <%# The library is a grid of media cards (13rem floor per card), so the default
+        :xl modal fits two columns and 4xl three, leaving a ragged last row. 5xl
+        fits four, so a page of 12 lands as three full rows. %>
+    <%= render Avo::ModalComponent.new(title: t("avo.media_library.title"), width: :"5xl") do |c| %>
       <div class="p-4">
         <%= render Avo::MediaLibrary::ListComponent.new attaching: @attaching %>
       </div>

data/avo.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
       "public gem pushes."
   end
 
-  spec.required_ruby_version = ">= 3.0.0"
+  spec.required_ruby_version = ">= 3.2.0"
   spec.post_install_message = "Thank you for using Avo 💪  Docs are available at https://docs.avohq.io"
 
   # NOTE: `public/` is rejected below — Avo 4 ships precompiled assets from

data/lib/avo/version.rb

@@ -1,3 +1,3 @@
 module Avo
-  VERSION = "4.0.26" unless const_defined?(:VERSION)
+  VERSION = "4.1.0" unless const_defined?(:VERSION)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: avo
 version: !ruby/object:Gem::Version
-  version: 4.0.26
+  version: 4.1.0
 platform: ruby
 authors:
 - Adrian Marin
@@ -224,6 +224,8 @@ files:
 - app/assets/builds/avo/application.css
 - app/assets/builds/avo/application.js
 - app/assets/builds/avo/application.js.map
+- app/assets/builds/avo/avo.custom.js
+- app/assets/builds/avo/avo.custom.js.map
 - app/assets/builds/avo/dependencies.css
 - app/assets/builds/avo/late-registration.js
 - app/assets/builds/avo/late-registration.js.map
@@ -1187,7 +1189,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.0.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="