avo 2.9.2.pre1 → 2.10.0

data/lib/avo/fields/base_field.rb

@@ -4,8 +4,11 @@ module Avo
       extend ActiveSupport::DescendantsTracker
       extend Avo::Fields::FieldExtensions::HasFieldName
 
-      include Avo::Fields::FieldExtensions::VisibleInDifferentViews
+      include Avo::Concerns::IsResourceItem
+      include Avo::Concerns::HandlesFieldArgs
+
       include ActionView::Helpers::UrlHelper
+      include Avo::Fields::FieldExtensions::VisibleInDifferentViews
 
       include Avo::Concerns::HandlesFieldArgs
       include Avo::Concerns::HasHTMLAttributes
@@ -48,8 +51,9 @@ module Avo
       attr_reader :panel_name
 
       class_attribute :field_name_attribute
+      class_attribute :item_type, default: :field
 
-      def initialize(id, _options: {}, **args, &block)
+      def initialize(id, **args, &block)
         super(id, **args, &block)
 
         @id = id
@@ -206,9 +210,14 @@ module Avo
 
       # Try and build the component class or fallback to a blank one
       def component_for_view(view = :index)
+        # Use the edit variant for all "update" views
+        view = :edit if view.in? [:new, :create, :update]
+
         component_class = "::Avo::Fields::#{view_component_name}::#{view.to_s.camelize}Component"
         component_class.constantize
       rescue
+        # When returning nil, a race condition happens and throws an error in some environments.
+        # See https://github.com/avo-hq/avo/pull/365
         ::Avo::BlankFieldComponent
       end
 
@@ -228,6 +237,14 @@ module Avo
         true
       end
 
+      def visible_in_reflection?
+        true
+      end
+
+      def hidden_in_reflection?
+        !visible_in_reflection?
+      end
+
       private
 
       def model_or_class(model)

data/lib/avo/fields/date_field.rb

@@ -3,6 +3,7 @@ module Avo
     class DateField < TextField
       attr_reader :first_day_of_week
       attr_reader :picker_format
+      attr_reader :disable_mobile
       attr_reader :format
       attr_reader :relative
 
@@ -13,6 +14,7 @@ module Avo
         @picker_format = args[:picker_format].present? ? args[:picker_format] : "Y-m-d"
         @format = args[:format].present? ? args[:format] : :long
         @relative = args[:relative].present? ? args[:relative] : false
+        @disable_mobile = args[:disable_mobile].present? ? args[:disable_mobile] : false
       end
 
       def formatted_value

data/lib/avo/fields/date_time_field.rb

@@ -2,29 +2,25 @@ module Avo
   module Fields
     class DateTimeField < DateField
       attr_reader :format
-      attr_reader :picker_format
       attr_reader :time_24hr
       attr_reader :timezone
 
       def initialize(id, **args, &block)
         super(id, **args, &block)
 
-        add_boolean_prop args, :time_24hr
-        add_string_prop args, :picker_format, "Y-m-d H:i:S"
-        add_string_prop args, :format, "yyyy-LL-dd TT"
-        add_string_prop args, :timezone
+        @picker_format = args[:picker_format].present? ? args[:picker_format] : "Y-m-d H:i:S"
+        @time_24hr = args[:time_24hr].present? ? args[:time_24hr] : false
+        @timezone = args[:timezone].present? ? args[:timezone] : Rails.application.config.time_zone
       end
 
       def formatted_value
         return nil if value.nil?
 
-        value.utc.to_time.iso8601
-      end
-
-      def edit_formatted_value
-        return nil if value.nil?
-
-        value.utc.iso8601
+        if @format.is_a?(Symbol)
+          value.to_time.in_time_zone(timezone).to_formatted_s(@format)
+        else
+          value.to_time.in_time_zone(timezone).strftime(@format)
+        end
       end
 
       def fill_field(model, key, value, params)
@@ -36,18 +32,10 @@ module Avo
 
         return model if value.blank?
 
-        model[id] = utc_time(value)
+        model[id] = value.to_time.in_time_zone(Rails.application.config.time_zone)
 
         model
       end
-
-      def utc_time(value)
-        if timezone.present?
-          ActiveSupport::TimeZone.new(timezone).local_to_utc(Time.parse(value))
-        else
-          value
-        end
-      end
     end
   end
 end

data/lib/avo/fields/field_extensions/visible_in_different_views.rb

@@ -7,13 +7,20 @@ module Avo
         attr_accessor :show_on_new
         attr_accessor :show_on_edit
 
-        def initialize(id, **args, &block)
+        def initialize(id = nil, **args, &block)
           @show_on_index = @show_on_index.nil? ? true : @show_on_index
           @show_on_show = @show_on_show.nil? ? true : @show_on_show
           @show_on_new = @show_on_new.nil? ? true : @show_on_new
           @show_on_edit = @show_on_edit.nil? ? true : @show_on_edit
         end
 
+        # Validates if the field is visible on certain view
+        def visible_on?(view)
+          raise "No view specified on visibility check." if view.blank?
+
+          send :"show_on_#{view.to_s}"
+        end
+
         def show_on(*where)
           return show_on_all if where.include? :all
 
@@ -44,6 +51,16 @@ module Avo
           end
         end
 
+        # When submitting the form on creation, the new page will be create but we don't have a visibility marker for create so we'll default to new
+        def show_on_create
+          show_on_new
+        end
+
+        # When submitting the form on update, the new page will be create but we don't have a visibility marker for update so we'll default to edit
+        def show_on_update
+          show_on_edit
+        end
+
         private
 
         def show_on_view(view)

data/lib/avo/fields/has_base_field.rb

@@ -29,7 +29,10 @@ module Avo
       end
 
       def frame_url
-        "#{@resource.record_path}/#{id}?turbo_frame=#{turbo_frame}"
+        Avo::Services::URIService.parse(@resource.record_path)
+          .append_path(id.to_s)
+          .append_query(turbo_frame: turbo_frame.to_s)
+          .to_s
       end
 
       # The value
@@ -59,6 +62,22 @@ module Avo
       def placeholder
         @placeholder || I18n.t("avo.choose_an_option")
       end
+
+      def has_own_panel?
+        true
+      end
+
+      def visible_in_reflection?
+        false
+      end
+
+      # Adds the view override component
+      # has_one, has_many, has_and_belongs_to_many fields don't have edit views
+      def component_for_view(view = :index)
+        view = :show if view.in? [:new, :create, :update, :edit]
+
+        super view
+      end
     end
   end
 end

data/lib/avo/fields/has_one_field.rb

@@ -22,7 +22,10 @@ module Avo
       end
 
       def frame_url
-        "#{@resource.record_path}/#{id}/#{value.id}?turbo_frame=#{turbo_frame}"
+        Avo::Services::URIService.parse(@resource.record_path)
+          .append_paths(id, value.id)
+          .append_query(turbo_frame: turbo_frame)
+          .to_s
       end
 
       def fill_field(model, key, value, params)

data/lib/avo/grid_collector.rb

@@ -13,15 +13,18 @@ module Avo
     end
 
     def cover(field_name, as:, **args, &block)
-      self.cover_field = self.class.parse_field(field_name, as: as, **args, &block)
+      field_parser = Avo::Dsl::FieldParser.new(id: field_name, as: as, order_index: items_index, **args, &block).parse
+      self.cover_field = field_parser.instance if field_parser.valid?
     end
 
     def title(field_name, as:, **args, &block)
-      self.title_field = self.class.parse_field(field_name, as: as, **args, &block)
+      field_parser = Avo::Dsl::FieldParser.new(id: field_name, as: as, order_index: items_index, **args, &block).parse
+      self.title_field = field_parser.instance if field_parser.valid?
     end
 
     def body(field_name, as:, **args, &block)
-      self.body_field = self.class.parse_field(field_name, as: as, **args, &block)
+      field_parser = Avo::Dsl::FieldParser.new(id: field_name, as: as, order_index: items_index, **args, &block).parse
+      self.body_field = field_parser.instance if field_parser.valid?
     end
 
     def hydrate(model:, view:, resource:)

data/lib/avo/items_holder.rb

@@ -0,0 +1,68 @@
+module Avo
+  class ItemsHolder
+    attr_reader :tools
+    attr_accessor :items
+    attr_accessor :invalid_fields
+
+    def initialize
+      @items = []
+      @items_index = 0
+      @invalid_fields = []
+    end
+
+    # Adds a field to the bag
+    def field(field_name, **args, &block)
+      field_parser = Avo::Dsl::FieldParser.new(id: field_name, order_index: @items_index, **args, &block).parse
+
+      if field_parser.invalid?
+        as = args.fetch(:as, nil)
+
+        # End execution ehre and add the field to the invalid_fileds payload so we know to wanr the developer about that.
+        # @todo: Make sure this warning is still active
+        return add_invalid_field({
+          name: field_name,
+          as: as,
+          # resource: resource_class.name,
+          message: "There's an invalid field configuration for this resource. <br/> <code class='px-1 py-px rounded bg-red-600'>field :#{field_name}, as: #{as}</code>"
+        })
+      end
+
+      add_item field_parser.instance
+    end
+
+    def tabs(instance)
+      add_item instance
+    end
+
+    def tab(name, **args, &block)
+      add_item Avo::TabBuilder.parse_block(name: name, **args, &block)
+    end
+
+    def tool(klass, **args)
+      instance = klass.new(**args)
+      add_item instance
+    end
+
+    def panel(panel_name = nil, **args, &block)
+      panel = Avo::PanelBuilder.parse_block(name: panel_name, **args, &block)
+
+      add_item panel
+    end
+
+    def add_item(instance)
+      @items << instance
+
+      increment_order_index
+    end
+
+    private
+
+    def add_invalid_field(payload)
+      @invalid_fields << payload
+    end
+
+    def increment_order_index
+      @items_index += 1
+    end
+  end
+end

data/lib/avo/licensing/h_q.rb

@@ -98,6 +98,7 @@ module Avo
           **other_metadata(:filters),
           main_menu_present: Avo.configuration.main_menu.present?,
           profile_menu_present: Avo.configuration.profile_menu.present?,
+          **config_metadata
         }
       rescue
         {}
@@ -178,6 +179,15 @@ module Avo
         }
       end
 
+      def config_metadata
+        {
+          config: {
+            root_path: Avo.configuration.root_path,
+            app_name: Avo.configuration.app_name
+          }
+        }
+      end
+
       def cache_and_return_error(error, exception_message = "")
         cache_response response: {error: error, exception_message: exception_message}.stringify_keys, time: 5.minutes.to_i
       end

data/lib/avo/main_panel.rb

@@ -0,0 +1,3 @@
+class Avo::MainPanel < Avo::Panel
+  class_attribute :item_type, default: :main_panel
+end

data/lib/avo/menu/builder.rb

@@ -5,6 +5,13 @@ class Avo::Menu::Builder
     end
   end
 
+  delegate :context, to: ::Avo::App
+  delegate :current_user, to: ::Avo::App
+  delegate :params, to: ::Avo::App
+  delegate :request, to: ::Avo::App
+  delegate :root_path, to: ::Avo::App
+  delegate :view_context, to: ::Avo::App
+
   def initialize(name: nil, items: [])
     @menu = Avo::Menu::Menu.new
 
@@ -60,7 +67,7 @@ class Avo::Menu::Builder
   # Add all the tools
   def all_tools(**args)
     Avo::App.tools_for_navigation.each do |tool|
-      link tool.humanize, path: "#{root_path}/#{tool}"
+      link tool.humanize, path: root_path(paths: [tool])
     end
   end
 
@@ -68,10 +75,4 @@ class Avo::Menu::Builder
   def build
     @menu
   end
-
-  protected
-
-  def root_path
-    Avo::App.root_path
-  end
 end

data/lib/avo/panel.rb

@@ -0,0 +1,25 @@
+class Avo::Panel
+  include Avo::Concerns::IsResourceItem
+
+  class_attribute :item_type, default: :panel
+
+  attr_reader :name
+  attr_reader :description
+  attr_accessor :items_holder
+
+  delegate :items, :add_item, to: :items_holder
+
+  def initialize(name: nil, description: nil)
+    @name = name
+    @description = description
+    @items_holder = Avo::ItemsHolder.new
+  end
+
+  def add_item(item)
+    @items << item
+  end
+
+  def has_items?
+    @items.present?
+  end
+end

data/lib/avo/panel_builder.rb

@@ -0,0 +1,23 @@
+class Avo::PanelBuilder
+  class << self
+    def parse_block(**args, &block)
+      Docile.dsl_eval(new(**args), &block).build
+    end
+  end
+
+  delegate :field, to: :items_holder
+  delegate :items, to: :items_holder
+
+  attr_reader :items_holder
+
+  def initialize(name: nil, **args)
+    @panel = Avo::Panel.new(name: name, **args)
+    @items_holder = Avo::ItemsHolder.new
+  end
+
+  # Fetch the tab
+  def build
+    @panel.items_holder = @items_holder
+    @panel
+  end
+end

data/lib/avo/services/uri_service.rb

@@ -0,0 +1,71 @@
+module Avo
+  module Services
+    class URIService
+      class << self
+        def parse(path)
+          self.new path
+        end
+      end
+
+      attr_reader :uri
+
+      def initialize(path = '')
+        @uri = Addressable::URI.parse(path)
+      end
+
+      def append_paths(*paths)
+        paths = Array.wrap(paths).flatten
+
+        return self if paths.blank?
+
+        # Add the intermediary forward slash
+        @uri.path = @uri.path.concat("/") unless @uri.path.ends_with? "/"
+
+        # Add the paths to the URI
+        @uri.merge!(path: @uri.path.concat(join_paths(paths)))
+
+        self
+      end
+      alias_method :append_path, :append_paths
+
+      def append_query(params)
+        params = if params.is_a? Hash
+          params.map do |key, value|
+            "#{key}=#{value}"
+          end
+        else
+          {}
+        end
+
+        return self if params.blank?
+
+        # Add the query params to the URI
+        @uri.merge!(query: [@uri.query, *params].compact.join("&"))
+
+        self
+      end
+
+      def to_s
+        @uri.to_s
+      end
+
+      private
+
+      def join_paths(paths)
+        paths.map do |path|
+          sanitize_path path
+        end
+        .join("/")
+      end
+
+      # Removes the forward slash if it's present at the start of the path
+      def sanitize_path(path)
+        if path.to_s.starts_with? '/'
+          path = path[1..-1]
+        end
+
+        path
+      end
+    end
+  end
+end

data/lib/avo/tab.rb

@@ -0,0 +1,78 @@
+class Avo::Tab
+  include Avo::Concerns::IsResourceItem
+  include Avo::Fields::FieldExtensions::VisibleInDifferentViews
+
+  class_attribute :item_type, default: :tab
+  delegate :items, :add_item, to: :items_holder
+
+  attr_reader :name
+  attr_reader :view
+  attr_accessor :description
+  attr_accessor :items_holder
+  attr_accessor :holds_one_field
+
+  def initialize(name: nil, description: nil, view: nil, holds_one_field: false, **args)
+    # Initialize the visibility markers
+    super
+
+    @name = name
+    @description = description
+    @holds_one_field = holds_one_field
+    @items_holder = Avo::ItemsHolder.new
+    @view = view
+
+    show_on args[:show_on] if args[:show_on].present?
+    hide_on args[:hide_on] if args[:hide_on].present?
+    only_on args[:only_on] if args[:only_on].present?
+    except_on args[:except_on] if args[:except_on].present?
+  end
+
+  def hydrate(view: nil)
+    @view = view
+
+    self
+  end
+
+  def turbo_frame_id(parent: nil)
+    id = "#{Avo::Tab.to_s.parameterize} #{name}".parameterize
+
+    return id if parent.nil?
+
+    "#{parent.turbo_frame_id} #{id}".parameterize
+  end
+
+  def empty?
+    visible_items.blank?
+  end
+
+  # Checks for visibility on itself or on theone field it holds
+  def visible_on?(view)
+    if holds_one_field
+      super(view) && items.first.visible_on?(view)
+    else
+      super(view)
+    end
+  end
+
+  def items
+    if self.items_holder.present?
+      self.items_holder.items
+    else
+      []
+    end
+  end
+
+  def visible_items
+    items.map do |item|
+      if item.is_field?
+        visible = item.visible_on?(view)
+        # Remove the fields that shouldn't be visible in this view
+        # eg: has_many fields on edit
+        item = nil unless visible
+      end
+
+      item
+    end
+    .compact
+  end
+end

data/lib/avo/tab_builder.rb

@@ -0,0 +1,25 @@
+class Avo::TabBuilder
+  class << self
+    def parse_block(**args, &block)
+      Docile.dsl_eval(new(**args), &block).build
+    end
+  end
+
+  attr_reader :items_holder
+
+  delegate :field, to: :items_holder
+  delegate :tool, to: :items_holder
+  delegate :panel, to: :items_holder
+  delegate :items, to: :items_holder
+
+  def initialize(name: nil, **args)
+    @tab = Avo::Tab.new(name: name, **args)
+    @items_holder = Avo::ItemsHolder.new
+  end
+
+  # Fetch the tab
+  def build
+    @tab.items_holder = @items_holder
+    @tab
+  end
+end

data/lib/avo/tab_group.rb

@@ -0,0 +1,40 @@
+class Avo::TabGroup
+  include Avo::Concerns::HasFields
+  include Avo::Concerns::IsResourceItem
+
+  class_attribute :item_type, default: :tab_group
+
+  attr_reader :view
+  attr_accessor :index
+  attr_accessor :items_holder
+
+  def initialize(index: 0, view: nil)
+    @index = index
+    @items_holder = Avo::ItemsHolder.new
+    @view = view
+  end
+
+  def hydrate(view: nil)
+    @view = view
+
+    self
+  end
+
+  def visible_items
+    items.map do |item|
+      item.hydrate view: view
+    end
+    .select do |item|
+      # Remove items hidden in this view
+      item.visible_on? view
+    end
+    .select do |item|
+      # Remove empty items
+      !item.empty?
+    end
+  end
+
+  def turbo_frame_id
+    "#{Avo::TabGroup.to_s.parameterize} #{index}".parameterize
+  end
+end

data/lib/avo/tab_group_builder.rb

@@ -0,0 +1,43 @@
+class Avo::TabGroupBuilder
+  class << self
+    def parse_block(&block)
+      Docile.dsl_eval(new, &block).build
+    end
+  end
+
+  attr_reader :items_holder
+
+  delegate :tab, to: :items_holder
+
+  def initialize
+    @group = Avo::TabGroup.new
+    @items_holder = Avo::ItemsHolder.new
+  end
+
+  def field(field_name, **args, &block)
+    parsed = Avo::Dsl::FieldParser.new(id: field_name, order_index: @items_index, **args, &block).parse
+    field_instance = parsed.instance
+
+    name = field_instance.name
+    tab = Avo::Tab.new name: name
+
+    if field_instance.has_own_panel?
+      tab.items_holder.add_item parsed.instance
+      tab.holds_one_field = true
+    else
+      # If the field is not in a panel, create one and add it
+      panel = Avo::Panel.new name: name
+      panel.items_holder.add_item parsed.instance
+      # Add that panel to the bag
+      tab.items_holder.add_item panel
+    end
+
+    @items_holder.tabs tab
+  end
+
+  # Fetch the tab
+  def build
+    @group.items_holder = @items_holder
+    @group
+  end
+end

data/lib/avo/version.rb

@@ -1,3 +1,3 @@
 module Avo
-  VERSION = "2.9.2.pre1" unless const_defined?(:VERSION)
+  VERSION = "2.10.0" unless const_defined?(:VERSION)
 end

data/lib/avo.rb

@@ -5,6 +5,7 @@ require_relative "avo/engine" if defined?(Rails)
 loader = Zeitwerk::Loader.for_gem
 loader.inflector.inflect(
   "html" => "HTML",
+  "uri_service" => "URIService",
   "has_html_attributes" => "HasHTMLAttributes"
 )
 loader.ignore("#{__dir__}/generators")