avo 2.9.1.pre7 → 2.9.2.pre1

data/app/controllers/avo/application_controller.rb

@@ -13,8 +13,7 @@ module Avo
     protect_from_forgery with: :exception
     before_action :init_app
     before_action :check_avo_license
-    before_action :set_default_locale
-    around_action :set_force_locale
+    before_action :set_locale
     before_action :set_authorization
     before_action :_authenticate!
     before_action :set_container_classes
@@ -28,7 +27,7 @@ module Avo
     add_flash_types :info, :warning, :success, :error
 
     def init_app
-      Avo::App.init request: request, context: context, current_user: _current_user, view_context: view_context, params: params
+      Avo::App.init request: request, context: context, root_path: avo.root_path.delete_suffix("/"), current_user: _current_user, view_context: view_context, params: params
 
       @license = Avo::App.license
     end
@@ -288,30 +287,10 @@ module Avo
       @resource.form_scope
     end
 
-    def set_default_locale
+    def set_locale
       I18n.locale = params[:set_locale] || I18n.default_locale
 
       I18n.default_locale = I18n.locale
     end
-
-    # Temporary set the locale
-    def set_force_locale
-      if params[:force_locale].present?
-        initial_locale = I18n.locale.to_s.dup
-        I18n.locale = params[:force_locale]
-        yield
-        I18n.locale = initial_locale
-      else
-        yield
-      end
-    end
-
-    def default_url_options
-      if params[:force_locale].present?
-        { **super, force_locale: params[:force_locale] }
-      else
-        super
-      end
-    end
   end
 end

data/app/javascript/avo.js

@@ -74,11 +74,7 @@ document.addEventListener('turbo:frame-load', () => {
 document.addEventListener('turbo:before-fetch-response', async (e) => {
   if (e.detail.fetchResponse.response.status === 500) {
     const { id, src } = e.target
-    // Don't try to redirect to failed to load if this is alread a redirection to failed to load and crashed somewhere.
-    // You'll end up with a request loop.
-    if (!e.detail.fetchResponse?.response?.url?.includes('/failed_to_load')) {
-      e.target.src = `${window.Avo.configuration.root_path}/failed_to_load?turbo_frame=${id}&src=${src}`
-    }
+    e.target.src = `${window.Avo.configuration.root_path}/failed_to_load?turbo_frame=${id}&src=${src}`
   }
 })
 

data/app/javascript/js/controllers/fields/date_field_controller.js

@@ -2,63 +2,125 @@ import { Controller } from '@hotwired/stimulus'
 import { DateTime } from 'luxon'
 import flatpickr from 'flatpickr'
 
-import { castBoolean } from '../../helpers/cast_boolean'
-
 // Get the DateTime with the TZ offset applied.
 function universalTimestamp(timestampStr) {
   return new Date(new Date(timestampStr).getTime() + (new Date(timestampStr).getTimezoneOffset() * 60 * 1000))
 }
 
 export default class extends Controller {
-  static targets = ['input']
+  static targets = ['input', 'fakeInput']
+
+  static values = {
+    view: String,
+    timezone: String,
+    format: String,
+    enableTime: Boolean,
+    pickerFormat: String,
+    firstDayOfWeek: Number,
+    time24Hr: Boolean,
+  }
+
+  get browserZone() {
+    const time = DateTime.local()
+
+    return time.zoneName
+  }
+
+  get initialValue() {
+    if (this.isOnShow || this.isOnIndex) {
+      return this.context.element.innerText
+    } if (this.isOnEdit) {
+      return this.inputTarget.value
+    }
+
+    return null
+  }
+
+  get isOnIndex() {
+    return this.viewValue === 'index'
+  }
+
+  get isOnEdit() {
+    return this.viewValue === 'edit'
+  }
+
+  get isOnShow() {
+    return this.viewValue === 'show'
+  }
+
+  // Parse the time as if it were UTC
+  get parsedValue() {
+    return DateTime.fromISO(this.initialValue, { zone: 'UTC' })
+  }
+
+  get displayTimezone() {
+    return this.timezoneValue || this.browserZone
+  }
 
   connect() {
+    if (this.isOnShow || this.isOnIndex) {
+      this.initShow()
+    } else if (this.isOnEdit) {
+      this.initEdit()
+    }
+  }
+
+  // Turns the value in the controller wrapper into the timezone of the browser
+  initShow() {
+    this.context.element.innerText = this.parsedValue.setZone(this.displayTimezone).toFormat(this.formatValue)
+  }
+
+  initEdit() {
     const options = {
       enableTime: false,
       enableSeconds: false,
       // eslint-disable-next-line camelcase
-      time_24hr: false,
+      time_24hr: this.time24HrValue,
       locale: {
         firstDayOfWeek: 0,
       },
       altInput: true,
+      onChange: this.onChange.bind(this),
     }
-    const enableTime = castBoolean(this.inputTarget.dataset.enableTime)
 
     // Set the format of the displayed input field.
-    options.altFormat = this.inputTarget.dataset.pickerFormat
-
-    // Disable native input in mobile browsers
-    options.disableMobile = this.inputTarget.dataset.disableMobile
+    options.altFormat = this.pickerFormatValue
 
     // Set first day of the week.
-    options.locale.firstDayOfWeek = this.inputTarget.dataset.firstDayOfWeek
+    options.locale.firstDayOfWeek = this.firstDayOfWeekValue
 
     // Enable time if needed.
-    options.enableTime = enableTime
-    options.enableSeconds = enableTime
-
-    let currentValue
+    options.enableTime = this.enableTimeValue
+    options.enableSeconds = this.enableTimeValue
 
     // enable timezone display
-    if (enableTime) {
-      currentValue = DateTime.fromISO(this.inputTarget.value, { zone: window.Avo.configuration.timezone })
-      currentValue = currentValue.setZone(this.inputTarget.dataset.timezone)
-      currentValue = currentValue.toISO()
+    if (this.enableTimeValue) {
+      options.defaultDate = this.parsedValue.setZone(this.displayTimezone).toISO()
 
       options.dateFormat = 'Y-m-d H:i:S'
-      // eslint-disable-next-line camelcase
-      options.time_24hr = castBoolean(this.inputTarget.dataset.time24hr)
-      // this.timezone = Intl.DateTimeFormat().resolvedOptions().timeZone
-      options.appTimezone = this.inputTarget.dataset.timezone
     } else {
       // Because the browser treats the date like a timestamp and updates it ot 00:00 hour, when on a western timezone the date will be converted with one day offset.
       // Ex: 2022-01-30 will render as 2022-01-29 on an American timezone
-      currentValue = universalTimestamp(this.inputTarget.value)
+      options.defaultDate = universalTimestamp(this.initialValue)
     }
 
-    options.defaultDate = currentValue
+    flatpickr(this.fakeInputTarget, options)
+
+    this.updateRealInput(this.parsedValue.setZone(this.displayTimezone).toISO())
+  }
+
+  onChange(selectedDates) {
+    let time
+
+    if (this.timezoneValue) {
+      time = DateTime.fromISO(selectedDates[0].toISOString()).setZone('UTC', { keepLocalTime: true })
+    } else {
+      time = DateTime.fromISO(selectedDates[0].toISOString()).setZone('UTC', { keepLocalTime: false })
+    }
+    this.updateRealInput(time)
+  }
 
-    flatpickr(this.inputTarget, options)
+  updateRealInput(value) {
+    this.inputTarget.value = value
   }
 }

data/app/views/avo/partials/_javascript.html.erb

@@ -1,6 +1,6 @@
 <%= javascript_tag nonce: true do %>
   window.Avo = window.Avo || { configuration: {} }
   Avo.configuration.timezone = '<%= Avo.configuration.timezone %>'
-  Avo.configuration.root_path = '<%= Avo.configuration.root_path %>'
+  Avo.configuration.root_path = '<%= Avo::App.root_path %>'
   Avo.configuration.search_debounce = '<%= Avo.configuration.search_debounce %>'
 <% end %>

data/config/routes.rb

@@ -23,7 +23,7 @@ Avo::Engine.routes.draw do
     delete "/:resource_name/:id/active_storage_attachments/:attachment_name/:attachment_id", to: "attachments#destroy"
 
     # Ordering
-    patch "/:resource_name/:id/order", to: "resources#order", as: "order"
+    patch "/:resource_name/:id/order", to: "resources#order"
     patch "/:resource_name/:id/:related_name/:related_id/order", to: "associations#order", as: "associations_order"
 
     # Actions

data/lib/avo/app.rb

@@ -29,21 +29,14 @@ module Avo
         end
       end
 
-      # Renerate a dynamic root path using the URIService
-      def root_path(paths: [], query: {}, **args)
-        Avo::Services::URIService.parse(view_context.avo.root_url.to_s)
-          .append_paths(paths)
-          .append_query(query)
-          .to_s
-      end
-
-      def init(request:, context:, current_user:, view_context:, params:)
+      def init(request:, context:, current_user:, root_path:, view_context:, params:)
         self.error_messages = []
+        self.request = request
         self.context = context
         self.current_user = current_user
-        self.params = params
-        self.request = request
+        self.root_path = root_path
         self.view_context = view_context
+        self.params = params
 
         self.license = Licensing::LicenseManager.new(Licensing::HQ.new(request).response).license
         self.translation_enabled = license.has(:localization)

data/lib/avo/base_card.rb

@@ -59,7 +59,13 @@ module Avo
     def frame_url(enforced_range: nil, params: {})
       enforced_range ||= initial_range || ranges.first
 
-      Avo::App.view_context.avo.dashboard_card_path(dashboard.id, id, turbo_frame: turbo_frame, index: index, range: enforced_range, **params.permit!)
+      # append the parent params to the card request
+      begin
+        other_params = "&#{params.permit!.to_h.map { |k, v| "#{k}=#{v}" }.join("&")}"
+      rescue
+      end
+
+      "#{Avo::App.root_path}/dashboards/#{dashboard.id}/cards/#{id}?turbo_frame=#{turbo_frame}&index=#{index}&range=#{enforced_range}#{other_params}"
     end
 
     def card_classes

data/lib/avo/base_resource.rb

@@ -8,7 +8,6 @@ module Avo
     include Avo::Concerns::HasModel
     include Avo::Concerns::HasFields
     include Avo::Concerns::HasStimulusControllers
-    include Avo::Concerns::ModelClassConstantized
 
     delegate :view_context, to: ::Avo::App
     delegate :simple_format, :content_tag, to: :view_context
@@ -30,6 +29,7 @@ module Avo
     class_attribute :search_query, default: nil
     class_attribute :search_query_help, default: ""
     class_attribute :includes, default: []
+    class_attribute :model_class
     class_attribute :translation_key
     class_attribute :default_view_type, default: :table
     class_attribute :devise_password_optional, default: false

data/lib/avo/concerns/handles_field_args.rb

@@ -28,7 +28,7 @@ module Avo
         add_prop_from_args args, name: name, default: default, type: :array
       end
 
-      def add_string_prop(args, name, default = [])
+      def add_string_prop(args, name, default = nil)
         add_prop_from_args args, name: name, default: default, type: :string
       end
     end

data/lib/avo/dashboards/base_dashboard.rb

@@ -65,7 +65,7 @@ module Avo
         end
 
         def navigation_path
-          Avo::App.view_context.avo.dashboard_path id
+          "#{Avo::App.root_path}/dashboards/#{id}"
         end
 
         def is_visible?

data/lib/avo/fields/date_field.rb

@@ -3,7 +3,6 @@ module Avo
     class DateField < TextField
       attr_reader :first_day_of_week
       attr_reader :picker_format
-      attr_reader :disable_mobile
       attr_reader :format
       attr_reader :relative
 
@@ -14,7 +13,6 @@ module Avo
         @picker_format = args[:picker_format].present? ? args[:picker_format] : "Y-m-d"
         @format = args[:format].present? ? args[:format] : :long
         @relative = args[:relative].present? ? args[:relative] : false
-        @disable_mobile = args[:disable_mobile].present? ? args[:disable_mobile] : false
       end
 
       def formatted_value

data/lib/avo/fields/date_time_field.rb

@@ -2,25 +2,29 @@ module Avo
   module Fields
     class DateTimeField < DateField
       attr_reader :format
+      attr_reader :picker_format
       attr_reader :time_24hr
       attr_reader :timezone
 
       def initialize(id, **args, &block)
         super(id, **args, &block)
 
-        @picker_format = args[:picker_format].present? ? args[:picker_format] : "Y-m-d H:i:S"
-        @time_24hr = args[:time_24hr].present? ? args[:time_24hr] : false
-        @timezone = args[:timezone].present? ? args[:timezone] : Rails.application.config.time_zone
+        add_boolean_prop args, :time_24hr
+        add_string_prop args, :picker_format, "Y-m-d H:i:S"
+        add_string_prop args, :format, "yyyy-LL-dd TT"
+        add_string_prop args, :timezone
       end
 
       def formatted_value
         return nil if value.nil?
 
-        if @format.is_a?(Symbol)
-          value.to_time.in_time_zone(timezone).to_formatted_s(@format)
-        else
-          value.to_time.in_time_zone(timezone).strftime(@format)
-        end
+        value.utc.to_time.iso8601
+      end
+
+      def edit_formatted_value
+        return nil if value.nil?
+
+        value.utc.iso8601
       end
 
       def fill_field(model, key, value, params)
@@ -32,10 +36,18 @@ module Avo
 
         return model if value.blank?
 
-        model[id] = value.to_time.in_time_zone(Rails.application.config.time_zone)
+        model[id] = utc_time(value)
 
         model
       end
+
+      def utc_time(value)
+        if timezone.present?
+          ActiveSupport::TimeZone.new(timezone).local_to_utc(Time.parse(value))
+        else
+          value
+        end
+      end
     end
   end
 end

data/lib/avo/fields/has_base_field.rb

@@ -29,9 +29,7 @@ module Avo
       end
 
       def frame_url
-        Avo::Services::URIService.parse(@resource.record_path)
-          .append_path(id.to_s)
-          .append_query(turbo_frame: turbo_frame.to_s).to_s
+        "#{@resource.record_path}/#{id}?turbo_frame=#{turbo_frame}"
       end
 
       # The value

data/lib/avo/fields/has_one_field.rb

@@ -22,10 +22,7 @@ module Avo
       end
 
       def frame_url
-        Avo::Services::URIService.parse(@resource.record_path)
-          .append_paths(id, value.id)
-          .append_query(turbo_frame: turbo_frame)
-          .to_s
+        "#{@resource.record_path}/#{id}/#{value.id}?turbo_frame=#{turbo_frame}"
       end
 
       def fill_field(model, key, value, params)

data/lib/avo/menu/builder.rb

@@ -5,13 +5,6 @@ class Avo::Menu::Builder
     end
   end
 
-  delegate :context, to: Avo::App
-  delegate :current_user, to: Avo::App
-  delegate :params, to: Avo::App
-  delegate :request, to: Avo::App
-  delegate :root_path, to: Avo::App
-  delegate :view_context, to: Avo::App
-
   def initialize(name: nil, items: [])
     @menu = Avo::Menu::Menu.new
 
@@ -67,7 +60,7 @@ class Avo::Menu::Builder
   # Add all the tools
   def all_tools(**args)
     Avo::App.tools_for_navigation.each do |tool|
-      link tool.humanize, path: root_path(paths: [tool])
+      link tool.humanize, path: "#{root_path}/#{tool}"
     end
   end
 
@@ -75,4 +68,10 @@ class Avo::Menu::Builder
   def build
     @menu
   end
+
+  protected
+
+  def root_path
+    Avo::App.root_path
+  end
 end

data/lib/avo/version.rb

@@ -1,3 +1,3 @@
 module Avo
-  VERSION = "2.9.1.pre7" unless const_defined?(:VERSION)
+  VERSION = "2.9.2.pre1" unless const_defined?(:VERSION)
 end

data/lib/avo.rb

@@ -5,7 +5,6 @@ require_relative "avo/engine" if defined?(Rails)
 loader = Zeitwerk::Loader.for_gem
 loader.inflector.inflect(
   "html" => "HTML",
-  "uri_service" => "URIService",
   "has_html_attributes" => "HasHTMLAttributes"
 )
 loader.ignore("#{__dir__}/generators")