avo 2.45.0 → 3.0.0.beta1

data/app/controllers/avo/associations_controller.rb

@@ -2,18 +2,16 @@ require_dependency "avo/base_controller"
 
 module Avo
   class AssociationsController < BaseController
-    before_action :set_model, only: [:show, :index, :new, :create, :destroy, :order]
-    before_action :hydrate_resource, only: [:show, :index, :new, :create, :destroy, :order]
+    before_action :set_record, only: [:show, :index, :new, :create, :destroy]
     before_action :set_related_resource_name
-    before_action :set_related_resource, only: [:show, :index, :new, :create, :destroy, :order]
+    before_action :set_related_resource, only: [:show, :index, :new, :create, :destroy]
     before_action :set_related_authorization
     before_action :set_reflection_field
-    before_action :set_related_model, only: [:show, :order]
-    before_action :hydrate_related_resource, only: [:show, :index, :create, :destroy, :order]
+    before_action :set_related_record, only: [:show]
     before_action :set_reflection
-    before_action :set_attachment_class, only: [:show, :index, :new, :create, :destroy, :order]
-    before_action :set_attachment_resource, only: [:show, :index, :new, :create, :destroy, :order]
-    before_action :set_attachment_model, only: [:create, :destroy, :order]
+    before_action :set_attachment_class, only: [:show, :index, :new, :create, :destroy]
+    before_action :set_attachment_resource, only: [:show, :index, :new, :create, :destroy]
+    before_action :set_attachment_record, only: [:create, :destroy]
     before_action :authorize_index_action, only: :index
     before_action :authorize_attach_action, only: :new
     before_action :authorize_detach_action, only: :destroy
@@ -21,55 +19,55 @@ module Avo
     def index
       @parent_resource = @resource.dup
       @resource = @related_resource
-      @parent_model = @parent_resource.find_record(params[:id], params: params)
-      @parent_resource.hydrate(model: @parent_model)
-      association_name = BaseResource.valid_association_name(@parent_model, params[:related_name])
-      @query = @related_authorization.apply_policy @parent_model.send(association_name)
+      @parent_record = @parent_resource.find_record(params[:id], params: params)
+      @parent_resource.hydrate(record: @parent_record)
+      association_name = BaseResource.valid_association_name(@parent_record, params[:related_name])
+      @query = @related_authorization.apply_policy @parent_record.send(association_name)
       @association_field = @parent_resource.get_field params[:related_name]
 
       if @association_field.present? && @association_field.scope.present?
-        @query = Avo::Hosts::AssociationScopeHost.new(block: @association_field.scope, query: @query, parent: @parent_model).handle
+        @query = Avo::ExecutionContext.new(target: @association_field.scope, query: @query, parent: @parent_record).handle
       end
 
       super
     end
 
     def show
-      @parent_resource, @parent_model = @resource, @model
+      @parent_resource, @parent_record = @resource, @record
 
-      @resource, @model = @related_resource, @related_model
+      @resource, @record = @related_resource, @related_record
 
       super
     end
 
     def new
-      @resource.hydrate(model: @model)
+      @resource.hydrate(record: @record)
 
-      if @field.present? && !@field.searchable
+      if @field.present? && !@field.is_searchable?
         query = @related_authorization.apply_policy @attachment_class
 
         # Add the association scope to the query scope
         if @field.attach_scope.present?
-          query = Avo::Hosts::AssociationScopeHost.new(block: @field.attach_scope, query: query, parent: @model).handle
+          query = Avo::ExecutionContext.new(target: @field.attach_scope, query: query, parent: @record).handle
         end
 
-        @options = query.all.map do |model|
-          [model.send(@attachment_resource.class.title), model.id]
+        @options = query.all.map do |record|
+          [@attachment_resource.new(record: record).record_title, record.id]
         end
       end
     end
 
     def create
-      association_name = BaseResource.valid_association_name(@model, params[:related_name])
+      association_name = BaseResource.valid_association_name(@record, params[:related_name])
 
       if reflection_class == "HasManyReflection"
-        @model.send(association_name) << @attachment_model
+        @record.send(association_name) << @attachment_record
       else
-        @model.send("#{association_name}=", @attachment_model)
+        @record.send("#{association_name}=", @attachment_record)
       end
 
       respond_to do |format|
-        if @model.save
+        if @record.save
           format.html { redirect_back fallback_location: resource_view_response_path, notice: t("avo.attachment_class_attached", attachment_class: @related_resource.name) }
         else
           format.html { render :new }
@@ -78,12 +76,12 @@ module Avo
     end
 
     def destroy
-      association_name = BaseResource.valid_association_name(@model, params[:related_name])
+      association_name = BaseResource.valid_association_name(@record, params[:related_name])
 
       if reflection_class == "HasManyReflection"
-        @model.send(association_name).delete @attachment_model
+        @record.send(association_name).destroy @attachment_record
       else
-        @model.send("#{association_name}=", nil)
+        @record.send("#{association_name}=", nil)
       end
 
       respond_to do |format|
@@ -91,17 +89,10 @@ module Avo
       end
     end
 
-    def order
-      @parent_resource = @resource.dup
-      @resource, @model = @related_resource, @related_model
-
-      super
-    end
-
     private
 
     def set_reflection
-      @reflection = @model._reflections[params[:related_name].to_s]
+      @reflection = @record._reflections[params[:related_name].to_s]
     end
 
     def set_attachment_class
@@ -109,16 +100,16 @@ module Avo
     end
 
     def set_attachment_resource
-      @attachment_resource = @field.use_resource || (App.get_resource_by_model_name @attachment_class)
+      @attachment_resource = @field.use_resource || (Avo.resource_manager.get_resource_by_model_class @attachment_class)
     end
 
-    def set_attachment_model
-      @attachment_model = @related_resource.find_record attachment_id, params: params
+    def set_attachment_record
+      @attachment_record = @related_resource.find_record attachment_id, params: params
     end
 
     def set_reflection_field
       @field = @resource.get_field_definitions.find { |f| f.id == @related_resource_name.to_sym }
-      @field.hydrate(resource: @resource, model: @model, view: :new)
+      @field.hydrate(resource: @resource, record: @record, view: :new)
     rescue
     end
 
@@ -127,7 +118,7 @@ module Avo
     end
 
     def reflection_class
-      reflection = @model._reflections[params[:related_name]]
+      reflection = @record._reflections[params[:related_name]]
 
       klass = reflection.class.name.demodulize.to_s
       klass = reflection.through_reflection.class.name.demodulize.to_s if klass == "ThroughReflection"
@@ -136,7 +127,7 @@ module Avo
     end
 
     def authorize_if_defined(method)
-      @authorization.set_record(@model)
+      @authorization.set_record(@record)
 
       if @authorization.has_method?(method.to_sym)
         @authorization.authorize_action method.to_sym
@@ -158,8 +149,8 @@ module Avo
     private
 
     def set_related_authorization
-      @related_authorization = if related_resource
-        related_resource.authorization(user: _current_user)
+      @related_authorization = if @related_resource.present?
+        @related_resource.authorization(user: _current_user)
       else
         Services::AuthorizationService.new _current_user
       end

data/app/controllers/avo/attachments_controller.rb

@@ -4,17 +4,17 @@ module Avo
   class AttachmentsController < ApplicationController
     before_action :set_resource_name, only: [:destroy, :create]
     before_action :set_resource, only: [:destroy, :create]
-    before_action :set_model, only: [:destroy, :create]
+    before_action :set_record, only: [:destroy, :create]
 
     def create
       blob = ActiveStorage::Blob.create_and_upload! io: params[:file].to_io, filename: params[:filename]
-      association_name = BaseResource.valid_attachment_name(@model, params[:attachment_key])
+      association_name = BaseResource.valid_attachment_name(@record, params[:attachment_key])
 
       if association_name.blank?
         raise ActionController::BadRequest.new("Could not find the attachment association for #{params[:attachment_key]} (check the `attachment_key` for this Trix field)")
       end
 
-      @model.send(association_name).attach blob
+      @record.send(association_name).attach blob
 
       render json: {
         url: main_app.url_for(blob),
@@ -47,7 +47,7 @@ module Avo
     private
 
     def authorized_to(action)
-      @resource.authorization.authorize_action("#{action}_#{params[:attachment_name]}?", record: @model, raise_exception: false)
+      @resource.authorization.authorize_action("#{action}_#{params[:attachment_name]}?", record: @record, raise_exception: false)
     end
   end
 end

data/app/controllers/avo/base_controller.rb

@@ -6,14 +6,13 @@ module Avo
 
     before_action :set_resource_name
     before_action :set_resource
-    before_action :hydrate_resource
     before_action :set_applied_filters, only: :index
-    before_action :set_model, only: [:show, :edit, :destroy, :update, :order]
-    before_action :set_model_to_fill
+    before_action :set_record, only: [:show, :edit, :destroy, :update, :preview]
+    before_action :set_record_to_fill
     before_action :set_edit_title_and_breadcrumbs, only: [:edit, :update]
-    before_action :fill_model, only: [:create, :update]
+    before_action :fill_record, only: [:create, :update]
     # Don't run base authorizations for associations
-    before_action :authorize_base_action, if: -> { controller_name != "associations" }
+    before_action :authorize_base_action, except: :preview, if: -> { controller_name != "associations" }
     before_action :set_pagy_locale, only: :index
 
     def index
@@ -29,11 +28,6 @@ module Avo
         @query = @resource.class.query_scope
       end
 
-      # Remove default_scope for index view if no parent_resource present
-      if @resource.unscoped_queries_on_index && @parent_resource.blank?
-        @query = @query.unscoped
-      end
-
       # Eager load the associations
       if @resource.includes.present?
         @query = @query.includes(*@resource.includes)
@@ -52,7 +46,7 @@ module Avo
         field_id = @index_params[:sort_by].to_sym
         field = @resource.get_field_definitions.find { |field| field.id == field_id }
         @query = if field&.sortable.is_a?(Proc)
-          field.sortable.call(@query, @index_params[:sort_direction])
+          Avo::ExecutionContext.new(target: field.sortable, query: @query, direction: @index_params[:sort_direction]).handle
         else
           @query.order("#{@resource.model_class.table_name}.#{@index_params[:sort_by]} #{@index_params[:sort_direction]}")
         end
@@ -65,57 +59,62 @@ module Avo
         ).apply_query request, @query, filter_value
       end
 
-      apply_pagination
+      extra_pagy_params = {}
+
+      # Reset open filters when a user navigates to a new page
+      extra_pagy_params[:keep_filters_panel_open] = if params[:keep_filters_panel_open] == "1"
+        "0"
+      end
+
+      safe_call :set_and_apply_scopes
+      safe_call :apply_dynamic_filters
+
+      @pagy, @records = pagy(pagy_query, items: @index_params[:per_page], link_extra: "data-turbo-frame=\"#{params[:turbo_frame]}\"", size: [1, 2, 2, 1], params: extra_pagy_params)
 
-      # Create resources for each model
-      @resources = @models.map do |model|
-        @resource.hydrate(model: model, params: params).dup
+      # Create resources for each record
+      @resources = @records.map do |record|
+        @resource.hydrate(record: record, params: params).dup
       end
     end
 
     def show
-      @resource.hydrate(model: @model, view: :show, user: _current_user, params: params)
+      @resource.hydrate(record: @record, view: :show, user: _current_user, params: params).detect_fields
 
       set_actions
 
       @page_title = @resource.default_panel_name.to_s
 
       # If we're accessing this resource via another resource add the parent to the breadcrumbs.
-      if params[:via_resource_class].present? && params[:via_resource_id].present?
-        via_resource = Avo::App.get_resource(params[:via_resource_class]).dup
-        via_model = via_resource.find_record params[:via_resource_id], params: params
-        via_resource.hydrate model: via_model
+      if params[:via_resource_class].present? && params[:via_record_id].present?
+        via_resource = Avo.resource_manager.get_resource(params[:via_resource_class])
+        via_record = via_resource.find_record params[:via_record_id], params: params
+        via_resource = via_resource.new record: via_record
 
         add_breadcrumb via_resource.plural_name, resources_path(resource: via_resource)
-        add_breadcrumb via_resource.model_title, resource_path(model: via_model, resource: via_resource)
+        add_breadcrumb via_resource.record_title, resource_path(record: via_record, resource: via_resource)
       else
         add_breadcrumb @resource.plural_name.humanize, resources_path(resource: @resource)
       end
 
-      add_breadcrumb @resource.model_title
+      add_breadcrumb @resource.record_title
       add_breadcrumb I18n.t("avo.details").upcase_first
     end
 
     def new
-      @model = @resource.model_class.new
-      @resource = @resource.hydrate(model: @model, view: :new, user: _current_user)
-
-      # Handle special cases when creating a new record via a belongs_to relationship
-      if params[:via_belongs_to_resource_class].present?
-        return render turbo_stream: turbo_stream.append('attach_modal', partial: 'avo/base/new_via_belongs_to')
-      end
+      @record = @resource.model_class.new
+      @resource = @resource.hydrate(record: @record, view: :new, user: _current_user)
 
       set_actions
 
       @page_title = @resource.default_panel_name.to_s
 
       if is_associated_record?
-        via_resource = Avo::App.get_resource_by_model_name(params[:via_relation_class]).dup
-        via_model = via_resource.find_record params[:via_resource_id], params: params
-        via_resource.hydrate model: via_model
+        via_resource = Avo.resource_manager.get_resource_by_model_class(params[:via_relation_class])
+        via_record = via_resource.find_record params[:via_record_id], params: params
+        via_resource = via_resource.new record: via_record
 
         add_breadcrumb via_resource.plural_name, resources_path(resource: via_resource)
-        add_breadcrumb via_resource.model_title, resource_path(model: via_model, resource: via_resource)
+        add_breadcrumb via_resource.record_title, resource_path(record: via_record, resource: via_resource)
       end
 
       add_breadcrumb @resource.plural_name.humanize, resources_path(resource: @resource)
@@ -123,37 +122,37 @@ module Avo
     end
 
     def create
-      # model gets instantiated and filled in the fill_model method
-      saved = save_model
-      @resource.hydrate(model: @model, view: :new, user: _current_user)
+      # record gets instantiated and filled in the fill_record method
+      saved = save_record
+      @resource.hydrate(record: @record, view: :new, user: _current_user)
 
       # This means that the record has been created through another parent record and we need to attach it somehow.
-      if params[:via_resource_id].present? && params[:via_belongs_to_resource_class].nil?
-        @reflection = @model._reflections[params[:via_relation]]
+      if params[:via_record_id].present?
+        @reflection = @record._reflections[params[:via_relation]]
         # Figure out what kind of association does the record have with the parent record
 
         # Fills in the required infor for belongs_to and has_many
         # Get the foreign key and set it to the id we received in the params
         if @reflection.is_a?(ActiveRecord::Reflection::BelongsToReflection) || @reflection.is_a?(ActiveRecord::Reflection::HasManyReflection)
-          related_resource = Avo::App.get_resource_by_model_name params[:via_relation_class]
-          related_record = related_resource.find_record params[:via_resource_id], params: params
+          related_resource = Avo.resource_manager.get_resource_by_model_class params[:via_relation_class]
+          related_record = related_resource.find_record params[:via_record_id], params: params
 
-          @model.send("#{@reflection.foreign_key}=", related_record.id)
-          @model.save
+          @record.send("#{@reflection.foreign_key}=", related_record.id)
+          @record.save
         end
 
         # For when working with has_one, has_one_through, has_many_through, has_and_belongs_to_many, polymorphic
         if @reflection.is_a? ActiveRecord::Reflection::ThroughReflection
           # find the record
-          via_resource = ::Avo::App.get_resource_by_model_name(params[:via_relation_class]).dup
-          @related_record = via_resource.find_record params[:via_resource_id], params: params
-          association_name = BaseResource.valid_association_name(@model, params[:via_relation])
+          via_resource = Avo.resource_manager.get_resource_by_model_class(params[:via_relation_class])
+          @related_record = via_resource.find_record params[:via_record_id], params: params
+          association_name = BaseResource.valid_association_name(@record, params[:via_relation])
 
           if params[:via_association_type] == "has_one"
             # On has_one scenarios we should switch the @record and @related_record
-            @related_record.send("#{@reflection.parent_reflection.inverse_of.name}=", @model)
+            @related_record.send("#{@reflection.parent_reflection.inverse_of.name}=", @record)
           else
-            @model.send(association_name) << @related_record
+            @record.send(association_name) << @related_record
           end
         end
       end
@@ -174,9 +173,9 @@ module Avo
     end
 
     def update
-      # model gets instantiated and filled in the fill_model method
-      saved = save_model
-      @resource = @resource.hydrate(model: @model, view: :edit, user: _current_user)
+      # record gets instantiated and filled in the fill_record method
+      saved = save_record
+      @resource = @resource.hydrate(record: @record, view: :edit, user: _current_user)
       set_actions
 
       if saved
@@ -194,55 +193,46 @@ module Avo
       end
     end
 
-    def order
-      direction = params[:direction].to_sym
+    def preview
+      @resource.hydrate(record: @record, view: :show, user: _current_user, params: params)
 
-      if direction.present?
-        @resource
-          .hydrate(model: @model, params: params)
-          .ordering_host
-          .order direction
-      end
-
-      respond_to do |format|
-        format.html { redirect_to params[:referrer] || resources_path(resource: @resource) }
-      end
+      render layout: params[:turbo_frame].blank?
     end
 
     private
 
-    def save_model
+    def save_record
       perform_action_and_record_errors do
-        save_model_action
+        save_record_action
       end
     end
 
-    def save_model_action
-      @model.save!
+    def save_record_action
+      @record.save!
     end
 
     def destroy_model
       perform_action_and_record_errors do
-        destroy_model_action
+        destroy_record_action
       end
     end
 
-    def destroy_model_action
-      @model.destroy!
+    def destroy_record_action
+      @record.destroy!
     end
 
     def perform_action_and_record_errors(&block)
       begin
         succeeded = block.call
       rescue => exception
-        # In case there's an error somewhere else than the model
+        # In case there's an error somewhere else than the record
         # Example: When you save a license that should create a user for it and creating that user throws and error.
         # Example: When you Try to delete a record and has a foreign key constraint.
         exception_message = exception.message
       end
 
-      # Add the errors from the model
-      @errors = @model.errors.full_messages.reject { |error| exception_message.include? error }.unshift exception_message
+      # Add the errors from the record
+      @errors = @record.errors.full_messages.reject { |error| exception_message.include? error }.unshift exception_message
 
       succeeded
     end
@@ -300,7 +290,7 @@ module Avo
         @index_params[:per_page] = cookies[:per_page]
       end
 
-      if @parent_model.present?
+      if @parent_record.present?
         @index_params[:per_page] = Avo.configuration.via_per_page
       end
 
@@ -319,8 +309,20 @@ module Avo
       @index_params[:sort_direction] = params[:sort_direction] || :desc
 
       # View types
-      @index_params[:view_type] = params[:view_type] || @resource.default_view_type || Avo.configuration.default_view_type
-      @index_params[:available_view_types] = @resource.available_view_types
+      available_view_types = @resource.available_view_types
+      @index_params[:available_view_types] = available_view_types
+
+      @index_params[:view_type] = if params[:view_type].present?
+        params[:view_type]
+      elsif available_view_types.size == 1
+        available_view_types.first
+      else
+        @resource.default_view_type || Avo.configuration.default_view_type
+      end
+
+      if available_view_types.exclude? @index_params[:view_type].to_sym
+        raise "View type '#{@index_params[:view_type]}' is unavailable for #{@resource.class}."
+      end
     end
 
     def set_filters
@@ -338,7 +340,7 @@ module Avo
       @actions = @resource
         .get_actions
         .map do |action|
-          action[:class].new(model: @model, resource: @resource, view: @view, arguments: action[:arguments])
+          action[:class].new(record: @record, resource: @resource, view: @view, arguments: action[:arguments])
         end
         .select do |action|
           action.visible_in_view(parent_resource: @parent_resource)
@@ -392,45 +394,41 @@ module Avo
     end
 
     def set_edit_title_and_breadcrumbs
-      @resource = @resource.hydrate(model: @model, view: :edit, user: _current_user)
+      @resource = @resource.hydrate(record: @record, view: :edit, user: _current_user)
       @page_title = @resource.default_panel_name.to_s
 
       last_crumb_args = {}
       # If we're accessing this resource via another resource add the parent to the breadcrumbs.
-      if params[:via_resource_class].present? && params[:via_resource_id].present?
-        via_resource = Avo::App.get_resource(params[:via_resource_class]).dup
-        via_model = via_resource.find_record params[:via_resource_id], params: params
-        via_resource.hydrate model: via_model
+      if params[:via_resource_class].present? && params[:via_record_id].present?
+        via_resource = Avo.resource_manager.get_resource(params[:via_resource_class])
+        via_record = via_resource.find_record params[:via_record_id], params: params
+        via_resource = via_resource.new record: via_record
 
         add_breadcrumb via_resource.plural_name, resources_path(resource: @resource)
-        add_breadcrumb via_resource.model_title, resource_path(model: via_model, resource: via_resource)
+        add_breadcrumb via_resource.record_title, resource_path(record: via_record, resource: via_resource)
 
         last_crumb_args = {
           via_resource_class: params[:via_resource_class],
-          via_resource_id: params[:via_resource_id]
+          via_record_id: params[:via_record_id]
         }
       else
         add_breadcrumb @resource.plural_name.humanize, resources_path(resource: @resource)
       end
 
-      add_breadcrumb @resource.model_title, resource_path(model: @resource.model, resource: @resource, **last_crumb_args)
+      add_breadcrumb @resource.record_title, resource_path(record: @resource.record, resource: @resource, **last_crumb_args)
       add_breadcrumb t("avo.edit").humanize
     end
 
     def create_success_action
-      return render "close_modal_and_reload_field" if params[:via_belongs_to_resource_class].present?
-
       respond_to do |format|
         format.html { redirect_to after_create_path, notice: create_success_message}
       end
     end
 
     def create_fail_action
-      flash.now[:error] = create_fail_message
-
       respond_to do |format|
+        flash.now[:error] = create_fail_message
         format.html { render :new, status: :unprocessable_entity }
-        format.turbo_stream { render "create_fail_action" }
       end
     end
 
@@ -445,13 +443,13 @@ module Avo
     def after_create_path
       # If this is an associated record return to the association show page
       if is_associated_record?
-        parent_resource = ::Avo::App.get_resource_by_model_name(params[:via_relation_class]).dup
-        association_name = BaseResource.valid_association_name(@model, params[:via_relation])
+        parent_resource = Avo.resource_manager.get_resource_by_model_class(params[:via_relation_class])
+        association_name = BaseResource.valid_association_name(@record, params[:via_relation])
 
         return resource_view_path(
-          model: @model.send(association_name),
+          record: @record.send(association_name),
           resource: parent_resource,
-          resource_id: params[:via_resource_id]
+          resource_id: params[:via_record_id]
         )
       end
 
@@ -487,7 +485,7 @@ module Avo
 
     # Needs a different name, otwherwise, in some places, this can be called instead helpers.resource_view_path
     def resource_view_response_path
-      helpers.resource_view_path(model: @model, resource: @resource)
+      helpers.resource_view_path(record: @record, resource: @resource)
     end
 
     def destroy_success_action
@@ -497,10 +495,8 @@ module Avo
     end
 
     def destroy_fail_action
-      flash[:error] = destroy_fail_message
-
       respond_to do |format|
-        format.turbo_stream { render partial: "avo/partials/flash_alerts" }
+        format.html { redirect_back fallback_location: params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type]), error: destroy_fail_message }
       end
     end
 
@@ -522,14 +518,14 @@ module Avo
       if @resource.class.send(action) == :index
         resources_path(resource: @resource)
       elsif @resource.class.send(action) == :edit || Avo.configuration.resource_default_view == :edit
-        edit_resource_path(resource: @resource, model: @resource.model)
+        edit_resource_path(resource: @resource, record: @resource.record)
       else
-        resource_path(model: @model, resource: @resource)
+        resource_path(record: @record, resource: @resource)
       end
     end
 
     def is_associated_record?
-      params[:via_relation_class].present? && params[:via_resource_id].present?
+      params[:via_relation_class].present? && params[:via_record_id].present?
     end
 
     # Set pagy locale from params or from avo configuration, if both nil locale = "en"
@@ -537,8 +533,12 @@ module Avo
       @pagy_locale = locale.to_s || Avo.configuration.locale || "en"
     end
 
-    def apply_pagination
-      @pagy, @models = @resource.apply_pagination(index_params: @index_params, query: @query)
+    def safe_call(method)
+      send(method) if respond_to?(method, true)
+    end
+
+    def pagy_query
+      @query
     end
   end
 end