avo 2.12.0 → 2.13.1

data/app/controllers/avo/base_controller.rb

@@ -115,7 +115,7 @@ module Avo
         add_breadcrumb via_resource.model_title, resource_path(model: via_model, resource: via_resource)
       end
 
-      add_breadcrumb @resource.plural_name.humanize
+      add_breadcrumb @resource.plural_name.humanize, resources_path(resource: @resource)
       add_breadcrumb t("avo.new").humanize
     end
 
@@ -129,21 +129,14 @@ module Avo
         @reflection = @model._reflections[params[:via_relation]]
         # Figure out what kind of association does the record have with the parent record
 
-        # belongs_to
-        # has_many
+        # Fills in the required infor for belongs_to and has_many
         # Get the foreign key and set it to the id we received in the params
         if @reflection.is_a?(ActiveRecord::Reflection::BelongsToReflection) || @reflection.is_a?(ActiveRecord::Reflection::HasManyReflection)
-          foreign_key = @reflection.foreign_key
-          @model.send("#{foreign_key}=", params[:via_resource_id])
+          @model.send("#{@reflection.foreign_key}=", params[:via_resource_id])
           @model.save
         end
 
-        # has_one
-        # has_one_through
-
-        # has_many_through
-        # has_and_belongs_to_many
-        # polymorphic
+        # For when working with has_one, has_one_through, has_many_through, has_and_belongs_to_many, polymorphic
         if @reflection.is_a? ActiveRecord::Reflection::ThroughReflection
           # find the record
           via_resource = ::Avo::App.get_resource_by_model_name params[:via_relation_class]
@@ -153,13 +146,14 @@ module Avo
         end
       end
 
-      respond_to do |format|
-        if saved
-          format.html { redirect_to after_create_path, notice: "#{@resource.name} #{t("avo.was_successfully_created")}." }
-        else
-          flash.now[:error] = t "avo.you_missed_something_check_form"
-          format.html { render :new, status: :unprocessable_entity }
-        end
+      add_breadcrumb @resource.plural_name.humanize, resources_path(resource: @resource)
+      add_breadcrumb t("avo.new").humanize
+      set_actions
+
+      if saved
+        create_success_action
+      else
+        create_fail_action
       end
     end
 
@@ -171,26 +165,20 @@ module Avo
       # model gets instantiated and filled in the fill_model method
       saved = save_model
       @resource = @resource.hydrate(model: @model, view: :edit, user: _current_user)
+      set_actions
 
-      respond_to do |format|
-        if saved
-          format.html { redirect_to after_update_path, notice: "#{@resource.name} #{t("avo.was_successfully_updated")}." }
-        else
-          flash.now[:error] = t "avo.you_missed_something_check_form"
-          format.html { render :edit, status: :unprocessable_entity }
-        end
+      if saved
+        update_success_action
+      else
+        update_fail_action
       end
     end
 
     def destroy
-      respond_to do |format|
-        if destroy_model
-          format.html { redirect_to params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type]), notice: t("avo.resource_destroyed", attachment_class: @attachment_class) }
-        else
-          error_message = @errors.present? ? @errors.first : t("avo.failed")
-
-          format.html { redirect_back fallback_location: params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type]), error: error_message }
-        end
+      if destroy_model
+        destroy_success_action
+      else
+        destroy_fail_action
       end
     end
 
@@ -401,6 +389,27 @@ module Avo
       add_breadcrumb t("avo.edit").humanize
     end
 
+    def create_success_action
+      respond_to do |format|
+        format.html { redirect_to after_create_path, notice: create_success_message}
+      end
+    end
+
+    def create_fail_action
+      respond_to do |format|
+        flash.now[:error] = create_fail_message
+        format.html { render :new, status: :unprocessable_entity }
+      end
+    end
+
+    def create_success_message
+      "#{@resource.name} #{t("avo.was_successfully_created")}."
+    end
+
+    def create_fail_message
+      t "avo.you_missed_something_check_form"
+    end
+
     def after_create_path
       # If this is an associated record return to the association show page
       if params[:via_relation_class].present? && params[:via_resource_id].present?
@@ -412,12 +421,57 @@ module Avo
       redirect_path_from_resource_option(:after_create_path) || resource_path(model: @model, resource: @resource)
     end
 
+    def update_success_action
+      respond_to do |format|
+        format.html { redirect_to after_update_path, notice: update_success_message }
+      end
+    end
+
+    def update_fail_action
+      respond_to do |format|
+        flash.now[:error] = update_fail_message
+        format.html { render :edit, status: :unprocessable_entity }
+      end
+    end
+
+    def update_success_message
+      "#{@resource.name} #{t("avo.was_successfully_updated")}."
+    end
+
+    def update_fail_message
+      t "avo.you_missed_something_check_form"
+    end
+
     def after_update_path
       return params[:referrer] if params[:referrer].present?
 
       redirect_path_from_resource_option(:after_update_path) || resource_path(model: @model, resource: @resource)
     end
 
+    def destroy_success_action
+      respond_to do |format|
+        format.html { redirect_to after_destroy_path, notice: destroy_success_message }
+      end
+    end
+
+    def destroy_fail_action
+      respond_to do |format|
+        format.html { redirect_back fallback_location: params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type]), error: destroy_fail_message }
+      end
+    end
+
+    def destroy_success_message
+      t("avo.resource_destroyed", attachment_class: @attachment_class)
+    end
+
+    def destroy_fail_message
+      @errors.present? ? @errors.first : t("avo.failed")
+    end
+
+    def after_destroy_path
+      params[:referrer] || resources_path(resource: @resource, turbo_frame: params[:turbo_frame], view_type: params[:view_type])
+    end
+
     def redirect_path_from_resource_option(action = :after_update_path)
       return nil if @resource.class.send(action).blank?
 

data/app/controllers/avo/search_controller.rb

@@ -44,10 +44,13 @@ module Avo
     end
 
     def search_resource(resource)
-      query = resource.search_query.call(params: params).limit(8)
+      query =  Avo::Hosts::SearchScopeHost.new(
+        block: resource.search_query,
+        params: params,
+        scope: resource.class.scope.limit(8)
+      ).handle
 
-      # Figure out if this is a belongs_to search
-      query = apply_attach_scope query
+      query = apply_scope(query) if should_apply_any_scope?
 
       results = apply_search_metadata(query, resource)
 
@@ -67,22 +70,19 @@ module Avo
       [resource.name.pluralize.downcase, result_object]
     end
 
-    # Figure out if it's a belongs to search and if it has the attach_scope block present.
-    # If so, set the parent for those edit view and the parent with the grandparent for the new view.
-    def apply_attach_scope(query)
-      return query if params[:via_reflection_class].blank?
-
-      # Fetch the field
-      field = belongs_to_field
-
-      # No need to modify the query if there's no attach_scope present.
-      return query if field.attach_scope.blank?
-
-      # Try to fetch the parent.
-      if params[:via_reflection_id].present?
-        parent = params[:via_reflection_class].safe_constantize.find params[:via_reflection_id]
+    # When searching in a `has_many` association and will scope out the records against the parent record.
+    # This is also used when looking for `belongs_to` associations, and this method applies the parents `attach_scope` if present.
+    def apply_scope(query)
+      if should_apply_has_many_scope?
+        apply_has_many_scope
+      elsif should_apply_attach_scope?
+        apply_attach_scope(query, parent)
       end
+    end
 
+    # Parent passed as argument to be used as a variable instead of the method "def parent"
+    # Otherwise parent = params...safe_constantize... will try to call method "def parent="
+    def apply_attach_scope(query, parent)
       # If the parent is nil it probably means that someone's creating the record so it's not attached yet.
       # In these scenarios, try to find the grandparent for the new views where the parent is nil
       # and initialize the parent record with the grandparent attached so the user has the required information
@@ -94,8 +94,13 @@ module Avo
         )
       end
 
-      # Add to the query
-      Avo::Hosts::AssociationScopeHost.new(block: belongs_to_field.attach_scope, query: query, parent: parent).handle
+      Avo::Hosts::AssociationScopeHost.new(block: attach_scope, query: query, parent: parent).handle
+    end
+
+    def apply_has_many_scope
+      scope = parent.send(params[:via_association_id])
+
+      Avo::Hosts::SearchScopeHost.new(block: @resource.search_query, params: params, scope: scope).handle
     end
 
     def apply_search_metadata(models, avo_resource)
@@ -118,9 +123,41 @@ module Avo
       end
     end
 
-    def belongs_to_field
+    private
+
+    def should_apply_has_many_scope?
+      params[:via_association] == "has_many" && @resource.search_query.present?
+    end
+
+    def should_apply_attach_scope?
+      params[:via_association] == "belongs_to" && attach_scope.present?
+    end
+
+    def should_apply_any_scope?
+      should_apply_has_many_scope? || should_apply_attach_scope?
+    end
+
+    def attach_scope
+      @attach_scope ||= field&.attach_scope
+    end
+
+    def field
+      @field ||= fetch_field
+    end
+
+    def parent
+      @parent ||= fetch_parent
+    end
+
+    def fetch_field
       fields = ::Avo::App.get_resource_by_model_name(params[:via_reflection_class]).get_field_definitions
       fields.find { |f| f.id.to_s == params[:via_association_id] }
     end
+
+    def fetch_parent
+      return unless params[:via_reflection_id].present?
+
+      params[:via_reflection_class].safe_constantize.find params[:via_reflection_id]
+    end
   end
 end

data/app/javascript/js/controllers/menu_controller.js

@@ -22,8 +22,8 @@ export default class extends Controller {
   }
 
   get initiallyCollapsed() {
-    if (this.defaultState === 'collapsed') {
-      return this.userState === 'collapsed'
+    if (!this.userState) {
+      return this.defaultState === 'collapsed'
     }
 
     return this.userState === 'collapsed'

data/app/javascript/js/controllers/search_controller.js

@@ -48,6 +48,10 @@ export default class extends Controller {
     return this.dataset.viaAssociation === 'belongs_to'
   }
 
+  get isHasManySearch() {
+    return this.dataset.viaAssociation === 'has_many'
+  }
+
   get isGlobalSearch() {
     return this.dataset.searchResource === 'global'
   }
@@ -83,27 +87,50 @@ export default class extends Controller {
       params.global = true
     }
 
-    if (this.isBelongsToSearch) {
-      params = {
-        ...params,
-        // eslint-disable-next-line camelcase
-        via_association_id: this.dataset.viaAssociationId,
-        // eslint-disable-next-line camelcase
-        via_reflection_class: this.dataset.viaReflectionClass,
-        // eslint-disable-next-line camelcase
-        via_reflection_id: this.dataset.viaReflectionId,
-        // eslint-disable-next-line camelcase
-        via_parent_resource_id: this.dataset.viaParentResourceId,
-        // eslint-disable-next-line camelcase
-        via_parent_resource_class: this.dataset.viaParentResourceClass,
-        // eslint-disable-next-line camelcase
-        via_relation: this.dataset.viaRelation,
+    if (this.isBelongsToSearch || this.isHasManySearch) {
+      params = this.addAssociationParams(params)
+      params = this.addReflectionParams(params)
+
+      if (this.isBelongsToSearch) {
+        params = {
+          ...params,
+          // eslint-disable-next-line camelcase
+          via_parent_resource_id: this.dataset.viaParentResourceId,
+          // eslint-disable-next-line camelcase
+          via_parent_resource_class: this.dataset.viaParentResourceClass,
+          // eslint-disable-next-line camelcase
+          via_relation: this.dataset.viaRelation,
+        }
       }
     }
 
     return params
   }
 
+  addAssociationParams(params) {
+    params = {
+      ...params,
+      // eslint-disable-next-line camelcase
+      via_association: this.dataset.viaAssociation,
+      // eslint-disable-next-line camelcase
+      via_association_id: this.dataset.viaAssociationId,
+    }
+
+    return params
+  }
+
+  addReflectionParams(params) {
+    params = {
+      ...params,
+      // eslint-disable-next-line camelcase
+      via_reflection_class: this.dataset.viaReflectionClass,
+      // eslint-disable-next-line camelcase
+      via_reflection_id: this.dataset.viaReflectionId,
+    }
+
+    return params
+  }
+
   handleOnSelect({ item }) {
     if (this.isBelongsToSearch) {
       this.updateFieldAttribute(this.hiddenIdTarget, 'value', item._id)

data/app/views/avo/associations/new.html.erb

@@ -13,6 +13,7 @@
       <div class="flex-1 flex items-center justify-center px-0 lg:px-8 text-lg mt-8 mb-12">
         <% if @field.searchable %>
           <%= render Avo::Fields::BelongsToField::AutocompleteComponent.new form: form,
+            classes: input_classes("w-full"),
             field: @field,
             model_key: @field.target_resource&.model_key,
             foreign_key: 'related_id',

data/app/views/avo/dashboards/show.html.erb

@@ -1,4 +1,4 @@
-<%= render Avo::PanelComponent.new(title: @dashboard.name, description: @dashboard.description) do |c| %>
+<%= render Avo::PanelComponent.new(name: @dashboard.name, description: @dashboard.description) do |c| %>
   <% c.bare_content do %>
     <% if @dashboard.items.present? %>
       <div class="min-h-24">

data/app/views/avo/debug/index.html.erb

@@ -14,7 +14,7 @@
   hq_payload = Avo::Licensing::HQ.new(request).payload
 %>
 <div class="flex flex-col">
-  <%= render Avo::PanelComponent.new(title: 'Debug Avo', description: 'Use this page to debug the Avo license.') do |c| %>
+  <%= render Avo::PanelComponent.new(name: 'Debug Avo', description: 'Use this page to debug the Avo license.') do |c| %>
     <% c.tools do %>
     <% end %>
     <% c.bare_content do %>

data/app/views/avo/debug/report.html.erb

@@ -9,6 +9,7 @@
   </div>
   <div class="flex justify-end">
     <%= a_button icon: 'heroicons/outline/clipboard',
+      color: :primary,
       style: :primary,
       data: {
         controller: 'copy-to-clipboard',

data/app/views/avo/home/index.html.erb

@@ -1,5 +1,5 @@
 <div class="flex flex-col">
-  <%= render Avo::PanelComponent.new(title: 'Welcome to Avo', description: 'This page is visible only in development. It will be hidden in other environments.') do |c| %>
+  <%= render Avo::PanelComponent.new(name: 'Welcome to Avo', description: 'This page is visible only in development. It will be hidden in other environments.') do |c| %>
     <% c.body do %>
       <div class="flex flex-col justify-between py-6 min-h-24">
         <div class="px-6 space-y-4">

data/app/views/avo/partials/_resource_search.html.erb

@@ -3,6 +3,12 @@
     data-search-target="autocomplete"
     data-search-resource="<%= resource %>"
     data-translation-keys='{"no_item_found": "<%= I18n.translate 'avo.no_item_found' %>"}'
+    <% if via_reflection.present? %>
+      data-via-association="<%= via_reflection[:association] %>"
+      data-via-association-id="<%= via_reflection[:association_id] %>"
+      data-via-reflection-class="<%= via_reflection[:class] %>"
+      data-via-reflection-id="<%= via_reflection[:id] %>"
+    <% end %>
   >
   </div>
   <div class="hidden relative inline-flex text-gray-400 text-sm border border-gray-300 rounded cursor-pointer" data-search-target="button"></div>

data/app/views/avo/private/design.html.erb

@@ -1,7 +1,7 @@
 <div class="flex flex-col">
-  <%= render Avo::PanelComponent.new(title: 'Welcome to Avo', description: 'This page is visible only in development. It will be hidden in other environments.') do |c| %>
+  <%= render Avo::PanelComponent.new(name: 'Welcome to Avo', description: 'This page is visible only in development. It will be hidden in other environments.') do |c| %>
     <% c.tools do %>
-      <%= a_link('/admin', icon: 'arrow-left', style: :primary, is_link: true) do %>
+      <%= a_link('/admin', icon: 'arrow-left', color: :green, style: :primary, is_link: true) do %>
         Primary
       <% end %>
 

data/app/views/layouts/avo/application.html.erb

@@ -18,7 +18,7 @@
       <% end %>
     <% end %>
   </head>
-  <body class="bg-gray-25 os-mac">
+  <body class="bg-application os-mac">
     <div class="relative flex flex-1 w-full min-h-full" data-controller="sidebar" data-sidebar-open-value="<%= @sidebar_open %>">
       <div class="flex-1 flex flex-col max-w-full">
         <%= render partial: "avo/partials/navbar" %>

data/lib/avo/base_resource.rb

@@ -3,8 +3,8 @@ module Avo
     extend ActiveSupport::DescendantsTracker
 
     include ActionView::Helpers::UrlHelper
-    include Avo::Concerns::HasModel
     include Avo::Concerns::HasFields
+    include Avo::Concerns::HasEditableControls
     include Avo::Concerns::HasStimulusControllers
     include Avo::Concerns::ModelClassConstantized
 
@@ -439,5 +439,9 @@ module Avo
     def ordering_host(**args)
       Avo::Hosts::Ordering.new resource: self, options: self.class.ordering, **args
     end
+
+    def has_model_id?
+      model.present? && model.id.present?
+    end
   end
 end

data/lib/avo/concerns/has_editable_controls.rb

@@ -0,0 +1,34 @@
+module Avo
+  module Concerns
+    module HasEditableControls
+      extend ActiveSupport::Concern
+
+      included do
+        class_attribute :show_controls
+        class_attribute :show_controls_holder
+        class_attribute :show_controls_holder_called, default: false
+      end
+
+      def has_show_controls?
+        return false if ::Avo::App.license.lacks_with_trial(:resource_show_controls)
+
+        self.class.show_controls.present?
+      end
+
+      def render_show_controls
+        return [] if ::Avo::App.license.lacks_with_trial(:resource_show_controls)
+
+        if show_controls.present?
+          Avo::Resources::Controls::ExecutionContext.new(
+            block: show_controls,
+            resource: self,
+            record: model,
+            view: view
+          ).handle&.items || []
+        else
+          []
+        end
+      end
+    end
+  end
+end

data/lib/avo/concerns/has_fields.rb

@@ -17,19 +17,19 @@ module Avo
         def field(name, **args, &block)
           ensure_items_holder_initialized
 
-          self.items_holder.field name, **args, &block
+          items_holder.field name, **args, &block
         end
 
         def panel(name = nil, **args, &block)
           ensure_items_holder_initialized
 
-          self.items_holder.panel name, **args, &block
+          items_holder.panel name, **args, &block
         end
 
         def tabs(&block)
           ensure_items_holder_initialized
 
-          self.items_holder.tabs Avo::TabGroupBuilder.parse_block(&block)
+          items_holder.tabs Avo::TabGroupBuilder.parse_block(&block)
         end
 
         def tool(klass, **args)
@@ -39,27 +39,29 @@ module Avo
         end
 
         def heading(body, **args)
-          self.items_holder.heading body, **args
+          ensure_items_holder_initialized
+
+          items_holder.heading body, **args
         end
         # END DSL methods
 
         def items
-          if self.items_holder.present?
-            self.items_holder.items
+          if items_holder.present?
+            items_holder.items
           else
             []
           end
         end
 
         def tools
-          self.tools_holder
+          tools_holder
         end
 
         # Dives deep into panels and tabs to fetch all the fields for a resource.
         def fields(only_root: false)
           fields = []
 
-          self.items.each do |item|
+          items.each do |item|
             next if item.nil?
 
             unless only_root
@@ -76,7 +78,6 @@ module Avo
               end
             end
 
-
             if item.is_field?
               fields << item
             end
@@ -86,7 +87,7 @@ module Avo
         end
 
         def tab_groups
-          self.items.select do |item|
+          items.select do |item|
             item.instance_of? Avo::TabGroup
           end
         end

data/lib/avo/fields/base_field.rb

@@ -160,7 +160,7 @@ module Avo
         final_value = @model.send(property) if (model_or_class(@model) == "model") && @model.respond_to?(property)
 
         # On new views and actions modals we need to prefill the fields
-        if (@view === :new) || @action.present?
+        if @view.in?([:new, :create]) || @action.present?
           if default.present?
             final_value = if default.respond_to?(:call)
               default.call

data/lib/avo/fields/date_field.rb

@@ -5,15 +5,13 @@ module Avo
       attr_reader :picker_format
       attr_reader :disable_mobile
       attr_reader :format
-      attr_reader :relative
 
       def initialize(id, **args, &block)
         super(id, **args, &block)
 
-        add_string_prop args, :first_day_of_week, 0
+        add_string_prop args, :first_day_of_week, 1
         add_string_prop args, :picker_format, "Y-m-d"
         add_string_prop args, :format, "yyyy-LL-dd"
-        add_boolean_prop args, :relative
         add_boolean_prop args, :disable_mobile
       end
 

data/lib/avo/fields/field_extensions/has_include_blank.rb

@@ -4,7 +4,7 @@ module Avo
       module HasIncludeBlank
         def include_blank
           if @args[:include_blank] == true
-            placeholder || '—'
+            placeholder || "—"
           elsif @args[:include_blank] == false
             false
           else

data/lib/avo/fields/has_base_field.rb

@@ -6,6 +6,7 @@ module Avo
       attr_accessor :attach_scope
       attr_accessor :description
       attr_accessor :discreet_pagination
+      attr_accessor :hide_search_input
 
       def initialize(id, **args, &block)
         super(id, **args, &block)
@@ -14,6 +15,7 @@ module Avo
         @attach_scope = args[:attach_scope].present? ? args[:attach_scope] : nil
         @display = args[:display].present? ? args[:display] : :show
         @searchable = args[:searchable] == true
+        @hide_search_input = args[:hide_search_input] || false
         @description = args[:description]
         @use_resource = args[:use_resource] || nil
         @discreet_pagination = args[:discreet_pagination] || false