avo 1.3.3 → 1.4.0

data/db/migrate/20210421064037_add_color_to_teams.rb

@@ -0,0 +1,5 @@
+class AddColorToTeams < ActiveRecord::Migration[6.0]
+  def change
+    add_column :teams, :color, :string
+  end
+end

data/db/migrate/20210423075924_add_progress_to_projects.rb

@@ -0,0 +1,5 @@
+class AddProgressToProjects < ActiveRecord::Migration[6.0]
+  def change
+    add_column :projects, :progress, :integer
+  end
+end

data/lib/avo.rb

@@ -27,7 +27,7 @@ module Avo
         root_path: ROOT_PATH,
         public_output_dir: "avo-packs",
         cache_manifest: Rails.env.production?,
-        fallback_to_webpacker: -> { Avo::IN_DEVELOPMENT || Rails.env.test?}
+        fallback_to_webpacker: -> { Avo::IN_DEVELOPMENT }
       )
     end
   end

data/lib/avo/app.rb

@@ -1,9 +1,7 @@
 module Avo
   class App
-    class_attribute :app, default: {
-      resources: [],
-      cache_store: nil
-    }
+    class_attribute :resources, default: []
+    class_attribute :cache_store, default: nil
     class_attribute :fields, default: []
     class_attribute :request, default: nil
     class_attribute :context, default: nil
@@ -16,9 +14,9 @@ module Avo
         I18n.locale = Avo.configuration.language_code
 
         if Rails.cache.instance_of?(ActiveSupport::Cache::NullStore)
-          app[:cache_store] ||= ActiveSupport::Cache::MemoryStore.new
+          self.cache_store ||= ActiveSupport::Cache::MemoryStore.new
         else
-          app[:cache_store] = Rails.cache
+          self.cache_store = Rails.cache
         end
       end
 
@@ -38,10 +36,6 @@ module Avo
         init_resources
       end
 
-      def cache_store
-        app[:cache_store]
-      end
-
       # This method will find all fields available in the Avo::Fields namespace and add them to the fields class_variable array
       # so later we can instantiate them on our resources.
       #
@@ -67,7 +61,7 @@ module Avo
       end
 
       def init_resources
-        app[:resources] = BaseResource.descendants
+        self.resources = BaseResource.descendants
           .select do |resource|
             resource != BaseResource
           end
@@ -78,15 +72,11 @@ module Avo
           end
       end
 
-      def get_resources
-        app[:resources]
-      end
-
       # Returns the Avo resource by camelized name
       #
       # get_resource_by_name('User') => UserResource
       def get_resource(resource)
-        app[:resources].find do |available_resource|
+        resources.find do |available_resource|
           "#{resource}Resource".safe_constantize == available_resource.class
         end
       end
@@ -103,7 +93,7 @@ module Avo
       # get_resource_by_name('User') => UserResource
       # get_resource_by_name(User) => UserResource
       def get_resource_by_model_name(name)
-        get_resources.find do |resource|
+        resources.find do |resource|
           resource.model_class.model_name.name == name.to_s
         end
       end
@@ -113,7 +103,7 @@ module Avo
       # get_resource_by_controller_name('delayed_backend_active_record_jobs') => DelayedJobResource
       # get_resource_by_controller_name('users') => UserResource
       def get_resource_by_controller_name(name)
-        get_resources.find do |resource|
+        resources.find do |resource|
           resource.model_class.to_s.pluralize.underscore.tr("/", "_") == name.to_s
         end
       end
@@ -126,8 +116,7 @@ module Avo
       end
 
       def get_available_resources(user = nil)
-        App.get_resources
-          .select do |resource|
+        resources.select do |resource|
             Services::AuthorizationService.authorize user, resource.model, Avo.configuration.authorization_methods.stringify_keys["index"], raise_exception: false
           end
           .sort_by { |r| r.name }

data/lib/avo/base_resource.rb

@@ -61,9 +61,17 @@ module Avo
     def get_field_definitions
       return [] if self.class.fields.blank?
 
-      self.class.fields.map do |field|
+      fields = self.class.fields.map do |field|
         field.hydrate(resource: self, panel_name: default_panel_name, user: user)
       end
+
+      if Avo::App.license.invalid? || Avo::App.license.lacks(:custom_fields)
+        fields = fields.reject do |field|
+          field.custom?
+        end
+      end
+
+      fields
     end
 
     def get_fields(panel: nil, reflection: nil)

data/lib/avo/engine.rb

@@ -15,6 +15,7 @@ module Avo
 
     initializer "avo.autoload", before: :set_autoload_paths do |app|
       [
+        ["app", "avo", "fields"],
         ["app", "avo", "filters"],
         ["app", "avo", "actions"],
         ["app", "avo", "resources"]

data/lib/avo/fields/badge_field.rb

@@ -1,17 +1,15 @@
 module Avo
   module Fields
     class BadgeField < BaseField
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "badge-field"
-        }
+      attr_reader :options
 
-        super(name, **args, &block)
+      def initialize(id, **args, &block)
+        super(id, **args, &block)
 
         hide_on [:edit, :new]
 
         default_options = {info: :info, success: :success, danger: :danger, warning: :warning}
-        @meta[:options] = args[:options].present? ? default_options.merge(args[:options]) : default_options
+        @options = args[:options].present? ? default_options.merge(args[:options]) : default_options
       end
     end
   end

data/lib/avo/fields/base_field.rb

@@ -5,91 +5,65 @@ module Avo
       extend Avo::Fields::FieldExtensions::HasFieldName
       include Avo::Fields::FieldExtensions::VisibleInDifferentViews
 
-      attr_accessor :id
-      attr_accessor :name
-      attr_accessor :translation_key
-      attr_accessor :partial_name
-      attr_accessor :partial_path
-      attr_accessor :updatable
-      attr_accessor :sortable
-      attr_accessor :required
-      attr_accessor :readonly
-      attr_accessor :nullable
-      attr_accessor :null_values
-      attr_accessor :format_using
-      attr_accessor :computed # if block is present
-      attr_accessor :computable # if allowed to be computable
-      attr_accessor :computed_value # the value after computation
-      attr_accessor :block
-      attr_accessor :placeholder
-      attr_accessor :help
-      attr_accessor :default
-      attr_accessor :visible
-      attr_accessor :model
-      attr_accessor :resource
-      attr_accessor :view
-      attr_accessor :user
-      attr_accessor :action
-      attr_accessor :meta
-      attr_accessor :panel_name
-      attr_accessor :link_to_resource
-      attr_accessor :options
+      attr_reader :id
+      attr_reader :name
+      attr_reader :translation_key
+      attr_reader :block
+      attr_reader :required
+      attr_reader :readonly
+      attr_reader :sortable
+      attr_reader :nullable
+      attr_reader :null_values
+      attr_reader :format_using
+      attr_reader :placeholder
+      attr_reader :help
+      attr_reader :default
+      attr_reader :visible
+
+      # Private options
+      attr_reader :updatable
+      attr_reader :computable # if allowed to be computable
+      attr_reader :computed # if block is present
+      attr_reader :computed_value # the value after computation
+
+      # Hydrated payload
+      attr_reader :model
+      attr_reader :view
+      attr_reader :resource
+      attr_reader :action
+      attr_reader :user
+      attr_reader :panel_name
 
       class_attribute :field_name_attribute
 
-      @meta = {}
-
-      def initialize(id, **args, &block)
+      def initialize(id, _options: {}, **args, &block)
         super(id, **args, &block)
-        @defaults ||= {}
-
-        args = @defaults.merge(args).symbolize_keys
-
-        null_values = [nil, "", *args[:null_values]]
-        # The field properties as a hash {property: default_value}
-        @field_properties = {
-          id: id,
-          name: id.to_s.humanize(keep_id_suffix: true),
-          translation_key: nil,
-          block: block,
-          partial_name: "field",
-          required: false,
-          readonly: false,
-          updatable: true,
-          sortable: false,
-          nullable: false,
-          null_values: null_values,
-          computable: true,
-          computed: block.present?,
-          computed_value: false,
-          format_using: false,
-          placeholder: id.to_s.humanize,
-          help: nil,
-          default: nil,
-          visible: true,
-          meta: {},
-          panel_name: nil,
-          options: {}
-        }
-
-        # Set the values in the following order
-        # - app defaults
-        # - field defaults
-        # - field option
-        @field_properties.each do |name, default_value|
-          final_value = args[name.to_sym]
-          send("#{name}=", name != "null_values" && (final_value.nil? || !defined?(final_value)) ? default_value : final_value)
-        end
+
+        @id = id
+        @name = args[:name] || id.to_s.humanize(keep_id_suffix: true)
+        @translation_key = args[:translation_key]
+        @block = block
+        @required = args[:required] || false
+        @readonly = args[:readonly] || false
+        @sortable = args[:sortable] || false
+        @nullable = args[:nullable] || false
+        @null_values = args[:null_values] || [nil, ""]
+        @format_using = args[:format_using] || nil
+        @placeholder = args[:placeholder] || id.to_s.humanize(keep_id_suffix: true)
+        @help = args[:help] || nil
+        @default = args[:default] || nil
+        @visible = args[:visible] || true
+
+        @updatable = true
+        @computable = true
+        @computed = block.present?
+        @computed_value = nil
 
         # Set the visibility
         show_on args[:show_on] if args[:show_on].present?
         hide_on args[:hide_on] if args[:hide_on].present?
         only_on args[:only_on] if args[:only_on].present?
         except_on args[:except_on] if args[:except_on].present?
-
-        if args[:use_partials].present?
-          @custom_partials = args[:use_partials]
-        end
       end
 
       def hydrate(model: nil, resource: nil, action: nil, view: nil, panel_name: nil, user: nil)
@@ -142,12 +116,6 @@ module Avo
         model
       end
 
-      def partial_path_for(view)
-        return @custom_partials[view] if @custom_partials.present? && @custom_partials[view].present?
-
-        "avo/fields/#{view}/#{partial_name}"
-      end
-
       # Try to see if the field has a different database ID than it's name
       def database_id(model)
         foreign_key
@@ -167,8 +135,13 @@ module Avo
         id.to_sym
       end
 
-      def component_name(view = :index)
-        "Avo::#{view.to_s.classify}::Fields::#{partial_name.gsub("-field", "").underscore.camelize}FieldComponent"
+      def view_component_name
+        "#{type.classify}Field"
+      end
+
+      def component_for_view(view = :index)
+        # puts ['component_for_view->', "Avo::Fields::#{type.classify}Field::#{view.to_s.classify}Component"].inspect
+        "Avo::Fields::#{view_component_name}::#{view.to_s.classify}Component".safe_constantize
       end
 
       def model_errors
@@ -181,6 +154,12 @@ module Avo
         self.class.name.demodulize.to_s.underscore.gsub("_field", "")
       end
 
+      def custom?
+        !method(:initialize).source_location.first.include?("lib/avo/field")
+      rescue
+        true
+      end
+
       private
 
       def model_or_class(model)

data/lib/avo/fields/belongs_to_field.rb

@@ -1,16 +1,16 @@
 module Avo
   module Fields
     class BelongsToField < BaseField
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "belongs-to-field",
-          placeholder: I18n.t("avo.choose_an_option")
-        }
+      attr_reader :searchable
+      attr_reader :relation_method
 
-        super(name, **args, &block)
+      def initialize(id, **args, &block)
+        args[:placeholder] ||= I18n.t("avo.choose_an_option")
 
-        @meta[:searchable] = args[:searchable] == true
-        @meta[:relation_method] = name.to_s.parameterize.underscore
+        super(id, **args, &block)
+
+        @searchable = args[:searchable] == true
+        @relation_method = name.to_s.parameterize.underscore
       end
 
       def options
@@ -29,12 +29,12 @@ module Avo
       def foreign_key
         if @model.present?
           if @model.instance_of?(Class)
-            @model.reflections[@meta[:relation_method]].foreign_key
+            @model.reflections[@relation_method].foreign_key
           else
-            @model.class.reflections[@meta[:relation_method]].foreign_key
+            @model.class.reflections[@relation_method].foreign_key
           end
         elsif @resource.present?
-          @resource.model_class.reflections[@meta[:relation_method]].foreign_key
+          @resource.model_class.reflections[@relation_method].foreign_key
         end
       end
 

data/lib/avo/fields/boolean_field.rb

@@ -4,13 +4,8 @@ module Avo
       attr_reader :true_value
       attr_reader :false_value
 
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "boolean-field",
-          computable: true
-        }
-
-        super(name, **args, &block)
+      def initialize(id, **args, &block)
+        super(id, **args, &block)
 
         @true_value = args[:true_value].present? ? args[:true_value] : true
         @false_value = args[:false_value].present? ? args[:false_value] : false

data/lib/avo/fields/boolean_group_field.rb

@@ -3,13 +3,8 @@ module Avo
     class BooleanGroupField < BaseField
       attr_reader :options
 
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "boolean-group-field",
-          computable: true
-        }
-
-        super(name, **args, &block)
+      def initialize(id, **args, &block)
+        super(id, **args, &block)
 
         @options = args[:options].present? ? args[:options] : {}
       end

data/lib/avo/fields/code_field.rb

@@ -1,21 +1,17 @@
 module Avo
   module Fields
     class CodeField < BaseField
-      attr_reader :height
       attr_reader :language
       attr_reader :theme
+      attr_reader :height
       attr_reader :tab_size
       attr_reader :indent_with_tabs
       attr_reader :line_wrapping
 
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "code-field"
-        }
-
+      def initialize(id, **args, &block)
         hide_on :index
 
-        super(name, **args, &block)
+        super(id, **args, &block)
 
         @language = args[:language].present? ? args[:language].to_s : "javascript"
         @theme = args[:theme].present? ? args[:theme].to_s : "material-darker"

data/lib/avo/fields/country_field.rb

@@ -4,13 +4,10 @@ module Avo
       attr_reader :countries
       attr_reader :display_code
 
-      def initialize(name, **args, &block)
-        @defaults = {
-          partial_name: "country-field",
-          placeholder: I18n.t("avo.choose_a_country")
-        }
+      def initialize(id, **args, &block)
+        args[:placeholder] ||= I18n.t("avo.choose_a_country")
 
-        super(name, **args, &block)
+        super(id, **args, &block)
 
         @countries = ISO3166::Country.translations.sort_by { |code, name| name }.to_h
         @display_code = args[:display_code].present? ? args[:display_code] : false