autonumeric-rails 1.9.21 → 1.9.22

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# 1.9.22
+
+- Update autoNumeric v 1.9.22
+- autoNumeric fields now automatically initialize after AJAX requests.
+Manual DOM modification (through JavaScript) must still trigger `refresh_autonumeric` event manually
+
 # 1.9.21
 
 - Update autoNumeric v 1.9.21

data/README.md

@@ -44,10 +44,15 @@ You can also pass autoNumeric configuration parameters directly with a Hash in y
     
 See autoNumeric pages (links above) for all details on configuration and options
 
-## Dynamic fields (AJAX and friends)
+## AJAX
 
-When a new fields with autonumeric attributes are generated after the DOM is loaded, either created by JavaScript
-function or resulting of an AJAX call, you must manually refresh in order to initialize those new fields.
+autonumeric-rails looks for `ajaxComplete` events which are trigger by jQuery every time an Ajax request finishes.
+As a result, rails-ujs elements (i.e. `data-remote` elements) now automatically initialize autonumeric fields after the AJAX request is complete.
+
+## Javascript DOM manipulation
+
+When a Javascript function generate and add to the DOM new fields with autonumeric attributes,
+you must manually refresh in order to initialize those new fields.
 
 To do so you must trigger the `refresh_autonumeric` event on `document` after you modified the DOM:
 
@@ -56,8 +61,8 @@ To do so you must trigger the `refresh_autonumeric` event on `document` after yo
 ## Internal
 
 Autonumeric-rails creates in the DOM an hidden input with the same name as the text field.
-On each modification of the test field value, the hidden input is updated with the sanitized value.
-When validating the form the hidden form value is naturally sent to the server as it is located after the text field.
+On each modification of the text field value (through the `keyup` event), the hidden input is updated with the sanitized value.
+When validating the form, the hidden field value is sent to the server as it is located after the text field in the DOM.
     
 ## Contributing
 

data/lib/autonumeric/rails/version.rb

@@ -1,5 +1,5 @@
 module Autonumeric
   module Rails
-    VERSION = '1.9.21'
+    VERSION = '1.9.22'
   end
 end

data/spec/autonumeric-rails_spec.rb

@@ -101,12 +101,17 @@ describe 'Autonumeric-rails', type: :feature, js: true do
   before { wait_for_jquery }
 
   context 'Through form helper' do
-    let(:url) { 'through_form_helper' }
+    let(:url) { 'static_fields' }
     it_behaves_like 'all autonumeric-rails tests'
   end
 
-  context 'With dynamically created fields' do
-    let(:url) { 'dynamic_field' }
+  context 'Javascript manually created fields' do
+    let(:url) { 'javascript_fields' }
+    it_behaves_like 'all autonumeric-rails tests'
+  end
+
+  context 'AJAX request created fields' do
+    let(:url) { 'ajax_fields' }
     it_behaves_like 'all autonumeric-rails tests'
   end
 

data/spec/dummy/app/controllers/application_controller.rb

@@ -1,6 +1,4 @@
 class ApplicationController < ActionController::Base
-  protect_from_forgery with: :exception
-
   def self.create_action(name)
     define_method(name) do
       send :without_record

data/spec/dummy/app/controllers/forms_controller.rb

@@ -1,12 +1,25 @@
 class FormsController < ApplicationController
-  create_action :through_form_helper
-  create_action :dynamic_field
 
-  def without_record
-    @record = Record.new
+  create_action :static_fields
+  create_action :javascript_fields
+  create_action :get_content_from_ajax
+
+  def ajax_fields
+    @url_prefix = ''
   end
 
-  def with_record
-    @record = Record.find params[:id]
+  def ajax_fields_with_record
+    @url_prefix = "/#{params[:id]}"
+    render action: :ajax_fields
   end
+
+  private
+
+    def without_record
+      @record = Record.new
+    end
+
+    def with_record
+      @record = Record.find params[:id]
+    end
 end

data/spec/dummy/app/views/forms/ajax_fields.html.erb

@@ -0,0 +1,10 @@
+<div id="content"></div>
+
+<script>
+  jQuery(function() {
+    $.ajax({
+      url: '/get_content_from_ajax<%= @url_prefix %>',
+      dataType: 'script'
+    });
+  });
+</script>

data/spec/dummy/app/views/forms/get_content_from_ajax.js.erb

@@ -0,0 +1 @@
+$("div#content").html("<%= j render template: 'forms/static_fields.html.erb' %>");

data/spec/dummy/app/views/forms/javascript_fields.html.erb

@@ -0,0 +1,18 @@
+<%= form_for @record do |f| %>
+    <%= f.text_field :field2, data: {autonumeric: {aSign: 'USD ', mDec: 1}} %>
+    <%= f.submit 'Go' %>
+<% end %>
+
+<script>
+    jQuery(function() {
+        var new_field;
+        new_field = $('<input>').attr('id', 'record_field1').attr('name', 'record[field1]');
+        new_field.attr('data-autonumeric', 'true').data('autonumeric', 'true');
+        <% if @record.field1 %>
+        new_field.val('<%= @record.field1.to_s %>');
+        <% end %>
+        $('form').prepend(new_field);
+
+        $(document).trigger('refresh_autonumeric');
+    });
+</script>

data/spec/dummy/config/routes.rb

@@ -1,9 +1,15 @@
 Dummy::Application.routes.draw do
   resources :records, only: [:create, :update]
 
-  get '/through_form_helper', to: 'forms#through_form_helper'
-  get '/through_form_helper/:id', to: 'forms#through_form_helper_with_record'
+  get '/static_fields', to: 'forms#static_fields'
+  get '/static_fields/:id', to: 'forms#static_fields_with_record'
 
-  get '/dynamic_field', to: 'forms#dynamic_field'
-  get '/dynamic_field/:id', to: 'forms#dynamic_field_with_record'
+  get '/javascript_fields', to: 'forms#javascript_fields'
+  get '/javascript_fields/:id', to: 'forms#javascript_fields_with_record'
+
+  get '/ajax_fields', to: 'forms#ajax_fields'
+  get '/ajax_fields/:id', to: 'forms#ajax_fields_with_record'
+
+  get '/get_content_from_ajax', to: 'forms#get_content_from_ajax'
+  get '/get_content_from_ajax/:id', to: 'forms#get_content_from_ajax_with_record'
 end

data/vendor/assets/javascripts/{autoNumeric-1.9.21.js → autoNumeric-1.9.22.js}

@@ -2,7 +2,7 @@
  * autoNumeric.js
  * @author: Bob Knothe
  * @author: Sokolov Yura
- * @version: 1.9.21 - 2014-04-01 GMT 9:00 AM
+ * @version: 1.9.22 - 2014-04-20 GMT 7:00 PM
  *
  * Created by Robert J. Knothe on 2010-10-25. Please report any bugs to https://github.com/BobKnothe/autoNumeric
  * Created by Sokolov Yura on 2010-11-07
@@ -953,7 +953,6 @@
                 } else {
                     return this;
                 }
-                settings.lastSetValue = '';
                 settings.runOnce = false;
                 var holder = getHolder($this, settings);
                 if ($.inArray($this.prop('tagName'), settings.tagList) === -1 && $this.prop('tagName') !== 'INPUT') {
@@ -1154,21 +1153,21 @@
                     $.error("You must initialize autoNumeric('init', {options}) prior to calling the 'set' method");
                     return this;
                 }
-                /** allows locale decimal separator to be a comma */
-                if ((testValue === $this.attr('value') || testValue === $this.text()) && settings.runOnce === false) {
-                    value = value.replace(',', '.');
-                }
                 /** routine to handle page re-load from back button */
                 if (testValue !== $this.attr('value') && $this.prop('tagName') === 'INPUT' && settings.runOnce === false) {
+                    value = (settings.nBracket !== null) ? negativeBracket($this.val(), settings.nBracket, 'pageLoad') : value;
                     value = autoStrip(value, settings);
                 }
+                /** allows locale decimal separator to be a comma */
+                if ((testValue === $this.attr('value') || testValue === $this.text()) && settings.runOnce === false) {
+                    value = value.replace(',', '.');
+                }
                 /** returns a empty string if the value being 'set' contains non-numeric characters and or more than decimal point (full stop) and will not be formatted */
                 if (!$.isNumeric(+value)) {
                     return '';
                 }
                 value = checkValue(value, settings);
                 settings.oEvent = 'set';
-                settings.lastSetValue = value; /** saves the unrounded value from the set method - $('selector').data('autoNumeric').lastSetValue; - helpful when you need to change the rounding accuracy*/
                 value.toString();
                 if (value !== '') {
                     value = autoRound(value, settings);

data/vendor/assets/javascripts/autonumeric.js

@@ -1,2 +1,2 @@
-//= require autoNumeric-1.9.21.js
+//= require autoNumeric-1.9.22.js
 //= require autonumeric_ujs.js

data/vendor/assets/javascripts/autonumeric_ujs.js

@@ -1,7 +1,7 @@
 /**
  * autonumeric_ujs.js
  * @author: randoum
- * @version: 1.9.18 - 2013-12-13
+ * @version: 1.9.22 - 2014-04-22
  *
  * Created by Randoum on 2013-08-15. Please report any bugs to https://github.com/randoum/autonumeric-rails
  *
@@ -32,9 +32,16 @@
  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
  * OTHER DEALINGS IN THE SOFTWARE.
  */
+
 var AutonumericRails;
 
 window.AutonumericRails = AutonumericRails = (function() {
+    AutonumericRails.create_autonumeric_object = function(obj) {
+        if (!obj.data('autonumeric-initialized')) {
+            return new this(obj);
+        }
+    };
+
     function AutonumericRails(field) {
         this.field = field;
         this.field.data('autonumeric-initialized', true);
@@ -65,15 +72,16 @@ window.AutonumericRails = AutonumericRails = (function() {
 
 window.refresh_autonumeric = function() {
     $('input[data-autonumeric]').each(function() {
-        if (!$(this).data('autonumeric-initialized')) {
-            new window.AutonumericRails($(this));
-        }
+        AutonumericRails.create_autonumeric_object($(this));
     });
 };
 
 jQuery(function() {
-    refresh_autonumeric();
+    window.refresh_autonumeric();
     $(document).on('refresh_autonumeric', function() {
-        refresh_autonumeric();
+        window.refresh_autonumeric();
+    });
+    $(document).on('ajaxComplete', function() {
+        window.refresh_autonumeric();
     });
-});
+});

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: autonumeric-rails
 version: !ruby/object:Gem::Version
-  version: 1.9.21
+  version: 1.9.22
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-19 00:00:00.000000000 Z
+date: 2014-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jquery-rails
@@ -218,13 +218,11 @@ files:
 - spec/dummy/app/controllers/concerns/.keep
 - spec/dummy/app/controllers/forms_controller.rb
 - spec/dummy/app/controllers/records_controller.rb
-- spec/dummy/app/helpers/application_helper.rb
-- spec/dummy/app/mailers/.keep
-- spec/dummy/app/models/.keep
-- spec/dummy/app/models/concerns/.keep
 - spec/dummy/app/models/record.rb
-- spec/dummy/app/views/forms/dynamic_field.html.erb
-- spec/dummy/app/views/forms/through_form_helper.html.erb
+- spec/dummy/app/views/forms/ajax_fields.html.erb
+- spec/dummy/app/views/forms/get_content_from_ajax.js.erb
+- spec/dummy/app/views/forms/javascript_fields.html.erb
+- spec/dummy/app/views/forms/static_fields.html.erb
 - spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/bin/bundle
 - spec/dummy/bin/rails
@@ -248,15 +246,14 @@ files:
 - spec/dummy/config/routes.rb
 - spec/dummy/db/migrate/20131227002328_create_records.rb
 - spec/dummy/db/schema.rb
-- spec/dummy/lib/assets/.keep
 - spec/dummy/log/.keep
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/spec_helper.rb
-- spec/support/general.rb
-- vendor/assets/javascripts/autoNumeric-1.9.21.js
+- spec/support/wait_for_jquery.rb
+- vendor/assets/javascripts/autoNumeric-1.9.22.js
 - vendor/assets/javascripts/autonumeric.js
 - vendor/assets/javascripts/autonumeric_ujs.js
 homepage: https://github.com/randoum/autonumeric-rails

data/spec/dummy/app/helpers/application_helper.rb

@@ -1,2 +0,0 @@
-module ApplicationHelper
-end

data/spec/dummy/app/views/forms/dynamic_field.html.erb

@@ -1,19 +0,0 @@
-<%= form_for @record do |f| %>
-    <%= f.text_field :field2, data: {autonumeric: {aSign: 'USD ', mDec: 1}} %>
-    <%= f.submit 'Go' %>
-<% end %>
-
-<script>
-    jQuery(function() {
-        var hidden;
-        hidden = $('<input>').attr('id', 'record_field1').attr('name', 'record[field1]');
-        hidden.attr('data-autonumeric', 'true').data('autonumeric', 'true');
-        <% if @record.field1 %>
-        hidden.val('<%= @record.field1.to_s %>');
-        <% end %>
-        $('form').prepend(hidden);
-
-
-        $(document).trigger('refresh_autonumeric');
-    });
-</script>