autonumeric-rails 0.1.9.17 → 1.9.18.0

data/.gitignore

@@ -15,4 +15,6 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-.idea
+.idea
+vendor/assets/javascripts/autonumeric_ujs.js.coffee
+spec/dummy/log/*.log

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--format progress

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+# 1.9.18.0
+
+- Update autoNumeric v 1.9.18
+- Rewrite JS code using Javascript class, to keep things clean
+- Add support for dynamically generated DOM elements, with limitations (see README)
+- Write proper tests
+- Fix bug when value of an existing record could be lost
+
+# 0.1.9.17
+
+- Update autoNumeric v 1.9.17
+
+# 0.1.9.15
+
+- Initial version, wrapping autoNumeric v 1.9.15

data/README.md

@@ -1,6 +1,6 @@
-# autonumeric-rails
+## autonumeric-rails
 
-Wrap up the excelent autoNumeric.js javascript library 
+Wrap up the excellent autoNumeric.js javascript library
 
 autoNumeric is a jQuery plugin that automatically formats currency (money) and numbers as you type on form inputs.
 It supports most International numeric formats and currency signs including those used in Europe, North and 
@@ -43,6 +43,16 @@ You can also pass autoNumeric configuration parameters directly with a Hash in y
     <% end %>
     
 See autoNumeric pages (links above) for all details on configuration and options
+
+## Internal and compatibility
+
+Autonumeric-rails creates in the DOM an hidden input with the same name as the text field.
+On each modification of the test field value, the hidden input is updated with the sanitized value.
+When validating the form the hidden form value is naturally sent to the server as it is located after the text field.
+
+I've tried to add support for dynamically generated fields (through AJAX or other JS functions)
+and seems to works OK. But it relies on DOM event "DOMNodeInserted" which seems not to be
+compatible with IE 8 and older.
     
 ## Contributing
 

data/Rakefile

@@ -1 +1,9 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new
+
+task :default => :spec
+task :test => :spec
+
+

data/autonumeric-rails.gemspec

@@ -14,10 +14,20 @@ Gem::Specification.new do |spec|
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
+  spec.test_files    = `git ls-files -- test/*`.split($/)
   spec.require_paths = ['lib']
 
   spec.add_dependency 'jquery-rails', '>= 2.0.2'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rails', '~> 4.0.2'
+  spec.add_development_dependency 'sqlite3'
+
+  spec.add_development_dependency 'rspec-rails'
+  spec.add_development_dependency 'rspec-html-matchers'
+  spec.add_development_dependency 'database_cleaner'
+  spec.add_development_dependency 'capybara'
+  spec.add_development_dependency 'selenium-webdriver'
+  spec.add_development_dependency 'headless'
 end

data/lib/autonumeric/rails/version.rb

@@ -1,5 +1,5 @@
 module Autonumeric
   module Rails
-    VERSION = '0.1.9.17'
+    VERSION = '1.9.18.0'
   end
 end

data/spec/autonumeric-rails_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+shared_examples 'all autonumeric-rails tests' do
+  context 'Without DB' do
+    let(:record_id) { '' }
+
+    it 'Input tag' do
+      assert_selector("input#record_field1[name='record[field1]'][data-autonumeric='true']")
+      assert_selector("input#record_field2[name='record[field2]'][data-autonumeric='#{params}']")
+    end
+
+    it 'Hidden tags' do
+      assert_selector("input#record_field1_val[name='record[field1]'][type='hidden']")
+      assert_selector("input#record_field2_val[name='record[field2]'][type='hidden']")
+    end
+
+    it 'Hidden tag is located after Input tag' do
+      find(:xpath, ".//*[@id='record_field1']/following-sibling::*[1]")['id'].should eq('record_field1_val')
+      find(:xpath, ".//*[@id='record_field2']/following-sibling::*[1]")['id'].should eq('record_field2_val')
+    end
+
+    it 'Set empty default values' do
+      find('#record_field1').value.should eq('')
+      find('#record_field1_val').value.should eq('')
+
+      find('#record_field2').value.should eq('')
+      find('#record_field2_val').value.should eq('')
+    end
+
+    it 'Typing value updates hidden field value' do
+      find('#record_field1').set '12345'
+      find('#record_field2').set '54321.987'
+
+      find('#record_field1').value.should eq('12,345.00')
+      find('#record_field1_val').value.should eq('12345')
+
+      find('#record_field2').value.should eq('USD 54,321.9')
+      find('#record_field2_val').value.should eq('54321.9')
+    end
+
+    it 'Creates record without values' do
+      click_button 'Go'
+
+      from_db = Record.last
+      from_db.field1.should eq(nil)
+      from_db.field2.should eq(nil)
+    end
+
+    it 'Creates record with values' do
+      find('#record_field1').set '122333'
+      find('#record_field2').set '4444.5'
+      click_button 'Go'
+
+      from_db = Record.last
+      from_db.field1.should eq(122333)
+      from_db.field2.should eq(4444.5)
+    end
+  end
+
+  context 'With DB record' do
+    let(:record) { Record.create field1: 112233, field2: 445566.7 }
+    let(:record_id) { "/#{record.id}" }
+
+    it 'Loads record and set values' do
+      find('#record_field1').value.should eq('112,233.00')
+      find('#record_field1_val').value.should eq('112233')
+
+      find('#record_field2').value.should eq('USD 445,566.7')
+      find('#record_field2_val').value.should eq('445566.7')
+    end
+
+    it 'Without modifying values' do
+      click_button 'Go'
+
+      from_db = Record.find record.id
+      from_db.field1.should eq(112233)
+      from_db.field2.should eq(445566.7)
+    end
+
+    it 'Updates record' do
+      find('#record_field1').set '332211'
+      find('#record_field2').set '776655.4'
+      click_button 'Go'
+
+      from_db = Record.find record.id
+      from_db.field1.should eq(332211)
+      from_db.field2.should eq(776655.4)
+    end
+  end
+end
+
+
+
+describe 'Autonumeric-rails', type: :feature, js: true do
+
+  subject { page }
+
+  let(:params) { {aSign: 'USD ', mDec: 1}.to_json }
+
+  before { visit "/#{url}#{record_id}" }
+  before { wait_for_jquery }
+
+  context 'Through form helper' do
+    let(:url) { 'through_form_helper' }
+    it_behaves_like 'all autonumeric-rails tests'
+  end
+
+  context 'With dynamically created fields' do
+    let(:url) { 'dynamic_field' }
+    it_behaves_like 'all autonumeric-rails tests'
+  end
+
+end

data/spec/dummy/.rspec

@@ -0,0 +1 @@
+--color

data/spec/dummy/README.rdoc

@@ -0,0 +1,28 @@
+== README
+
+This README would normally document whatever steps are necessary to get the
+application up and running.
+
+Things you may want to cover:
+
+* Ruby version
+
+* System dependencies
+
+* Configuration
+
+* Database creation
+
+* Database initialization
+
+* How to run the test suite
+
+* Services (job queues, cache servers, search engines, etc.)
+
+* Deployment instructions
+
+* ...
+
+
+Please feel free to use a different markup language if you do not plan to run
+<tt>rake doc:app</tt>.

data/spec/dummy/Rakefile

@@ -0,0 +1,6 @@
+# Add your own tasks in files placed in lib/tasks ending in .rake,
+# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+
+require File.expand_path('../config/application', __FILE__)
+
+Dummy::Application.load_tasks

data/spec/dummy/app/assets/javascripts/application.js

@@ -0,0 +1,14 @@
+// This is a manifest file that'll be compiled into application.js, which will include all the files
+// listed below.
+//
+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
+// or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
+//
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// compiled file.
+//
+// Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
+// about supported directives.
+//
+//= require jquery
+//= require autonumeric

data/spec/dummy/app/assets/stylesheets/application.css

@@ -0,0 +1,13 @@
+/*
+ * This is a manifest file that'll be compiled into application.css, which will include all the files
+ * listed below.
+ *
+ * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
+ * or vendor/assets/stylesheets of plugins, if any, can be referenced here using a relative path.
+ *
+ * You're free to add application-wide styles to this file and they'll appear at the top of the
+ * compiled file, but it's generally better to create a new file per style scope.
+ *
+ *= require_self
+ *= require_tree .
+ */

data/spec/dummy/app/controllers/application_controller.rb

@@ -0,0 +1,15 @@
+class ApplicationController < ActionController::Base
+  protect_from_forgery with: :exception
+
+  def self.create_action(name)
+    define_method(name) do
+      send :without_record
+      render action: name
+    end
+
+    define_method("#{name}_with_record".to_sym) do
+      send :with_record
+      render action: name
+    end
+  end
+end

data/spec/dummy/app/controllers/forms_controller.rb

@@ -0,0 +1,12 @@
+class FormsController < ApplicationController
+  create_action :through_form_helper
+  create_action :dynamic_field
+
+  def without_record
+    @record = Record.new
+  end
+
+  def with_record
+    @record = Record.find params[:id]
+  end
+end

data/spec/dummy/app/controllers/records_controller.rb

@@ -0,0 +1,17 @@
+class RecordsController < ApplicationController
+  def create
+    Record.create record_params
+    render nothing: true
+  end
+
+  def update
+    Record.find(params[:id]).update_attributes record_params
+    render nothing: true
+  end
+
+  private
+
+  def record_params
+    params.require(:record).permit [:field1, :field2]
+  end
+end

data/spec/dummy/app/helpers/application_helper.rb

@@ -0,0 +1,2 @@
+module ApplicationHelper
+end

data/spec/dummy/app/models/record.rb

@@ -0,0 +1,2 @@
+class Record < ActiveRecord::Base
+end

data/spec/dummy/app/views/forms/dynamic_field.html.erb

@@ -0,0 +1,16 @@
+<%= form_for @record do |f| %>
+    <%= f.text_field :field2, data: {autonumeric: {aSign: 'USD ', mDec: 1}} %>
+    <%= f.submit 'Go' %>
+<% end %>
+
+<script>
+    jQuery(function() {
+        var hidden;
+        hidden = $('<input>').attr('id', 'record_field1').attr('name', 'record[field1]');
+        hidden.attr('data-autonumeric', 'true').data('autonumeric', 'true');
+        <% if @record.field1 %>
+        hidden.val('<%= @record.field1.to_s %>');
+        <% end %>
+        $('form').prepend(hidden);
+    });
+</script>

data/spec/dummy/app/views/forms/through_form_helper.html.erb

@@ -0,0 +1,5 @@
+<%= form_for @record do |f| %>
+    <%= f.text_field :field1, data: {autonumeric: true} %>
+    <%= f.text_field :field2, data: {autonumeric: {aSign: 'USD ', mDec: 1}} %>
+    <%= f.submit 'Go' %>
+<% end %>

data/spec/dummy/app/views/layouts/application.html.erb

@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<html>
+<head>
+  <title>Dummy</title>
+  <%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track' => true %>
+  <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>
+  <%= csrf_meta_tags %>
+</head>
+<body>
+
+<%= yield %>
+
+</body>
+</html>

data/spec/dummy/bin/bundle

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+load Gem.bin_path('bundler', 'bundle')

data/spec/dummy/bin/rails

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require_relative '../config/boot'
+require 'rails/commands'

data/spec/dummy/bin/rake

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

data/spec/dummy/config.ru

@@ -0,0 +1,4 @@
+# This file is used by Rack-based servers to start the application.
+
+require ::File.expand_path('../config/environment',  __FILE__)
+run Rails.application

data/spec/dummy/config/application.rb

@@ -0,0 +1,27 @@
+require File.expand_path('../boot', __FILE__)
+
+require 'active_record/railtie'
+require 'action_controller/railtie'
+require 'action_mailer/railtie'
+require 'sprockets/railtie'
+require 'jquery-rails'
+
+Bundler.require(*Rails.groups)
+require 'autonumeric-rails'
+
+module Dummy
+  class Application < Rails::Application
+    # Settings in config/environments/* take precedence over those specified here.
+    # Application configuration should go into files in config/initializers
+    # -- all .rb files in that directory are automatically loaded.
+
+    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
+    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # config.time_zone = 'Central Time (US & Canada)'
+
+    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
+    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # config.i18n.default_locale = :de
+  end
+end
+