auto_strip_attributes 1.0.0 → 1.0.1

data/.gitignore

@@ -7,3 +7,5 @@ pkg/*
 .project
 .idea
 .redcar
+
+help

data/.travis.yml

@@ -0,0 +1,6 @@
+rvm:
+  - 1.8.7 # (current default)
+  - 1.9.2
+gemfile:
+  - gemfiles/Gemfile.rails-3.1.x
+  - gemfiles/Gemfile.rails-3.0.x

data/README.md

@@ -29,18 +29,34 @@ class User < ActiveRecord::Base
 end
 ```
 
+# Requirements
+
+Gem has been tested with ruby 1.8.7, 1.9.2 and Rails 3.x. Although it should also work with previous versions of rails.
+
+http://travis-ci.org/#!/holli/auto_strip_attributes
+
 # Support
 
 Submit suggestions or feature requests as a GitHub Issue or Pull Request. Remember to update tests. Tests are quite extensive.
 
+# Other approaches
+
+This gem works by addin before_validation hook and setting attributes with self[attribute]=stripped_value. See: https://github.com/holli/auto_strip_attributes/blob/master/lib/auto_strip_attributes.rb
+
+Other approaches could include calling attribute= from before_validation. This would end up calling possible custom setters twice. Might not be desired effect (e.g. if setter does some logging).
+
+Method chaining attribute= can be also used. But then stripping would be omitted if there is some code that calls model[attribute]= directly. This could happen easily when using hashes in some places.
+
 ## Similar gems
 
 There are many similar gems. Most of those don't have :squish or :nullify options. Those gems
-might have some extra methods whereas this gem is kept as simple as possible.
+might have some extra methods whereas this gem is kept as simple as possible. These gems have a bit
+different approaches. See discussion in previous chapter.
 
 - https://github.com/phatworx/acts_as_strip
 - https://github.com/rmm5t/strip_attributes
 - https://github.com/thomasfedb/attr_cleaner
+- https://github.com/mdeering/attribute_normalizer (Bit hardcore approach, more features and more complex)
 
 # Licence
 

data/auto_strip_attributes.gemspec

@@ -19,10 +19,11 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
 
-  s.add_runtime_dependency "activemodel", "~> 3.0"
+  s.add_runtime_dependency "activerecord", ">= 3.0"
 
-  s.add_development_dependency "activerecord", "~> 3.0"
-  s.add_development_dependency "minitest",  "~> 2.5.0"
-  s.add_development_dependency 'ruby-debug'
+  s.add_development_dependency "activerecord", ">= 3.0"
+  s.add_development_dependency "minitest",  "2.6.0"
+  s.add_development_dependency "mocha", "~> 0.9.12"
+  #s.add_development_dependency 'ruby-debug'
   s.add_development_dependency 'rake'
 end

data/gemfiles/Gemfile.rails-3.0.x

@@ -0,0 +1,8 @@
+source "http://rubygems.org"
+
+# This is for testing with rails 3.0
+
+gem 'rake'
+gem "activerecord", "~> 3.0.0"
+gem "minitest",  "2.6.0"
+gem "mocha", "~> 0.9.12"

data/gemfiles/Gemfile.rails-3.1.x

@@ -0,0 +1,8 @@
+source "http://rubygems.org"
+
+# This is for testing with rails 3.0
+
+gem 'rake'
+gem "activerecord", "~> 3.0.0"
+gem "minitest",  "2.6.0"
+gem "mocha", "~> 0.9.12"

data/lib/auto_strip_attributes.rb

@@ -33,5 +33,5 @@ module AutoStripAttributes
 end
 
 ActiveRecord::Base.send(:extend, AutoStripAttributes) if defined? ActiveRecord
-#ActiveModel::Validations::HelperMethods.send(:include, AutoStripAttributes)
+#ActiveModel::Validations::HelperMethods.send(:include, AutoStripAttributes) if defined? ActiveRecord
 

data/lib/auto_strip_attributes/version.rb

@@ -1,4 +1,4 @@
 module AutoStripAttributes
   #VERSION = "0.0.1"
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/auto_strip_attributes_test.rb

@@ -1,8 +1,28 @@
-require "test/test_helper"
+require 'minitest/autorun'
+require "active_record"
+require "auto_strip_attributes"
+#require 'ruby-debug'
+require 'mocha'
+
+
+#require "test/test_helper"
 # bundle exec ruby test/auto_strip_attributes_test.rb -v --name /test_name/
 
 #class AutoStripAttributesTest < Test::Unit::TestCase
 #class AutoStripAttributesTest < MiniTest::Unit::TestCase
+
+class MockRecordParent
+  include ActiveModel::Validations
+  include ActiveModel::Validations::Callbacks
+  extend AutoStripAttributes
+
+  # Overriding @record[key]=val , that's only found in activerecord, not in ActiveModel
+  def []=(key, val)
+    # send("#{key}=", val)  # We dont want to call setter again
+    instance_variable_set(:"@#{key}", val)
+  end
+end
+
 describe AutoStripAttributes do
 
   def setup
@@ -14,49 +34,57 @@ describe AutoStripAttributes do
   end
 
   describe "Basic attribute with default options" do
-    class MockRecordBasic < ActiveRecord::Base
-      column :foo, :string
+    class MockRecordBasic < MockRecordParent
+      attr_accessor :foo
       auto_strip_attributes :foo
     end
-    before do
-      @record = MockRecordBasic.new()
-    end
 
     it "should be ok for normal strings" do
+      @record = MockRecordBasic.new()
       @record.foo = " aaa \t"
       @record.valid?
       @record.foo.must_equal "aaa"
     end
 
     it "should set empty strings to nil" do
+      @record = MockRecordBasic.new()
       @record.foo = " "
       @record.valid?
       @record.foo.must_be_nil
     end
 
     it "should call strip method to attribute if possible" do
-      str_mock = MiniTest::Mock.new()
-      str_mock.expect :'nil?', false
-      str_mock.expect :strip, (@stripped_str="stripped_str_here")
+      @record = MockRecordBasic.new()
+      str_mock = "  strippable_str  "
+      str_mock.expects(:strip).returns(@stripped_str="stripped_str_here")
       @record.foo = str_mock
       @record.valid?
-      str_mock.verify
+      assert true
       @record.foo.must_be_same_as @stripped_str
+
+      #str_mock.expect :'nil?', false
+      #str_mock.expect :strip, (@stripped_str="stripped_str_here")
+      #@record.foo = str_mock
+      #@record.valid?
+      #str_mock.verify
+      #@record.foo.must_be_same_as @stripped_str
     end
 
     it "should not call strip method for non strippable attributes" do
+      @record = MockRecordBasic.new()
       str_mock = MiniTest::Mock.new() # answers false to str_mock.respond_to?(:strip)
-      str_mock.expect :'nil?', false
       @record.foo = str_mock
       @record.valid?
-      str_mock.verify
       assert @record.foo === str_mock
+      str_mock.verify # "Should not call anything on mock when respond_to is false"
     end
   end
 
   describe "Attribute with nullify option" do
-    class MockRecordWithNullify < ActiveRecord::Base
-      column :foo, :string
+    #class MockRecordWithNullify < ActiveRecord::Base
+    class MockRecordWithNullify < MockRecordParent
+      #column :foo, :string
+      attr_accessor :foo
       auto_strip_attributes :foo, :nullify => false
     end
 
@@ -69,8 +97,9 @@ describe AutoStripAttributes do
   end
 
   describe "Attribute with squish option" do
-    class MockRecordWithSqueeze < ActiveRecord::Base
-      column :foo, :string
+    class MockRecordWithSqueeze < MockRecordParent #< ActiveRecord::Base
+      #column :foo, :string
+      attr_accessor :foo
       auto_strip_attributes :foo, :squish => true
     end
 
@@ -90,11 +119,12 @@ describe AutoStripAttributes do
   end
 
   describe "Multible attributes with multiple options" do
-    class MockRecordWithMultipleAttributes < ActiveRecord::Base
-      column :foo, :string
-      column :bar, :string
-      column :biz, :string
-      column :bang, :integer
+    class MockRecordWithMultipleAttributes < MockRecordParent #< ActiveRecord::Base
+      #column :foo, :string
+      #column :bar, :string
+      #column :biz, :string
+      #column :bang, :integer
+      attr_accessor :foo, :bar, :biz, :bang
       auto_strip_attributes :foo, :bar
       auto_strip_attributes :biz, {:nullify => false, :squish => true}
     end
@@ -112,8 +142,9 @@ describe AutoStripAttributes do
   end
 
   describe "Attribute with custom setter" do
-    class MockRecordWithCustomSetter < ActiveRecord::Base
-      column :foo, :string
+    class MockRecordWithCustomSetter < MockRecordParent # < ActiveRecord::Base
+      #column :foo, :string
+      attr_accessor :foo
       auto_strip_attributes :foo
 
       def foo=(val)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: auto_strip_attributes
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Olli Huotari
@@ -15,71 +15,73 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-26 00:00:00 Z
+date: 2011-09-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  name: activerecord
   prerelease: false
-  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
         hash: 7
         segments: 
         - 3
         - 0
         version: "3.0"
+  type: :runtime
   version_requirements: *id001
-  name: activemodel
 - !ruby/object:Gem::Dependency 
+  name: activerecord
   prerelease: false
-  type: :development
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
         hash: 7
         segments: 
         - 3
         - 0
         version: "3.0"
+  type: :development
   version_requirements: *id002
-  name: activerecord
 - !ruby/object:Gem::Dependency 
+  name: minitest
   prerelease: false
-  type: :development
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 27
+        hash: 23
         segments: 
         - 2
-        - 5
+        - 6
         - 0
-        version: 2.5.0
+        version: 2.6.0
+  type: :development
   version_requirements: *id003
-  name: minitest
 - !ruby/object:Gem::Dependency 
+  name: mocha
   prerelease: false
-  type: :development
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 3
+        hash: 35
         segments: 
         - 0
-        version: "0"
+        - 9
+        - 12
+        version: 0.9.12
+  type: :development
   version_requirements: *id004
-  name: ruby-debug
 - !ruby/object:Gem::Dependency 
+  name: rake
   prerelease: false
-  type: :development
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -89,8 +91,8 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  type: :development
   version_requirements: *id005
-  name: rake
 description: AutoStripAttributes helps to remove unnecessary whitespaces from ActiveRecord or ActiveModel attributes. It's good for removing accidental spaces from user inputs. It works by adding a before_validation hook to the record. It has option to set empty strings to nil or to remove extra spaces inside the string.
 email: 
 - olli.huotari@iki.fi
@@ -102,14 +104,16 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
 - auto_strip_attributes.gemspec
+- gemfiles/Gemfile.rails-3.0.x
+- gemfiles/Gemfile.rails-3.1.x
 - lib/auto_strip_attributes.rb
 - lib/auto_strip_attributes/version.rb
 - test/auto_strip_attributes_test.rb
-- test/test_helper.rb
 homepage: https://github.com/holli/auto_strip_attributes
 licenses: []
 

data/test/test_helper.rb

@@ -1,16 +0,0 @@
-require 'minitest/autorun'
-require "active_record"
-require "auto_strip_attributes"
-#require 'ruby-debug'
-
-class ActiveRecord::Base
-  alias_method :save, :valid?
-  def self.columns()
-    @columns ||= []
-  end
-
-  def self.column(name, sql_type = nil, default = nil, null = true)
-    @columns ||= []
-    @columns << ActiveRecord::ConnectionAdapters::Column.new(name.to_s, default, sql_type, null)
-  end
-end