auto_ria_api 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8510748df81bd748312782710a402741ef40d43e1c99534074edcd6c99a3fbc
-  data.tar.gz: 24dd5cf3ef295c3233aa4d3dc077189713db56840ea3e8acef5b43315959cfbc
+  metadata.gz: 8635fbea479db01d9e8530a65f4ad495e69adc0c22a28795f038029d5ac1af13
+  data.tar.gz: f9a5e97b35a6f3c9243accc396075134689bd8f8dc235604e9c09f90ebf3a1e9
 SHA512:
-  metadata.gz: 33be752da4987dfc7dc6f8ffde4cb9b6c98f9e13ac44992d9fbb6ced4e09dfff64f6bd82fdc4ac4f65203ef890f9316c592850c019daeb5b8a33b1545fbd5d7e
-  data.tar.gz: cd375a982d420af853b01dc1c4d347582446d027338a5c03a9f1011ec208bad2f3f19c63d52b38a9743aa58ec603c724dc69ae119fd666677f5c69e3c050bbd2
+  metadata.gz: d4e0c32bb7ca8db34bb9fb30bafe33ef953a3e275d6ecc8e49b6211b79b1e137e99b326384d043acec0fcc2218fea830dc9f97bcc3efe587bb0b5bafd9307c55
+  data.tar.gz: 4027e5bc143eaa35a068513b03824af36fb432fd6372cb2e8a66a37732f67935ef4539a32cdc93195ad232adb1c43fe976d2c0bbe5188b934746773bfa2c4152

data/Gemfile

@@ -1,4 +1,4 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 

data/README.md

@@ -61,7 +61,7 @@ Help is appreciated Feel free to fork and make a difference!
 
 ## Tests
 
-Provide `ENV['AUTO_RIA_API_KEY']` in your `.env` file or add it to system env: `export AUTO_RIA_API_KEY=your_key` and run `rspec` 
+run `rspec` 
 
 ## License
 

data/auto_ria_api.gemspec

@@ -21,8 +21,8 @@ Gem::Specification.new do |spec|
     spec.metadata['source_code_uri'] = 'https://github.com/drkmen/auto_ria_api'
     spec.metadata['changelog_uri'] = 'https://github.com/drkmen/auto_ria_api'
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
   # Specify which files should be added to the gem when it is released.
@@ -30,11 +30,11 @@ Gem::Specification.new do |spec|
   spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.17"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/auto_ria_api.rb

@@ -4,34 +4,43 @@ require 'json'
 
 module AutoRiaApi
   class Base
+    attr_accessor :api_key
+    attr_reader :default_url
+
+    DEFAULT_URL = 'https://developers.ria.com'.freeze
+
     def initialize(api_key:, url: nil)
-      raise ArgumentError, 'API key should not be empty.' if blank?(api_key)
+      raise ArgumentError, 'API key should not be empty' if blank?(api_key)
+
       @api_key = api_key
-      @default_url = url || 'https://developers.ria.com/'
+      @default_url = url || DEFAULT_URL
     end
 
     def types
       request '/auto/categories'
     end
 
-    def carcasses(type:, grouped: false, all: false)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
-      return request '/auto/bodystyles' if all
-      group = '_group' if grouped
-      request "/auto/categories/#{type}/bodystyles/#{group}"
+    def carcasses(type:, options: {})
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+      return request '/auto/bodystyles' if options[:all]
+
+      group = '/_group' if options[:grouped]
+      request "/auto/categories/#{type}/bodystyles#{group}"
     end
 
     def marks(type:)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
       request "/auto/categories/#{type}/marks"
     end
 
-    def models(type:, mark:, grouped: false, all: false)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
-      raise ArgumentError, 'Mark should not be empty.' if blank?(mark)
-      return request '/auto/models' if all
-      group = '_group' if grouped
-      request "/auto/categories/#{type}/marks/#{mark}/models/#{group}"
+    def models(type:, mark:, options: {})
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+      raise ArgumentError, '`mark` should not be empty' if blank?(mark)
+      return request '/auto/models' if options[:all]
+
+      group = options[:grouped] ? '/_group' : ''
+      request "/auto/categories/#{type}/marks/#{mark}/models" + group
     end
 
     def regions
@@ -39,17 +48,19 @@ module AutoRiaApi
     end
 
     def cities(region:)
-      raise ArgumentError, 'Region should not be empty.' if blank?(region)
+      raise ArgumentError, '`region` should not be empty' if blank?(region)
+
       request "/auto/states/#{region}/cities"
     end
 
     def gearboxes(type:)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
       request "/auto/categories/#{type}/gearboxes"
     end
 
     def driver_types
-      raise 'Not implemented'
+      raise NotImplementedError
     end
 
     def fuels
@@ -61,40 +72,44 @@ module AutoRiaApi
     end
 
     def options(type:)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
       request "/auto/categories/#{type}/auto_options"
     end
 
     def average_price(*args)
-      raise 'Not implemented'
+      raise NotImplementedError
     end
 
     def search(*args)
-      raise 'Not implemented'
+      raise NotImplementedError
     end
 
     def info(car_id:)
-      raise ArgumentError, 'car_id should not be empty.' if blank?(car_id)
+      raise ArgumentError, '`car_id` should not be empty' if blank?(car_id)
+
       request '/auto/info', auto_id: car_id
     end
 
     def photos(car_id:)
-      raise ArgumentError, 'car_id should not be empty.' if blank?(car_id)
+      raise ArgumentError, '`car_id` should not be empty' if blank?(car_id)
+
       request "/auto/fotos/#{car_id}", auto_id: car_id
     end
 
     private
 
     def request(url, params = {}, method = :get_response)
-      uri = URI(@default_url + url)
-      uri.query = URI.encode_www_form(params.merge(api_key: @api_key))
+      uri = URI(default_url + url)
+      uri.query = URI.encode_www_form(params.merge(api_key: api_key))
       response = Net::HTTP.public_send(method, uri)
       parsed response
     end
 
     def parsed(response)
       res = JSON.parse(response.body)
-      raise Error, res.dig('error') if res.is_a?(Hash) && res.has_key?('error')
+      raise ResponseError, res.dig('error').to_s if res.is_a?(Hash) && res.has_key?('error')
+
       yield res if block_given?
       res
     end
@@ -104,5 +119,5 @@ module AutoRiaApi
     end
   end
 
-  class Error < StandardError; end
+  class ResponseError < StandardError; end
 end

data/lib/auto_ria_api/version.rb

@@ -1,3 +1,3 @@
 module AutoRiaApi
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: auto_ria_api
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - drkmen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-14 00:00:00.000000000 Z
+date: 2020-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler