auto_ria_api 0.1.1 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ad52d92d1b42ebfe2298c8c65d6e1860f88c6ad794fa8fc51dadf2de730422a
-  data.tar.gz: 92653049945c86cacf4ea14f83de2d6897d7aaf70663f44fb4d4d67dd31fb480
+  metadata.gz: a8ab0dcbe23001fb09d111b0ec606aa294c36b3127d12305e34b6e56ff006cf9
+  data.tar.gz: 86482a3933c9471daa342de07f7fcb27432beb7888f48f54d8b8657bf3970464
 SHA512:
-  metadata.gz: c55d7cda985ce3ec8b7a2086a55ec4ba9c50699f09bed831dc0384f63dcf4ed947306f037ad5b47f5beb13a5708b2f0e475cdd360cbe53eccee7a718d5aab8b5
-  data.tar.gz: 4037cbeb2ba4f3c93dd2379e149f5f98f4530118d9dd2e5bb4e5d6be5075dd260210110c1102fb929d4b43941e8cc4268c9437d2196f08dce115d4f3a1aa1e8a
+  metadata.gz: 5a920fe0b529b321c8afd3579b2b1079c8fa0e20dcd1260a198a82d6de74765bea89e3dc211b03161096356402614847f1902cd4e7d2561217b52b90a4fde0a7
+  data.tar.gz: 53ac1564848628d3fbe1749dfa86452ff4a4f0bee6707276ab38bef2623d77fc46c18486bcf46927858c10c71fd2f5ef5e3ad57ddffc4b58a89226901f137cf5

data/.gitignore

@@ -9,3 +9,6 @@
 
 # rspec failure tracking
 .rspec_status
+
+# IDE
+.idea/

data/.rubocop.yml

@@ -0,0 +1,58 @@
+#inherit_from: .rubocop_todo.yml
+AllCops:
+  TargetRubyVersion: '2.5'
+  DisplayCopNames: true
+  Exclude:
+    - Gemfile
+    - bin/*
+    - config/**/*
+    - config/application.rb
+    - db/**/*
+    - node_modules/**/*
+    - vendor/engines/*/bin/*
+    - vendor/engines/*/config/*
+    - vendor/engines/*/*.gemspec
+
+Documentation:
+  Enabled: false
+
+Metrics/ClassLength:
+  Max: 250
+
+Metrics/MethodLength:
+  Max: 50
+  Exclude:
+    - lib/tasks/*.rake
+    - spec/lib/tl_lincoln/factories/*
+
+Metrics/AbcSize:
+  Max: 30
+
+Layout/EndOfLine:
+  EnforcedStyle: lf
+
+Metrics/BlockLength:
+  Max: 30
+  Exclude:
+    - spec/**/*
+    - lib/tasks/*.rake
+    - lib/tl_lincoln/spec/**/*
+    - config/routes.rb
+    - config/environments/*
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/ParameterLists:
+  Max: 10
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/BlockComments:
+  Exclude:
+    - spec/spec_helper.rb
+
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - !ruby/regexp /.xml.builder$/

data/Gemfile

@@ -1,4 +1,4 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    auto_ria_api (0.1.1)
+    auto_ria_api (0.1.5)
 
 GEM
   remote: https://rubygems.org/
@@ -32,4 +32,4 @@ DEPENDENCIES
   rspec (~> 3.0)
 
 BUNDLED WITH
-   1.17.1
+   1.17.3

data/README.md

@@ -27,16 +27,19 @@ First of all you need an api_key which you can get at [https://developers.ria.co
 @client = AutoRiaApi::Base.new(api_key: ENV['AUTO_RIA_API_KEY'])
 
 # Methods:
-@clien.types
-@clien.carcasses(type, grouped: false, all: false)
-@clien.marks(carcasse)
-@clien.models(carcasse, mark, grouped: false, all: false)
-@clien.regions
-@clien.cities(region)
-@clien.gearboxes(carcasse)
-@clien.fuels
-@clien.colors
-@clien.options(carcasse)
+@client.types
+@client.carcasses(type:, options: { grouped: false, all: false })
+@client.marks(type:)
+@client.models(type:, mark, options: { grouped: false, all: false })
+@client.regions
+@client.cities(region:)
+@client.gearboxes(type:)
+@client.driver_types(type:)
+@client.fuels
+@client.colors
+@client.options(type:)
+
+@client.info(car_id:)
 # all method arguments assuming ID (Integer)
 
 ```
@@ -59,7 +62,7 @@ Help is appreciated Feel free to fork and make a difference!
 
 ## Tests
 
-Provide `ENV['AUTO_RIA_API_KEY']` in your `.env` file or add it to system env: `export AUTO_RIA_API_KEY=your_key` and run `rspec` 
+run `rspec` 
 
 ## License
 

data/auto_ria_api.gemspec

@@ -21,8 +21,8 @@ Gem::Specification.new do |spec|
     spec.metadata['source_code_uri'] = 'https://github.com/drkmen/auto_ria_api'
     spec.metadata['changelog_uri'] = 'https://github.com/drkmen/auto_ria_api'
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
   # Specify which files should be added to the gem when it is released.
@@ -30,11 +30,11 @@ Gem::Specification.new do |spec|
   spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.17"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/auto_ria_api.rb

@@ -4,34 +4,43 @@ require 'json'
 
 module AutoRiaApi
   class Base
+    attr_accessor :api_key
+    attr_reader :default_url
+
+    DEFAULT_URL = 'https://developers.ria.com'.freeze
+
     def initialize(api_key:, url: nil)
-      raise ArgumentError, 'API key should not be empty.' if blank?(api_key)
+      raise ArgumentError, 'API key should not be empty' if blank?(api_key)
+
       @api_key = api_key
-      @default_url = url || 'https://developers.ria.com/'
+      @default_url = url || DEFAULT_URL
     end
 
     def types
       request '/auto/categories'
     end
 
-    def carcasses(type:, grouped: false, all: false)
-      raise ArgumentError, 'Type should not be empty.' if blank?(type)
-      return request '/auto/bodystyles' if all
-      group = '_group' if grouped
-      request "/auto/categories/#{type}/bodystyles/#{group}"
+    def carcasses(type:, options: {})
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+      return request '/auto/bodystyles' if options[:all]
+
+      group = '/_group' if options[:grouped]
+      request "/auto/categories/#{type}/bodystyles#{group}"
     end
 
-    def marks(carcasse:)
-      raise ArgumentError, 'Carcass should not be empty.' if blank?(carcasse)
-      request "/auto/categories/#{carcasse}/marks"
+    def marks(type:)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
+      request "/auto/categories/#{type}/marks"
     end
 
-    def models(carcasse:, mark:, grouped: false, all: false)
-      raise ArgumentError, 'Carcass should not be empty.' if blank?(carcasse)
-      raise ArgumentError, 'Mark should not be empty.' if blank?(mark)
-      return request '/auto/models' if all
-      group = '_group' if grouped
-      request "/auto/categories/#{carcasse}/marks/#{mark}/models/#{group}"
+    def models(type:, mark:, options: {})
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+      raise ArgumentError, '`mark` should not be empty' if blank?(mark)
+      return request '/auto/models' if options[:all]
+
+      group = options[:grouped] ? '/_group' : ''
+      request "/auto/categories/#{type}/marks/#{mark}/models" + group
     end
 
     def regions
@@ -39,17 +48,21 @@ module AutoRiaApi
     end
 
     def cities(region:)
-      raise ArgumentError, 'Region should not be empty.' if blank?(region)
+      raise ArgumentError, '`region` should not be empty' if blank?(region)
+
       request "/auto/states/#{region}/cities"
     end
 
-    def gearboxes(carcasse:)
-      raise ArgumentError, 'Carcasse should not be empty.' if blank?(carcasse)
-      request "/auto/categories/#{carcasse}/gearboxes"
+    def gearboxes(type:)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
+      request "/auto/categories/#{type}/gearboxes"
     end
 
-    def driver_types
-      raise 'Not implemented'
+    def driver_types(type:)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
+      request "/auto/categories/#{type}/driverTypes"
     end
 
     def fuels
@@ -60,39 +73,47 @@ module AutoRiaApi
       request '/auto/colors'
     end
 
-    def options(carcasse:)
-      raise ArgumentError, 'Carcasse should not be empty.' if blank?(carcasse)
-      request "/auto/categories/#{carcasse}/auto_options"
+    def options(type:)
+      raise ArgumentError, '`type` should not be empty' if blank?(type)
+
+      request "/auto/categories/#{type}/auto_options"
     end
 
-    def average_price(*args)
-      raise 'Not implemented'
+    def average_price(params)
+      request "/auto/average_price", params
     end
 
     def search(*args)
-      raise 'Not implemented'
+      raise NotImplementedError
     end
 
     def info(car_id:)
-      raise ArgumentError, 'car_id should not be empty.' if blank?(car_id)
+      raise ArgumentError, '`car_id` should not be empty' if blank?(car_id)
+
       request '/auto/info', auto_id: car_id
     end
 
+    def photos(car_id:)
+      raise ArgumentError, '`car_id` should not be empty' if blank?(car_id)
+
+      request "/auto/fotos/#{car_id}", auto_id: car_id
+    end
+
     private
 
     def request(url, params = {}, method = :get_response)
-      uri = URI(@default_url + url)
-      uri.query = URI.encode_www_form(params.merge(api_key: @api_key))
+      uri = URI(default_url + url)
+      uri.query = URI.encode_www_form(params.merge(api_key: api_key))
       response = Net::HTTP.public_send(method, uri)
       parsed response
     end
 
     def parsed(response)
       res = JSON.parse(response.body)
+      raise ResponseError, res.dig('error').to_s if res.is_a?(Hash) && res.has_key?('error')
+
       yield res if block_given?
       res
-    rescue => e
-      e
     end
 
     def blank?(arg)
@@ -100,5 +121,5 @@ module AutoRiaApi
     end
   end
 
-  class Error < StandardError; end
+  class ResponseError < StandardError; end
 end

data/lib/auto_ria_api/version.rb

@@ -1,3 +1,3 @@
 module AutoRiaApi
-  VERSION = '0.1.1'
+  VERSION = '0.1.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: auto_ria_api
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.6
 platform: ruby
 authors:
 - drkmen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-12 00:00:00.000000000 Z
+date: 2020-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -61,6 +61,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock