authz_jurnal_client 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d451a03c29d40d2db74d2e4ecb7a3af61869f0851603f588ab17fe7f7ff79c0f
-  data.tar.gz: 196c69edecba8d9151f1040b3d99d5501a29bacae2758e305aea4e0c78881e06
+  metadata.gz: d069465c6785118e6e04894f5e8b876d782d240db6a0202086f9891e8cba5e10
+  data.tar.gz: c2c16f5fe8092437ad332a843544fd284865ba291509f10fd8d586740eaf03e0
 SHA512:
-  metadata.gz: 03dc07308fdd976ca844f90790ff12bd1259d26db55b048206d4aa85b75aefa9d3f63fc919afd9e491630fdb2bdc60db56b6230de6fa54540d6f4ef695a6401d
-  data.tar.gz: 034cdd2ba58fe841bf15e21b8a024e79f700e686d7824120e5622ac60b39283a50337a1fa6be8e3dcade4180c09d932275a8d6ec1a77102d66a7bdda498c588c
+  metadata.gz: d041033d4ee886da9f2568f34b4737252b8c996dd29b47f143bd80682b8cb67a2f0b16691550860c0ea649e8cf39437a46918e4643751c58b17f809ef6f17fb2
+  data.tar.gz: a7fc7343a40bba4805b8d0796f9db0b3d7fafe5e7654938eae98d92548aa4676c6b6136bb1fa48555cba40659a4b6c128333c7399e0ecb05fbb676d1516c78ba

data/Gemfile

@@ -15,5 +15,5 @@ gem "redis"
 
 gem "faraday"
 
-gem "byebug"
+gem 'simplecov', require: false
 

data/Gemfile.lock

@@ -1,15 +1,15 @@
 PATH
   remote: .
   specs:
-    authz_jurnal_client (0.0.5)
+    authz_jurnal_client (0.0.7)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    byebug (11.1.3)
     connection_pool (2.3.0)
     diff-lcs (1.5.0)
+    docile (1.4.0)
     faraday (2.7.4)
       faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
@@ -24,13 +24,13 @@ GEM
       redis-client (>= 0.9.0)
     redis-client (0.12.1)
       connection_pool
-    regexp_parser (2.6.2)
+    regexp_parser (2.7.0)
     rexml (3.2.5)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
       rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.0)
+    rspec-core (3.12.1)
       rspec-support (~> 3.12.0)
     rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
@@ -39,7 +39,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.44.1)
+    rubocop (1.45.1)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.2.0.0)
@@ -53,6 +53,12 @@ GEM
       parser (>= 3.1.1.0)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.5)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     unicode-display_width (2.4.2)
 
 PLATFORMS
@@ -60,12 +66,12 @@ PLATFORMS
 
 DEPENDENCIES
   authz_jurnal_client!
-  byebug
   faraday
   rake (~> 13.0)
   redis
   rspec (~> 3.0)
   rubocop (~> 1.21)
+  simplecov
 
 BUNDLED WITH
    1.17.3

data/README.md

@@ -10,7 +10,7 @@ AuthzJurnalClient allows you to access the user roles API directly. It also prov
 Install the gem thusly in the gemfile
 
 ``` markdown
-gem 'authz_jurnal_client' or gem install authz_jurnal_client
+gem 'authz_jurnal_client',  git: 'git@bitbucket.org:jurnal/authz-jurnal-client.git', tag: 'v0.0.1'
 ```
 
 

data/lib/authz_jurnal_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AuthzJurnalClient
-  VERSION = "0.0.5"
+  VERSION = "0.0.7"
 end

data/lib/authz_jurnal_client.rb

@@ -2,7 +2,6 @@ require "ostruct"
 require "json"
 require "faraday"
 require "redis"
-require 'byebug'
 
 require_relative "authz_jurnal_client/version"
 
@@ -11,7 +10,7 @@ module AuthzJurnalClient
 
   class UserRoles
     class << self
-      attr_accessor :redis, :domain, :authorization, :expiry
+      attr_accessor :redis, :domain, :authorization, :expiry, :cache
       def config(opts = {})
         @authorization = opts[:authorization]
         @headers = {"Authorization" => @authorization}
@@ -19,26 +18,33 @@ module AuthzJurnalClient
         redis_path = opts[:redis] || 'redis://localhost:6379'
         @redis = Redis.new(url: redis_path)
         @expiry = opts[:expiry] || 3600
+        @cache = opts[:cache].nil? ? true : opts[:cache]
       end
 
       def call(id, cid)
-        if @redis
+        return get_errors({errors: { messages: "uid or cid cannot be blank!"}}) if id.nil? || cid.nil?
+
+        if @redis && @cache
           cached = @redis.get(make_key(id, cid))
-          return get_roles(cached) if cached
+          return get_response(cached) if cached
         end
 
         response = backend_request(id, cid)
-        return unless response.success?
+        if !response.success?
+          return get_errors({errors: { messages: "request failed to fetch data!"}})
+        end
 
         @redis&.setex(make_key(id, cid), @expiry, response.body)
-        get_roles(response.body)
+        get_response(response.body)
       rescue Redis::CannotConnectError
         response = backend_request(id, cid)
-        get_roles(response.body)
+        get_response(response.body)
       end
 
       def backend_request(id, cid)
         conn = Faraday.new("#{@domain}/api/v1/users/#{id}") do |f|
+          f.options.open_timeout = 10
+          f.options.timeout = 60
           f.adapter :net_http
         end
 
@@ -49,9 +55,15 @@ module AuthzJurnalClient
         "manage_roles:#{id}-#{cid}"
       end
 
-      def get_roles(j)
+      def get_response(j)
         data = eval(j)
-        JSON.parse( data.to_json, object_class: OpenStruct).data.roles
+        response = JSON.parse( data.to_json, object_class: OpenStruct)
+        response.data.roles
+      end
+
+      def get_errors(e)
+        data = e.is_a?(Hash) ? e : eval(e)
+        response = JSON.parse( data.to_json, object_class: OpenStruct)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authz_jurnal_client
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Alam Topani
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-06 00:00:00.000000000 Z
+date: 2023-02-09 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -17,21 +17,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".byebug_history"
 - ".rspec"
-- ".rspec_status"
 - Gemfile
 - Gemfile.lock
 - README.md
 - Rakefile
-- authz_jurnal_client-0.0.1.gem
-- authz_jurnal_client-0.0.2.gem
-- authz_jurnal_client-0.0.3.gem
-- authz_jurnal_client-0.0.4.gem
 - lib/authz_jurnal_client.rb
 - lib/authz_jurnal_client/version.rb
 - lib/sig/authz_jurnal_client.rbs
-homepage: https://bitbucket.org/jurnal/authz-jurnal-client/src/nat-dev/
+homepage: https://bitbucket.org/jurnal/authz-jurnal-client/src/master/
 licenses: []
 metadata: {}
 post_install_message:

data/.byebug_history

@@ -1,11 +0,0 @@
-continue
-d.to_json
-d
-continue
-JSON.parse( j, object_class: OpenStruct).data.roles
-j
-continue
-JSON.parse( j, object_class: OpenStruct).data.roles
-j
-continue
-roles = AuthzJurnalClient::UserRoles.call(1, 1)

data/.rspec_status

@@ -1,9 +0,0 @@
-example_id                                | status | run_time        |
------------------------------------------ | ------ | --------------- |
-./spec/authz_jurnal_client_spec.rb[1:1:1] | passed | 0.0031 seconds  |
-./spec/authz_jurnal_client_spec.rb[1:2:1] | passed | 0.01582 seconds |
-./spec/authz_jurnal_client_spec.rb[1:2:2] | passed | 0.00067 seconds |
-./spec/authz_jurnal_client_spec.rb[1:3:1] | passed | 0.00443 seconds |
-./spec/authz_jurnal_client_spec.rb[1:3:2] | passed | 0.00199 seconds |
-./spec/authz_jurnal_client_spec.rb[1:4:1] | passed | 0.00143 seconds |
-./spec/authz_jurnal_client_spec.rb[1:4:2] | passed | 0.00153 seconds |