authorizy 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3025788b5adf8a466ed73bfc45f709612ad1b05de0e5e887a84c67c31cd5074
-  data.tar.gz: 354c47240e842ecdd4afa112e95e02ef094f94dfcd17e9431d7dbe97ee580283
+  metadata.gz: 2d7006471814660a18a36666a304b2a8178d0e6c206c08b4c7d84f1bb0619214
+  data.tar.gz: 75484b0f5b9960632799937725244e38552e2ad90999ddb9390572cf1880f2e5
 SHA512:
-  metadata.gz: a8a73b41a1b8ea247cd59114d9ddf857f7727efa4c780fd5b6fe17a8805aa86528061e7fa49ec2f32c9fe4a80bb0d05a70341d8176af302cb6e31da4bdce9403
-  data.tar.gz: d9c32ae7a0b4a81742d3caa9879c69b7949cc86ecf104b4e79f7e642fa7b92efb5b4047993a38f2136e8b226dd5119046f5e5faed85134e5f249513c3fed72dc
+  metadata.gz: b2591d21df9e87ac0161c6a03327797350f93b9a230733a2597f9ec703cd853a7de62c3e0fc52c1f6e2fe16fbaabc2c1317ce3e93a5c83284283262b750be875
+  data.tar.gz: 4e2d661a5560bb7f2fd3aca9fb8846e147828bac74b3cea9bcfd803ac1a64a0a95de9d7b7a4a2019cc7ad31c41694ae73a21bd0fb770e9412f537dd406403816

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.2.2
+
+## Fixes
+
+- When Cop returns anything different from `true` it is converted to `false`;
+
 # v0.2.1
 
 ## Fixes

data/lib/authorizy/core.rb

@@ -16,7 +16,7 @@ module Authorizy
                      session_permissions.any? { |tuple| route_match?(tuple) } ||
                      user_permissions.any? { |tuple| route_match?(tuple) }
 
-      return @cop.public_send(cop_controller) if @cop.respond_to?(cop_controller)
+      return @cop.public_send(cop_controller) == true if @cop.respond_to?(cop_controller)
 
       false
     end

data/lib/authorizy/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Authorizy
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/authorizy/core/access_spec.rb

@@ -85,6 +85,76 @@ RSpec.describe Authorizy::Core, '#access?' do
         expect(described_class.new(current_user, params, session, cop: cop).access?).to be(true)
       end
     end
+
+    context 'when cop return nil' do
+      let!(:cop) do
+        Class.new(Authorizy::BaseCop) do
+          def access?
+            false
+          end
+
+          def admin__controller
+            nil
+          end
+        end.new(current_user, params, session)
+      end
+
+      it 'is converted to false' do
+        expect(described_class.new(current_user, params, session, cop: cop).access?).to be(false)
+      end
+    end
+
+    context 'when cop return empty' do
+      let!(:cop) do
+        Class.new(Authorizy::BaseCop) do
+          def access?
+            false
+          end
+
+          def admin__controller
+            ''
+          end
+        end.new(current_user, params, session)
+      end
+
+      it 'is converted to false' do
+        expect(described_class.new(current_user, params, session, cop: cop).access?).to be(false)
+      end
+    end
+
+    context 'when cop return nothing' do
+      let!(:cop) do
+        Class.new(Authorizy::BaseCop) do
+          def access?
+            false
+          end
+
+          def admin__controller; end
+        end.new(current_user, params, session)
+      end
+
+      it 'is converted to false' do
+        expect(described_class.new(current_user, params, session, cop: cop).access?).to be(false)
+      end
+    end
+
+    context 'when cop return true as string' do
+      let!(:cop) do
+        Class.new(Authorizy::BaseCop) do
+          def access?
+            false
+          end
+
+          def admin__controller
+            'true'
+          end
+        end.new(current_user, params, session)
+      end
+
+      it 'is converted to false' do
+        expect(described_class.new(current_user, params, session, cop: cop).access?).to be(false)
+      end
+    end
   end
 
   context 'when user has the controller permission but not action' do

data/spec/authorizy/rspec_spec.rb

@@ -9,23 +9,3 @@ RSpec.describe RSpec::Matchers, '#be_authorized' do
     ).squish
   end
 end
-
-# matcher.actual
-# matcher.actual_formatted
-# matcher.and
-# matcher.description
-# matcher.diffable?
-# matcher.does_not_match?
-# matcher.expected
-# matcher.expected_formatted
-# matcher.expects_call_stack_jump?
-# matcher.failure_message
-# matcher.failure_message_when_negated
-# matcher.match_unless_raises
-# matcher.matcher_name
-# matcher.matcher_name=
-# matcher.matches?
-# matcher.or
-# matcher.present_ivars
-# matcher.rescued_exception
-# matcher.supports_block_expectations?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authorizy
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Washington Botelho
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-05 00:00:00.000000000 Z
+date: 2021-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord