authorizy 0.1.0 → 0.3.0

data/spec/authorizy/expander/expand_spec.rb

@@ -15,19 +15,17 @@ RSpec.describe Authorizy::Expander, '#expand' do
     context 'when data is symbol' do
       let(:permissions) do
         [
-          { action: :create, controller: :controller },
-          { action: :edit, controller: :controller },
-          { action: :new, controller: :controller },
-          { action: :update, controller: :controller },
+          %i[controller create],
+          %i[controller update],
         ]
       end
 
-      it 'mappes the default actions aliases' do
+      it 'maps the default actions aliases' do
         expect(expander.expand(permissions)).to match_array [
-          { 'action' => 'create', 'controller' => 'controller' },
-          { 'action' => 'edit',   'controller' => 'controller' },
-          { 'action' => 'new',    'controller' => 'controller' },
-          { 'action' => 'update', 'controller' => 'controller' },
+          %w[controller create],
+          %w[controller edit],
+          %w[controller new],
+          %w[controller update],
         ]
       end
     end
@@ -35,19 +33,17 @@ RSpec.describe Authorizy::Expander, '#expand' do
     context 'when data is string' do
       let(:permissions) do
         [
-          { 'action' => 'create', 'controller' => 'controller' },
-          { 'action' => 'edit', 'controller' => 'controller' },
-          { 'action' => 'new', 'controller' => 'controller' },
-          { 'action' => 'update', 'controller' => 'controller' },
+          %w[controller create],
+          %w[controller update],
         ]
       end
 
-      it 'mappes the default actions aliases' do
+      it 'maps the default actions aliases' do
         expect(expander.expand(permissions)).to match_array [
-          { 'action' => 'create', 'controller' => 'controller' },
-          { 'action' => 'edit',   'controller' => 'controller' },
-          { 'action' => 'new',    'controller' => 'controller' },
-          { 'action' => 'update', 'controller' => 'controller' },
+          %w[controller create],
+          %w[controller edit],
+          %w[controller new],
+          %w[controller update],
         ]
       end
     end
@@ -55,87 +51,86 @@ RSpec.describe Authorizy::Expander, '#expand' do
 
   context 'when a dependencies is given' do
     context 'when keys and values are strings' do
-      let(:dependencies) { { 'controller' => { 'action' => [{ 'action' => 'action2', 'controller' => 'controller2' }] } } }
-      let!(:permissions) { [{ 'action' => 'action', 'controller' => 'controller' }] }
+      let(:dependencies) { { 'controller' => { 'action' => [%w[controller_2 action_2]] } } }
+      let!(:permissions) { [%w[controller action]] }
 
       it 'addes the dependencies permissions' do
         config_mock(dependencies: dependencies) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller2' },
+            %w[controller action],
+            %w[controller_2 action_2],
           ]
         end
       end
     end
 
     context 'when keys and values are symbol' do
-      let(:dependencies) { { controller: { action: [{ action: :action2, controller: :controller2 }] } } }
-      let!(:permissions) { [{ 'action' => 'action', 'controller' => 'controller' }] }
+      let(:dependencies) { { controller: { action: [%i[controller_2 action_2]] } } }
+      let!(:permissions) { [%w[controller action]] }
 
       it 'addes the dependencies permissions' do
         config_mock(dependencies: dependencies) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller2' },
+            %w[controller action],
+            %w[controller_2 action_2],
           ]
         end
       end
     end
   end
 
-
   context 'when aliases is given' do
-    let!(:permissions) { [{ 'action' => 'action', 'controller' => 'controller' }] }
+    let!(:permissions) { [%w[controller action]] }
 
     context 'when key and values are strings' do
-      let(:aliases) { { 'action' => 'action2' } }
+      let(:aliases) { { 'action' => 'action_2' } }
 
-      it 'mappes the action with the current controller' do
+      it 'maps the action with the current controller' do
         config_mock(aliases: aliases) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller' },
+            %w[controller action],
+            %w[controller action_2],
           ]
         end
       end
     end
 
     context 'when key and values are symbols' do
-      let(:aliases) { { action: :action2 } }
+      let(:aliases) { { action: :action_2 } }
 
-      it 'mappes the action with the current controller' do
+      it 'maps the action with the current controller' do
         config_mock(aliases: aliases) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller' },
+            %w[controller action],
+            %w[controller action_2],
           ]
         end
       end
     end
 
     context 'when key and values are array of strings' do
-      let(:aliases) { { action: %w[action2 action3] } }
+      let(:aliases) { { action: %w[action_2 action_3] } }
 
-      it 'mappes the actions with the current controller' do
+      it 'maps the actions with the current controller' do
         config_mock(aliases: aliases) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller' },
-            { 'action' => 'action3', 'controller' => 'controller' },
+            %w[controller action],
+            %w[controller action_2],
+            %w[controller action_3],
           ]
         end
       end
     end
 
     context 'when key and values are array of symbols' do
-      let(:aliases) { { action: %i[action2 action3] } }
+      let(:aliases) { { action: %i[action_2 action_3] } }
 
-      it 'mappes the actions with the current controller' do
+      it 'maps the actions with the current controller' do
         config_mock(aliases: aliases) do
           expect(expander.expand(permissions)).to match_array [
-            { 'action' => 'action', 'controller' => 'controller' },
-            { 'action' => 'action2', 'controller' => 'controller' },
-            { 'action' => 'action3', 'controller' => 'controller' },
+            %w[controller action],
+            %w[controller action_2],
+            %w[controller action_3],
           ]
         end
       end

data/spec/authorizy/extension/authorizy_question_spec.rb

@@ -12,32 +12,36 @@ RSpec.describe DummyController, '#authorizy?', type: :controller do
   end
 
   context 'when config returns current user' do
-    let!(:current_user) { User.new }
-    let!(:parameters) { ActionController::Parameters.new }
+    let!(:config) { Authorizy.config }
+    let!(:user) { User.new }
+
+    before { allow(Authorizy).to receive(:config).and_return(config) }
 
     context 'when authorizy returns false' do
-      let!(:authorizy) { instance_double('Authorizy::Core', access?: false) }
+      let!(:core) { instance_double('Authorizy::Core', access?: false) }
+      let!(:parameters) { ActionController::Parameters.new(controller: 'controller', action: 'action') }
 
       it 'returns false' do
         allow(Authorizy::Core).to receive(:new)
-          .with(current_user, parameters, session, controller: 'controller', action: 'action')
-          .and_return(authorizy)
+          .with(user, parameters, session, cop: config.cop)
+          .and_return(core)
 
-        config_mock(current_user: current_user) do
+        config_mock(current_user: user) do
           expect(controller.helpers.authorizy?('controller', 'action')).to be(false)
         end
       end
     end
 
     context 'when authorizy returns true' do
-      let!(:authorizy) { instance_double('Authorizy::Core', access?: true) }
+      let!(:core) { instance_double('Authorizy::Core', access?: true) }
+      let!(:parameters) { ActionController::Parameters.new(controller: 'controller', action: 'action') }
 
       it 'returns true' do
         allow(Authorizy::Core).to receive(:new)
-          .with(current_user, parameters, session, controller: 'controller', action: 'action')
-          .and_return(authorizy)
+          .with(user, parameters, session, cop: config.cop)
+          .and_return(core)
 
-        config_mock(current_user: current_user) do
+        config_mock(current_user: user) do
           expect(controller.helpers.authorizy?('controller', 'action')).to be(true)
         end
       end

data/spec/authorizy/extension/authorizy_spec.rb

@@ -3,12 +3,20 @@
 require 'support/controllers/dummy_controller'
 
 RSpec.describe DummyController, '#authorizy', type: :controller do
+  let!(:config) { Authorizy.config }
   let!(:parameters) { ActionController::Parameters.new(key: 'value', controller: 'dummy', action: 'action') }
+  let!(:user) { nil }
+
+  before { allow(Authorizy).to receive(:config).and_return(config) }
 
   context 'when user has access' do
     let!(:authorizy_core) { instance_double('Authorizy::Core', access?: true) }
 
-    before { allow(Authorizy::Core).to receive(:new).with(nil, parameters, session).and_return(authorizy_core) }
+    before do
+      allow(Authorizy::Core).to receive(:new)
+        .with(user, parameters, session, cop: config.cop)
+        .and_return(authorizy_core)
+    end
 
     context 'when is a xhr request' do
       it 'receives the default values and do not denied the access' do
@@ -32,14 +40,18 @@ RSpec.describe DummyController, '#authorizy', type: :controller do
   context 'when user has no access' do
     let!(:authorizy_core) { instance_double('Authorizy::Core', access?: false) }
 
-    before { allow(Authorizy::Core).to receive(:new).with(nil, parameters, session).and_return(authorizy_core) }
+    before do
+      allow(Authorizy::Core).to receive(:new)
+        .with(user, parameters, session, cop: config.cop)
+        .and_return(authorizy_core)
+    end
 
     context 'when is a xhr request' do
       it 'receives the default values and denied the access' do
         get :action, xhr: true, params: { key: 'value' }
 
         expect(response.body).to   eq('{"message":"Action denied for dummy#action"}')
-        expect(response.status).to be(422)
+        expect(response.status).to be(401)
       end
     end
 

data/spec/authorizy/rspec_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+RSpec.describe RSpec::Matchers, '#be_authorized' do
+  it 'pending' do
+    matcher = be_authorized('controller', 'action', params: { params: true }, session: { session: true })
+
+    expect(matcher.description).to eq %(
+      be authorized "controller", "action", and {:params=>{:params=>true}, :session=>{:session=>true}}
+    ).squish
+  end
+end

data/spec/common_helper.rb

@@ -2,6 +2,8 @@
 
 ENV['RAILS_ENV'] ||= 'test'
 
+require 'support/coverage'
+
 require 'support/application'
 require 'support/common'
 require 'support/i18n'

data/spec/spec_helper.rb

@@ -12,9 +12,9 @@ def config_mock(aliases: nil, cop: nil, current_user: nil, dependencies: nil, re
   Authorizy.configure do |config|
     config.aliases      = aliases                        if aliases
     config.cop          = cop                            if cop
-    config.current_user = -> (_context) { current_user } if current_user
-    config.dependencies = dependencies                   if dependencies
-    config.redirect_url = -> (_context) { redirect_url } if redirect_url
+    config.current_user = ->(_context) { current_user } if current_user
+    config.dependencies = dependencies if dependencies
+    config.redirect_url = ->(_context) { redirect_url } if redirect_url
   end
 
   yield

data/spec/support/coverage.rb

@@ -9,6 +9,10 @@ if ENV['COVERAGE'] == 'true'
   SimpleCov.minimum_coverage(ENV.fetch('MINIMUM_COVERAGE', 80).to_i)
 
   SimpleCov.start('rails') do
-    add_filter('vendor')
+    add_filter [
+      '/lib/generators',
+      '/vendor',
+      '/lib/authorizy/version.rb',
+    ]
   end
 end

data/spec/support/models/authorizy_cop.rb

@@ -9,23 +9,23 @@ class AuthorizyCop < Authorizy::BaseCop
     params[:access] == 'true'
   end
 
-  def get_action
+  def fetch_action
     action
   end
 
-  def get_controller
+  def fetch_controller
     controller
   end
 
-  def get_current_user
+  def fetch_current_user
     current_user
   end
 
-  def get_params
+  def fetch_params
     params
   end
 
-  def get_session
+  def fetch_session
     session
   end
 end

data/spec/support/schema.rb

@@ -6,7 +6,7 @@ require 'support/models/user'
 ActiveRecord::Base.establish_connection(
   adapter:  'postgresql',
   host:     'localhost',
-  username: 'postgres',
+  username: 'postgres'
 )
 
 ActiveRecord::Base.connection.execute('DROP DATABASE IF EXISTS authorizy_test;')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authorizy
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Washington Botelho
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-10 00:00:00.000000000 Z
+date: 2021-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +94,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -112,6 +154,7 @@ files:
 - lib/authorizy/core.rb
 - lib/authorizy/expander.rb
 - lib/authorizy/extension.rb
+- lib/authorizy/rspec.rb
 - lib/authorizy/version.rb
 - lib/generators/authorizy/install_generator.rb
 - lib/generators/authorizy/templates/config/initializers/authorizy.rb
@@ -121,6 +164,7 @@ files:
 - spec/authorizy/config/cop_spec.rb
 - spec/authorizy/config/current_user_spec.rb
 - spec/authorizy/config/dependencies_spec.rb
+- spec/authorizy/config/field_spec.rb
 - spec/authorizy/config/initialize_spec.rb
 - spec/authorizy/config/redirect_url_spec.rb
 - spec/authorizy/cop/controller_spec.rb
@@ -130,6 +174,7 @@ files:
 - spec/authorizy/expander/expand_spec.rb
 - spec/authorizy/extension/authorizy_question_spec.rb
 - spec/authorizy/extension/authorizy_spec.rb
+- spec/authorizy/rspec_spec.rb
 - spec/common_helper.rb
 - spec/spec_helper.rb
 - spec/support/application.rb
@@ -163,36 +208,38 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: A JSON based Authorization.
 test_files:
-- spec/spec_helper.rb
-- spec/common_helper.rb
-- spec/support/schema.rb
-- spec/support/routes.rb
-- spec/support/locales/en.yml
-- spec/support/i18n.rb
-- spec/support/application.rb
-- spec/support/models/authorizy_cop.rb
-- spec/support/models/empty_cop.rb
-- spec/support/models/user.rb
-- spec/support/common.rb
-- spec/support/coverage.rb
-- spec/support/controllers/dummy_controller.rb
-- spec/support/controllers/admin/dummy_controller.rb
-- spec/authorizy/core/access_spec.rb
-- spec/authorizy/extension/authorizy_spec.rb
-- spec/authorizy/extension/authorizy_question_spec.rb
+- spec/authorizy/base_cop/access_question_spec.rb
+- spec/authorizy/config/aliases_spec.rb
+- spec/authorizy/config/cop_spec.rb
+- spec/authorizy/config/current_user_spec.rb
 - spec/authorizy/config/dependencies_spec.rb
+- spec/authorizy/config/field_spec.rb
 - spec/authorizy/config/initialize_spec.rb
 - spec/authorizy/config/redirect_url_spec.rb
-- spec/authorizy/config/current_user_spec.rb
-- spec/authorizy/config/cop_spec.rb
-- spec/authorizy/config/aliases_spec.rb
-- spec/authorizy/expander/expand_spec.rb
-- spec/authorizy/base_cop/access_question_spec.rb
-- spec/authorizy/cop/namespaced_controller_spec.rb
 - spec/authorizy/cop/controller_spec.rb
 - spec/authorizy/cop/model_spec.rb
+- spec/authorizy/cop/namespaced_controller_spec.rb
+- spec/authorizy/core/access_spec.rb
+- spec/authorizy/expander/expand_spec.rb
+- spec/authorizy/extension/authorizy_question_spec.rb
+- spec/authorizy/extension/authorizy_spec.rb
+- spec/authorizy/rspec_spec.rb
+- spec/common_helper.rb
+- spec/spec_helper.rb
+- spec/support/application.rb
+- spec/support/common.rb
+- spec/support/controllers/admin/dummy_controller.rb
+- spec/support/controllers/dummy_controller.rb
+- spec/support/coverage.rb
+- spec/support/i18n.rb
+- spec/support/locales/en.yml
+- spec/support/models/authorizy_cop.rb
+- spec/support/models/empty_cop.rb
+- spec/support/models/user.rb
+- spec/support/routes.rb
+- spec/support/schema.rb