authlogic_facebook_shim 0.3.3 → 0.5.0

data/test/units/session/config_test.rb

@@ -1,145 +1,147 @@
 require File.expand_path( '../../test_helper.rb', File.dirname(__FILE__) )
 
-class AuthlogicFacebookShim::Session::ConfigTest < ActiveSupport::TestCase
-
-  context "Session::Config" do
+describe AuthlogicFacebookShim::Session::Config do
     
-    setup do
-      @session_class = Class.new(Authlogic::Session::Base)
-    end
+  before do
+    @session_class = Class.new(Authlogic::Session::Base)
+  end
 
-    context "facebook_config_file" do
+  describe "facebook_config_file" do
 
-      should "have a default 'facebook.yml'" do
-        assert_equal 'facebook.yml', @session_class.facebook_config_file
-      end
-      
-      should "have a setter method" do
-        fb_config = 'fbconf.yml'
-        @session_class.facebook_config_file = fb_config
-        assert_equal fb_config, @session_class.facebook_config_file
-      end
-      
+    it "should have a default 'facebook.yml'" do
+      @session_class.facebook_config_file.must_equal 'facebook.yml'
+    end
+    
+    it "should have a setter method" do
+      fb_config = 'fbconf.yml'
+      @session_class.facebook_config_file = fb_config
+      @session_class.facebook_config_file.must_equal fb_config
     end
     
-    context "facebook_app_id" do
+  end
+  
+  describe "facebook_app_id" do
 
-      should "default to default_config.app_id" do
-        default_from_config = 'defaultappid'
-        flexmock(@session_class).should_receive('default_config.app_id').and_return(default_from_config).once
-        assert_equal default_from_config, @session_class.facebook_app_id
-      end
+    it "should default to default_config.app_id" do
+      default_from_config = 'defaultappid'
       
-      should "have a setter method" do
-        fb_app_id = '234234234'
-        @session_class.facebook_app_id = fb_app_id
-        assert_equal fb_app_id, @session_class.facebook_app_id
-      end
+      expect @session_class.default_config, 'app_id', :with => [], :return => default_from_config
       
+      @session_class.facebook_app_id.must_equal default_from_config
+    end
+    
+    it "should have a setter method" do
+      fb_app_id = '234234234'
+      @session_class.facebook_app_id = fb_app_id
+      @session_class.facebook_app_id.must_equal fb_app_id
     end
+    
+  end
 
-    context "facebook_secret_key" do
+  describe "facebook_secret_key" do
 
-      should "default to default_config.secret_key" do
-        default_from_config = 'defaultsecretkey'
-        flexmock(@session_class).should_receive('default_config.secret_key').and_return(default_from_config).once
-        assert_equal default_from_config, @session_class.facebook_secret_key
-      end
+    it "should default to default_config.secret_key" do
+      default_from_config = 'defaultsecretkey'
       
-      should "have a setter method" do
-        fb_secret = '553246736447566b583138525a716e693950736'
-        @session_class.facebook_secret_key = fb_secret
-        assert_equal fb_secret, @session_class.facebook_secret_key
-      end
+      expect @session_class.default_config, 'secret_key', :with => [], :return => default_from_config
       
+      @session_class.facebook_secret_key.must_equal default_from_config
     end
     
-    context "facebook_api_key" do
-
-      should "default to default_config.api_key" do
-        default_from_config = 'defaultapikey'
-        flexmock(@session_class).should_receive('default_config.api_key').and_return(default_from_config).once
-        assert_equal default_from_config, @session_class.facebook_api_key
-      end
-      
-      should "have a setter method" do
-        fb_api_key = '25a366a46366451636933676978776a45585734'
-        @session_class.facebook_api_key = fb_api_key
-        assert_equal fb_api_key, @session_class.facebook_api_key
-      end
-      
+    it "should have a setter method" do
+      fb_secret = '553246736447566b583138525a716e693950736'
+      @session_class.facebook_secret_key = fb_secret
+      @session_class.facebook_secret_key.must_equal fb_secret
     end
     
-    context "facebook_uid_field" do
+  end
+  
+  describe "facebook_api_key" do
 
-      should "have a default of :facebook_uid" do
-        assert_equal :facebook_uid, @session_class.facebook_uid_field
-      end
+    it "should default to default_config.api_key" do
+      default_from_config = 'defaultapikey'
       
-      should "have a setter method" do
-        fb_uid_field = 'fb_uid'
-        @session_class.facebook_uid_field = fb_uid_field
-        assert_equal fb_uid_field, @session_class.facebook_uid_field
-      end
+      expect @session_class.default_config, 'api_key', :with => [], :return => default_from_config
       
+      @session_class.facebook_api_key.must_equal default_from_config
     end
     
-    context "facebook_finder" do
+    it "should have a setter method" do
+      fb_api_key = '25a366a46366451636933676978776a45585734'
+      @session_class.facebook_api_key = fb_api_key
+      @session_class.facebook_api_key.must_equal fb_api_key
+    end
+    
+  end
+  
+  describe "facebook_uid_field" do
 
-      should 'have a default nil' do
-        assert_nil @session_class.facebook_finder
-      end
-      
-      should "have a setter method" do
-        fb_finder = 'find_by_fb_uid'
-        @session_class.facebook_finder = fb_finder
-        assert_equal fb_finder, @session_class.facebook_finder
-      end
-      
+    it "should have a default of :facebook_uid" do
+      @session_class.facebook_uid_field.must_equal :facebook_uid
     end
     
-    context "facebook_auto_register" do
+    it "should have a setter method" do
+      fb_uid_field = 'fb_uid'
+      @session_class.facebook_uid_field = fb_uid_field
+      @session_class.facebook_uid_field.must_equal fb_uid_field
+    end
+    
+  end
+  
+  describe "facebook_finder" do
 
-      should 'have a default false' do
-        assert_false @session_class.facebook_auto_register
-      end
-      
-      should "have a setter method" do
-        fb_auto_reg = true
-        @session_class.facebook_auto_register = fb_auto_reg
-        assert_equal fb_auto_reg, @session_class.facebook_auto_register
-      end
-      
+    it 'should default to false' do
+      @session_class.facebook_finder.must_equal false
     end
+    
+    it "should have a setter method" do
+      fb_finder = 'find_by_fb_uid'
+      @session_class.facebook_finder = fb_finder
+      @session_class.facebook_finder.must_equal fb_finder
+    end
+    
+  end
+  
+  describe "facebook_auto_register" do
 
-    context "default_config" do
+    it 'should have a default false' do
+      @session_class.facebook_auto_register.must_equal false
+    end
+    
+    it "should have a setter method" do
+      fb_auto_reg = true
+      @session_class.facebook_auto_register = fb_auto_reg
+      @session_class.facebook_auto_register.must_equal fb_auto_reg
+    end
+    
+  end
 
-      should "be a class method" do
-        assert @session_class.respond_to?(:default_config)
-      end
-      
-      should "return an OpenStruct" do
-        assert @session_class.default_config.is_a?(OpenStruct)
-      end
-      
-      should "return the app_id from the default config file" do
-        assert_equal 'appidfromfile', @session_class.default_config.app_id
-      end
-      
-      should "return the api_key from the default config file" do
-        assert_equal 'apikeyfromfile', @session_class.default_config.api_key
-      end
-      
-      should "return the secret_key from the default config file" do
-        assert_equal 'secretkeyfromfile', @session_class.default_config.secret_key
-      end
+  describe "default_config" do
 
-      should "return an empty OpenStruct if the file isn't found" do
-        flexmock(@session_class).should_receive(:facebook_config_file).and_return('notthere.yml').once
-        assert_equal OpenStruct.new({}), @session_class.default_config
-      end
+    it "should be a class method" do
+      @session_class.must_respond_to :default_config
     end
     
+    it "should return an OpenStruct" do
+      @session_class.default_config.must_be_instance_of OpenStruct
+    end
+    
+    it "should return the app_id from the default config file" do
+      @session_class.default_config.app_id.must_equal 'appidfromfile'
+    end
+    
+    it "should return the api_key from the default config file" do
+      @session_class.default_config.api_key.must_equal 'apikeyfromfile'
+    end
+    
+    it "should return the secret_key from the default config file" do
+      @session_class.default_config.secret_key.must_equal 'secretkeyfromfile'
+    end
+
+    it "should return an empty OpenStruct if the file isn't found" do
+      expect @session_class, :facebook_config_file, :with => [], :return => 'notthere.yml'
+      @session_class.default_config.must_equal OpenStruct.new({})
+    end
   end
   
 end

data/test/units/session/facebook_test.rb

@@ -1,218 +1,237 @@
 require File.expand_path( '../../test_helper.rb', File.dirname(__FILE__) )
+require 'koala'
 
-class AuthlogicFacebookShim::Session::FacebookTest < ActiveSupport::TestCase
-  
-  setup :activate_authlogic
+describe AuthlogicFacebookShim::Session::Facebook do
+
+  before do
+    activate_authlogic
+  end
 
-  context "Session::Facebook" do
+  describe "setup - for my own sanity" do
     
-    setup do
-      @mock_cookies = MockCookieJar.new
-      @mock_cookies['fbs_mockappid'] = {:value => 'access_token=mockaccesstoken&expires=0&secret=mocksecret&session_key=mocksessionkey&sig=cbd80b97f124bf392f76e2ee61168990&uid=mockuid'}
+    before do
+      @session = UserSession.new
+      override @session, :controller => controller
+    end
       
-      flexmock(controller).should_receive(:cookies).and_return(@mock_cookies).by_default
-
-      @session = flexmock(UserSession.new)
-      @session.should_receive(:controller).and_return(controller).by_default
+    it "should set the controller" do
+      @session.controller.must_equal controller
     end
-
-    context "setup - for my own sanity" do
+    
+  end
+  
+  describe "config accessors" do
+    
+    before do
+      @session = UserSession.new
+      override @session, :controller => controller
+    end
+    
+    after do
+      Object.instance_eval do
+        remove_const :User
+        remove_const :UserSession
+        GC.start
         
-      should "set the controller" do
-        assert_equal controller, @session.controller
+        load(File.join(Rails.root, 'app', 'models', 'user.rb'))
+        load(File.join(Rails.root, 'app', 'models', 'user_session.rb'))
       end
+    end
+
+    it "should return facebook_app_id" do
+      mockappid = 'mockappid'
+      override UserSession, :facebook_app_id => mockappid
+      @session.send(:facebook_app_id).must_equal mockappid
+    end
+
+    it "should return facebook_api_key" do
+      mockapikey = 'mockapikey'
+      override UserSession, :facebook_api_key => mockapikey
       
-      should "set the cookies" do
-        assert_equal @mock_cookies, @session.controller.cookies
-      end
-            
+      @session.send(:facebook_api_key).must_equal mockapikey
     end
-    
-    context "config accessors" do
 
-      should "return facebook_app_id" do
-        mockappid = 'mockappid'
-        flexmock(UserSession).should_receive(:facebook_app_id).and_return(mockappid).once
-        assert_equal mockappid, @session.send(:facebook_app_id)
-      end
+    it "should return facebook_secret_key" do
+      mocksecret = 'mocksecret'
+      override UserSession, :facebook_secret_key => mocksecret
+      
+      @session.send(:facebook_secret_key).must_equal mocksecret
+    end
 
-      should "return facebook_api_key" do
-        mockapikey = 'mockapikey'
-        flexmock(UserSession).should_receive(:facebook_api_key).and_return(mockapikey).once
-        assert_equal mockapikey, @session.send(:facebook_api_key)
-      end
+    it "should return facebook_uid_field" do
+      mockuidfield = 'mock_uidfield'
+      override UserSession, :facebook_uid_field => mockuidfield
+      
+      @session.send(:facebook_uid_field).must_equal mockuidfield
+    end
+    
+    describe "facebook_finder" do
 
-      should "return facebook_secret_key" do
-        mocksecret = 'mocksecret'
-        flexmock(UserSession).should_receive(:facebook_secret_key).and_return(mocksecret).once
-        assert_equal mocksecret, @session.send(:facebook_secret_key)
+      it "should delegate to the class" do
+        mockfinder = 'mockfinder'
+        override UserSession, :facebook_finder => mockfinder
+        
+        @session.send(:facebook_finder).must_equal mockfinder
       end
 
-      should "return facebook_uid_field" do
-        mockuidfield = 'mockuidfield'
-        flexmock(UserSession).should_receive(:facebook_uid_field).and_return(mockuidfield).once
-        assert_equal mockuidfield, @session.send(:facebook_uid_field)
+      it "should default if the class returns nil" do
+        override UserSession, :facebook_finder => false
+        override @session, :facebook_uid_field => 'mock_uidfield'
+        
+        @session.send(:facebook_finder).must_equal "find_by_mock_uidfield"
       end
-      
-      context "facebook_finder" do
 
-        should "delegate to the class" do
-          mockfinder = 'mockfinder'
-          flexmock(UserSession).should_receive(:facebook_finder).and_return(mockfinder).once
-          assert_equal mockfinder, @session.send(:facebook_finder)
-        end
+    end
 
-        should "default if the class returns nil" do
-          flexmock(UserSession).should_receive(:facebook_finder).and_return(nil).once
-          @session.should_receive(:facebook_uid_field).and_return('mockuidfield').once
-          assert_equal "find_by_mockuidfield", @session.send(:facebook_finder)
-        end
+    it "should return facebook_auto_register?" do
+      override UserSession, :facebook_auto_register => true
+      
+      @session.send(:facebook_auto_register?).must_equal true
+    end
 
-      end
+  end
+  
+  describe "validating with facebook" do
+    
+    before do
+      @session = UserSession.new
+      override @session, :controller => controller
+    end
+    
+    describe "with a valid facebook session" do
+      
+      before do
+        @facebook_session = OpenStruct.new(:uid => 'mockuid')
 
-      should "return facebook_auto_register?" do
-        flexmock(UserSession).should_receive(:facebook_auto_register).and_return(true).once
-        assert @session.send(:facebook_auto_register?)
+        override @session, :facebook_session? => true
+        override @session, :facebook_session => @facebook_session
       end
 
-    end
-    
-    context "validating with facebook" do
+      describe "with an existing facebook uid" do
       
-      context "with a valid facebook session" do
+        before do
+          override @session, :facebook_finder => 'finder_method'
+        
+          @user = User.create
+          override User, :finder_method => @user
         
-        setup do
-          @facebook_session = flexmock('facebook session', :uid => 'mockuid')
-          @session.should_receive(:facebook_session).and_return(@facebook_session).by_default
+          @session.save
+        end
+      
+        it "should return true for logged_in_with_facebook?" do
+          @session.logged_in_with_facebook?.must_equal true
         end
+      
+        it "should set attempted_record" do
+          @session.attempted_record.must_equal @user
+        end
+      
+      end
 
-        context "with an existing facebook uid" do
+      describe "without an existing facebook uid" do
         
-          setup do
-            @session.should_receive(:facebook_finder).and_return('finder_method').by_default
+        before do
+          override @session, :facebook_finder => 'finder_method'
+          override User, :finder_method => nil
           
-            @user = User.create
-            flexmock(User).should_receive('finder_method').with('mockuid').and_return(@user).by_default
+          @user = User.new
+          override User, :new => @user
+        end
+      
+        describe "and facebook_auto_register? true" do
           
+          before do
+            override @session, :facebook_auto_register? => true
+          end
+
+          it "should build a new user on attempted_record" do
+            override User, :new => @user
+            
             @session.save
+            @session.attempted_record.must_equal @user
           end
         
-          should "return true for logged_in_with_facebook?" do
-            assert @session.logged_in_with_facebook?
+          it "should attempt to call before_connect on the new user" do
+            expect @user, :before_connect, :with => [@facebook_session], :return => true
+            assert @session.save
           end
         
-          should "set attempted_record" do
-            assert_equal @user, @session.attempted_record
+          it "should save the new user" do
+            expect @user, :save, :with => [:validate => false], :return => true
+            assert @session.save
           end
         
         end
+      
+        describe "and facebook_auto_register? false" do
 
-        context "without an existing facebook uid" do
-          
-          setup do
-            @session.should_receive(:facebook_finder).and_return('finder_method').by_default
-            flexmock(User).should_receive('finder_method').with('mockuid').and_return(nil).by_default
+          it "should return false for logged_in_with_facebook?" do
+            override @session, :facebook_auto_register? => false
+            @session.save
             
-            @user = flexmock(User.new)
-            flexmock(User).should_receive(:new).and_return(@user).by_default
+            @session.logged_in_with_facebook?.must_equal false
           end
         
-          context "and facebook_auto_register? true" do
+          it "should not set attempted record" do
+            override @session, :facebook_auto_register? => false
             
-            setup do
-              @session.should_receive(:facebook_auto_register?).and_return(true).by_default
-            end
-
-            should "build a new user on attempted_record" do
-              flexmock(User).should_receive(:new).and_return(@user).once
-              @session.save
-              assert_equal @user, @session.attempted_record
-            end
-          
-            should "attempt to call before_connect on the new user" do
-              # TODO this is a bit flakey because I can't get flexmock to mock with(@facebook_session)
-              @user.should_receive(:before_connect).with(any).and_return(true).once
-              assert @session.save
-            end
-          
-            should "save the new user" do
-              @user.should_receive(:save).with(false).and_return(true).at_least.once
-              assert @session.save
-            end
-          
-          end
-        
-          context "and facebook_auto_register? false" do
-
-            should "return false for logged_in_with_facebook?" do
-              @session.should_receive(:facebook_auto_register?).and_return(false).once
-              @session.save
-              
-              assert_equal false, @session.logged_in_with_facebook?
-            end
-          
-            should "not set attempted record" do
-              @session.should_receive(:facebook_auto_register?).and_return(false).once
-              @session.save
+            @session.save
 
-              assert_nil @session.attempted_record
-            end
-          
+            @session.attempted_record.must_be_nil
           end
         
         end
-
+      
       end
 
-      context "when skip_facebook_authentication is true" do
+    end
 
-        should "not attempt to validate with facebook" do
-          @session.should_receive(:skip_facebook_authentication).and_return(true).once
-          @session.should_receive(:validate_by_facebook).never
-          
-          assert_equal false, @session.save
-        end
+    describe "when skip_facebook_authentication is true" do
+
+      it "should not attempt to validate with facebook" do
+        override @session, :skip_facebook_authentication => true
+        override @session, :validate_by_facebook => lambda { raise Override::ExpectationError.new('to not be called', 'called') }
         
-        should "return false for logged_in_with_facebook?" do
-          @session.should_receive(:skip_facebook_authentication).and_return(true).once
-          
-          assert_equal false, @session.save
-          assert_nil @session.logged_in_with_facebook?
-        end
+        @session.save.must_equal false
+      end
+      
+      it "should return false for logged_in_with_facebook?" do
+        override @session, :skip_facebook_authentication => true
         
-        should "not set attempted record" do
-          @session.should_receive(:skip_facebook_authentication).and_return(true).once
-
-          assert_equal false, @session.save
-          assert_nil @session.attempted_record
-        end
+        @session.save.must_equal false
+        @session.logged_in_with_facebook?.must_be_nil
       end
       
-      context "when authenticating_with_unauthorized_record? is false" do
+      it "should not set attempted record" do
+        override @session, :skip_facebook_authentication => true
 
-        should "not attempt to validate with facebook" do
-          @session.should_receive(:authenticating_with_unauthorized_record?).and_return(false).at_least.once
-          @session.should_receive(:validate_by_facebook).never
-          
-          assert_equal false, @session.save
-        end
+        @session.save.must_equal false
+        @session.attempted_record.must_be_nil
+      end
+    end
+    
+    describe "when authenticating_with_unauthorized_record? is true" do
+      
+      before do
+        override @session, :facebook_session? => true
+        override @session, :authenticating_with_unauthorized_record? => true
+      end
 
-        should "return false for logged_in_with_facebook?" do
-          @session.should_receive(:authenticating_with_unauthorized_record?).and_return(true).at_least.once
-          
-          assert_equal false, @session.save
-          assert_nil @session.logged_in_with_facebook?
-        end
+      it "should not attempt to validate with facebook" do
+        override @session, :validate_by_facebook => lambda { raise Override::ExpectationError.new('to not be called', 'called') }
         
-        should "not set attempted record" do
-          @session.should_receive(:authenticating_with_unauthorized_record?).and_return(true).at_least.once
+        @session.save.must_equal false
+      end
 
-          assert_equal false, @session.save
-          assert_nil @session.attempted_record
-        end
-        
+      it "should return false for logged_in_with_facebook?" do
+        @session.save.must_equal false
+        @session.logged_in_with_facebook?.must_be_nil
       end
       
+      it "should not set attempted record" do
+        @session.save.must_equal false
+        @session.attempted_record.must_be_nil
+      end
       
     end