authlogic 3.8.0 → 4.5.0

data/.rubocop_todo.yml

@@ -1,391 +1,74 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-07-18 00:47:31 -0400 using RuboCop version 0.41.2.
+# on 2018-05-22 23:50:03 -0400 using RuboCop version 0.56.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Exclude:
-    - 'lib/authlogic/test_case/mock_cookie_jar.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles.
-# SupportedStyles: either, start_of_block, start_of_line
-Lint/BlockAlignment:
-  Exclude:
-    - 'lib/authlogic.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
-# SupportedStyles: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-
-Lint/Loop:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/persistence_token.rb'
-
-Lint/ShadowingOuterLocalVariable:
-  Exclude:
-    - 'lib/authlogic/session/cookies.rb'
-    - 'lib/authlogic/session/password.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/authlogic/crypto_providers/wordpress.rb'
-    - 'lib/authlogic/random.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/base.rb'
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/activation.rb'
-    - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'lib/authlogic/session/existence.rb'
-    - 'lib/authlogic/session/scopes.rb'
-    - 'lib/authlogic/test_case/mock_controller.rb'
-    - 'lib/authlogic/test_case/mock_cookie_jar.rb'
-    - 'test/i18n_test.rb'
-    - 'test/test_helper.rb'
-
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-
+# Offense count: 10
 Metrics/AbcSize:
-  Max: 82
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Max: 12
-
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 130
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Max: 13
-
-# Cop supports --auto-correct.
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
-
-Style/AccessorMethodName:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
-    - 'test/test_helper.rb'
+  Max: 18.5
 
+# Offense count: 59
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
   Enabled: false
 
-# Cop supports --auto-correct.
-Style/AlignArray:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
-    - 'test/acts_as_authentic_test/password_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'test/config_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/email.rb'
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'test/acts_as_authentic_test/email_test.rb'
-    - 'test/acts_as_authentic_test/login_test.rb'
-
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'test/test_helper.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: is_a?, kind_of?
-Style/ClassCheck:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
+# Offense count: 5
 Style/ClassVars:
   Exclude:
     - 'lib/authlogic/i18n.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Enabled: false
-
-Style/ConstantName:
-  Exclude:
-    - 'lib/authlogic/random.rb'
-
+# Offense count: 22
 Style/Documentation:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/ElseAlignment:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty, nil, both
-Style/EmptyElse:
-  Exclude:
-    - 'lib/authlogic/session/persistence.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Style/ExtraSpacing:
-  Exclude:
-    - 'test/acts_as_authentic_test/email_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Style/FirstParameterIndentation:
-  Exclude:
-    - 'lib/authlogic/session/brute_force_protection.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: when_needed, always
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
-Style/HashSyntax:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
   Exclude:
-    - 'test/test_helper.rb'
+    # Permanent
+    - 'test/**/*'
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Style/IndentArray:
-  Exclude:
-    - 'lib/authlogic.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Style/IndentAssignment:
-  Exclude:
-    - 'lib/authlogic/session/password.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: normal, rails
-Style/IndentationConsistency:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: Width.
-Style/IndentationWidth:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
-    - 'lib/authlogic/session/scopes.rb'
-    - 'test/session_test/callbacks_test.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/logged_in_status.rb'
-
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: module_function, extend_self
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/authlogic/random.rb'
-
-Style/MultilineOperationIndentation:
-  Enabled: false
-
-Style/MultilineTernaryOperator:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/session/password.rb'
-    - 'lib/authlogic/session/session.rb'
-
-# Cop supports --auto-correct.
-Style/MutableConstant:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/password.rb'
-    - 'lib/authlogic/crypto_providers/scrypt.rb'
-    - 'lib/authlogic/crypto_providers/wordpress.rb'
-    - 'lib/authlogic/session/callbacks.rb'
-    - 'test/acts_as_authentic_test/email_test.rb'
-    - 'test/acts_as_authentic_test/logged_in_status_test.rb'
-
-# Cop supports --auto-correct.
-Style/NegatedIf:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/base.rb'
-    - 'lib/authlogic/acts_as_authentic/logged_in_status.rb'
-    - 'lib/authlogic/acts_as_authentic/perishable_token.rb'
-    - 'lib/authlogic/acts_as_authentic/restful_authentication.rb'
-    - 'lib/authlogic/acts_as_authentic/single_access_token.rb'
+    # TODO
+    - 'lib/authlogic/config.rb'
+    - 'lib/authlogic/controller_adapters/sinatra_adapter.rb'
+    - 'lib/authlogic/crypto_providers.rb'
+    - 'lib/authlogic/i18n/translator.rb'
+    - 'lib/authlogic/session/activation.rb'
     - 'lib/authlogic/session/active_record_trickery.rb'
-    - 'lib/authlogic/session/cookies.rb'
+    - 'lib/authlogic/session/existence.rb'
+    - 'lib/authlogic/session/foundation.rb'
     - 'lib/authlogic/session/klass.rb'
-    - 'lib/authlogic/session/params.rb'
-    - 'lib/authlogic/session/password.rb'
     - 'lib/authlogic/session/persistence.rb'
+    - 'lib/authlogic/session/scopes.rb'
+    - 'lib/authlogic/test_case.rb'
+    - 'lib/authlogic/test_case/mock_cookie_jar.rb'
+    - 'lib/authlogic/version.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
-# SupportedStyles: skip_modifier_ifs, always
-Style/Next:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/Not:
+Style/FrozenStringLiteralComment:
   Exclude:
-    - 'lib/authlogic/acts_as_authentic/login.rb'
+    # Freezing strings in lib would be a breaking change. We'll have to wait
+    # for the next major version.
+    - lib/**/*
 
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
+# Offense count: 4
+Style/MethodMissingSuper:
   Exclude:
-    - 'test/random_test.rb'
+    - 'lib/authlogic/controller_adapters/abstract_adapter.rb'
+    - 'lib/authlogic/controller_adapters/sinatra_adapter.rb'
+    - 'lib/authlogic/test_case/mock_request.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: AllowSafeAssignment.
-Style/ParenthesesAroundCondition:
+# Offense count: 3
+Style/MissingRespondToMissing:
   Exclude:
-    - 'test/test_helper.rb'
+    - 'lib/authlogic/controller_adapters/sinatra_adapter.rb'
+    - 'lib/authlogic/test_case/mock_request.rb'
 
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'authlogic.gemspec'
-
-# Cop supports --auto-correct.
-Style/Proc:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/email.rb'
-    - 'lib/authlogic/session/http_auth.rb'
-    - 'test/acts_as_authentic_test/email_test.rb'
+Style/NumericPredicate:
+  Enabled: false
 
+# Offense count: 10
 # Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
+# Configuration parameters: .
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   EnforcedStyle: compact
-
-# Cop supports --auto-correct.
-Style/RedundantBegin:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/base.rb'
-    - 'lib/authlogic/crypto_providers/bcrypt.rb'
-    - 'lib/authlogic/crypto_providers/scrypt.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowMultipleReturnValues.
-Style/RedundantReturn:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
-    - 'test/libs/user_session.rb'
-
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/perishable_token.rb'
-    - 'lib/authlogic/acts_as_authentic/restful_authentication.rb'
-    - 'lib/authlogic/controller_adapters/rack_adapter.rb'
-
-# Cop supports --auto-correct.
-Style/RescueModifier:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/session_maintenance.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  EnforcedStyle: use_perl_names
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
-  Exclude:
-    - 'lib/authlogic/authenticates_many/base.rb'
-    - 'lib/authlogic/session/foundation.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
-# IgnoredMethods: respond_to, define_method
-Style/SymbolProc:
-  Exclude:
-    - 'lib/authlogic/acts_as_authentic/persistence_token.rb'
-
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, MinSize, WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: brackets

data/.travis.yml

@@ -1,48 +1,24 @@
 language: ruby
-
-# cache: bundler
-# We would like to enable travis' bundler cache (cache: bundler) but for some reason
-# travis installs our bundle under the test directory (test/vendor/bundle/*) and, as a
-# result, travis tries to run all of the tests of all of our dependencies!
-# TODO: There's probably a way to configure the bundle path
+cache: bundler
 
 before_install:
+  - gem update --system
   - gem update bundler
 
+# We only test the oldest and the newest ruby versions that we support. We
+# do not test intermediate versions.
 rvm:
-  - 1.9.3
-  - 2.1.10
-  - 2.2.6
-  - 2.3.3
+  - 2.3.7
+  - 2.5.1
 
+# We only test living versions of rails, per the [rails maintenance
+# policy](http://guides.rubyonrails.org/maintenance_policy.html)
 gemfile:
-  - test/gemfiles/Gemfile.rails-3.2.x
-  - test/gemfiles/Gemfile.rails-4.0.x
-  - test/gemfiles/Gemfile.rails-4.1.x
-  - test/gemfiles/Gemfile.rails-4.2.x
-  - test/gemfiles/Gemfile.rails-5.0.x
-  - test/gemfiles/Gemfile.rails-5.1.x
+  - gemfiles/Gemfile.rails-4.2.x
+  - gemfiles/Gemfile.rails-5.1.x
+  - gemfiles/Gemfile.rails-5.2.x
 
 matrix:
-  exclude:
-    - rvm: 1.9.3
-      gemfile: test/gemfiles/Gemfile.rails-4.1.x
-    - rvm: 1.9.3
-      gemfile: test/gemfiles/Gemfile.rails-5.0.x
-    - rvm: 1.9.3
-      gemfile: test/gemfiles/Gemfile.rails-5.1.x
-    - rvm: 1.9.3
-      gemfile: test/gemfiles/Gemfile.rails-5.2.x
-    - rvm: 2.1.10
-      gemfile: test/gemfiles/Gemfile.rails-5.0.x
-    - rvm: 2.1.10
-      gemfile: test/gemfiles/Gemfile.rails-5.1.x
-    - rvm: 2.1.10
-      gemfile: test/gemfiles/Gemfile.rails-5.2.x
-    - rvm: 2.2.6
-      gemfile: test/gemfiles/Gemfile.rails-3.2.x
-    - rvm: 2.3.3
-      gemfile: test/gemfiles/Gemfile.rails-3.2.x
   fast_finish: true
 
 sudo: false