authentise 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5c482f7dd3c413ce5388825d6e8f166b1fe3e1c
-  data.tar.gz: 1d396496e639f998e7b367a2a21710a27ae65eaf
+  metadata.gz: 3aef31bbee80882d5a0fb9cc9f8886618a6a1392
+  data.tar.gz: 5ab1be6cb10ae50d499c3b36c016625a78933042
 SHA512:
-  metadata.gz: ea354a546c8a850305183e55728b10d090bb17ce600dc1f9c2942c03b1317bb9c9ed44610181efb4585031e684c08f7d707b29fcf66d3e8086e208010ceef08b
-  data.tar.gz: 554da033fd57e3b024b3d264a4e4195a4d9ae88f54fe6dcabef9860a9ba7e6690bd321302691192f33ee345e197d1ca695aff6e0be179c5996dd95f725bd6a22
+  metadata.gz: 76767cfbb943f34a0c6adff9360a520cc2038dddb4f2a245837735c32b3875a72f016be95dd4f1464d85a6e8b6a04f2f8a4fc16664f23f98b362b13e9717b263
+  data.tar.gz: b00686d2645056043d11342547711b2de495d0e96f658de7b4d4d7d30a36091abcda194caddbce63e0f34995f7d8f6301a6aa4a258297b10a83e8f1c24cf2b73

data/lib/authentise/api.rb

@@ -11,6 +11,13 @@ module Authentise
     # 404 Error
     class NotFoundError < Error; end
 
+    # Other response codes
+    class UnknownResponseCodeError < Error
+      def initialize(code, message)
+        super("(#{code}) #{message}")
+      end
+    end
+
     module_function
 
     # DEPRECATED, use Authentise::API::Print.create_token(…)

data/lib/authentise/api/print.rb

@@ -20,21 +20,25 @@ module Authentise
           print_value_currency: print_value_currency,
           partner_job_id: partner_job_id,
         }.to_json
-        options = {
-          content_type: :json,
-          accept: :json,
-          open_timeout: 2,
-          timeout: 2,
-        }
-        RestClient.post(url, body, options) do |response, _request, _result|
+        RestClient.post(url, body, rest_client_options) do |response, _, _|
           if response.code == 201
             { url: response.headers[:x_token_location] }
           else
-            fail API::Error, response
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
 
+      private
+
+      def rest_client_options
+        {
+          content_type: :json,
+          accept: :json,
+          open_timeout: 2,
+          timeout: 2,
+        }
+      end
     end
   end
 end

data/lib/authentise/api/users.rb

@@ -32,7 +32,7 @@ module Authentise
               uuid: json["uuid"],
             }
           else
-            fail API::Error, json["message"]
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
@@ -58,8 +58,7 @@ module Authentise
               token: response.cookies["session"],
             }
           else
-            json = JSON.parse(response)
-            fail API::Error, json["message"]
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end

data/lib/authentise/api/warehouse.rb

@@ -46,7 +46,7 @@ module Authentise
               upload_url: response.headers[:x_upload_location],
             }
           else
-            fail API::Error, JSON.parse(response)["message"]
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
@@ -62,7 +62,7 @@ module Authentise
           if response.code == 200
             true
           else
-            fail API::Error, response
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
@@ -81,9 +81,9 @@ module Authentise
           if response.code == 200
             parse_model(response, url)
           elsif response.code == 404
-            fail Authentise::API::NotFoundError
+            fail NotFoundError
           else
-            fail Authentise::API::Error, "Error #{response.code}"
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
@@ -177,7 +177,7 @@ module Authentise
               url: response.headers[:location],
             }
           else
-            fail API::Error, JSON.parse(response)["message"]
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end
@@ -196,9 +196,9 @@ module Authentise
           if response.code == 200
             parse_snapshot(response)
           elsif response.code == 404
-            fail Authentise::API::NotFoundError
+            fail NotFoundError
           else
-            fail Authentise::API::Error, "Error #{response.code}"
+            fail UnknownResponseCodeError.new(response.code, response)
           end
         end
       end

data/lib/authentise/version.rb

@@ -1,3 +1,3 @@
 module Authentise
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/api/print_spec.rb

@@ -2,6 +2,11 @@ require "spec_helper"
 require "authentise/api/print"
 
 describe Authentise::API::Print do
+  before do
+    @response_error_body = {
+      message: "Some test error",
+    }.to_json
+  end
 
   describe "create_token" do
     it "returns a token_url" do
@@ -41,13 +46,15 @@ describe Authentise::API::Print do
 
     it "raises errors" do
       stub_request(:post, "https://print.authentise.com/token/")
-        .to_return(status: 400, body: "Some test error")
+        .to_return(status: 400, body: @response_error_body)
 
-      assert_raises Authentise::API::Error do
+      err = assert_raises Authentise::API::UnknownResponseCodeError do
         Authentise::API::Print.create_token(
           model_url: "http://example.com/model/42",
         )
       end
+
+      err.message.must_equal('(400) {"message":"Some test error"}')
     end
   end
 end

data/spec/api/users_spec.rb

@@ -50,7 +50,7 @@ describe Authentise::API::Users do
         .with(body: @request_body, headers: @request_headers)
         .to_return(status: 400, body: @response_error_body)
 
-      assert_raises Authentise::API::Error do
+      err = assert_raises Authentise::API::UnknownResponseCodeError do
         Authentise::API::Users.create_user(
           email: "test@example.com",
           name: "Test User",
@@ -58,6 +58,8 @@ describe Authentise::API::Users do
           password: "password",
         )
       end
+
+      err.message.must_equal('(400) {"message":"Some test error"}')
     end
   end
 
@@ -97,12 +99,14 @@ describe Authentise::API::Users do
       stub_request(:post, "https://users.authentise.com/sessions/")
         .to_return(status: 400, body: @response_error_body)
 
-      assert_raises Authentise::API::Error do
+      err = assert_raises Authentise::API::UnknownResponseCodeError do
         Authentise::API::Users.create_session(
           username: "testuser",
           password: "password",
         )
       end
+
+      err.message.must_equal('(400) {"message":"Some test error"}')
     end
   end
 end

data/spec/api/warehouse_spec.rb

@@ -44,12 +44,14 @@ describe Authentise::API::Warehouse do
         .with(body: @request_body.to_json, headers: @request_headers)
         .to_return(status: 400, body: @response_error_body)
 
-      assert_raises Authentise::API::Error do
+      err = assert_raises Authentise::API::UnknownResponseCodeError do
         Authentise::API::Warehouse.create_model(
           name: "Test",
           session_token: "f45k",
         )
       end
+
+      err.message.must_equal('(400) {"message":"Some test error"}')
     end
   end
 
@@ -78,12 +80,14 @@ describe Authentise::API::Warehouse do
       stub_request(:put, "https://example.com/")
         .to_return(status: 400, body: @response_error_body)
 
-      assert_raises Authentise::API::Error do
+      err = assert_raises Authentise::API::UnknownResponseCodeError do
         Authentise::API::Warehouse.put_file(
           url: "https://example.com/",
           path: "spec/fixtures/example.stl",
         )
       end
+
+      err.message.must_equal('(400) {"message":"Some test error"}')
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: authentise
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-31 00:00:00.000000000 Z
+date: 2015-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client