authenticate 0.3.1 → 0.3.2

data/spec/features/password_update_spec.rb

@@ -28,7 +28,6 @@ feature 'visitor updates password' do
   end
 end
 
-
 def update_password(user, password)
   visit_password_reset_page_for user
   fill_in 'password_reset_password', with: password
@@ -38,4 +37,3 @@ end
 def visit_password_reset_page_for(user)
   visit edit_users_password_path(id: user, token: user.password_reset_token)
 end
-

data/spec/features/sign_out_spec.rb

@@ -18,5 +18,4 @@ feature 'visitor signs out' do
     visit sign_out_path
     expect_user_to_be_signed_out
   end
-
 end

data/spec/features/sign_up_spec.rb

@@ -29,7 +29,6 @@ feature 'visitor signs up' do
   end
 end
 
-
 def expect_sign_up_page
   expect(current_path).to eq sign_up_path
 end

data/spec/features/timeoutable_spec.rb

@@ -26,5 +26,4 @@ feature 'visitor session time' do
       expect_user_to_be_signed_out
     end
   end
-
 end

data/spec/model/brute_force_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'authenticate/model/brute_force'
 
-
 describe Authenticate::Model::BruteForce do
   before(:each) do
     @user = create(:user)
@@ -46,10 +45,10 @@ describe Authenticate::Model::BruteForce do
   end
 
   context '#unlock!' do
-    before(:each) {
+    before(:each) do
       @user.lock!
       @user.unlock!
-    }
+    end
     it 'zeros failed_logins_count' do
       expect(@user.failed_logins_count).to be(0)
     end

data/spec/model/configuration_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 require 'authenticate/configuration'
 
 describe Authenticate::Configuration do
-
   context 'user model' do
     module Gug
+      # Faux user model
       class Profile
         extend ActiveModel::Naming
       end
@@ -42,7 +42,7 @@ describe Authenticate::Configuration do
 
       context 'with strategy set to username' do
         before do
-            @conf.authentication_strategy = :username
+          @conf.authentication_strategy = :username
         end
         it 'includes username in modules' do
           expect(@conf.modules).to include :username
@@ -51,11 +51,6 @@ describe Authenticate::Configuration do
           expect(@conf.modules).to_not include :email
         end
       end
-
     end
-
   end
-
-
-
 end

data/spec/model/db_password_spec.rb

@@ -1,18 +1,17 @@
 require 'spec_helper'
 require 'authenticate/model/db_password'
 
-
 describe Authenticate::Model::DbPassword do
   describe 'Passwords' do
     context '#password_match?' do
       subject { create(:user, password: 'password') }
 
       it 'matches a password' do
-        expect(subject.password_match? 'password').to be_truthy
+        expect(subject.password_match?('password')).to be_truthy
       end
 
       it 'fails to match a bad password' do
-        expect(subject.password_match? 'bad password').to be_falsey
+        expect(subject.password_match?('bad password')).to be_falsey
       end
 
       it 'saves passwords' do
@@ -20,7 +19,7 @@ describe Authenticate::Model::DbPassword do
         subject.save!
 
         user = User.find(subject.id)
-        expect(user.password_match? 'new_password').to be_truthy
+        expect(user.password_match?('new_password')).to be_truthy
       end
     end
 
@@ -49,7 +48,7 @@ describe Authenticate::Model::DbPassword do
       context 'on an existing user' do
         subject { create(:user, password: 'password') }
 
-        it { is_expected.to be_valid  }
+        it { is_expected.to be_valid }
 
         it 'should not be valid with an empty password' do
           subject.password = ''
@@ -64,6 +63,5 @@ describe Authenticate::Model::DbPassword do
         end
       end
     end
-
   end
 end

data/spec/model/email_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'authenticate/model/email'
 
-
 describe Authenticate::Model::Email do
   it 'validates email' do
     user = build(:user, :without_email)
@@ -12,7 +11,7 @@ describe Authenticate::Model::Email do
   end
 
   it 'extracts credentials from params' do
-    params = {session:{email:'foo', password:'bar'}}
+    params = { session: { email: 'foo', password: 'bar' } }
     expect(User.credentials(params)).to match_array(%w(foo bar))
   end
 
@@ -20,5 +19,4 @@ describe Authenticate::Model::Email do
     user = create(:user)
     expect(User.authenticate([user.email, user.password])).to eq(user)
   end
-
 end

data/spec/model/lifetimed_spec.rb

@@ -1,10 +1,8 @@
 require 'spec_helper'
 require 'authenticate/model/lifetimed'
 
-
 describe Authenticate::Model::Lifetimed do
   context '#max_session_lifetime_exceeded?' do
-
     it 'passes fresh sessions' do
       Timecop.freeze do
         user = create(:user, current_sign_in_at: 1.minute.ago.utc)
@@ -19,5 +17,4 @@ describe Authenticate::Model::Lifetimed do
       end
     end
   end
-
 end

data/spec/model/modules_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Authenticate::Modules do
+  # dummy user model to test .check_fields
+  class UserProfile
+    extend ActiveModel::Model
+    include Authenticate::Modules
+  end
+
+  describe '.check_fields' do
+    context 'user model with missing fields' do
+      it 'fails when required_fields are not present' do
+        expect { UserProfile.load_modules }.to raise_error(Authenticate::Modules::MissingAttribute)
+      end
+    end
+    context 'user model with all fields' do
+      it 'fleshed out user model is fine' do
+        expect { User.load_modules }.to_not raise_error
+      end
+    end
+  end
+end

data/spec/model/password_reset_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'authenticate/model/password_reset'
 
-
 describe Authenticate::Model::PasswordReset do
   context 'forgot_password!' do
     subject { create(:user) }
@@ -14,7 +13,6 @@ describe Authenticate::Model::PasswordReset do
     it 'sets password reset sent at' do
       expect(subject.password_reset_sent_at).to_not be_nil
     end
-
   end
 
   context '#reset_password_period_valid?' do
@@ -43,12 +41,10 @@ describe Authenticate::Model::PasswordReset do
     subject { create(:user) }
 
     context 'within time time' do
-      before(:each) {
-        subject.password_reset_sent_at = 1.minutes.ago
-      }
+      before(:each) { subject.password_reset_sent_at = 1.minutes.ago }
 
       it 'allows password update within time limit' do
-        expect(subject.update_password 'password2').to be_truthy
+        expect(subject.update_password('password2')).to be_truthy
       end
 
       it 'clears password reset token' do
@@ -61,14 +57,11 @@ describe Authenticate::Model::PasswordReset do
         subject.update_password 'password2'
         expect(subject.session_token).to_not eq(token)
       end
-
     end
 
     it 'stops password update after time limit' do
       subject.password_reset_sent_at = 6.minutes.ago
-      expect(subject.update_password 'password2').to be_falsey
+      expect(subject.update_password('password2')).to be_falsey
     end
-
   end
-
 end

data/spec/model/session_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
-
 describe Authenticate::Session do
   describe 'session token' do
     it 'finds a user from session token' do
@@ -18,7 +17,7 @@ describe Authenticate::Session do
     end
     it 'returns nil with a bogus session token' do
       request = mock_request
-      cookies = {Authenticate.configuration.cookie_name.freeze.to_sym => 'some made up value'}
+      cookies = { Authenticate.configuration.cookie_name.freeze.to_sym => 'some made up value' }
       session = Authenticate::Session.new(request, cookies)
       expect(session.current_user).to be_nil
     end
@@ -56,9 +55,9 @@ describe Authenticate::Session do
     context 'modules' do
       it 'runs the callbacks' do
         user = create(:user, :with_session_token, sign_in_count: 0)
-        cookies = {authenticate_session_token: user.session_token}
+        cookies = { authenticate_session_token: user.session_token }
         session = Authenticate::Session.new(mock_request, cookies)
-        expect{session.login(user)}.to change{user.sign_in_count}.by(1)
+        expect { session.login(user) }. to change { user.sign_in_count }.by(1)
       end
       it 'fails login if a callback fails' do
         cookies = {}
@@ -72,6 +71,6 @@ describe Authenticate::Session do
   end
 end
 
-def cookies_for user
+def cookies_for(user)
   { Authenticate.configuration.cookie_name.freeze.to_sym => user.session_token }
 end

data/spec/model/timeoutable_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'authenticate/model/timeoutable'
 
-
 describe Authenticate::Model::Timeoutable do
   subject { create(:user) }
 

data/spec/model/token_spec.rb

@@ -4,8 +4,6 @@ describe Authenticate::Token do
   it 'is a random hex string' do
     token = 'my_token'
     allow(SecureRandom).to receive(:hex).with(20).and_return(token)
-
     expect(Authenticate::Token.new).to eq token
   end
-
-end
+end

data/spec/model/trackable_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 require 'authenticate/model/trackable'
 
-
 describe Authenticate::Model::Trackable do
-  subject {create(:user)}
+  subject { create(:user) }
   context '#last_sign_in_at' do
     it 'sets to old current_sign_in_at if it is not nil' do
       old_sign_in = 2.days.ago.utc

data/spec/model/user_spec.rb

@@ -17,5 +17,4 @@ describe Authenticate::User do
       expect(new_user.session_token).to_not eq old_token
     end
   end
-
 end

data/spec/orm/active_record.rb

@@ -13,5 +13,5 @@ def teardown_orm
 end
 
 def migrations_path
-  Rails.root.join("db", "migrate", "core")
+  Rails.root.join('db', 'migrate', 'core')
 end

data/spec/spec_helper.rb

@@ -1,7 +1,7 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 ENV['RAILS_ENV'] ||= 'test'
 
-require File.expand_path('../dummy/config/environment.rb',  __FILE__)
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 require 'rspec/rails'
 require 'shoulda-matchers'
 require 'capybara/rails'
@@ -26,8 +26,6 @@ RSpec.configure do |config|
   config.order = :random
   config.use_transactional_fixtures = true
 
-  # config.mock_with :rspec
-
   config.expect_with :rspec do |expectations|
     expectations.syntax = :expect
   end
@@ -36,21 +34,15 @@ RSpec.configure do |config|
     mocks.syntax = :expect
   end
 
-
-  config.after(:each, :type => :feature) do
+  config.after(:each, type: :feature) do
     DatabaseCleaner.clean       # Truncate the database
     Capybara.reset_sessions!    # Forget the (simulated) browser state
     Capybara.use_default_driver # Revert Capybara.current_driver to Capybara.default_driver
   end
 end
 
-
-def restore_default_configuration
-  puts 'restore_default_configuration called!!!!!!!!!!!!!!!!!!!!!'
-end
-
 def mock_request(params = {})
-  req = double("request")
+  req = double('request')
   allow(req).to receive(:params).and_return(params)
   allow(req).to receive(:remote_ip).and_return('111.111.111.111')
   req

data/spec/support/controllers/controller_helpers.rb

@@ -1,8 +1,8 @@
 require 'authenticate/controller'
 
 module Controllers
+  # Helpers for controller tests
   module ControllerHelpers
-
     def sign_in
       user = create(:user)
       sign_in_as user
@@ -15,7 +15,6 @@ module Controllers
     def sign_out
       controller.logout
     end
-
   end
 end
 

data/spec/support/features/feature_helpers.rb

@@ -1,7 +1,6 @@
 module Features
+  # Helpers for feature tests
   module FeatureHelpers
-
-
     def sign_in_with(email, password)
       visit sign_in_path
       fill_in 'session_email', with: email
@@ -11,7 +10,7 @@ module Features
 
     def sign_out
       within '#header' do
-        click_link I18n.t("layouts.application.sign_out")
+        click_link I18n.t('layouts.application.sign_out')
       end
     end
 
@@ -27,7 +26,6 @@ module Features
     def expect_user_to_be_signed_out
       expect(page).to have_content 'Sign in'
     end
-
   end
 end
 

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: authenticate
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Justin Tomich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-11 00:00:00.000000000 Z
+date: 2016-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: email_validator
   requirement: !ruby/object:Gem::Requirement
@@ -62,58 +62,58 @@ dependencies:
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.4'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
@@ -134,42 +134,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.2
+        version: '2.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.6.2
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: '0.8'
 description: Authentication for Rails applications
 email:
 - justin@tomich.org
@@ -182,9 +182,11 @@ extra_rdoc_files:
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -321,6 +323,7 @@ files:
 - spec/model/db_password_spec.rb
 - spec/model/email_spec.rb
 - spec/model/lifetimed_spec.rb
+- spec/model/modules_spec.rb
 - spec/model/password_reset_spec.rb
 - spec/model/session_spec.rb
 - spec/model/timeoutable_spec.rb