auth-hmac 1.0.0 → 1.0.1

data/History.txt

@@ -1,3 +1,7 @@
-== 1.0.1 2008-08-11
+== 1.0.1 2008-08-22
+
+* Fixed nil pointer exception when with_auth called with nil creds.
+
+== 1.0.0 2008-08-11
 
 * Initial release

data/lib/auth-hmac.rb

@@ -207,7 +207,7 @@ class AuthHMAC
         end
         
         def hmac_authenticated?
-          self.class.authhmac.authenticated?(request)
+          self.class.authhmac.nil? ? true : self.class.authhmac.authenticated?(request)
         end
       end
       

data/lib/auth-hmac/version.rb

@@ -2,7 +2,7 @@ class AuthHMAC
   module VERSION #:nodoc:
     MAJOR = 1
     MINOR = 0
-    TINY  = 0
+    TINY  = 1
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/spec/auth-hmac_spec.rb

@@ -228,6 +228,35 @@ describe AuthHMAC do
       def rescue_action(e) raise(e) end
     end
     
+    class NilCredentialsController < ActionController::Base
+      with_auth_hmac nil
+      before_filter :force_auth
+      
+      def index
+        render :nothing => true, :status => :ok
+      end
+      
+      def public
+        render :nothing => true, :status => :ok
+      end
+      
+      def rescue_action(e) raise(e) end
+        
+      private
+      def force_auth
+        hmac_authenticated?
+      end
+    end
+    
+    it "should not raise an error when credentials are nil" do
+      request = ActionController::TestRequest.new
+      request.action = 'index'
+      request.path = "/index"
+      lambda do
+        NilCredentialsController.new.process(request, ActionController::TestResponse.new).code.should == "200"
+      end.should_not raise_error
+    end
+    
     it "should allow a request with the proper hmac" do
       request = ActionController::TestRequest.new
       request.env['Authorization'] = "AuthHMAC access key 1:6BVEVfAyIDoI3K+WallRMnDxROQ="

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: auth-hmac
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Sean Geoghegan
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-11 00:00:00 +09:30
+date: 2008-08-22 00:00:00 +09:30
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency