aurfy 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 807c908b4b165b45e3c4c8aefede47feeb33f9ab
-  data.tar.gz: 0d30726a6980abf6501298c864205bab91a04ac1
+  metadata.gz: cdf97785085e8e57fe1637e2397ebfcdd9ed2dae
+  data.tar.gz: 5f14266cd1992ec98e279839e27a29921c575826
 SHA512:
-  metadata.gz: 2c55f2e3f6fea97418c7b1116badfef9599acb9847e7aa8e5736e41509597cfb7be4caf083c3f48122a158fef9d78b6603de216db2b9c045a8e10846285bcf6c
-  data.tar.gz: f6d30dec227ea60d20bc07fafc389c7bf120c9605d12d0a5045bf0c2d858665943cf01f16986823d47e4bb910a6f6feb3d415ea80fa7badcacee13722fbec57f
+  metadata.gz: 16c239e41a1e87763c7d0d73bc163f44e2c3a502dab5ceb27731898d6796cae8eb8e0901e31d9c3bfdbf9f7d408395563211255a6fc7b06f0758ec9f6e1d6b45
+  data.tar.gz: 451e505339b82c154f1dfbe3f26142c245d710bb5a88164afb5b2525efb43a4612a23b99d8dc4c6cbe68e33bf1ec8c0ba0e9c9869665fd6de221a2cce7df97d1

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - 2.2.0
+script: bundle exec rspec

data/Gemfile

@@ -1,5 +1,8 @@
 source 'https://rubygems.org'
 
-gem 'simplecov', require: false, group: :test
+group :test do
+  gem 'simplecov', require: false
+  gem "codeclimate-test-reporter", require: nil
+end
 
 gemspec

data/README.md

@@ -1,5 +1,9 @@
 # aurfy
 
+[![Build Status](https://travis-ci.org/camelmasa/aurfy.png)](https://travis-ci.org/camelmasa/aurfy)
+[![Code Climate](https://codeclimate.com/github/camelmasa/aurfy/badges/gpa.svg)](https://codeclimate.com/github/camelmasa/aurfy)
+[![Test Coverage](https://codeclimate.com/github/camelmasa/aurfy/badges/coverage.svg)](https://codeclimate.com/github/camelmasa/aurfy)
+
 Ruby client for [Aurfy](http://www.aurfy.com/)
 
 Instration
@@ -21,7 +25,12 @@ Usage
 -----
 
 ```rb
-client = Aurfy::Client.new("M000000000", "D0123456789012345678901234567890")
+require "aurfy"
+
+merchant_id       = "M000000000"
+trade_certificate = "D0123456789012345678901234567890"
+
+client = Aurfy::Client.new(merchant_id, trade_certificate)
 
 client.request(
   cardnumber:  "0123456789012345",

data/lib/aurfy/client.rb

@@ -2,22 +2,22 @@ module Aurfy
   API_URL      = "https://pgw.aurfy.com/v2/api/purchase/express"
   TEST_API_URL = "http://test-pgw.comconnpay.com/v2/api/purchase/express"
 
-  attr_reader :api_url
-
   class Client
+    attr_reader :api_url, :merchantid, :trade_certificate
+
     def initialize(merchantid, trade_certificate, test = false)
-      @api_url = test ? API_URL : TEST_API_URL
+      @api_url = test ? TEST_API_URL : API_URL
+      @merchantid = merchantid
+      @trade_certificate = trade_certificate
     end
 
     def request(options = {})
-      configure.options = options
+      configure.options = options.merge(merchantid: merchantid, trade_certificate: trade_certificate)
 
       result = Faraday.post @api_url, configure.params
       Response.new(result)
     end
 
-    private
-
     def configure
       @configure ||= Configure.new
     end

data/lib/aurfy/configure.rb

@@ -9,10 +9,10 @@ module Aurfy
     def initialize
       @cardtype         = "UP"
       @charset          = "UTF-8"
-      @ordertime        = DateTime.now.strftime("%Y%m%d%H%M%S")
-      @orderid          = DateTime.now.strftime("%Y%m%d%H%M%S%N")
       @ordercurrency    = "USD"
       @orderdescription = ""
+      @orderid          = DateTime.now.strftime("%Y%m%d%H%M%S%N")
+      @ordertime        = DateTime.now.strftime("%Y%m%d%H%M%S")
       @signmethod       = "MD5"
       @transtype        = "PURCHASE"
       @txnremark1       = ""
@@ -34,9 +34,8 @@ module Aurfy
     end
 
     def sorted_variables
-      instance_variables.map { |v| [v.to_s.sub("@", "").to_sym, instance_variable_get(v)] }.delete_if do
-        |k, _| k == :trade_certificate
-      end.sort.to_h
+      variables = instance_variables.map { |v| [v.to_s.sub("@", "").to_sym, instance_variable_get(v)] }
+      Hash[variables.delete_if { |k, _| k == :trade_certificate }.sort]
     end
 
     def signature_key

data/lib/aurfy/parser.rb

@@ -9,7 +9,7 @@ module Aurfy
     def parse
       params = body.split("&").map { |p| p.split("=") }
       params = params.map { |p| p.length >= 2 ? p : p.push("") }
-      params.to_h.each_with_object({}) { |(k, v), a| a[k.to_s.to_sym] = v }
+      Hash[params].each_with_object({}) { |(k, v), a| a[k.to_s.to_sym] = v }
     end
   end
 end

data/lib/aurfy/response.rb

@@ -1,7 +1,7 @@
 module Aurfy
   class Response
-    attr_reader :result, :merchantid, :orderamount, :ordercurrency, :orderid, :ordertime, :respcode, :respmsg, :signature, :signmethod,
-       :txnid, :txnremark1, :txnremark2, :txnstatus, :txntime
+    attr_reader :result, :merchantid, :orderamount, :ordercurrency, :orderid, :ordertime, :respcode, :respmsg,
+                :signature, :signmethod, :txnid, :txnremark1, :txnremark2, :txnstatus, :txntime
 
     def self.keys
       [:merchantid, :orderamount, :ordercurrency, :orderid, :ordertime, :respcode, :respmsg, :signature, :signmethod,

data/lib/aurfy/version.rb

@@ -1,6 +1,6 @@
 module Aurfy
   MAJOR = 0
   MINOR = 1
-  PATCH = 0
+  PATCH = 1
   VERSION = [MAJOR, MINOR, PATCH].join('.').freeze
 end

data/spec/aurfy/client_spec.rb

@@ -3,6 +3,24 @@ require 'spec_helper'
 describe Aurfy::Client do
   subject { described_class.new("merchant_id", "trade_certificate") }
 
+  describe "#initialize" do
+    it "assigns parameters for payment" do
+      expect(subject.merchantid).to eq "merchant_id"
+      expect(subject.trade_certificate).to eq "trade_certificate"
+      expect(subject.api_url).to eq Aurfy::API_URL
+    end
+
+    context "with test argumaent" do
+      subject { described_class.new("merchant_id", "trade_certificate", true) }
+
+      it "assigns parameters for payment" do
+        expect(subject.merchantid).to eq "merchant_id"
+        expect(subject.trade_certificate).to eq "trade_certificate"
+        expect(subject.api_url).to eq Aurfy::TEST_API_URL
+      end
+    end
+  end
+
   describe "#request" do
     context "with valid credit card" do
       it "returns successful Aurfy::Response instance" do

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 require 'simplecov'
 SimpleCov.start do
   add_filter "spec"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aurfy
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Masahiro Saito
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-30 00:00:00.000000000 Z
+date: 2015-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -67,6 +67,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - README.md
 - aurfy.gemspec