auntie 0.2.0 → 0.3.0

data/spec/bbc/location_spec.rb

@@ -1,45 +1,45 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
-describe Location, "when first created" do
+describe Location, 'when first created' do
   before(:each) do
     @io = StringIO.new
     @location = Location.new(@io)
   end
 
-  it "lists location matches for a term" do
+  after(:each) do
+    @location = nil
+    @io = nil
+  end
+
+  it 'lists location matches for a term' do
     @location.stub_chain(:open, :read) { fixture 'location.json' }
 
     @location.find 'royston'
 
-    expect( @io.string ).to include('Barnsley')
-    expect( @io.string ).to include('2639017')
+    expect(@io.string).to include('Barnsley')
+    expect(@io.string).to include('2639017')
 
-    expect( @io.string ).to include('Hertfordshire')
-    expect( @io.string ).to include('2639018')
+    expect(@io.string).to include('Hertfordshire')
+    expect(@io.string).to include('2639018')
   end
 
-  it "warns when a term is too small" do
-    lambda {
-      @location.find 'ky'
-    }.should raise_error(SystemExit)
-
-    #TODO: Check it emits "Please use a longer search term"
+  it 'warns when a term is too small' do
+    expect { @location.find 'ky' }.to raise_error('Please use a longer search term')
   end
 
-  it "explains when no results are found" do
+  it 'explains when no results are found' do
+    @location.stub_chain(:open, :read) { '{}' }
+
+    @location.find 'Royston Vasey'
+
+    expect(@io.string).to include("No locations found matching 'Royston Vasey'")
   end
 
-  it "explains when it fails" do
+  it 'explains when it fails' do
     @location.stub_chain(:open, :read) { 'corrupt { json' }
 
-    begin
-      @location.find 'Royston Vasey'
-    rescue SystemExit
-    end
-
-    expect(@io.string).to end_with "Unable to download location data\n"
+    expect { @location.find 'Royston Vasey' }.to raise_error('Unable to download location data')
   end
 end
-

data/spec/bbc/news_spec.rb

@@ -1,9 +1,8 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe News do
-
   before(:each) do
     @io = StringIO.new
     @news = News.new(@io)
@@ -14,35 +13,27 @@ describe News do
     @io = nil
   end
 
-  it "shows the latest headlines" do
+  it 'shows the latest headlines' do
     @news.stub(:console_columns).and_return(120)
     @news.stub_chain(:open, :read) { fixture 'news.json' }
     @news.load
 
-    expect( @io.string ).to start_with 'BBC News Headlines'
-    expect( @io.string ).to include "Police say Moscow school gunman has been 'neutralised'"
+    expect(@io.string).to start_with 'BBC News Headlines'
+    expect(@io.string).to include "Police say Moscow school gunman has been 'neutralised'"
   end
 
-  it "explains when it fails" do
+  it 'explains when it fails' do
     @news.stub_chain(:open, :read).and_return('corrupt { json')
 
-    begin
-      @news.load
-    rescue SystemExit
-    end
-
-    #Unsure why this doesn't work with abort.
-    #expect(@news.load).to raise_error(SystemExit, "Unable to download news")
-
-    expect(@io.string).to end_with "Unable to download news\n"
+    expect { @news.load }.to raise_error('Unable to download news')
   end
 
-  it "truncates output to the size of the shell" do
+  it 'truncates output to the size of the shell' do
     @news.stub(:console_columns).and_return(80)
     @news.stub_chain(:open, :read) { fixture 'news.json' }
 
     @news.load
 
-    expect( @io.string ).to end_with "in the last quarter. It put\n"
+    expect(@io.string).to end_with "in the last quarter. It put\n"
   end
 end

data/spec/bbc/now_next_spec.rb

@@ -1,13 +1,13 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe NowNext do
   before(:each) do
     @io = StringIO.new
     @nn = NowNext.new @io
 
-    @nn.stub(:time_now) { Time.at(1391430000) }
+    @nn.stub(:time_now) { Time.at(1_391_430_000) }
   end
 
   after(:each) do
@@ -16,7 +16,6 @@ describe NowNext do
   end
 
   it "shows what's on tv now" do
-    #TODO: Mock Time
     @nn.stub_chain(:open, :read) { fixture 'now_next_tv.json' }
     @nn.tv_now
 
@@ -39,7 +38,7 @@ describe NowNext do
 
     @nn.radio_now
 
-    expect(@io.string).to include "Fearne Cotton"
+    expect(@io.string).to include 'Fearne Cotton'
   end
 
   it "shows what's on radio next" do
@@ -50,4 +49,13 @@ describe NowNext do
     expect(@io.string).to match(/40 mins\s+Radio 6 Music\s+Radcliffe and Maconie/)
     expect(@io.string).to match(/5 hours\s+Radio 5 live sports extra\s+Coming up on 5 live sports extra/)
   end
+
+  it 'explains when it fails' do
+    @nn.stub_chain(:open, :read) { 'corrupt { json' }
+
+    expect { @nn.radio_now }.to raise_error('Unable to download radio schedules')
+    expect { @nn.radio_next }.to raise_error('Unable to download radio schedules')
+    expect { @nn.tv_next }.to raise_error('Unable to download tv schedules')
+    expect { @nn.tv_now }.to raise_error('Unable to download tv schedules')
+  end
 end

data/spec/bbc/schedule_spec.rb

@@ -1,13 +1,12 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe Schedule do
-
   before(:each) do
     @io = StringIO.new
     @schedule = Schedule.new @io
-    @schedule.stub(:time_now).and_return(Time.at 1391435797) #13:56:37
+    @schedule.stub(:time_now).and_return(Time.at 1_391_435_797) # 13:56:37
   end
 
   after(:each) do
@@ -15,10 +14,10 @@ describe Schedule do
     @schedule = nil
   end
 
-  it "lists todays schedule for BBC One" do
+  it 'lists todays schedule for BBC One' do
     @schedule.stub_chain(:open, :read) { fixture 'schedule_tv.json' }
 
-    channel = { :id => "bbcone" }
+    channel = { id: 'bbcone' }
     @schedule.load channel
 
     expect(@io.string).to include '13:45 Doctors'
@@ -26,19 +25,19 @@ describe Schedule do
     expect(@io.string).to include '00:30 Joins BBC News'
   end
 
-  it "what is on now is the first in the list" do
+  it 'what is on now is the first in the list' do
     @schedule.stub_chain(:open, :read) { fixture 'schedule_tv.json' }
 
-    channel = { :id => "bbcone" }
+    channel = { id: 'bbcone' }
     @schedule.load channel
 
     expect(@io.string).to start_with "\e[92m13:45 Doctors"
   end
 
-  it "lists todays schedule for Radio Six Musix" do
+  it 'lists todays schedule for Radio Six Music' do
     @schedule.stub_chain(:open, :read) { fixture 'schedule_radio_today.json' }
 
-    station = { :id => "6music" }
+    station = { id: '6music' }
     @schedule.load station
 
     expect(@io.string).to include '13:00 Radcliffe and Maconie'
@@ -48,7 +47,7 @@ describe Schedule do
   it "lists yesterday's schedule for Radio Six Music" do
     @schedule.stub_chain(:open, :read) { fixture 'schedule_radio_yesterday.json' }
 
-    station = { :id => "6music", :period => "/yesterday"  }
+    station = { id: '6music', period: '/yesterday' }
     @schedule.load station
 
     expect(@io.string).to include '20:00 Stuart Maconie\'s Freak Zone'
@@ -57,7 +56,7 @@ describe Schedule do
   it "lists tomorrow's schedule for Radio Six Music" do
     @schedule.stub_chain(:open, :read) { fixture 'schedule_radio_tomorrow.json' }
 
-    station = { :id => "6music" }
+    station = { id: '6music' }
     @schedule.load station
 
     expect(@io.string).to include '13:00 Radcliffe and Maconie'

data/spec/bbc/shell_symbols_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require File.join(File.dirname(__FILE__), '/../spec_helper')
+
+describe ShellCharacters, 'character conversion to symbols escaped for terminal output' do
+  it 'converts cardinal compass points to symbols' do
+    points =  %w(N NE E SE S SW W NW)
+    symbols = %w(↑ ↗ → ↘ ↓ ↙ ← ↖)
+
+    points.zip(symbols).each do |p, s|
+      expect(ShellCharacters.symbol_for_compass(p)).to eq(s)
+    end
+  end
+
+  it 'converts ordinal compass points to symbols' do
+    points =  %w(NE SE  SW  NW)
+    symbols = %w(↗  ↘  ↙  ↖)
+
+    points.zip(symbols).each do |p, s|
+      expect(ShellCharacters.symbol_for_compass(p)).to eq(s)
+    end
+  end
+
+  it 'rounds secondary intercardinal points to the closest cardinal' do
+    points =  %w(NNE ENE ESE SSE SSW WSW WNW NNW)
+    symbols = %w( ↑   →   →   ↓   ↓   ←   ←   ↑)
+
+    points.zip(symbols).each do |p, s|
+      expect(ShellCharacters.symbol_for_compass(p)).to eq(s)
+    end
+
+  end
+
+  it 'defaults to north when a compass point description is not recognised' do
+    expect(ShellCharacters.symbol_for_compass('')).to eq('↑')
+  end
+
+  it 'has degrees centigrade' do
+    expect(ShellCharacters.degrees_c).to eq('°C')
+  end
+
+  it 'has degrees farenheit' do
+    expect(ShellCharacters.degrees_f).to eq('°F')
+  end
+
+  it 'draws blocks' do
+    expect(ShellCharacters.square_block).to eq('█')
+  end
+end

data/spec/bbc/sport_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe Sport do
   before(:each) do
@@ -13,23 +13,18 @@ describe Sport do
     @io = nil
   end
 
-  it "shows the latest headlines" do
+  it 'shows the latest headlines' do
     @sport.stub_chain(:open, :read) { fixture 'sport.json' }
     @sport.headlines
 
-    expect( @io.string ).to include 'Winter olympics'
-    expect( @io.string ).to include "Leeds boss"
-    expect( @io.string ).to include "American football"
+    expect(@io.string).to include 'Winter olympics'
+    expect(@io.string).to include 'Leeds boss'
+    expect(@io.string).to include 'American football'
   end
 
-  it "explains when it fails" do
+  it 'explains when it fails' do
     @sport.stub_chain(:open, :read) { 'corrupt { json' }
 
-    begin
-      @sport.headlines
-    rescue SystemExit
-    end
-
-    expect(@io.string).to end_with "Unable to download sport\n"
+    expect { @sport.headlines }.to raise_error 'Unable to download sport data'
   end
 end

data/spec/bbc/version_spec.rb

@@ -1,17 +1,17 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
-describe AUNTIE, "when asked" do
-  it "provides a human readable name for the application" do
+describe AUNTIE, 'when asked' do
+  it 'provides a human readable name for the application' do
     AUNTIE::NAME.should_not be_nil
   end
 
-  it "shows the semantic version of the application" do
+  it 'shows the semantic version of the application' do
     AUNTIE::VERSION.should =~ /\d+\.\d+\.\d+/
   end
 
-  it "has a user agent which includes the application name and version" do
+  it 'has a user agent which includes the application name and version' do
     AUNTIE::USER_AGENT.should =~ /\d+\.\d+\.\d+/
     AUNTIE::USER_AGENT.should =~ /#{AUNTIE::NAME}/
   end

data/spec/bbc/weather_spec.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-require File.join(File.dirname(__FILE__), "/../spec_helper")
+require File.join(File.dirname(__FILE__), '/../spec_helper')
 
 describe Weather do
   before(:each) do
@@ -13,29 +13,23 @@ describe Weather do
     @io = nil
   end
 
-  it "shows the hourly forecast" do
+  it 'shows the hourly forecast' do
     @weather.stub_chain(:open, :read) { fixture '3hourlyforecast.json' }
     @weather.hourly
 
-    expect( @io.string ).to start_with "\nThe next 24 hours in SE1"
+    expect(@io.string).to start_with "\nThe next 24 hours in SE1"
   end
 
-  it "shows the daily forecast" do
+  it 'shows the daily forecast' do
     @weather.stub_chain(:open, :read) { fixture '3dayforecast.json' }
     @weather.daily
 
-    expect( @io.string ).to start_with "\nThe next 3 days in London"
+    expect(@io.string).to start_with "\nThe next 3 days in London"
   end
 
-  it "explains when it fails" do
+  it 'explains when it fails' do
     @weather.stub_chain(:open, :read) { 'corrupt } json {' }
 
-    begin
-      @weather.hourly
-    rescue SystemExit
-    end
-
-    expect(@io.string).to end_with "Unable to download the weather\n"
+    expect { @weather.hourly }.to raise_error 'Unable to download the weather'
   end
-
 end

data/spec/spec_helper.rb

@@ -1,7 +1,13 @@
 # encoding: utf-8
 
-$:.push File.join(File.dirname(__FILE__), "..", "lib")
-$:.push File.dirname(__FILE__)
+$LOAD_PATH.push File.join(File.dirname(__FILE__), '..', 'lib')
+$LOAD_PATH.push File.dirname(__FILE__)
+
+require 'coveralls'
+Coveralls.wear!
+
+# require 'simplecov'
+# SimpleCov.start
 
 require 'auntie'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: auntie
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Simon Gregory
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -80,7 +80,7 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Command line access to BBC services
+description: BBC News, Weather, Sport, and TV & Radio schedules right in your shell
 email: simon.gregory@bbc.co.uk
 executables:
 - weather
@@ -88,9 +88,11 @@ executables:
 - radio
 - news
 - sport
+- auntie
 extensions: []
 extra_rdoc_files: []
 files:
+- bin/auntie
 - bin/news
 - bin/radio
 - bin/sport
@@ -123,10 +125,13 @@ files:
 - LICENSE
 - Rakefile
 - README.md
+- spec/bbc/colors_spec.rb
+- spec/bbc/describe_time_spec.rb
 - spec/bbc/location_spec.rb
 - spec/bbc/news_spec.rb
 - spec/bbc/now_next_spec.rb
 - spec/bbc/schedule_spec.rb
+- spec/bbc/shell_symbols_spec.rb
 - spec/bbc/sport_spec.rb
 - spec/bbc/version_spec.rb
 - spec/bbc/weather_spec.rb