audio_book_creator 0.0.1 → 0.2.0

data/spec/audio_book_creator/cached_hash_spec.rb

@@ -16,4 +16,8 @@ describe AudioBookCreator::CachedHash do
     it { expect(subject[:key]).to eq("val") }
     it { subject[:key] ; expect(cache[:key]).to eq("val") }
   end
+
+  context "#with missing key" do
+    it { expect(subject[:key]).to be_nil }
+  end
 end

data/spec/audio_book_creator/cli_spec.rb

@@ -1,6 +1,4 @@
 require 'spec_helper'
-require 'uri'
-require 'logger'
 # NOTE: cli class is not in the path by default
 #       it is only included by running the command
 require 'audio_book_creator/cli'
@@ -8,8 +6,9 @@ require 'audio_book_creator/cli'
 describe AudioBookCreator::Cli do
   # this sidesteps creating a database file
   subject { described_class.new }
+  let(:minimal_args) { %w(http://site.com/title) }
 
-  context "with no arguments" do
+  describe "#parse", "with no arguments" do
     it "displays an error" do
       expect($stdout).to receive(:puts).with(/url/, /Usage.*title/)
       expect(subject).to receive(:exit).with(2).and_raise("exited")
@@ -17,108 +16,50 @@ describe AudioBookCreator::Cli do
     end
   end
 
-  context "with one argument" do
-    it "assigns title and url" do
-      subject.parse(%w(http://site.com/title))
-      expect(subject.book_def.title).to eq("title")
-      expect(subject.book_def.urls).to eq(%w(http://site.com/title))
-    end
-
-    it "defaults to warn" do
-      subject.parse(%w(http://site.com/title))
+  describe "#parse" do
+    # not really part of this spec
+    it "defaults to non verbose" do
+      subject.parse(minimal_args)
       expect(AudioBookCreator.logger.level).to eq(Logger::WARN)
     end
-  end
 
-  context "with title and url" do
-    it "assigns title and url" do
-      subject.parse(%w(title http://site.com/))
-      expect(subject.book_def.title).to eq("title")
-      expect(subject.book_def.urls).to eq(%w(http://site.com/))
-    end
-  end
-
-  context "with multiple urls" do
-    it "assigns title and url" do
-      subject.parse(%w(http://site.com/title http://site.com/title2))
-      expect(subject.book_def.title).to eq("title")
-      expect(subject.book_def.urls).to eq(%w(http://site.com/title http://site.com/title2))
-    end
-  end
-
-  context "with title and multiple urls" do
-    it "has multiple urls" do
-      subject.parse(%w(title http://site.com/page1 http://site.com/page2))
-      expect(subject.book_def.title).to eq("title")
-      expect(subject.book_def.urls).to eq(%w(http://site.com/page1 http://site.com/page2))
+    it "sets to info" do
+      subject.parse(%w(http://site.com/title --no-verbose))
+      expect(AudioBookCreator.logger.level).to eq(Logger::WARN)
     end
-  end
 
-  context "with verbose" do
-    it "defaults to warning logging" do
-      subject.parse(%w(http://site.com/title --verbose))
-      expect(AudioBookCreator.logger.level).to eq(Logger::INFO)
-    end
+    context "with verbose" do
+      it "sets to info" do
+        subject.parse(%w(http://site.com/title --verbose))
+        expect(AudioBookCreator.logger.level).to eq(Logger::INFO)
+      end
 
-    it "defaults to warning" do
-      subject.parse(%w(http://site.com/title -v))
-      expect(AudioBookCreator.logger.level).to eq(Logger::INFO)
+      it "sets to info (abbreviated)" do
+        subject.parse(%w(http://site.com/title -v))
+        expect(AudioBookCreator.logger.level).to eq(Logger::INFO)
+      end
     end
-  end
 
-
-  context "#parse" do
     # actual cli calls subject.parse.run, so it needs to chain
-    it { expect(subject.parse(%w(http://site.com/title))).to eq(subject) }
-  end
-
-  # parameters
-
-  context "#defaults" do
-    it "should default values" do
-      # NOTE: calling with no constructor
-      pristine = described_class.new
-      expect(subject.surfer_def.max).not_to be_truthy
-      expect(subject.page_def.title_path).to eq("h1")
-      expect(subject.page_def.body_path).to eq("p")
-      expect(subject.page_def.link_path).to eq("a")
-    end
-  end
-
-  # file sanitization is tested in audio_book_creator.spec
-  context "#base_dir" do
-    it "should derive base_dir from title" do
-      subject.parse(%w(title http://site.com/))
-      expect(subject.book_def.base_dir).to eq("title")
-    end
-
-    it "should support titles with spaces" do
-      subject.parse(["title !for", "http://site.com/"])
-      expect(subject.book_def.base_dir).to eq("title-for")
-    end
-
-    it "should support titles with extra stuff" do
-      subject.parse(["title,for!", "http://site.com/"])
-      expect(subject.book_def.base_dir).to eq("title-for")
+    it "can chain" do
+      expect(subject.parse(minimal_args)).to eq(subject)
     end
 
-    it "should override basedir" do
-      subject.parse(%w(title http://site.com/ --base-dir dir))
-      expect(subject.book_def.base_dir).to eq("dir")
+    it "provides usage" do
+      expect($stdout).to receive(:puts).with(/Usage: audio_book_creator.*\[title\] url/)
+      expect { subject.parse(%w(--help)) }.to raise_error(SystemExit)
     end
-  end
 
-  context "with version" do
-    it "should provide version" do
+    it "provides version" do
       expect($stdout).to receive(:puts).with(/audio_book_creator #{AudioBookCreator::VERSION}/)
       expect { subject.parse(%w(--version)) }.to raise_error(SystemExit)
     end
-  end
 
-  context "#help" do
     {
       "-v" => "Run verbosely",
       "--verbose" => "Run verbosely",
+      "--default" => "Set these parameters as default for this url regular expression",
+      "--skip-defaults" => "Skip using defaults",
       "--title" => "Title css",
       "--body" => "Content css",
       "--link" => "Next Page css",
@@ -131,17 +72,16 @@ describe AudioBookCreator::Cli do
       "--voice" => "Set speaker voice",
       "--base-dir" => "Directory to hold files",
       "-A" => "Load book into itunes",
-      "--itunes" => "Load book into itunes",
+      "--[no-]itunes" => "Load book into itunes",
     }.each do |switch, text|
       it "should display #{text} for #{switch} option" do
-        expect($stdout).to receive(:puts).with(/#{switch}.*#{text}/)
+        expect($stdout).to receive(:puts).with(/#{Regexp.escape(switch)}.*#{text}/)
         expect { subject.parse(%w(--help)) }.to raise_error(SystemExit)
       end
     end
 
     it "should provide help" do
       expect($stdout).to receive(:puts).with(/Usage/)
-      #expect(subject).to receive(:exit).with(1).and_raise("exited")
       expect { subject.parse(%w(--help)) }.to raise_error(SystemExit)
     end
 
@@ -151,41 +91,63 @@ describe AudioBookCreator::Cli do
     end
   end
 
-  context "#page_def" do
-    it "should create page_def" do
-      subject.parse(%w(http://site.com/title))
-      # defaults
-      expect(subject.page_def.title_path).to eq("h1")
-      expect(subject.page_def.body_path).to eq("p")
-      expect(subject.page_def.link_path).to eq("a")
+  describe "#parse", "#set_defaults" do
+    it "defaults to no" do
+      subject.parse(minimal_args)
+      expect(subject.set_defaults).to be_falsey
+    end
+
+    it "sets to true" do
+      subject.parse(%w(http://site.com/title --default))
+      expect(subject.set_defaults).to eq(true)
+    end
+  end
+
+  describe "#parse", "#skip_defaults" do
+    it "defaults to no" do
+      subject.parse(minimal_args)
+      expect(subject.skip_defaults).to be_falsey
     end
 
-    it "should support title" do
+    it "sets to true" do
+      subject.parse(%w(http://site.com/title --skip-defaults))
+      expect(subject.skip_defaults).to eq(true)
+    end
+  end
+
+  describe "#parse", "#page_def" do
+    it "#title" do
       subject.parse(%w(http://site.com/title --title h1.big))
       expect(subject.page_def.title_path).to eq("h1.big")
     end
 
-    it "should support body" do
+    it "#body_path" do
       subject.parse(%w(http://site.com/title --body p.content))
       expect(subject.page_def.body_path).to eq("p.content")
     end
 
-    it "should support link" do
+    it "#link_path" do
       subject.parse(%w(http://site.com/title --link a.next_page))
       expect(subject.page_def.link_path).to eq("a.next_page")
     end
+
+    it "#chapter_path" do
+      subject.parse(%w(http://site.com/title --chapter a.chapter))
+      expect(subject.page_def.chapter_path).to eq("a.chapter")
+    end
   end
 
-  context "#book_def" do
+  context "#parse", "#book_def" do
     it "should create book_def" do
-      subject.parse(%w(http://site.com/title))
+      subject.parse(minimal_args)
       # defaults
       expect(subject.book_def.base_dir).to eq("title")
       expect(subject.book_def.title).to eq("title")
-      expect(subject.book_def.author).to eq("Vicki")
-      expect(subject.book_def.itunes).not_to be_truthy
+      #expect(subject.book_def.author).to eq("Vicki")
+      #expect(subject.book_def.itunes).not_to be_truthy
     end
 
+    # MOVE to book_def
     it "should support basedir" do
       subject.parse(%w(http://site.com/title --base-dir dir))
       # defaults
@@ -196,17 +158,73 @@ describe AudioBookCreator::Cli do
     it "should set itunes" do
       subject.parse(%w(http://site.com/title -A))
       expect(subject.book_def.itunes).to be_truthy
+
+      subject.parse(%w(http://site.com/title --itunes))
+      expect(subject.book_def.itunes).to be_truthy
+    end
+
+    it "should unset itunes" do
+      subject.parse(%w(http://site.com/title --no-itunes))
+      expect(subject.book_def.itunes).to be_falsy
     end
 
     it "should pass all urls to book_def" do
       subject.parse(%w(http://site.com/title http://site.com/title http://site.com/title2))
       expect(subject.book_def.urls).to eq(%w(http://site.com/title http://site.com/title http://site.com/title2))
     end
+
+    describe "#title #urls" do
+      context "with url" do
+        it "assigns url abbreviation as title" do
+          subject.parse(minimal_args)
+          expect(subject.book_def.title).to eq("title")
+          expect(subject.book_def.urls).to eq(minimal_args)
+        end
+      end
+
+      context "with title and url" do
+        it "assigns title and url" do
+          subject.parse(%w(title http://site.com/))
+          expect(subject.book_def.title).to eq("title")
+          expect(subject.book_def.urls).to eq(%w(http://site.com/))
+        end
+      end
+
+      context "with multiple urls" do
+        it "assigns title and url" do
+          subject.parse(%w(http://site.com/title http://site.com/title2))
+          expect(subject.book_def.title).to eq("title")
+          expect(subject.book_def.urls).to eq(%w(http://site.com/title http://site.com/title2))
+        end
+      end
+
+      context "with title and multiple urls" do
+        it "has multiple urls" do
+          subject.parse(%w(title http://site.com/page1 http://site.com/page2))
+          expect(subject.book_def.title).to eq("title")
+          expect(subject.book_def.urls).to eq(%w(http://site.com/page1 http://site.com/page2))
+        end
+      end
+    end
+
+    # NOTE: file sanitization is tested in audio_book_creator.spec
+    describe "#base_dir" do
+      # MOVE to book_def
+      it "should support titles with spaces" do
+        subject.parse(["title !for", "http://site.com/"])
+        expect(subject.book_def.base_dir).to eq("title-for")
+      end
+
+      it "should override basedir" do
+        subject.parse(%w(title http://site.com/ --base-dir dir))
+        expect(subject.book_def.base_dir).to eq("dir")
+      end
+    end
   end
 
-  context "#speaker_def" do
+  describe "#parse", "#speaker_def" do
     it "should default" do
-      subject.parse(%w(http://site.com/title))
+      subject.parse(minimal_args)
       expect(subject.speaker_def.voice).to eq("Vicki")
       expect(subject.speaker_def.rate).to eq(280)
       expect(subject.speaker_def.channels).to eq(1)
@@ -232,43 +250,92 @@ describe AudioBookCreator::Cli do
     end
   end
 
-  context "#surfer_def" do
-    it "assigns cache_filename" do
-      subject.parse(%w(http://site.com/title))
-      expect(subject.surfer_def.cache_filename).to eq("pages.db")
+  describe "#parse", "#surfer_def" do
+    it "defaults" do
+      subject.parse(minimal_args)
     end
-  end
 
-  context "max param" do
-    it "should have a max" do
-      subject.parse(%w(http://site.com/title --max 20))
-      expect(subject.surfer_def.max).to eq(20)
+    context "#max" do
+      it "sets" do
+        subject.parse(%w(http://site.com/title --max 20))
+        expect(subject.surfer_def.max).to eq(20)
+      end
+
+      it "unsets" do
+        subject.parse(%w(http://site.com/title --max 20 --no-max))
+        expect(subject.surfer_def.max).not_to be_truthy
+      end
     end
 
-    it "should have no max" do
-      subject.parse(%w(http://site.com/title --max 20 --no-max))
-      expect(subject.surfer_def.max).not_to be_truthy
+    context "#regen_html" do
+      it "sets" do
+        subject.parse(%w(http://site.com/title --force-html))
+        expect(subject.surfer_def.regen_html).to be_truthy
+      end
     end
   end
 
   describe "#conductor" do
     it "should create a conductor" do
-      subject.parse(%w(http://site.com/title))
+      subject.parse(minimal_args)
       expect(subject.conductor.page_def).to eq(subject.page_def)
       expect(subject.conductor.book_def).to eq(subject.book_def)
       expect(subject.conductor.speaker_def).to eq(subject.speaker_def)
       expect(subject.conductor.surfer_def).to eq(subject.surfer_def)
       expect(subject.conductor).to respond_to(:run)
+      # this makes it not just look like the cli
+      expect(subject.conductor).to respond_to(:spider)
+    end
+  end
+
+  describe "#defaulter" do
+    it "creates a defaulter" do
+      subject.parse(minimal_args)
+      expect(subject.defaulter.page_def).to eq(subject.page_def)
+      expect(subject.defaulter.book_def).to eq(subject.book_def)
+      expect(subject.defaulter).to respond_to(:store)
     end
   end
 
   describe "#run" do
-    it "should call book conductor" do
-      subject.parse(%w(http://site.com/title))
-      conductor = double(:conductor)
-      expect(conductor).to receive(:run).and_return("YAY")
-      expect(subject).to receive(:conductor).and_return(conductor)
+    it "call book conductor and loads from settings" do
+      subject.parse(minimal_args)
+      stub_component(:conductor) { |c| expect(c).to receive(:run).and_return("YAY") }
+      stub_component(:defaulter) { |d| expect(d).to receive(:load_unset_values) }
       expect(subject.run).to eq("YAY")
     end
+
+    it "call book conductor and loads from settings" do
+      subject.parse(minimal_args)
+      subject.skip_defaults = true
+      stub_component(:conductor) { |c| expect(c).to receive(:run).and_return("YAY") }
+      expect(subject).not_to receive(:defaulter)
+      expect(subject.run).to eq("YAY")
+    end
+
+    it "stores settings - and notify" do
+      subject.parse(minimal_args)
+      subject.set_defaults = true
+      expect($stdout).to receive(:puts).with("stored for host.com")
+      stub_component(:defaulter) do |d|
+        allow(d).to receive(:host).at_least(:once).and_return("host.com")
+        allow(d).to receive(:store).at_least(:once).and_return(true)
+      end
+      subject.run
+    end
+
+    it "stores settings - and notify failure" do
+      subject.parse(minimal_args)
+      subject.set_defaults = true
+      expect($stdout).to receive(:puts).with(/^not stored/)
+      stub_component(:defaulter) { |d| expect(d).to receive(:store).and_return(false) }
+      subject.run
+    end
+  end
+
+  def stub_component(name, &block)
+    dbl = double(name)
+    yield(dbl)
+    expect(subject).to receive(name).at_least(:once).and_return(dbl)
   end
 end

data/spec/audio_book_creator/conductor_spec.rb

@@ -8,7 +8,7 @@ describe AudioBookCreator::Conductor do
     end
   end
   let(:speaker_def) { AudioBookCreator::SpeakerDef.new }
-  let(:surfer_def)  { AudioBookCreator::SurferDef.new("http://host.com/", 5, true, "database") }
+  let(:surfer_def)  { AudioBookCreator::SurferDef.new(5, true) }
   subject           { described_class.new(page_def, book_def, speaker_def, surfer_def) }
 
   context "#initialize" do
@@ -16,10 +16,21 @@ describe AudioBookCreator::Conductor do
     it { expect(subject.book_def).to    eq(book_def) }
     it { expect(subject.speaker_def).to eq(speaker_def) }
     it { expect(subject.surfer_def).to  eq(surfer_def) }
+    it { expect(subject.page_def.invalid_urls).to  eq(subject.invalid_urls) }
   end
 
-  context "#page_cache" do
-    it { expect(subject.page_cache.filename).to eq(subject.surfer_def.cache_filename) }
+  describe "#page_cache" do
+    it "sets filename" do
+      expect(subject.page_cache.filename).to eq("pages.db")
+    end
+
+    it "sets table_name" do
+      expect(subject.page_cache.table_name).to eq("pages")
+    end
+
+    it "sets table_name" do
+      expect(subject.page_cache.encode).to eq(false)
+    end
   end
 
   context "#web" do
@@ -38,8 +49,9 @@ describe AudioBookCreator::Conductor do
 
   context "#invalid_urls" do
     it "sets references" do
-      #expect(subject.invalid_urls.host).to eq(subject.surfer_def.host)
-      expect(subject.invalid_urls.host).to eq("host.com")
+      expect(subject.invalid_urls.host).to eq("www.host.com")
+      expect(subject.page_def.invalid_urls.host).to eq("www.host.com")
+      expect(subject.page_def.invalid_urls).to eq(subject.invalid_urls)
     end
   end
 
@@ -47,7 +59,6 @@ describe AudioBookCreator::Conductor do
     it "sets references" do
       expect(subject.spider.page_def).to eq(subject.page_def)
       expect(subject.spider.web).to eq(subject.cached_web)
-      expect(subject.spider.invalid_urls).to eq(subject.invalid_urls)
     end
   end