attributor 6.3 → 6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b30fd80bf80e1fba073207107cc6ee008d8f7f5edc3acd49863d58d27c9b2caa
-  data.tar.gz: 7549362dfe5fb7f1eb654ab7927996baee065f4b37cbdb74fcfb472189b8ea17
+  metadata.gz: 9242ef6d878ab79e69393d7bf31b6459873d39a8307c9dac0ea05ce8c4a01912
+  data.tar.gz: 0b2f333abe4957d1575df87c734c4f642274a83d50562059c33fb261154e44a5
 SHA512:
-  metadata.gz: 46fb615c0952564d354ed67e9ed4e794bead86868111cf3a1447f1aab92e9a8106addca135673b59acb67f58dfdbbc5ed8a49d9f5f5cebdf5a2439719c495768
-  data.tar.gz: 726a29e1f6a30025f51a62dfb63fc8331e3202a3553f031ad776679ee7a525a7e689feb75ed184d0eb306b6bbe6b7c03605bb6b396fd5e234e0ddc1fa751b2e8
+  metadata.gz: 48a0ea86f5550dd44b0d162ea96c1a98bbd7019955857f607817efe921fc4250c210e2591664d18a9388fd614d323547c83421b64ba678369c47d248423770ca
+  data.tar.gz: dcd17fa9b98e35d02e471ef340b641ba15ff4fafd6f05d5ac650204830ba7cc7a44feaf40b6a2386c660ab17d3b8d0b881d01d84c4a83a46fe41c6552a2ec74d

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## next
 
+## 6.5 (1/19/2023)
+- Fix JSON schema reporting for BigDecimal types to be a string, with a format=bigdecimal
+
+## 6.4 (10/26/2022)
+- Cache default values for a type, to speedup loading/coercing an object to it
+
 ## 6.3 (10/21/2022)
 - Added some small utility enhancements for dealing with attributes and types
   * .duplicate an attribute, with a different inner type and/or options

data/lib/attributor/types/bigdecimal.rb

@@ -1,8 +1,9 @@
 require 'bigdecimal'
 
 module Attributor
-  class BigDecimal 
-    include Numeric
+  class BigDecimal
+    include Type
+
     def self.native_type
       ::BigDecimal
     end
@@ -19,7 +20,18 @@ module Attributor
     end
 
     def self.json_schema_type
-      :number
+      :string
+    end
+
+    # Bigdecimal numbers are too big to be represented as numbers in JSON schema
+    # The way to do so, is to represent them as strings, but add a 'format' specifying
+    # how to parse that (seemingly, there is a 'double' well known type that json API 
+    # claims we can use) ... not sure if this is the right one, as technically BigDecimal
+    # has very large precision that a double wouldn't be able to fit...
+    def self.as_json_schema( shallow: false, example: nil, attribute_options: {} )
+      hash = super
+      hash[:format] = 'bigdecimal'
+      hash
     end
   end
 end

data/lib/attributor/types/hash.rb

@@ -30,6 +30,7 @@ module Attributor
       attr_reader :insensitive_map
       attr_accessor :extra_keys
       attr_reader :requirements
+      attr_reader :cached_defaults
     end
 
     @key_type = Object
@@ -40,6 +41,7 @@ module Attributor
 
     @error = false
     @requirements = []
+    @cached_defaults = {}
 
     def self.slice!(*keys)
       missing_keys = keys - @keys.keys
@@ -81,7 +83,7 @@ module Attributor
         @key_attribute = Attribute.new(@key_type)
         @value_attribute = Attribute.new(@value_type)
         @requirements = []
-
+        @cached_defaults = {}
         @error = false
       end
     end
@@ -419,14 +421,21 @@ module Attributor
       # handle default values for missing keys
       keys.each do |key_name, attribute|
         next if hash.key?(key_name)
-        sub_context = generate_subcontext(context, key_name)
-        default = attribute.load(nil, sub_context, recurse: recurse)
+
+        # Cache default values to avoid a whole loading call for the attribute
+        default = if @cached_defaults.key?(key_name)
+          @cached_defaults[key_name]
+        else
+          sub_context = generate_subcontext(context, key_name)
+          @cached_defaults[key_name] = attribute.load(nil, sub_context, recurse: recurse)
+        end
         hash[key_name] = default unless default.nil?
       end
-
       hash
     end
 
+    
+
     def self.validate(object, context = Attributor::DEFAULT_ROOT_CONTEXT, _attribute)
       context = [context] if context.is_a? ::String
 

data/lib/attributor/types/model.rb

@@ -46,6 +46,7 @@ module Attributor
         @value_attribute = va
 
         @requirements = []
+        @cached_defaults = {}
         @error = false
       end
     end

data/lib/attributor/version.rb

@@ -1,3 +1,3 @@
 module Attributor
-  VERSION = '6.3'.freeze
+  VERSION = '6.5'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attributor
 version: !ruby/object:Gem::Version
-  version: '6.3'
+  version: '6.5'
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-21 00:00:00.000000000 Z
+date: 2023-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie