attributor 5.0.2 → 5.1.0

data/spec/types/tempfile_spec.rb

@@ -1,6 +1,5 @@
 require File.join(File.dirname(__FILE__), '..', 'spec_helper.rb')
 
-
 describe Attributor::Tempfile do
   it 'has specs'
-end
+end

data/spec/types/temporal_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Attributor::Temporal do
+  subject(:type) { Attributor::Temporal }
+
+  it 'raises an exception for native_type' do
+    expect { type.native_type }.to raise_error(NotImplementedError)
+  end
+end

data/spec/types/time_spec.rb

@@ -1,11 +1,10 @@
 require File.join(File.dirname(__FILE__), '..', 'spec_helper.rb')
 
 describe Attributor::Time do
-
   subject(:type) { Attributor::Time }
 
   it 'it is not Dumpable' do
-    type.new.is_a?(Attributor::Dumpable).should_not be(true)
+    expect(type.new.is_a?(Attributor::Dumpable)).not_to be(true)
   end
 
   context '.native_type' do
@@ -17,45 +16,40 @@ describe Attributor::Time do
   end
 
   context '.dump' do
-    let(:example) { type.example}
+    let(:example) { type.example }
     subject(:value) { type.dump(example) }
     it 'is formatted correctly' do
-      value.should match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}[\+-]\d{2}:\d{2}/)
+      expect(value).to match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}[\+-]\d{2}:\d{2}/)
     end
     context 'nil values' do
       it 'should be nil' do
-        type.dump(nil).should be_nil
+        expect(type.dump(nil)).to be_nil
       end
     end
   end
 
-
   context '.load' do
-
     it 'returns nil for nil' do
-      type.load(nil).should be(nil)
+      expect(type.load(nil)).to be(nil)
     end
 
     context 'for incoming objects' do
-
-      it "returns correct Time for DateTime objects" do
+      it 'returns correct Time for DateTime objects' do
         object = Time.now
         loaded = type.load(object)
-        loaded.should be_a(::Time)
-        loaded.to_time.should == object
+        expect(loaded).to be_a(::Time)
+        expect(loaded.to_time).to eq object
       end
 
-      it "returns correct Time for DateTime objects" do
+      it 'returns correct Time for DateTime objects' do
         object = DateTime.now
         loaded = type.load(object)
-        loaded.should be_a(::Time)
-        loaded.should eq(object.to_time)
+        expect(loaded).to be_a(::Time)
+        expect(loaded).to eq(object.to_time)
       end
-
     end
 
     context 'for incoming strings' do
-
       [
         '2001-02-03T04:05:06+07:00',
         'Sat, 03 Feb 2001 04:05:06 GMT',
@@ -67,11 +61,9 @@ describe Attributor::Time do
         '2007-10-19T04:11:33Z',
         '2001-02-03T04:05:06+07:00.123456', # custom format with microseconds
       ].each do |value|
-
         it "returns correct Time for #{value.inspect}" do
-          type.load(value).should == Time.parse(value)
+          expect(type.load(value)).to eq Time.parse(value)
         end
-
       end
 
       [
@@ -79,31 +71,23 @@ describe Attributor::Time do
         '2007-10-33T04:11:33Z',
         '2001-02-33T04:05:06+07:00.123456', # custom format with microseconds
       ].each do |value|
-
         it "raises Attributor::AttributorException for #{value.inspect}" do
-          expect {
+          expect do
             type.load(value)
-          }.to raise_error(Attributor::DeserializationError, /Error deserializing a String using Time/)
+          end.to raise_error(Attributor::DeserializationError, /Error deserializing a String using Time/)
         end
-
       end
 
       [
         '',
         'foobar'
       ].each do |value|
-
         it "raises Attributor::AttributorException for #{value.inspect}" do
-          expect {
+          expect do
             type.load(value)
-          }.to raise_error(Attributor::DeserializationError, /Error deserializing a String using Time/)
+          end.to raise_error(Attributor::DeserializationError, /Error deserializing a String using Time/)
         end
-
       end
-
     end
-
   end
-
 end
-

data/spec/types/type_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Attributor::Type do
+  subject(:type) do
+    Class.new { include Attributor::Type }
+  end
+
+  it 'raises an error for unimplemented example' do
+    expect { type.example }.to raise_error(Attributor::AttributorException)
+  end
+
+  it 'raises an error for unimplemented valid_type?' do
+    expect { type.valid_type?('foo') }.to raise_error(Attributor::AttributorException)
+  end
+end

data/spec/types/uri_spec.rb

@@ -1,11 +1,10 @@
 require File.join(File.dirname(__FILE__), '..', 'spec_helper.rb')
 
 describe Attributor::URI do
-
   subject(:type) { Attributor::URI }
 
   it 'it is not Dumpable' do
-    type.new.is_a?(Attributor::Dumpable).should_not be(true)
+    expect(type.new.is_a?(Attributor::Dumpable)).not_to be(true)
   end
 
   its(:native_type) { should be ::URI::Generic }
@@ -17,7 +16,7 @@ describe Attributor::URI do
   end
 
   context '.dump' do
-    let(:example){ type.example }
+    let(:example) { type.example }
     it 'uses the underlying URI to_s' do
       expect(type.dump(example)).to eq(example.to_s)
     end
@@ -65,7 +64,7 @@ describe Attributor::URI do
       end
 
       context 'when given a path option' do
-        let(:attribute) { Attributor::Attribute.new(type, path: /^\//) }
+        let(:attribute) { Attributor::Attribute.new(type, path: %r{^/}) }
 
         context 'given a URI that matches the path regex' do
           it 'does not return any errors' do
@@ -89,14 +88,14 @@ describe Attributor::URI do
 
     context 'for path option' do
       context 'given a regex definition' do
-        let(:options) { {path: Regexp.new('a-z')} }
+        let(:options) { { path: Regexp.new('a-z') } }
         it 'checks successfully' do
           expect(subject).to be_kind_of(Attributor::Attribute)
         end
       end
 
       context 'given any definition other than regex' do
-        let(:options) { {path: 1} }
+        let(:options) { { path: 1 } }
         it 'raises an exception' do
           expect { subject }.to raise_error(Attributor::AttributorException)
         end
@@ -104,7 +103,7 @@ describe Attributor::URI do
     end
 
     context 'for any other option' do
-      let(:options) { {something: 1} }
+      let(:options) { { something: 1 } }
       it 'raises an exception' do
         expect { subject }.to raise_error(Attributor::AttributorException)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attributor
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 5.1.0
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-18 00:00:00.000000000 Z
+date: 2016-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
@@ -57,72 +57,86 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.99'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: '1'
 - !ruby/object:Gem::Dependency
-  name: backports
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 0.8.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 0.8.7
 - !ruby/object:Gem::Dependency
-  name: yardstick
+  name: backports
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: yardstick
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -239,16 +253,44 @@ dependencies:
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: parslet
   requirement: !ruby/object:Gem::Requirement
@@ -273,6 +315,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -311,6 +354,7 @@ files:
 - lib/attributor/types/integer.rb
 - lib/attributor/types/model.rb
 - lib/attributor/types/object.rb
+- lib/attributor/types/polymorphic.rb
 - lib/attributor/types/regexp.rb
 - lib/attributor/types/string.rb
 - lib/attributor/types/struct.rb
@@ -330,6 +374,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/hashes.rb
 - spec/support/models.rb
+- spec/support/polymorphics.rb
 - spec/type_spec.rb
 - spec/types/bigdecimal_spec.rb
 - spec/types/boolean_spec.rb
@@ -345,11 +390,14 @@ files:
 - spec/types/ids_spec.rb
 - spec/types/integer_spec.rb
 - spec/types/model_spec.rb
+- spec/types/polymorphic_spec.rb
 - spec/types/regexp_spec.rb
 - spec/types/string_spec.rb
 - spec/types/struct_spec.rb
 - spec/types/tempfile_spec.rb
+- spec/types/temporal_spec.rb
 - spec/types/time_spec.rb
+- spec/types/type_spec.rb
 - spec/types/uri_spec.rb
 homepage: https://github.com/rightscale/attributor
 licenses:
@@ -371,7 +419,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A powerful attribute and type management library for Ruby
@@ -387,6 +435,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/hashes.rb
 - spec/support/models.rb
+- spec/support/polymorphics.rb
 - spec/type_spec.rb
 - spec/types/bigdecimal_spec.rb
 - spec/types/boolean_spec.rb
@@ -402,10 +451,13 @@ test_files:
 - spec/types/ids_spec.rb
 - spec/types/integer_spec.rb
 - spec/types/model_spec.rb
+- spec/types/polymorphic_spec.rb
 - spec/types/regexp_spec.rb
 - spec/types/string_spec.rb
 - spec/types/struct_spec.rb
 - spec/types/tempfile_spec.rb
+- spec/types/temporal_spec.rb
 - spec/types/time_spec.rb
+- spec/types/type_spec.rb
 - spec/types/uri_spec.rb
 has_rdoc: