attributes_history 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5ab51f8fcbd9cad95f6e3724546f8f5d57fb848
-  data.tar.gz: ecdc7309e290238fc6b21bf46c259b76f9dff6bc
+  metadata.gz: 047e72c287edac9652bb432b71b3fe4b2e0e7822
+  data.tar.gz: fe7bcfe8813faff091440a3f591467c6d6c79dc0
 SHA512:
-  metadata.gz: 7c05774dccf3d142db49d91e8a949aa4cb4d80159c9839b36a31f62c5c7b2cc7cc82487d473e9c1ae432d651718fa21a5e38a136c12a1b886041a6ea58f2fd43
-  data.tar.gz: d054f8a660744d412454a4c086bb881accbeb0cbc39db75115218ffa3a7b64abbb4efb50e5a67d603f8885547d0243fdce8a025450d4433f0fe15f863bc90967
+  metadata.gz: 07329646bcc03cfc94c4687339bf3f6296f3ddf85c8ec3c4d11114b72f15eb6c0dc0cd10492e35288c7c3a105b9ed958ec7f7fec9f32faee923376ae19f4133d
+  data.tar.gz: e09f2bf36bd530e5894c51f3c4cc575e6fe11e346acc395d00eea6afd08b277ec8af2285e5f77b7f75f233a45145e00348af80adcb4dc965857fb945425471b2

data/README.md

@@ -96,6 +96,24 @@ This is similar to how [paper_trail](https://github.com/airblade/paper_trail)
 works in that the versions represent past data, and only the current regular
 model record (contact in this case) has the current state.
 
+## Multiple `has_attributes_history` calls per class
+
+If you want to have some attributes (or groups of attributes) stored in
+different tables grouped by semantic meaning or because their size or rate of
+change is different, you can specify multiple `has_attributes_history` calls per
+class. The lists of attributes for the different calls can't have any
+overlapping attributes though or that will confuse the lookup logic.
+
+Here's an example of tracking `notes` in a separate log from `status` and
+`pledge`:
+
+```
+class Contact < ActiveRecord::Base
+  has_attributes_history for: [:status, :pledge], with_model: PartnerStatusLog
+  has_attributes_history for: [:notes], with_model: ContactNotesLog
+end
+```
+
 ## Enabling and disabling
 
 By default the history logging is enabled once you set it up, but you can

data/lib/attributes_history/gem_version.rb

@@ -1,3 +1,3 @@
 module AttributesHistory
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/lib/attributes_history/has_attributes_history.rb

@@ -6,22 +6,51 @@ module AttributesHistory
   module HasAttributesHistory
     extend ActiveSupport::Concern
 
+    included do
+      class_attribute :history_models, :history_associations
+      self.history_models ||= {}
+      self.history_associations ||= {}
+    end
+
     module ClassMethods
       # The options should include the keys :attributes and :version_class
       def has_attributes_history(options)
-        class_attribute :history_model, :history_attributes, :history_association
-        self.history_model = options[:with_model]
-        self.history_attributes = options[:for].map(&:to_s)
-        self.history_association = history_model.name.underscore.pluralize.to_sym
+        history_model = options[:with_model]
+        history_attributes = options[:for].map(&:to_s)
+        history_association = history_model.name.underscore.pluralize.to_sym
 
         has_many history_association
-        after_update { HistorySaver.new(self).save_if_needed }
-        define_verisons_by_date_lookups
+
+        store_history_options(history_model, history_attributes, history_association)
+        setup_history_callback(history_attributes, history_model)
+        define_attribute_on_date_methods(history_attributes)
+      end
+
+      def history_model(attribute)
+        self.history_models[attribute]
+      end
+
+      def history_association(attribute)
+        self.history_associations[attribute]
       end
 
       private
 
-      def define_verisons_by_date_lookups
+      def store_history_options(history_model, history_attributes, history_association)
+        history_attributes.each do |attribute|
+          self.history_associations[attribute] = history_association
+          self.history_models[attribute] = history_model
+        end
+      end
+
+      def setup_history_callback(history_attributes, history_model)
+        after_update do
+          HistorySaver.new(self, history_attributes, history_model)
+            .save_if_needed
+        end
+      end
+
+      def define_attribute_on_date_methods(history_attributes)
         define_method :attribute_on_date do |attribute, date|
           @history_retriever ||= HistoryRetriever.new(self)
           @history_retriever.attribute_on_date(attribute, date)

data/lib/attributes_history/history_retriever.rb

@@ -6,14 +6,18 @@ module AttributesHistory
     end
 
     def attribute_on_date(attribute, date)
-      history_entry = @cached_history[date] ||= find_entry_on(date)
+      history_association = @object.class.history_association(attribute)
+
+      history_entry = @cached_history[[history_association, date]] ||=
+        find_entry_on(history_association, date)
+
       history_entry.public_send(attribute)
     end
 
     private
 
-    def find_entry_on(date)
-      @object.public_send(@object.history_association)
+    def find_entry_on(history_association, date)
+      @object.public_send(history_association)
         .where('recorded_on > ?', date).order(:recorded_on).first || @object
     end
   end

data/lib/attributes_history/history_saver.rb

@@ -1,7 +1,9 @@
 module AttributesHistory
   class HistorySaver
-    def initialize(changed_object)
+    def initialize(changed_object, history_attributes, history_model)
       @object = changed_object
+      @history_attributes = history_attributes
+      @history_model = history_model
     end
 
     def save_if_needed
@@ -12,11 +14,14 @@ module AttributesHistory
     private
 
     def history_attributes_changed?
-      (@object.changed & @object.history_attributes).present?
+      (@object.changed & @history_attributes).present?
     end
 
     def save_history_entry
-      history_entry = @object.public_send(@object.history_association)
+      history_association =
+        @object.class.history_association(@history_attributes.first)
+
+      history_entry = @object.public_send(history_association)
                       .find_or_initialize_by(recorded_on: Date.current)
 
       # If there is an existing history record for today, just leave it as is,
@@ -25,7 +30,7 @@ module AttributesHistory
     end
 
     def history_params
-      Hash[@object.history_attributes.map { |f| [f, history_value_for(f)] }]
+      Hash[@history_attributes.map { |f| [f, history_value_for(f)] }]
     end
 
     def history_value_for(attribute)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attributes_history
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - draffensperger