attribute_normalizer 0.1.0 → 0.1.1

data/README.textile

@@ -4,38 +4,61 @@ p. I like to keep my Active Record models as strict as possible but I also like
 
 h2. Install as a Ruby gem
 
-  TODO: gem-er-a-size this!
-  
+p. The "attribute_normalizer gem":http://gemcutter.org/gems/attribute_normalizer is hosted over at "Gemcutter":http://gemcutter.org
+
+h3. Setup Gemcutter as a gem source if you have not already.
+
+p. It’s fairly simple to set up Gemcutter. Before we start, however, it’s worth making sure that we’ve upgraded to the latest version of RubyGems, which can be done by running
+
+<pre><code>sudo gem update --system</code></pre>
+
+p. From the command line. Once RubyGems has updated itself we can then install the Gemcutter gem with
+
+<pre><code>sudo gem install gemcutter</code></pre>
+
+p. After Gemcutter has installed we’ll need to update our gem sources to include gemcutter.org. To do this we run *gem tumble*.
+
+<pre><code>$ gem tumble
+Thanks for using Gemcutter!
+Your gem sources are now:
+- http://gemcutter.org
+- http://gems.rubyforge.org/
+- http://gems.github.com
+</code></pre>
+
+h3. Install the Attribute Normalizer gem
+
+<pre><code>sudo gem install attribute_normalizer</code></pre>
+
 h2. Install as a Ruby on Rails Plugin
 
 The traditional way.
 
   ./script/plugin install git://github.com/mdeering/attribute_normalizer.git
-  
+
 or the old-school but still c00l way!
 
   piston import git://github.com/mdeering/attribute_normalizer.git vendor/plugins/attribute_normalizer
-  
+
 or for all you hip gitsters.
 
   git submodule add git://github.com/mdeering/attribute_normalizer.git vendor/plugins/attribute_normalizer
   git submodule init
-  
+
 h2. Usage
 
 This is eager loaded into Active Record.  It is usable inside of other ruby classes outside of ActiveRecord by just including the module AttributeNormalizer.
 
 <pre><code>
 class Klass < ActiveRecord::Base
-  
+
   # Can take an array of attributes if you want
   normalize_attributes :first_name, :last_name
-  
+
   normalize_attributes :home_phone_number, :office_phone_number_ do |value|
-    return nil unless value.is_a?(String)
-    value.gsub(/\W/, '').gsub(/^1/, '')
+    value.is_a?(String) ? value.gsub(/\W/, '').gsub(/^1/, '') : nil
   end
-  
+
 end
 
 object = Klass.new
@@ -43,7 +66,7 @@ object = Klass.new
 object.first_name = ''
 object.first_name # => nil
 
-# Whitespace is cleaned up 
+# Whitespace is cleaned up
 object.last_name = "\tDeering\n"
 object.last_name # => 'Deering'
 
@@ -58,4 +81,4 @@ Original module code and concept was taken from "Dan Kubb":http://github.com/dku
 
 h2. Copyright
 
-Copyright (c) 2009 "Michael Deering(Edmonton Ruby on Rails)":http://mdeering.com See MIT-LICENSE for details.
+Copyright (c) 2009 "Michael Deering(Edmonton Ruby on Rails)":http://mdeering.com See MIT-LICENSE for details.

data/Rakefile

@@ -13,11 +13,23 @@ begin
   Jeweler::Tasks.new do |s|
     s.author       = AUTHOR
     s.email        = EMAIL
-    s.files        = %w(MIT-LICENSE README.textile Rakefile) + Dir.glob("{rails,lib,spec}/**/*")        
+    s.files        = %w(install.rb install.txt MIT-LICENSE README.textile Rakefile) + Dir.glob("{rails,lib,spec}/**/*")        
     s.homepage     = HOMEPAGE 
     s.name         = GEM    
     s.require_path = 'lib'       
     s.summary      = SUMMARY
+    s.post_install_message = %q[
+      =============================
+      Attribute Normalizer News:
+
+      I am looking for feedback on the roadmap for this gem.  Please visit
+      http://github.com/mdeering/attribute_normalizer/blob/master/ROADMAP.textile
+      and send your comments, suggestions, and pull requests.
+
+      Cheers,
+      Michael Deering http://mdeering.com
+      =============================      
+    ]
   end
   Jeweler::GemcutterTasks.new
 rescue LoadError

data/install.rb

@@ -0,0 +1 @@
+puts IO.read(File.join(File.dirname(__FILE__), 'install.txt'))

data/install.txt

@@ -0,0 +1,10 @@
+-----------------------------------------------------------------------
+  Attribute Normalizer News:
+  
+  I am looking for feedback on the roadmap for this gem.  Please visit
+  http://github.com/mdeering/attribute_normalizer/blob/master/ROADMAP.textile
+  and send your comments, suggestions, and pull requests.
+  
+  Cheers,
+  Michael Deering http://mdeering.com
+-----------------------------------------------------------------------

data/lib/attribute_normalizer.rb

@@ -22,18 +22,24 @@ module AttributeNormalizer
 
         src = <<-end_src
           def #{attribute}
-            @#{attribute} ||= self.class.send(:normalize_#{attribute}, self[:#{attribute}]) unless self[:#{attribute}].nil?
+            value = super
+            value.nil? ? value : self.class.send(:normalize_#{attribute}, value)
           end
 
           def #{attribute}=(#{attribute})
-            @#{attribute} = self[:#{attribute}] = self.class.send(:normalize_#{attribute}, #{attribute})
+            super(self.class.send(:normalize_#{attribute}, #{attribute}))
           end
         end_src
 
         module_eval src, __FILE__, __LINE__
-        
+
       end
-      
+
     end
+
+    alias :normalize_attribute :normalize_attributes
+
   end
 end
+
+ActiveRecord::Base.send(:include, AttributeNormalizer)

data/rails/init.rb

@@ -1,2 +1 @@
 require File.join(File.dirname(__FILE__), *%w[.. lib attribute_normalizer])
-ActiveRecord::Base.send(:include, AttributeNormalizer)

data/spec/attribute_normalizer_spec.rb

@@ -2,44 +2,44 @@ require File.dirname(__FILE__) + '/test_helper'
 require 'attribute_normalizer'
 
 describe AttributeNormalizer do
-  
+
   it 'should add the class method Class#normalize_attributes when included' do
-  
+
     klass = Class.new do
       include AttributeNormalizer
     end
-  
+
     klass.respond_to?(:normalize_attributes).should be_true
   end
-  
+
 end
 
 describe '#normalize_attributes without a block' do
-  
-  before do  
+
+  before do
 
     class Klass
       attr_accessor :attribute
       include AttributeNormalizer
       normalize_attributes :attribute
     end
-    
+
   end
 
   {
-    ' spaces in front and back ' => 'spaces in front and back', 
+    ' spaces in front and back ' => 'spaces in front and back',
     "\twe hate tabs!\t"          => 'we hate tabs!'
   }.each do |key, value|
     it "should normalize '#{key}' to '#{value}'" do
       Klass.send(:normalize_attribute, key).should == value
     end
   end
-  
+
 end
 
 describe '#normalize_attributes with a block' do
-  
-  before do  
+
+  before do
 
     class Klass
       attr_accessor :attribute
@@ -51,13 +51,13 @@ describe '#normalize_attributes with a block' do
         value
       end
     end
-    
+
     @object = Klass.new
-    
+
   end
 
   {
-    "\tMichael Deering" => 'MICHAEL DEERING', 
+    "\tMichael Deering" => 'MICHAEL DEERING',
     2                   => 4,
     2.0                 => 1.0
   }.each do |key, value|
@@ -65,30 +65,59 @@ describe '#normalize_attributes with a block' do
       Klass.send(:normalize_attribute, key).should == value
     end
   end
-  
+
 end
 
 describe 'with an instance' do
-  
+
   before do
-    class Klass
-      attr_accessor :attribute
-      include AttributeNormalizer
-      normalize_attributes :attribute
+    User.class_eval do
+      normalize_attributes :name
     end
-    
-    @object = Klass.new
+    @user = User.new
+  end
+
+  {
+    ' spaces in front and back ' => 'spaces in front and back',
+    "\twe hate tabs!\t"          => 'we hate tabs!'
+  }.each do |key, value|
+    it "should normalize '#{key}' to '#{value}'" do
+      @user.name = key
+      @user.name.should == value
+    end
+  end
+
+  context 'when another instance of the same saved record has been changed' do
+
+    before do
+      @user = User.create!(:name => 'Jimi Hendrix')
+      @user2 = User.find(@user.id)
+      @user2.update_attributes(:name => 'Thom Yorke')
+    end
+
+    it "should reflect the change when the record is reloaded" do
+      lambda { @user.reload }.should change(@user, :name).from('Jimi Hendrix').to('Thom Yorke')
+    end
+  end
+
+end
+
+describe 'normalize_attribute is aliased to normalize_attributes' do
+  before do
+    User.class_eval do
+      normalize_attribute :name
+    end
+    @user = User.new
   end
-  
+
   {
-    ' spaces in front and back ' => 'spaces in front and back', 
+    ' spaces in front and back ' => 'spaces in front and back',
     "\twe hate tabs!\t"          => 'we hate tabs!'
   }.each do |key, value|
     it "should normalize '#{key}' to '#{value}'" do
-      @object.send('attribute=', key)
-      @object.send(:attribute).should == value
+      @user.name = key
+      @user.name.should == value
     end
   end
-  
-  
+
 end

data/spec/test_helper.rb

@@ -1,9 +1,19 @@
 require 'rubygems'
 require 'spec'
-require 'activesupport'
-require 'activerecord'
+require 'active_support'
+require 'active_record'
+
+ActiveRecord::Base.establish_connection({ :database => ":memory:", :adapter => 'sqlite3', :timeout => 500 })
+
+ActiveRecord::Schema.define do
+  create_table :users, :force => true do |t|
+    t.string :name
+  end
+end
+
+class User < ActiveRecord::Base; end
 
 Spec::Runner.configure do |config|
 end
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: attribute_normalizer
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Michael Deering
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-01 00:00:00 -07:00
+date: 2010-01-02 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -25,6 +25,8 @@ files:
 - MIT-LICENSE
 - README.textile
 - Rakefile
+- install.rb
+- install.txt
 - lib/attribute_normalizer.rb
 - rails/init.rb
 - spec/attribute_normalizer_spec.rb
@@ -33,7 +35,7 @@ has_rdoc: true
 homepage: http://github.com/mdeering/attribute_normalizer
 licenses: []
 
-post_install_message: 
+post_install_message: "\n      =============================\n      Attribute Normalizer News:\n\n      I am looking for feedback on the roadmap for this gem.  Please visit\n      http://github.com/mdeering/attribute_normalizer/blob/master/ROADMAP.textile\n      and send your comments, suggestions, and pull requests.\n\n      Cheers,\n      Michael Deering http://mdeering.com\n      =============================      \n    "
 rdoc_options: 
 - --charset=UTF-8
 require_paths: