attr_json 0.4.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05247aceb96f0df4ce9f36a4f6c56099700a33aeddcc0d2a9596330f0ecb23c9
-  data.tar.gz: ed213264805ed42866d00c6e03e5504a63c96763ac1f83a3518302dbb5c51954
+  metadata.gz: be1175039b6fbd78d5a9c1bcaae7c4ce003d29f403ef1e86d71d3c226e659a0b
+  data.tar.gz: 588710deb7c2b6076ba1cf1094f9b4ab67fb7bd74cecfc8c560de5b0ef50eafb
 SHA512:
-  metadata.gz: 193073a8b1ac277d2f062bb8fae958ec2be300e53216e29fd7af5cf8e70db96e39da92c23ee2f452907b31e55fca0966dff7dd6e45c270028dd2c400a4f53477
-  data.tar.gz: d92e6761a2dfab4db80931a5af85bbad112631b12f0c62536fcd5ff532df41ffb475a0bea3cd10ac7d013b7ab4d779a19e2af980ab00fa320168715840e32fcc
+  metadata.gz: d71520892d16915465eab7c9e373f5e5ecabb8efee7a295da6532fbedd0c9817890da7e689e31f1bf1c7b3c1cad73f071f3563d7eb6d5637516de40174fce627
+  data.tar.gz: ea225c01754abfa5dec0e8749fd91ff68e1a329b54e684a27fee14655de7eb4eddf832538a961b14bbf83e222e0b90bfe554a8fdac001ca95aefb456353ed763

data/.travis.yml

@@ -1,21 +1,64 @@
 #
-dist: trusty
 sudo: false
 addons:
   postgresql: '9.4'
   chrome: stable
 language: ruby
 cache: bundler
-rvm:
-  - 2.4
-  - 2.5.1
-gemfile:
-  - gemfiles/rails_5_0.gemfile
-  - gemfiles/rails_5_1.gemfile
-  - gemfiles/rails_5_2.gemfile
-  - gemfiles/rails_edge_6.gemfile
+
+# rvm:
+#   - 2.4.5
+#   - 2.5.3
+#   - 2.6.5
+#   - 2.7.0
+# gemfile:
+#   - gemfiles/rails_5_0.gemfile
+#   - gemfiles/rails_5_1.gemfile
+#   - gemfiles/rails_5_2.gemfile
+#   - gemfiles/rails_6_0.gemfile
+#   - gemfiles/rails_edge.gemfile
+
 before_install:
-  - gem install bundler -v 1.14.6
+  - gem install bundler -v "~> 2.0"
+
 matrix:
+  include:
+    - rvm: 2.4.5
+      gemfile: gemfiles/rails_5_0.gemfile
+
+    - rvm: 2.4.5
+      gemfile: gemfiles/rails_5_1.gemfile
+
+    - rvm: 2.4.5
+      gemfile: gemfiles/rails_5_2.gemfile
+
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_5_0.gemfile
+
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_5_1.gemfile
+
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_5_2.gemfile
+
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_6_0.gemfile
+
+    - rvm: 2.6.5
+      gemfile: gemfiles/rails_5_2.gemfile
+
+    - rvm: 2.6.5
+      gemfile: gemfiles/rails_6_0.gemfile
+
+    - rvm: 2.7.0
+      gemfile: gemfiles/rails_6_0.gemfile
+
+    - rvm: 2.7.0
+      gemfile: gemfiles/rails_edge.gemfile
+
   allow_failures:
-  - gemfile: gemfiles/rails_edge_6.gemfile
+  - gemfile: gemfiles/rails_edge.gemfile
+  fast_finish: true
+
+
+

data/Appraisals

@@ -25,10 +25,17 @@ appraise "rails-5-2" do
   gem "pg", "~> 1.0"
 end
 
+appraise "rails-6-0" do
+  gem 'combustion', "~> 1.0"
+
+  gem "rails", ">= 6.0.0.beta1", "< 6.1"
+  gem "pg", "~> 1.0"
+end
+
 appraise "rails-edge-6" do
   # Edge rails needs unreleased combustion
   # https://github.com/pat/combustion/issues/92
-  gem 'combustion', git: "https://github.com/pat/combustion.git"
+  gem 'combustion', "~> 1.0"
 
   gem "rails", git: "https://github.com/rails/rails.git", branch: "master"
   gem "pg", "~> 1.0"

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+Notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased](https://github.com/jrochkind/attr_json/compare/v1.1.0...HEAD)
+
+## [1.1.0](https://github.com/jrochkind/attr_json/compare/v1.0.0...v1.1.0)
+
+### Added
+
+* not_jsonb_contains query method, like `jsonb_contains` but negated. https://github.com/jrochkind/attr_json/pull/85

data/Gemfile

@@ -10,7 +10,7 @@ gemspec
 # We also have these development dependencies here in the Gemfile instead of the
 # gemspec so appraisal can override them from our Appraisal file.
 
-gem 'combustion', '~> 0.9.0'
+gem 'combustion', '~> 1.1'
 
 # all of rails is NOT a dependency, just activerecord.
 # But we use it for integration testing with combustion. Hmm, a bit annoying
@@ -24,13 +24,13 @@ gem 'rails'
 gem 'railties'
 
 gem "pg"
-gem "rspec-rails", "~> 3.7"
+gem "rspec-rails", "~> 4.0"
 gem "simple_form", ">= 4.0"
 gem 'cocoon', ">= 1.2"
 gem 'jquery-rails'
 
 gem 'capybara', "~> 3.0"
-gem "chromedriver-helper"
+gem 'webdrivers', '~> 4.0'
 gem "selenium-webdriver"
 
 gem "byebug"

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/attr_json.svg)](https://badge.fury.io/rb/attr_json)
 
 
-ActiveRecord attributes stored serialized in a json column, super smooth. For Rails 5.0, 5.1, or 5.2. Ruby 2.4+.
+ActiveRecord attributes stored serialized in a json column, super smooth. For Rails 5.0, 5.1, 5.2, or 6.0. Ruby 2.4+.
 
 Typed and cast like Active Record. Supporting [nested models](#nested), [dirty tracking](#dirty), some [querying](#querying) (with postgres [jsonb](https://www.postgresql.org/docs/9.5/static/datatype-json.html) contains), and [working smoothy with form builders](#forms).
 
@@ -11,8 +11,6 @@ Typed and cast like Active Record. Supporting [nested models](#nested), [dirty t
 
 [Why might you want or not want this?](#why)
 
-AttrJson is pre-1.0. The functionality that is documented here _is_ already implemented (these docs are real, not vaporware) and seems pretty solid. It may still have backwards-incompat changes before 1.0 release. Review and feedback is very welcome.
-
 Developed for postgres, but most features should work with MySQL json columns too, although
 has not yet been tested with MySQL.
 
@@ -140,6 +138,9 @@ MyModel.jsonb_contains(my_string: "foo", my_integer: 100).first
 # Implemented with scopes, this is an ordinary relation, you can
 # combine it with whatever, just like ordinary `where`.
 
+MyModel.not_jsonb_contains(my:string: "foo", my_integer: 100).to_sql
+# SELECT "products".* FROM "products" WHERE NOT (products.json_attributes @> ('{"my_string":"foo","my_integer":100}')::jsonb)
+
 # typecasts much like ActiveRecord on query too:
 MyModel.jsonb_contains(my_string: "foo", my_integer: "100")
 # no problem
@@ -285,6 +286,20 @@ always mean 'contains' -- the previous query needs a `my_labels.hello`
 which is a hash that includes the key/value, `lang: en`, it can have
 other key/values in it too.  String values will need to match exactly.
 
+<a name="arbitrary-json-data"></a>
+## Storing Arbitrary JSON data
+
+Arbitrary JSON data (hashes, arrays, primitives of any depth) can be stored within attributes by using the rails built in `ActiveModel::Type::Value` as the attribute type. This is basically a "no-op" value type -- JSON alone will be used to serialize/deserialize whatever values you put there, because of the json type on the container field.
+
+```ruby
+class MyModel < ActiveRecord::Base
+  include AttrJson::Record
+
+  attr_json :arbitrary_hash, ActiveModel::Type::Value.new
+end
+
+```
+
 
 <a name="forms"></a>
 ## Forms and Form Builders
@@ -383,16 +398,16 @@ to prevent overwriting other updates from processes.
 
 ## State of Code, and To Be Done
 
-This is a pre-1.0 work in progress. But the functionality that is here seems pretty solid.
+The functionality that is here seems pretty solid, and is being used by jrochkind in a production app.
 
-Backwards incompatible changes are possible before 1.0. Once I tag something 1.0, I'm pretty serious about minimizing backwards incompats.
-
-I do not yet use this myself in production, and may not for a while. I generally am reluctant to release something as 1.0 with implied suitable for production when I'm not yet using it in production myself, but may with enough feedback. A couple others are already using in production.
+We are committed to [semantic versioning](https://semver.org/) and will endeavor to release no backwards breaking changes without a major version. We are also serious about minimizing backwards incompat releases altogether (ie minimiing major version releases).
 
 Feedback of any kind of _very welcome_, please feel free to use the issue tracker.
 
 Except for the jsonb_contains stuff using postgres jsonb contains operator, I don't believe any postgres-specific features are used. It ought to work with MySQL, testing and feedback welcome. (Or a PR to test on MySQL?).  My own interest is postgres.
 
+This is still mostly a single-maintainer operation, so has all the sustainability risks of that. Although there are other people using and contributing to it, check out the Github Issues and Pull Request tabs yourself to get a sense.
+
 ### Possible future features:
 
 * partial updates for json hashes would be really nice: Using postgres jsonb merge operators to only overwrite what changed. In my initial attempts, AR doesn't make it easy to customize this.
@@ -450,3 +465,5 @@ There is a `./bin/console` that will give you a console in the context of attr_j
 * Didn't actually notice existing [json_attributes](https://github.com/joel/json_attributes)
   until I was well on my way here. I think it's not updated for Rails5 or type-aware,
   haven't looked at it too much.
+
+* [store_model](https://github.com/DmitryTsepelev/store_model) was created after `attr_json`, and has some overlapping functionality.

data/attr_json.gemspec

@@ -45,10 +45,10 @@ attributes use as much of the existing ActiveRecord architecture as we can.}
   # Only to get CI to work on versions of Rails other than we release with,
   # should never release a gem with RAILS_GEM set!
   unless ENV['APPRAISAL_INITIALIZED'] || ENV["TRAVIS"]
-    spec.add_runtime_dependency "activerecord", ">= 5.0.0", "< 5.3"
+    spec.add_runtime_dependency "activerecord", ">= 5.0.0", "< 6.1"
   end
 
-  spec.add_development_dependency "bundler", "~> 1.14"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", ">= 10.0"
   spec.add_development_dependency "rspec", "~> 3.7"
   spec.add_development_dependency "database_cleaner", "~> 1.5"

data/gemfiles/rails_5_0.gemfile

@@ -6,12 +6,12 @@ gem "combustion", "~> 0.9.0"
 gem "rails", "~> 5.0.0"
 gem "railties"
 gem "pg", "~> 0.18"
-gem "rspec-rails", "~> 3.7"
+gem "rspec-rails", "~> 4.0"
 gem "simple_form", ">= 4.0"
 gem "cocoon", ">= 1.2"
 gem "jquery-rails"
 gem "capybara", "~> 3.0"
-gem "chromedriver-helper"
+gem "webdrivers", "~> 4.0"
 gem "selenium-webdriver"
 gem "byebug"
 gem "rails-ujs", require: false

data/gemfiles/rails_5_1.gemfile

@@ -6,12 +6,12 @@ gem "combustion", "~> 0.9.0"
 gem "rails", "~> 5.1.0"
 gem "railties"
 gem "pg", "~> 1.0"
-gem "rspec-rails", "~> 3.7"
+gem "rspec-rails", "~> 4.0"
 gem "simple_form", ">= 4.0"
 gem "cocoon", ">= 1.2"
 gem "jquery-rails"
 gem "capybara", "~> 3.0"
-gem "chromedriver-helper"
+gem "webdrivers", "~> 4.0"
 gem "selenium-webdriver"
 gem "byebug"
 

data/gemfiles/rails_5_2.gemfile

@@ -6,12 +6,12 @@ gem "combustion", "~> 0.9.0"
 gem "rails", "~> 5.2.0"
 gem "railties"
 gem "pg", "~> 1.0"
-gem "rspec-rails", "~> 3.7"
+gem "rspec-rails", "~> 4.0"
 gem "simple_form", ">= 4.0"
 gem "cocoon", ">= 1.2"
 gem "jquery-rails"
 gem "capybara", "~> 3.0"
-gem "chromedriver-helper"
+gem "webdrivers", "~> 4.0"
 gem "selenium-webdriver"
 gem "byebug"
 

data/gemfiles/rails_6_0.gemfile

@@ -0,0 +1,18 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "combustion", "~> 1.0"
+gem "rails", ">= 6.0.0.beta1", "< 6.1"
+gem "railties"
+gem "pg", "~> 1.0"
+gem "rspec-rails", "~> 4.0"
+gem "simple_form", ">= 4.0"
+gem "cocoon", ">= 1.2"
+gem "jquery-rails"
+gem "capybara", "~> 3.0"
+gem "webdrivers", "~> 4.0"
+gem "selenium-webdriver"
+gem "byebug"
+
+gemspec path: "../"

data/gemfiles/rails_edge.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "combustion", "~> 1.0"
+gem "rails", git: "https://github.com/rails/rails.git", branch: "master"
+gem "railties"
+gem "pg", "~> 1.0"
+gem "rspec-rails", "~> 3.7"
+gem "simple_form", ">= 4.0"
+gem "cocoon", ">= 1.2"
+gem "jquery-rails"
+gem "capybara", "~> 3.0"
+gem "webdrivers", "~> 4.0"
+gem "selenium-webdriver"
+gem "byebug"
+gem "coffee-rails"
+
+gemspec path: "../"

data/gemfiles/rails_edge_6.gemfile

@@ -2,16 +2,16 @@
 
 source "https://rubygems.org"
 
-gem "combustion", git: "https://github.com/pat/combustion.git"
+gem "combustion", "~> 1.0"
 gem "rails", git: "https://github.com/rails/rails.git", branch: "master"
 gem "railties"
 gem "pg", "~> 1.0"
-gem "rspec-rails", "~> 3.7"
+gem "rspec-rails", "~> 4.0"
 gem "simple_form", ">= 4.0"
 gem "cocoon", ">= 1.2"
 gem "jquery-rails"
 gem "capybara", "~> 3.0"
-gem "chromedriver-helper"
+gem "webdrivers", "~> 4.0"
 gem "selenium-webdriver"
 gem "byebug"
 gem "coffee-rails"

data/lib/attr_json.rb

@@ -1,7 +1,6 @@
 require "attr_json/version"
 
 require "active_record"
-require "active_record/connection_adapters/postgresql_adapter"
 
 require 'attr_json/config'
 require 'attr_json/record'

data/lib/attr_json/attribute_definition.rb

@@ -12,7 +12,9 @@
     attr_reader :name, :type, :original_args, :container_attribute
 
     # @param name [Symbol,String]
-    # @param type [Symbol,ActiveModel::Type::Value]
+    # @param type [Symbol,ActiveModel::Type::Value] Symbol is looked up in
+    #   ActiveRecord::Type.lookup, but with `adapter: nil` for no custom
+    #   adapter-specific lookup.
     #
     # @option options store_key [Symbol,String]
     # @option options container_attribute [Symbol,ActiveModel::Type::Value]
@@ -40,7 +42,12 @@
         # ActiveModel::Type.lookup may make more sense, but ActiveModel::Type::Date
         # seems to have a bug with multi-param assignment. Mostly they return
         # the same types, but ActiveRecord::Type::Date works with multi-param assignment.
-        type = ActiveRecord::Type.lookup(type)
+        #
+        # We pass `adapter: nil` to avoid triggering a db connection.
+        # See: https://github.com/jrochkind/attr_json/issues/41
+        # This is at the "cost" of not using any adapter-specific types... which
+        # maybe preferable anyway?
+        type = ActiveRecord::Type.lookup(type, adapter: nil)
       elsif ! type.is_a? ActiveModel::Type::Value
         raise ArgumentError, "Second argument (#{type}) must be a symbol or instance of an ActiveModel::Type::Value subclass"
       end

data/lib/attr_json/attribute_definition/registry.rb

@@ -54,6 +54,11 @@ module AttrJson
         @name_to_definition.values
       end
 
+      # Returns all registered attributes as an array of symbols
+      def attribute_names
+        @name_to_definition.keys
+      end
+
       def container_attributes
         @store_key_to_definition.keys.collect(&:to_s)
       end

data/lib/attr_json/record.rb

@@ -18,7 +18,7 @@ module AttrJson
     extend ActiveSupport::Concern
 
     included do
-      unless self < ActiveRecord::Base
+      unless self <= ActiveRecord::Base
         raise TypeError, "AttrJson::Record can only be used with an ActiveRecord::Base model. #{self} does not appear to be one. Are you looking for ::AttrJson::Model?"
       end
 
@@ -26,6 +26,37 @@ module AttrJson
       self.attr_json_registry = AttrJson::AttributeDefinition::Registry.new
     end
 
+    protected
+
+    # adapted from ActiveRecord query_attribute method
+    # https://github.com/rails/rails/blob/v5.2.3/activerecord/lib/active_record/attribute_methods/query.rb#L12
+    #
+    # Sadly we could not re-use Rails code here, becuase the built-in method assumes attribute
+    # can be obtained with `self[attr_name]`, which you can not with attr_json (is that bad?), as
+    # well as `self.class.columns_hash[attr_name]` which you definitely can not (which is probably not bad),
+    # and has no way to use the value-translation semantics independently of that. May be a problem if
+    # ActiveRecord changes it's query method semantics in the future, will have to be sync'd here.
+    #
+    # Used to implement query methods on attr_json attributes, like `attr_json :foo, :string`, method `#foo?`
+    def self.attr_json_query_method(record, attribute)
+      value = record.send(attribute)
+
+      case value
+      when true
+        true
+      when false, nil, ActiveModel::Type::Boolean::FALSE_VALUES
+        false
+      else
+        if value.respond_to?(:to_i) && ( Numeric === value || value.to_s !~ /[^0-9]/ )
+          !value.to_i.zero?
+        elsif value.respond_to?(:zero?)
+          !value.zero?
+        else
+          !value.blank?
+        end
+      end
+    end
+
     class_methods do
       # Access or set class-wide json_attribute_config. Inherited by sub-classes,
       # but setting on sub-classes is unique to subclass. Similar to how
@@ -133,30 +164,27 @@ module AttrJson
         end
 
         _attr_jsons_module.module_eval do
+          # For getter and setter, we used to use read_store_attribute/write_store_attribute
+          # copied from Rails store_accessor implementation.
+          # https://github.com/rails/rails/blob/74c3e43fba458b9b863d27f0c45fd2d8dc603cbc/activerecord/lib/active_record/store.rb#L90-L96
+          #
+          # But in fact just getting/setting in the hash provided to us by ActiveRecord json type
+          # container works BETTER for dirty tracking. We had a test that only passed doing it
+          # this simple way.
+
           define_method("#{name}=") do |value|
             attribute_def = self.class.attr_json_registry.fetch(name.to_sym)
-            # write_store_attribute copied from Rails store_accessor implementation.
-            # https://github.com/rails/rails/blob/74c3e43fba458b9b863d27f0c45fd2d8dc603cbc/activerecord/lib/active_record/store.rb#L90-L96
-
-            # special handling for nil, sorry, because if name key was previously
-            # not present, write_store_attribute by default will decide there was
-            # no change and refuse to make the change. TODO messy.
-            if value.nil? && !public_send(attribute_def.container_attribute).has_key?(attribute_def.store_key)
-               public_send :"#{attribute_def.container_attribute}_will_change!"
-               public_send(attribute_def.container_attribute)[attribute_def.store_key] = nil
-            else
-              # use of `write_store_attribute` is copied from Rails store_accessor implementation.
-              # https://github.com/rails/rails/blob/74c3e43fba458b9b863d27f0c45fd2d8dc603cbc/activerecord/lib/active_record/store.rb#L90-L96
-              write_store_attribute(attribute_def.container_attribute, attribute_def.store_key, attribute_def.cast(value))
-            end
+            public_send(attribute_def.container_attribute)[attribute_def.store_key] = attribute_def.cast(value)
           end
 
           define_method("#{name}") do
             attribute_def = self.class.attr_json_registry.fetch(name.to_sym)
+            public_send(attribute_def.container_attribute)[attribute_def.store_key]
+          end
 
-            # use of `read_store_attribute` is copied from Rails store_accessor implementation.
-            # https://github.com/rails/rails/blob/74c3e43fba458b9b863d27f0c45fd2d8dc603cbc/activerecord/lib/active_record/store.rb#L90-L96
-            read_store_attribute(attribute_def.container_attribute, attribute_def.store_key)
+          define_method("#{name}?") do
+            # implementation of `query_store_attribute` is based on Rails `query_attribute` implementation
+            AttrJson::Record.attr_json_query_method(self, name)
           end
         end
 

data/lib/attr_json/record/query_builder.rb

@@ -10,6 +10,20 @@ module AttrJson
       end
 
       def contains_relation
+        contains_relation_impl do |relation, query, params|
+          relation.where(query, params)
+        end
+      end
+
+      def contains_not_relation
+        contains_relation_impl do |relation, query, params|
+          relation.where.not(query, params)
+        end
+      end
+
+      protected
+
+      def contains_relation_impl
         result_relation = relation
 
         group_attributes_by_container.each do |container_attribute, attributes|
@@ -18,14 +32,12 @@ module AttrJson
           attributes.each do |key, value|
             add_to_param_hash!(param_hash, key, value)
           end
-          result_relation = result_relation.where("#{relation.table_name}.#{container_attribute} @> (?)::jsonb", param_hash.to_json)
+          result_relation = yield(result_relation, "#{relation.table_name}.#{container_attribute} @> (?)::jsonb", param_hash.to_json)
         end
 
         result_relation
       end
 
-      protected
-
       def merge_param_hash!(original, new)
         original.deep_merge!(new) do |key, old_val, new_val|
           if old_val.is_a?(Array) && old_val.first.is_a?(Hash) && new_val.is_a?(Array) && new_val.first.is_a?(Hash)

data/lib/attr_json/record/query_scopes.rb

@@ -17,6 +17,8 @@ module AttrJson
     #
     #      some_model.jsonb_contains(a_string: "foo").first
     #
+    #      some_model.not_jsonb_contains(a_string: "bar").first
+    #
     # See more in {file:README} docs.
     module QueryScopes
       extend ActiveSupport::Concern
@@ -29,6 +31,10 @@ module AttrJson
         scope(:jsonb_contains, lambda do |attributes|
           QueryBuilder.new(self, attributes).contains_relation
         end)
+
+        scope(:not_jsonb_contains, lambda do |attributes|
+          QueryBuilder.new(self, attributes).contains_not_relation
+        end)
       end
     end
   end

data/lib/attr_json/type/model.rb

@@ -8,6 +8,8 @@ module AttrJson
     # but normally that's only done in AttrJson::Model.to_type, there isn't
     # an anticipated need to create from any other place.
     class Model < ::ActiveModel::Type::Value
+      class BadCast < ArgumentError ; end
+
       attr_accessor :model
       def initialize(model)
         #TODO type check, it really better be a AttrJson::Model. maybe?
@@ -34,10 +36,11 @@ module AttrJson
           # TODO Maybe we ought not to do this on #to_h?
           model.new_from_serializable(v.to_h)
         else
-          # Bad input? Most existing ActiveModel::Types seem to decide
-          # either nil, or a base value like the empty string. They don't
-          # raise. So we won't either, just nil.
-          nil
+          # Bad input. Originally we were trying to return nil, to be like
+          # existing ActiveRecord which kind of silently does a basic value
+          # with null input. But that ended up making things confusing, let's
+          # just raise.
+          raise BadCast.new("Can not cast from #{v.inspect} to #{self.type}")
         end
       end
 

data/lib/attr_json/type/polymorphic_model.rb

@@ -51,6 +51,8 @@ module AttrJson
     #      MyRecord.jsonb_contains(author: { name: "foo", type: "Corporation"})
     #      MyRecord.jsonb_contains(author: Corporation.new(name: "foo"))
     #
+    # Additionally, there is not_jsonb_contains, which creates the same query terms like jsonb_contains, but negated.
+    #
     class PolymorphicModel < ActiveModel::Type::Value
       class TypeError < ::TypeError ; end
 

data/lib/attr_json/version.rb

@@ -1,3 +1,3 @@
 module AttrJson
-  VERSION = "0.4.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_json
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Jonathan Rochkind
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2020-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -19,7 +19,7 @@ dependencies:
         version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,21 +29,21 @@ dependencies:
         version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -133,6 +133,7 @@ files:
 - ".travis.yml"
 - ".yardopts"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -149,6 +150,8 @@ files:
 - gemfiles/rails_5_0.gemfile
 - gemfiles/rails_5_1.gemfile
 - gemfiles/rails_5_2.gemfile
+- gemfiles/rails_6_0.gemfile
+- gemfiles/rails_edge.gemfile
 - gemfiles/rails_edge_6.gemfile
 - lib/attr_json.rb
 - lib/attr_json/attribute_definition.rb
@@ -192,7 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: ActiveRecord attributes stored serialized in a json column, super smooth.