attr_json 0.2.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1033d8a923d5935a8b18e10612883d6756279089
-  data.tar.gz: 8c8b5faf3c24cc27d1d6e382b44c3a63b180826a
+SHA256:
+  metadata.gz: 3cd2566fed014325bee56f5c062080d3c929a790dbb3b287e92b086c2fa3180f
+  data.tar.gz: ffa8e7b471dce27a2708b12e6a2bf27edb5b20d1345656ca026ecc4b263a01a7
 SHA512:
-  metadata.gz: 57dec15a2438c7d5fa8b2460afc3c3fcedef01aad80a78bf9bb1511b9be68bb6b7166acb7dc9b1aa25d5614c8cd7eb688fc55433ed9bce1fdb8eab8d1061e22d
-  data.tar.gz: 76f0397e93f14b3ca5ff38c01bf4da3b6d4ea11080414d60e7da2126ecffc78926e087245fe82cc8d30a5d8bc6ffa41d2092b096ed8bcb2ad91149960610a85d
+  metadata.gz: f8db6d4211a2dd9f4b9d8a5482b723597958082617e139157c325e8e3b9dddf15216d21bd56daece5d5b3674acdc8e099a22998ad452473a4bf0834774b7a21f
+  data.tar.gz: 13e2cd5b4b10f67f4ecfc1be8732c6a33a7f7a7fdb561b6d8f4f89ae39c74e4b0b153ae10fdf5d650a239534f5b28cd33750aaff90009eeec8877677e765a935

data/.github/workflows/ci.yml

@@ -0,0 +1,87 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ '**' ]
+  # UTC Tuesdays 0900. note, no notifications will be sent for failed scheduled builds. :(
+  schedule:
+    - cron: '0 9 * * TUE'
+
+
+env:
+  POSTGRES_USER: postgres
+  POSTGRES_PASSWORD: postgres
+
+jobs:
+  tests:
+    services:
+      db:
+        image: postgres:9.4
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+        ports: ['5432:5432']
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - gemfile: rails_5_0
+            ruby: 2.4
+
+          - gemfile: rails_5_0
+            ruby: 2.5
+
+          - gemfile: rails_5_1
+            ruby: 2.4
+
+          - gemfile: rails_5_2
+            ruby: 2.4
+
+          - gemfile: rails_5_2
+            ruby: 2.6
+
+          - gemfile: rails_6_0
+            ruby: 2.6
+
+          - gemfile: rails_6_0
+            ruby: 2.7
+
+          - gemfile: rails_6_1
+            ruby: 2.7
+
+          - gemfile: rails_6_1
+            ruby: '3.0'
+
+          - gemfile: rails_7_0
+            ruby: '3.0'
+
+          - gemfile: rails_7_0
+            ruby: 3.1
+
+          - gemfile: rails_7_0
+            ruby: 3.2
+
+
+    name: ${{ matrix.gemfile }}, ruby ${{ matrix.ruby }}
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: false
+
+    - name: Bundle install
+      run: |
+        bundle config set gemfile "${GITHUB_WORKSPACE}/gemfiles/${{ matrix.gemfile }}.gemfile"
+        bundle install --jobs 4 --retry 3
+
+    - name: Run tests
+      run: |
+        bundle exec rspec

data/.github/workflows/future_rails_ci.yml

@@ -0,0 +1,66 @@
+name: CI on Future Rails Versions
+
+# Experimenting with separate github actions workflow
+# for gemfiles for FUTURE Rails vesions, we'd like to keep an eye on
+# if they pass, but they aren't required to do so.
+#
+# This has to just be a copy-and-paste copy of our main ci.yml,
+# but with different gemfiles in the matrix. That is not great.
+# We also choose NOT to run this one on pull_request, we just
+# run it on master, see how that works.
+#
+# These jobs can be left out of "required" for merge in github settings
+# for "Branch Protection Rules" at https://github.com/jrochkind/attr_json/settings/branches
+#
+# You can move a Rails version between this file and ci.yml, and (un)check it in those
+# github settings. (I wish whether it was required to pass could be in this file
+# too, to keep things together)
+
+on:
+  push:
+    branches: [ master ]
+  # UTC Sundays 0900. note, no notifications will be sent for failed scheduled builds. :(
+  schedule:
+    - cron: '0 9 * * SUN'
+
+env:
+  POSTGRES_USER: postgres
+  POSTGRES_PASSWORD: postgres
+
+jobs:
+  tests:
+    services:
+      db:
+        image: postgres:9.4
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
+        ports: ['5432:5432']
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+
+          - gemfile: rails_edge
+            ruby: '3.1'
+
+    name: ${{ matrix.gemfile }}, ruby ${{ matrix.ruby }}
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+
+    - name: Bundle install
+      run: |
+        bundle config set gemfile "${GITHUB_WORKSPACE}/gemfiles/${{ matrix.gemfile }}.gemfile"
+        bundle install --jobs 4 --retry 3
+
+    - name: Run tests
+      run: bundle exec rspec

data/.gitignore

@@ -9,3 +9,4 @@
 /spec/internal/tmp/cache
 /tmp/
 .byebug_history
+/gemfiles/*.lock

data/Appraisals

@@ -0,0 +1,62 @@
+appraise "rails-5-0" do
+  gem 'combustion', '~> 0.9.0'
+
+  gem "rails", "~> 5.0.0"
+
+  # rails 5.1+ includes it by default, but rails 5.0 needs it:
+  gem 'rails-ujs', require: false
+
+  # Rails 5 won't work with pg 1.0 even though it doesn't say so
+  gem "pg",  "~> 0.18"
+end
+
+appraise "rails-5-1" do
+  gem 'combustion', '~> 0.9.0'
+
+  gem "rails", "~> 5.1.0"
+
+  gem "pg", "~> 1.0"
+end
+
+appraise "rails-5-2" do
+  gem 'combustion', '~> 0.9.0'
+
+  gem "rails", "~> 5.2.0"
+  gem "pg", "~> 1.0"
+end
+
+appraise "rails-6-0" do
+  gem 'combustion', "~> 1.0"
+
+  gem "rails", ">= 6.0.0", "< 6.1"
+  gem "pg", "~> 1.0"
+end
+
+appraise "rails-6-1" do
+  gem 'combustion', "~> 1.0"
+
+  gem "rails", "~> 6.1.0"
+  gem "pg", "~> 1.0"
+
+  # sprockets-rails is already a rails 6.1 dependency, but combustion is failing
+  # to require it, this is one way to get it required.
+  # https://github.com/pat/combustion/issues/128
+  gem "sprockets-rails"
+end
+
+appraise "rails-7-0" do
+  gem 'combustion', "~> 1.0"
+
+  gem "rails", "~> 7.0.0"
+  gem "pg", "~> 1.0"
+end
+
+appraise "rails-edge" do
+  # need combustion edge to work with rails edge, will no longer
+  # be true on next combustion release, probably no later than Rails 7.1
+  # https://github.com/pat/combustion/pull/126
+  gem 'combustion', "~> 1.0", github: "pat/combustion"
+
+  gem "rails", git: "https://github.com/rails/rails.git", branch: "main"
+  gem "pg", "~> 1.0"
+end

data/CHANGELOG.md

@@ -0,0 +1,67 @@
+# Changelog
+Notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased](https://github.com/jrochkind/attr_json/compare/v1.4.1...HEAD)
+
+
+## [1.5.0](https://github.com/jrochkind/attr_json/compare/v1.4.1...v1.5.0)
+
+### Added
+
+* AttrJson::Model#dup will properly deep-dup attributes https://github.com/jrochkind/attr_json/pull/169
+
+* AttrJson::Model#freeze will freeze attributes -- but not deep-freeze. https://github.com/jrochkind/attr_json/pull/169
+
+* AttrJson::Model has some methods conventional in ActiveModel classes: Klass.attribute_types, Klass.attribute_names, and instance.attribute_names. https://github.com/jrochkind/attr_json/pull/169
+
+## [1.4.1](https://github.com/jrochkind/attr_json/compare/v1.4.0...v1.4.1)
+
+### Fixed
+
+* Fixed an obscure bug involving a conflict between attribute defaults and accepts_nested_attributes, in which defaults could overwrite assigned attributes. The `.fill_in_defaults` class method, which was never intended as public API and was commented accordingly, is gone. https://github.com/jrochkind/attr_json/pull/160
+
+## [1.4.0](https://github.com/jrochkind/attr_json/compare/v1.3.0...v1.4.0)
+
+### Changed
+
+* When using store_key feature on an AttrJson::Model, you should not be able to pass in the store_key as a key in initializer or assign_attributes. It was really a bug that this ended up mapped to attribute this way, which could cause a problem in some cases; but calling it out in Changed section because if you were accidentally relying on it, it may appear as a backwards incompat to you. https://github.com/jrochkind/attr_json/pull/125
+
+* Rails 7.0.0 allowed by gemspec and tested in CI
+
+### Fixed
+
+* polymorphic single type can be set to nil https://github.com/jrochkind/attr_json/pull/115
+* polymorphic models can be serialized from hash in container attribute. Thanks @machty. https://github.com/jrochkind/attr_json/pull/123
+* fix bug with deserialization of nested attributes that have types that apply different serialization vs cast logic. Thanks @bradleesand. https://github.com/jrochkind/attr_json/pull/125
+
+## [1.3.0](https://github.com/jrochkind/attr_json/compare/v1.2.0...v1.3.0)
+
+### Added
+
+* Gemspec allows use with ActiveRecord 6.1.x
+
+## [1.2.0](https://github.com/jrochkind/attr_json/compare/v1.1.0...v1.2.0)
+
+### Added
+
+* attr_json_config(bad_cast: :as_nil) to avoid raising on data that can't be cast to a
+  AttrJson::Model, instead just casting to nil. https://github.com/jrochkind/attr_json/pull/95
+
+* Documented and tested support for using ActiveRecord serialize to map one AttrJson::Model
+to an entire column on it's own. https://github.com/jrochkind/attr_json/pull/89 and
+https://github.com/jrochkind/attr_json/pull/93
+
+* Better synchronization with ActiveRecord attributes when using rails_attribute:true, and a configurable true default_rails_attribute.  Thanks @volkanunsal . https://github.com/jrochkind/attr_json/pull/94
+
+### Changed
+
+* AttrJson::Model#== now requires same class for equality. And doesn't raise on certain arguments. https://github.com/jrochkind/attr_json/pull/90 Thanks @caiofilipemr for related bug report.
+
+## [1.1.0](https://github.com/jrochkind/attr_json/compare/v1.0.0...v1.1.0)
+
+### Added
+
+* not_jsonb_contains query method, like `jsonb_contains` but negated. https://github.com/jrochkind/attr_json/pull/85

data/Gemfile

@@ -3,40 +3,43 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in attr_json.gemspec
 gemspec
 
-# for our integration test in a real rails env, we add em in development too,
-# so we can bring up the app or a console in development to play with it.
-group :test, :development do
-  gem 'combustion', '~> 0.9.0'
-  # all of rails is NOT a dependency, just activerecord.
-  # But we use it for integration testing with combustion. Hmm, a bit annoying
-  # that now our other tests can't be sure they're depending, this might not
-  # be the way to do it.
-  gem "rails", ENV["RAILS_GEM"] && ENV["RAILS_GEM"].split(",")
-
-  # Rails 5.0 won't work with pg 1.0, but that isn't actually in it's gemspec.
-  # So we specify a compatible PG_GEM spec when testing with rails 5.
-  ENV['PG_GEM'] ||= ">= 0.18.1"
-  gem "pg", ENV['PG_GEM']
-
-  gem "rspec-rails", "~> 3.7"
-  gem "simple_form", ">= 4.0"
-  gem 'cocoon', ">= 1.2"
-  gem 'jquery-rails'
-  gem 'capybara', "~> 3.0"
-  gem "chromedriver-helper"
-  gem "selenium-webdriver"
-  # rails 5.1+ includes it by default, but rails 5.0 needs it:
-  gem 'rails-ujs', require: false
-end
-
-if ENV['RAILS_GEM']
-  gem "activerecord", ENV['RAILS_GEM'].split(",")
-
-  # This shouldn't really be needed, but seems to maybe be a bundler bug,
-  # this makes standalone_migrations dependencies resolve properly even when our
-  # RAILS_REQ is for 5.2.0.rc2. If in the future you delete this and everything
-  # still passes, feel free to remove.
-  gem "railties", ENV['RAILS_GEM'].split(",")
-end
+# Dependencies for testing and development. To let appraisal override them, we
+# do NOT put them in group :test,:development -- which anyway doesn't make a
+# lot of sense in a gem Gemfile anyway, there is no "production" in a gem Gemfile.
+#
+# We also have these development dependencies here in the Gemfile instead of the
+# gemspec so appraisal can override them from our Appraisal file.
+
+gem 'combustion', '~> 1.1'
+
+# all of rails is NOT a dependency, just activerecord.
+# But we use it for integration testing with combustion. Hmm, a bit annoying
+# that now our other tests can't be sure they're depending, this might not
+# be the way to do it.
+gem 'rails'
+
+gem "pg"
+gem "rspec-rails", "~> 6.0"
+gem "simple_form", ">= 4.0"
+gem 'cocoon', ">= 1.2"
+gem 'jquery-rails'
+
+# Even though we don't use coffee-script, when running specs, some part of rails
+# or other part of our stack is still insisting on requiring it, for reasons we
+# don't understand, so we need to depend on it.
+gem "coffee-rails"
+
+# We do some tests using cocoon via sprockets, which needs sprockets-rails,
+# which is not automatically available in Rails 7. We add it explicitly,
+# which will duplciate dependences in rails pre-7, but add for rails 7. Not sure
+# the future of cocoon in general. https://github.com/nathanvda/cocoon/issues/555
+gem "sprockets-rails"
+
+
+gem 'capybara', "~> 3.0"
+gem 'webdrivers', '~> 5.0'
+gem "selenium-webdriver"
 
 gem "byebug"
+
+