attr_extras 6.2.4 → 7.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4f8e12f94bbc166632e1a65a52f83ddc14e4982ad57f87043fa285e7e7a8cf2
-  data.tar.gz: 1d621e46616f5df763909d9481f983d60fe4e014a8a9a3b0dbfc2635d8867d71
+  metadata.gz: e5fd3ea490025e4ed3942658efff5b14335b261d843dead16fedd3f75fe9ca2c
+  data.tar.gz: 1adcf6c8e345de200ba9d0798caa4d996a62fb76ebcbe4ad2d167a996e98dacd
 SHA512:
-  metadata.gz: 44cade5ed299c18a1e8c01706e04767f1b49f3a934a53759542702fd6435c8ba225b360250dd276a78174fdea32e112ca1155cf20e172db765940ea05ecb3b03
-  data.tar.gz: 7fe165a6de71503666cb3344478c769385d50a31ca11de78cce7f934d87393867a5e2c3bc05703c7a3fdc86dd81da729703452c35d0999600f70b42a35851629
+  metadata.gz: ba168966ed66c2369fd23e1a11505ea06b0c559ce874492ec9744240505d6fbc3af2a13fc91b0e4ed4b51ff0768fd67c51fb24b6ed2ae5181fe71194ce304159
+  data.tar.gz: 37696980e733441e426e0102e2e8473b61206ef95be7a761197d5ed41571f2ead7304313a8c49d810b00eed4f21b485be1b0011ef3e5aa77a2efdde32852a598

data/.github/dependabot.yml

@@ -0,0 +1,8 @@
+version: 2
+updates:
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      # Check for updates to GitHub Actions every weekday
+      interval: "daily"

data/.github/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: Ruby CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version: [3.1, "3.0", 2.7, jruby-head]
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - "tmp/**/*"
+inherit_gem:
+  barsoom_utils: shared_rubocop.yml

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [7.0.0](https://github.com/barsoom/attr_extras/releases/tag/v7.0.0)
+
+- Drop end-of-lifed Ruby 2.5 and 2.6.
+- Don't share default value object instances. (We now do a shallow `dup`.) Thanks to [sammo1235](https://github.com/barsoom/attr_extras/pull/46)!
+
 ## [6.2.4](https://github.com/barsoom/attr_extras/releases/tag/v6.2.4)
 
 - Fix keyword argument warnings with Ruby 2.7. Thanks to [Elliot Winkler](https://github.com/barsoom/attr_extras/pull/34)!

data/Gemfile

@@ -1,4 +1,12 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in attr_extras.gemspec
 gemspec
+
+group :development, :test do
+  gem "barsoom_utils"
+  gem "m" # Running individual tests.
+  gem "minitest"
+  gem "rake"
+  gem "rubocop"
+end

data/README.md

@@ -1,22 +1,31 @@
 [![Gem Version](https://badge.fury.io/rb/attr_extras.svg)](https://badge.fury.io/rb/attr_extras)
-[![Build status](https://secure.travis-ci.org/barsoom/attr_extras.svg)](https://travis-ci.org/#!/barsoom/attr_extras/builds)
+[![Ruby CI](https://github.com/barsoom/attr_extras/actions/workflows/ci.yml/badge.svg)](https://github.com/barsoom/attr_extras/actions/workflows/ci.yml)
 [![Code Climate](https://codeclimate.com/github/barsoom/attr_extras/badges/gpa.svg)](https://codeclimate.com/github/barsoom/attr_extras)
 
 # attr\_extras
 
 Takes some boilerplate out of Ruby, lowering the barrier to extracting small focused classes, without [the downsides of using `Struct`](http://thepugautomatic.com/2013/08/struct-inheritance-is-overused/).
 
+Provides lower-level methods like `attr_private` and `attr_value` that nicely complement Ruby's built-in `attr_accessor`, `attr_reader` and `attr_writer`.
+
+Also higher-level ones like `pattr_initialize` (or `attr_private_initialize`) and `method_object` to really cut down on the boilerplate.
+
 Instead of
 
 ``` ruby
-class InvoiceBuilder
-  def initialize(invoice, employee)
-    @invoice, @employee = invoice, employee
+class InvoicePolicy
+  def initialize(invoice, company:)
+    @invoice = invoice
+    @company = company
+  end
+
+  def payable?
+    some_logic(invoice, company)
   end
 
   private
 
-  attr_reader :invoice, :employee
+  attr_reader :invoice, :company
 end
 ```
 
@@ -24,11 +33,58 @@ you can just do
 
 ``` ruby
 class InvoiceBuilder
-  pattr_initialize :invoice, :employee
+  pattr_initialize :invoice, [:company!]
+
+  def payable?
+    some_logic(invoice, company)
+  end
+end
+```
+
+And instead of
+
+``` ruby
+class PayInvoice
+  def self.call(invoice, amount)
+    new(invoice, amount).call
+  end
+
+  def initialize(invoice, amount)
+    @invoice = invoice
+    @amount = amount
+  end
+
+  def call
+    PaymentGateway.charge(invoice.id, amount_in_cents)
+  end
+
+  private
+
+  def amount_in_cents
+    amount * 100
+  end
+
+  attr_reader :invoice, :amount
 end
 ```
 
-This nicely complements Ruby's built-in `attr_accessor`, `attr_reader` and `attr_writer`.
+you can just do
+
+``` ruby
+class PayInvoice
+  method_object :invoice, :amount
+
+  def call
+    PaymentGateway.charge(invoice.id, amount_in_cents)
+  end
+
+  private
+
+  def amount_in_cents
+    amount * 100
+  end
+end
+```
 
 Supports positional arguments as well as optional and required keyword arguments.
 
@@ -461,17 +517,6 @@ You can run an individual test using the [m](https://github.com/qrush/m) gem:
 The tests are intentionally split into two test suites for reasons described in `Rakefile`.
 
 
-## Contributors
-
-* [Henrik Nyh](https://github.com/henrik)
-* [Joakim Kolsjö](https://github.com/joakimk)
-* [Victor Arias](https://github.com/victorarias)
-* [Teo Ljungberg](https://github.com/teoljungberg)
-* [Kim Persson](https://github.com/lavinia)
-* [Joe Ferris](https://github.com/jferris)
-* [Julien Vanier](https://github.com/monkbroc)
-
-
 ## License
 
 [MIT](LICENSE.txt)

data/attr_extras.gemspec

@@ -2,22 +2,17 @@
 require File.expand_path("../lib/attr_extras/version", __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Henrik Nyh", "Joakim Kolsjö", "Tomas Skogberg", "Victor Arias", "Ola K"]
-  gem.email         = ["henrik@nyh.se"]
+  gem.authors       = [ "Henrik Nyh", "Joakim Kolsjö", "Tomas Skogberg", "Victor Arias", "Ola K" ]
+  gem.email         = [ "henrik@nyh.se" ]
   gem.summary       = %q{Takes some boilerplate out of Ruby with methods like attr_initialize.}
   gem.homepage      = "https://github.com/barsoom/attr_extras"
 
   gem.files         = `git ls-files`.split($\)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "attr_extras"
-  gem.require_paths = ["lib"]
+  gem.require_paths = [ "lib" ]
   gem.license       = "MIT"
   gem.version       = AttrExtras::VERSION
-
-  gem.add_development_dependency "minitest", ">= 5"
-  gem.add_development_dependency "m", "~> 1.5.1"  # Running individual tests.
-
-  # For Travis CI.
-  gem.add_development_dependency "rake"
+  gem.metadata      = { "rubygems_mfa_required" => "true" }
 end

data/lib/attr_extras/attr_implement.rb

@@ -1,6 +1,7 @@
 class AttrExtras::AttrImplement
   def initialize(klass, names)
-    @klass, @names = klass, names.dup
+    @klass = klass
+    @names = names.dup
   end
 
   def apply

data/lib/attr_extras/attr_initialize.rb

@@ -2,7 +2,9 @@ require "attr_extras/params_builder"
 
 class AttrExtras::AttrInitialize
   def initialize(klass, names, block)
-    @klass, @names, @block = klass, names, block
+    @klass = klass
+    @names = names
+    @block = block
   end
 
   attr_reader :klass, :names
@@ -19,13 +21,13 @@ class AttrExtras::AttrInitialize
     validate_args = method(:validate_args)
 
     klass.send(:define_method, :initialize) do |*values|
-      hash_values = (values[(klass_params.positional_args.length)..-1] || []).inject(:merge) || {}
+      hash_values = (values[(klass_params.positional_args.length)..-1] || []).reduce(:merge) || {}
 
       validate_arity.call(values.length, self.class)
       validate_args.call(values, klass_params)
 
       klass_params.default_values.each do |name, default_value|
-        instance_variable_set("@#{name}", default_value)
+        instance_variable_set("@#{name}", default_value.dup)
       end
 
       klass_params.positional_args.zip(values).each do |name, value|
@@ -55,7 +57,7 @@ class AttrExtras::AttrInitialize
   end
 
   def validate_args(values, klass_params)
-    hash_values = values[(klass_params.positional_args.length)..-1].inject(:merge) || {}
+    hash_values = values[(klass_params.positional_args.length)..-1].reduce(:merge) || {}
     unknown_keys = hash_values.keys - klass_params.hash_args_names
 
     if unknown_keys.any?

data/lib/attr_extras/attr_value.rb

@@ -1,6 +1,7 @@
 class AttrExtras::AttrValue
   def initialize(klass, *names)
-    @klass, @names = klass, names
+    @klass = klass
+    @names = names
   end
 
   attr_reader :klass, :names

data/lib/attr_extras/params_builder.rb

@@ -25,13 +25,13 @@ module AttrExtras
       end
 
       def hash_args_required
-        @hash_args_required ||= hash_args.select { |name| name.to_s.end_with?(REQUIRED_SIGN) }.
-          map { |name| remove_required_sign(name) }
+        @hash_args_required ||= hash_args.select { |name| name.to_s.end_with?(REQUIRED_SIGN) }
+          .map { |name| remove_required_sign(name) }
       end
 
       def default_values
         @default_values ||= begin
-          default_values_hash = names.flatten.select { |name| name.is_a?(Hash) }.inject(:merge) || {}
+          default_values_hash = names.flatten.select { |name| name.is_a?(Hash) }.reduce(:merge) || {}
 
           default_values_hash.map { |name, value|
             [ remove_required_sign(name), value ]

data/lib/attr_extras/utils.rb

@@ -1,7 +1,8 @@
 module AttrExtras::Utils
   def self.flat_names(names)
-    names.flatten.
-      flat_map { |x| x.is_a?(Hash) ? x.keys : x }.
-      map { |x| x.to_s.sub(/!\z/, "") }
+    names
+      .flatten
+      .flat_map { |x| x.is_a?(Hash) ? x.keys : x }
+      .map { |x| x.to_s.sub(/!\z/, "") }
   end
 end

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "6.2.4"
+  VERSION = "7.0.0"
 end

data/spec/attr_extras/aattr_initialize_spec.rb

@@ -65,4 +65,29 @@ describe Object, ".aattr_initialize" do
 
     _(example.foo).must_equal "Foo"
   end
+
+  it "does not use the same default value object across class instances" do
+    klass = Class.new do
+      aattr_initialize [:name, items: []]
+    end
+
+    data = [
+      { name: "One", items: [1, 2, 3] },
+      { name: "Two", items: [4, 5, 6] },
+    ]
+
+    results = data.each_with_object([]) do |datum, results|
+      name, items = datum.values_at(:name, :items)
+      foo = klass.new(name: name)
+
+      items.each do |n|
+        foo.items << n
+      end
+
+      results << foo
+    end
+
+    _(results.first.items).must_equal [1, 2, 3]
+    _(results.last.items).must_equal [4, 5, 6]
+  end
 end

data/spec/attr_extras/attr_implement_spec.rb

@@ -13,7 +13,7 @@ describe Object, ".attr_implement" do
 
   it "allows specifying arity and argument names" do
     klass = Class.new do
-      attr_implement :foo, [:name, :age]
+      attr_implement :foo, [ :name, :age ]
     end
 
     example = klass.new
@@ -80,7 +80,7 @@ end
 describe Object, ".cattr_implement" do
   it "applies to class methods" do
     klass = Class.new do
-      cattr_implement :foo, [:name, :age]
+      cattr_implement :foo, [ :name, :age ]
     end
 
     exception = _(lambda { klass.foo(1, 2) }).must_raise AttrExtras::MethodNotImplementedError

data/spec/attr_extras/attr_initialize_spec.rb

@@ -24,7 +24,7 @@ describe Object, ".attr_initialize" do
 
   it "can set ivars from a hash" do
     klass = Class.new do
-      attr_initialize :foo, [:bar, :baz]
+      attr_initialize :foo, [ :bar, :baz ]
     end
 
     example = klass.new("Foo", bar: "Bar", baz: "Baz")
@@ -35,7 +35,7 @@ describe Object, ".attr_initialize" do
 
   it "can set default values for keyword arguments" do
     klass = Class.new do
-      attr_initialize :foo, [:bar, baz: "default baz"]
+      attr_initialize :foo, [ :bar, baz: "default baz" ]
     end
 
     example = klass.new("Foo", bar: "Bar")
@@ -49,7 +49,7 @@ describe Object, ".attr_initialize" do
 
   it "treats hash values as optional" do
     klass = Class.new do
-      attr_initialize :foo, [:bar, :baz]
+      attr_initialize :foo, [ :bar, :baz ]
     end
 
     example = klass.new("Foo", bar: "Bar")
@@ -61,7 +61,7 @@ describe Object, ".attr_initialize" do
 
   it "can require hash values" do
     klass = Class.new do
-      attr_initialize [:optional, :required!]
+      attr_initialize [ :optional, :required! ]
     end
 
     example = klass.new(required: "X")
@@ -72,7 +72,7 @@ describe Object, ".attr_initialize" do
 
   it "complains about unknown hash values" do
     klass = Class.new do
-      attr_initialize :foo, [:bar, :baz!]
+      attr_initialize :foo, [ :bar, :baz! ]
     end
 
     # Should not raise.
@@ -85,7 +85,7 @@ describe Object, ".attr_initialize" do
   # Regression.
   it "assigns hash values to positional arguments even when there's also hash arguments" do
     klass = Class.new do
-      attr_initialize :foo, [:bar]
+      attr_initialize :foo, [ :bar ]
     end
 
     # Should not raise.
@@ -95,7 +95,7 @@ describe Object, ".attr_initialize" do
   # Regression.
   it "only looks at hash arguments when determining missing required keys" do
     klass = Class.new do
-      attr_initialize :foo, [:bar!]
+      attr_initialize :foo, [ :bar! ]
     end
 
     # Provides a hash to "foo" but does not provide "bar".

data/spec/attr_extras/params_builder_spec.rb

@@ -4,7 +4,7 @@ describe AttrExtras::AttrInitialize::ParamsBuilder do
   subject { AttrExtras::AttrInitialize::ParamsBuilder.new(names) }
 
   describe "when positional and hash params are present" do
-    let(:names) { [ :foo, :bar, [ :baz, :qux!, quux: "Quux" ]] }
+    let(:names) { [ :foo, :bar, [ :baz, :qux!, quux: "Quux" ] ] }
 
     it "properly devides params by the type" do
       _(subject.positional_args).must_equal [ :foo, :bar ]
@@ -16,7 +16,7 @@ describe AttrExtras::AttrInitialize::ParamsBuilder do
   end
 
   describe "when only positional params are present" do
-    let(:names) { [ :foo, :bar] }
+    let(:names) { [ :foo, :bar ] }
 
     it "properly devides params by the type" do
       _(subject.positional_args).must_equal [ :foo, :bar ]
@@ -28,7 +28,7 @@ describe AttrExtras::AttrInitialize::ParamsBuilder do
   end
 
   describe "when only hash params are present" do
-    let(:names) { [[ { baz: "Baz" }, :qux!, { quux: "Quux" } ]] }
+    let(:names) { [ [ { baz: "Baz" }, :qux!, { quux: "Quux" } ] ] }
 
     it "properly devides params by the type" do
       _(subject.positional_args).must_be_empty

data/spec/attr_extras/pattr_initialize_spec.rb

@@ -12,7 +12,7 @@ describe Object, ".pattr_initialize" do
 
   it "works with hash ivars" do
     klass = Class.new do
-      pattr_initialize :foo, [:bar, :baz!]
+      pattr_initialize :foo, [ :bar, :baz! ]
     end
 
     example = klass.new("Foo", bar: "Bar", baz: "Baz")

data/spec/attr_extras/utils_spec.rb

@@ -13,7 +13,7 @@ describe AttrExtras::Utils do
     end
 
     it "flattens hash arguments with defaults and strips any bangs" do
-      _(AttrExtras::Utils.flat_names([ :foo, [ bar: "Bar", baz!: "Baz"] ])).must_equal [ "foo", "bar", "baz" ]
+      _(AttrExtras::Utils.flat_names([ :foo, [ bar: "Bar", baz!: "Baz" ] ])).must_equal [ "foo", "bar", "baz" ]
     end
   end
 end

data/spec/attr_extras/vattr_initialize_spec.rb

@@ -15,7 +15,7 @@ describe Object, ".vattr_initialize" do
 
   it "works with hash ivars" do
     klass = Class.new do
-      vattr_initialize :foo, [:bar, :baz!]
+      vattr_initialize :foo, [ :bar, :baz! ]
     end
 
     example1 = klass.new("Foo", bar: "Bar", baz: "Baz")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 6.2.4
+  version: 7.0.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -12,50 +12,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-08 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
-  name: m
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.5.1
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2022-11-10 00:00:00.000000000 Z
+dependencies: []
 description: 
 email:
 - henrik@nyh.se
@@ -63,8 +21,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -102,7 +62,8 @@ files:
 homepage: https://github.com/barsoom/attr_extras
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -118,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.3.20
 signing_key: 
 specification_version: 4
 summary: Takes some boilerplate out of Ruby with methods like attr_initialize.

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-rvm:
-  - 2.7.1
-  - 2.6.6
-  - 2.5.8
-  - jruby-head