attr_extras 6.2.3 → 6.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8de2d9f5a942529a96ff782dae5d6cc8ed15136ca0a8b9a5bdab353a96b58ed1
-  data.tar.gz: 1b12b6151ac7c28bc78ab6637a7fe25c12842079dcea32075fba8a2176c6bd13
+  metadata.gz: e4f8e12f94bbc166632e1a65a52f83ddc14e4982ad57f87043fa285e7e7a8cf2
+  data.tar.gz: 1d621e46616f5df763909d9481f983d60fe4e014a8a9a3b0dbfc2635d8867d71
 SHA512:
-  metadata.gz: c953ecbac9eadca7fc324a37af2360de9d9d6740b3ed28f3fa2c76cb45a44479e7d0d05f77c2087451167759e42a87b7d414cab19ad5ac3c72f077d797fdffcf
-  data.tar.gz: 36723de91da1c0e754a5c20ee76238d23944f1cc15789fd5482ccccfa8798cf3cbd679d381c81932ae8427fe6e4e7ff05ebe00496cd36c32f2c0c8e1fa86dd30
+  metadata.gz: 44cade5ed299c18a1e8c01706e04767f1b49f3a934a53759542702fd6435c8ba225b360250dd276a78174fdea32e112ca1155cf20e172db765940ea05ecb3b03
+  data.tar.gz: 7fe165a6de71503666cb3344478c769385d50a31ca11de78cce7f934d87393867a5e2c3bc05703c7a3fdc86dd81da729703452c35d0999600f70b42a35851629

data/.travis.yml

@@ -1,10 +1,6 @@
 language: ruby
 rvm:
-  - 2.7.0
-  - 2.6.5
-  - 2.5.7
-  - 2.4.9
+  - 2.7.1
+  - 2.6.6
+  - 2.5.8
   - jruby-head
-before_install:  # For jruby-head to work.
-  - gem install bundler
-  - gem update bundler

data/CHANGELOG.md

@@ -1,30 +1,34 @@
 # Changelog
 
-# 6.2.3
+## [6.2.4](https://github.com/barsoom/attr_extras/releases/tag/v6.2.4)
+
+- Fix keyword argument warnings with Ruby 2.7. Thanks to [Elliot Winkler](https://github.com/barsoom/attr_extras/pull/34)!
+
+## [6.2.3](https://github.com/barsoom/attr_extras/releases/tag/v6.2.3)
 
 - `attr_implement` error says "an 'ear()' method" instead of "a 'ear()' method", when the method starts with a likely vowel.
 
-# 6.2.2
+## [6.2.2](https://github.com/barsoom/attr_extras/releases/tag/v6.2.2)
 
 - Fix warnings with Ruby 2.7. Thanks to [Juanito Fatas](https://github.com/barsoom/attr_extras/pull/31)!
 - Fix deprecation warnings for Minitest 6. Thanks again to [Juanito Fatas](https://github.com/barsoom/attr_extras/pull/30)!
 
-# 6.2.1
+## [6.2.1](https://github.com/barsoom/attr_extras/releases/tag/v6.2.1)
 
 * Bugfix with keyword argument defaults. Thanks to [Roman Dubrovsky](https://github.com/barsoom/attr_extras/pull/29)!
 
-# 6.2.0
+## [6.2.0](https://github.com/barsoom/attr_extras/releases/tag/v6.2.0)
 
 * Another bugfix when passing hash values to positional arguments.
 
-# 6.1.0
+## [6.1.0](https://github.com/barsoom/attr_extras/releases/tag/v6.1.0)
 
 * Bugfix when passing hash values to positional arguments.
 
-# 6.0.0 (yanked)
+## 6.0.0 (yanked)
 
 * Default arguments! Thanks to [Ola K](https://github.com/lesin). For example: `pattr_initialize [:foo, bar: "default value"]`
 
-# 5.2.0 and earlier
+## [5.2.0](https://github.com/barsoom/attr_extras/releases/tag/v5.2.0) and earlier
 
 Please [see Git history](https://github.com/barsoom/attr_extras/releases).

data/README.md

@@ -1,3 +1,4 @@
+[![Gem Version](https://badge.fury.io/rb/attr_extras.svg)](https://badge.fury.io/rb/attr_extras)
 [![Build status](https://secure.travis-ci.org/barsoom/attr_extras.svg)](https://travis-ci.org/#!/barsoom/attr_extras/builds)
 [![Code Climate](https://codeclimate.com/github/barsoom/attr_extras/badges/gpa.svg)](https://codeclimate.com/github/barsoom/attr_extras)
 

data/attr_extras.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |gem|
   gem.version       = AttrExtras::VERSION
 
   gem.add_development_dependency "minitest", ">= 5"
-  gem.add_development_dependency "m", "~> 1.5.0"  # Running individual tests.
+  gem.add_development_dependency "m", "~> 1.5.1"  # Running individual tests.
 
   # For Travis CI.
   gem.add_development_dependency "rake"

data/lib/attr_extras/explicit.rb

@@ -61,9 +61,17 @@ module AttrExtras
     alias_method :attr_accessor_initialize, :aattr_initialize
 
     def static_facade(method_name_or_names, *names)
-      Array(method_name_or_names).each do |method_name|
-        define_singleton_method(method_name) do |*values, &block|
-          new(*values).public_send(method_name, &block)
+      if names.any? { |name| name.is_a?(Array) }
+        Array(method_name_or_names).each do |method_name|
+          define_singleton_method(method_name) do |*args, **opts, &block|
+            new(*args, **opts).public_send(method_name, &block)
+          end
+        end
+      else
+        Array(method_name_or_names).each do |method_name|
+          define_singleton_method(method_name) do |*args, &block|
+            new(*args).public_send(method_name, &block)
+          end
         end
       end
 

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "6.2.3"
+  VERSION = "6.2.4"
 end

data/spec/attr_extras/static_facade_spec.rb

@@ -56,4 +56,34 @@ describe Object, ".static_facade" do
 
     assert klass.foo { :bar } == :bar
   end
+
+  it "does not blow up when the class method is called with an empty hash" do
+    klass = Class.new do
+      static_facade :foo,
+        :value
+
+      def foo
+      end
+    end
+
+    refute_raises_anything { klass.foo({}) }
+  end
+
+  it "does not emit warnings when the initializer is overridden with more keyword arguments" do
+    superklass = Class.new do
+      static_facade :something, [ :foo!, :bar! ]
+
+      def something
+      end
+    end
+
+    klass = Class.new(superklass) do
+      def initialize(extra:, **rest)
+        super(**rest)
+        @extra = extra
+      end
+    end
+
+    refute_warnings_emitted { klass.something(foo: 1, bar: 2, extra: "yay") }
+  end
 end

data/spec/spec_helper_without_loading_attr_extras.rb

@@ -2,3 +2,20 @@ require "minitest/autorun"
 require "minitest/pride"
 
 $: << File.dirname(__FILE__) + "/../lib"
+
+Minitest::Test.class_eval do
+  def refute_warnings_emitted(&block)
+    _, stderr = capture_io(&block)
+
+    assert stderr.empty?, -> do
+      warnings = stderr.strip.split("\n").map { |line| "  #{line}" }.join("\n")
+      "Expected no warnings to be emitted, but these ones were:\n\n#{warnings}"
+    end
+  end
+
+  def refute_raises_anything
+    yield
+  rescue => error
+    flunk "Expected no error to be raised, but got #{error.class} (#{error.message})."
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 6.2.3
+  version: 6.2.4
 platform: ruby
 authors:
 - Henrik Nyh
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-25 00:00:00.000000000 Z
+date: 2020-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -34,14 +34,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.5.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -118,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Takes some boilerplate out of Ruby with methods like attr_initialize.