attr_extras 6.1.0 → 6.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d927809a2d8cd1a5da0e4e910942027d230dfb45
-  data.tar.gz: 80988c71e715df538d82b902846ca660e5f5a4fb
+  metadata.gz: a03ce9220bfff01deb8bd149a84375a38873bc7f
+  data.tar.gz: d4b97c8e31eaaa0e12a44fc872f7882325ed94d7
 SHA512:
-  metadata.gz: 8d9bd920c1a3227cd592dab70c0035124322bc0a358ed535b8aa5e42c6a8fb26bdcde0c85c8ef92a81131179e0b9fafbb928ccff2ab454164bc549cec36bd745
-  data.tar.gz: 96ff27fb9e371d898f3056159a644cb3828ad2e10bc3c83273fb38ab8441661e78f46bf4f2960b59f0af09affaa39cb8033f5a75b64efbc74476705268a73735
+  metadata.gz: e8a01917e46705498fafd11c0df34424cc0cf35c69d9376c091f7ceb58b08553ee528e1ccf9fdc2fbf2961352745ecfa9ec030c1b9dac513b432cb6231926a32
+  data.tar.gz: 449c6e92127085a5efb2b8021a6335de05bce8a75008ec51ab523956eb057ce2cdd2d6384206ede335ec368f93a6ed8e3c130cfdbbfcbeb9f76aef609f7bd299

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 6.2.0
+
+* Another bugfix when passing hash values to positional arguments.
+
 # 6.1.0
 
 * Bugfix when passing hash values to positional arguments.

data/lib/attr_extras/attr_initialize.rb

@@ -19,7 +19,7 @@ class AttrExtras::AttrInitialize
     validate_args = method(:validate_args)
 
     klass.send(:define_method, :initialize) do |*values|
-      hash_values = values.select { |name| name.is_a?(Hash) }.inject(:merge) || {}
+      hash_values = (values[(klass_params.positional_args.length)..-1] || []).inject(:merge) || {}
 
       validate_arity.call(values.length, self.class)
       validate_args.call(values, klass_params)

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "6.1.0"
+  VERSION = "6.2.0"
 end

data/spec/attr_extras/attr_initialize_spec.rb

@@ -103,6 +103,18 @@ describe Object, ".attr_initialize" do
     exception.message.must_include "[:bar]"
   end
 
+  # Regression.
+  it "doesn't store hash values to positional arguments as ivars" do
+    klass = Class.new do
+      attr_initialize :foo
+      attr_reader :foo
+    end
+
+    # Should not raise.
+    example = klass.new({ "invalid.ivar.name" => 123 })
+    example.foo.must_equal({ "invalid.ivar.name" => 123 })
+  end
+
   it "accepts a block for initialization" do
     klass = Class.new do
       attr_initialize :value do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.2.0
 platform: ruby
 authors:
 - Henrik Nyh